Comments

• 

  Jessica Gramp

  Mon, 21 Mar 2016, 6:53 AM

  HI all,
  
  I've released a My Feedback bug fix for Moodle 2.9 and 3.0, so please install the new version if you are using Moodle 2.9 upwards. The fixes include those mentioned above, plus another issue where logging in as a student shows a fatal error: class ‘report_myfeedack’ not found in report\myfeedback\index.php.
  
  I fixed this by including the lib file explicitly in index.php after the other requires on line 39:
  
  require_once($CFG->dirroot . '/report/myfeedback/lib.php');
  
  I'll be presenting on how the pilot of My feedback is progressing at MoodleMoot IE/UK next week, so if anyone else is going along please do come up and say hi if you've tried this plugin or are thinking of installing it.
  
  Cheers.
  
  Jess
  
• 

  Andy Parker

  Mon, 21 Mar 2016, 5:22 PM

  Thanks for the new release, my students can now see the report. However they are unable to add reflective feedback, clicking add notes does nothing whether they have a personal tutor or not. Am I missing something? Thanks for your help
• 

  Jessica Gramp

  Tue, 22 Mar 2016, 2:26 AM

  Hi Andy,
  
  No, you are right. This appears to be broken in later versions of Moodle (we are still on an older version at UCL so it still works for us).
  
  I will raise it with the developer. Thanks for letting us know.
  
  Cheers.
  
  Jess
• 

  Jessica Gramp

  Wed, 23 Mar 2016, 6:03 PM

  Our developer (Delvon Forrester) has figured out what's happening:
  
  I found out what the issue is with self-reflective notes and non-moodle feedback not doing anything when you click to add/edit notes. The popup box is dependent on bootstrap and because in Moodle 3.0 they normally test with the clean theme (which has bootstrapbase as its parent theme), but this does not seem to use the bootstrap modal which is used for the popup box.
  
  We may have to add that info to the plugin as a dependency for that functionality or I will have to spend some free time (at some point) and find the best way to add the bootstrap functionalities to the clean theme so that we can add that info to the plugin for those who don’t use a bootstrap compatible theme.
• 

  Dinis Medeiros

  Fri, 29 Apr 2016, 6:40 AM

  With role TEACHER i got: Error reading from database. Any help? Please!
• 

  Dinis Medeiros

  Fri, 29 Apr 2016, 6:50 AM

  Undefined property: stdClass::$profile_field_year in /moodle/report/myfeedback/index.php on line 179
• 

  Delvon Forrester

  Tue, 3 May 2016, 9:09 PM

  Hi Dinis,
  The Undefined property issue is fixed in a later release but this is because it is looking for a profile field called year. The fix is to wrap that line with isset() function: so you should have something like this:
  $year = '';
  profile_load_data($user);
  if (isset($user->profile_field_year)) {
  $year = $user->profile_field_year;
  }
  
  Or you can add a profile field with shortname 'year' (without the quotes) on your Moodle site at Site Admin >> Users >> Accounts >> User profile fields.
  Either of the above will resolve the issue until you get an updated release hopefully soon.
  
  
  
• 

  Delvon Forrester

  Tue, 3 May 2016, 9:11 PM

  With the Error reading from database I will need more info so I can get an idea why you get that error.
• 

  Ricardo Caiado

  Thu, 27 Oct 2016, 8:22 PM

  Hi,
  
  "version.php" for 2.8.4 package is wrong!
  
  "$plugin->release = '2.7.1 (Build: 2016032002)';"
  
  Ricardo
  
• 

  Jessica Gramp

  Thu, 27 Oct 2016, 11:40 PM

  Thanks Ricardo. I'm not sure why, but I uploaded this in a slightly different way from normal, by bringing across the v284 source from github, but it seems to have brought across the old version (v2.7.1) even though it was tagged as v.2.8.4 (strange!). This is why the version.php file was showing the older version number, because it had imported the old version. Thank you for picking up on this. I have now uploaded v284 manually and it appears to now have the latest version on moodle.org.
  
  For anyone who has downloaded the "latest" v2.8.4 version before Oct 27 16:38 (BST) from moodle.org, please check the version number in version.php is 2.8.4. If not, you will need to download it again. The github version seems fine. Thank you.
• 

  Ricardo Caiado

  Wed, 7 Dec 2016, 8:52 PM

  Any upgrade to Moodle 3.2?
• 

  Delvon Forrester

  Thu, 8 Dec 2016, 8:30 PM

  Hi Ricardo,
  
  I've not yet tested it on 3.2. Did you get an error doing so?
  I will have a look at it soon and see if there are issues.
• 

  Mark Picker

  Mon, 12 Dec 2016, 1:42 PM

  Hi,
  
  Is this plugin meant to work with MSSQL? There are calls to the LIMIT clause which isn't supported in MSSQL. e.g. if you open /report/myfeedback/index.php?userid=1 you get the following error:
  
  Debug info: Incorrect syntax near 'limit'.
  SELECT userid FROM mdl_role_assignments
  WHERE roleid = ? AND contextid = ?
  ORDER BY timemodified DESC limit 1
  [array (
  0 => 0,
  1 => 5,
  )]
  Error code: dmlreadexception
  
  Stack trace: •line 474 of \lib\dml\moodle_database.php: dml_read_exception thrown
  •line 282 of \lib\dml\mssql_native_moodle_database.php: call to moodle_database->query_end()
  •line 788 of \lib\dml\mssql_native_moodle_database.php: call to mssql_native_moodle_database->query_end()
  •line 822 of \lib\dml\mssql_native_moodle_database.php: call to mssql_native_moodle_database->get_recordset_sql()
  •line 1527 of \lib\dml\moodle_database.php: call to mssql_native_moodle_database->get_records_sql()
  •line 1294 of \report\myfeedback\lib.php: call to moodle_database->get_record_sql()
  •line 142 of \report\myfeedback\index.php: call to report_myfeedback->get_my_personal_tutor()
  
  Regards
  Mark
• 

  Anders Holm-Pedersen

  Wed, 14 Dec 2016, 8:47 PM

  Hi.
  Right now the plugin converts all grades into the F-A scale . Is it possible to avoid this, as we dont use that scale in Denmark. I would like it to just show the grades, that are already shown in the gradebook. Thanks in advance
• 

  Edwyn Omar Valladares

  Fri, 27 Jan 2017, 4:05 AM

  "Error reading from database" ??