Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(0 errors, 46 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

report/embedquestion/tests/attempt_tracker_test.php
(#26) PHPUnit testcase name "report_embedquestion_attempt_tracker_testcase" does not match file name "attempt_tracker_test"
(#52) Test method test_user_has_attempt() is missing any coverage information, own or at class level
(#149) Test method test_user_has_attempt_with_old_cache_hierarchy() is missing any coverage information, own or at class level
report/embedquestion/tests/backup_test.php
(#61) Test method test_duplicate_activity_should_not_copy_attempts() is missing any coverage information, own or at class level
(#103) Test method test_backup_and_restore_course_with_user_data_should_copy_attempts() is missing any coverage information, own or at class level
(#147) Test method test_restore_deleted_page_with_attempt() is missing any coverage information, own or at class level
(#188) Test method test_backup_and_restore_page_with_user_data_should_copy_attempts() is missing any coverage information, own or at class level
report/embedquestion/tests/events_test.php
(#67) Test method test_course_report_viewed() is missing any coverage information, own or at class level
(#98) Test method test_course_report_viewed_related_user_validation() is missing any coverage information, own or at class level
(#112) Test method test_course_report_viewed_groupid_validation() is missing any coverage information, own or at class level
(#127) Test method test_course_report_viewed_context_validation() is missing any coverage information, own or at class level
(#185) Test method test_activity_report_viewed_all_users() is missing any coverage information, own or at class level
(#217) Test method test_activity_report_viewed_related_user_validation() is missing any coverage information, own or at class level
(#231) Test method test_activity_report_viewed_groupid_validation() is missing any coverage information, own or at class level
(#246) Test method test_activity_report_viewed_context_validation() is missing any coverage information, own or at class level
report/embedquestion/tests/latest_attempt_table_test.php
(#26) PHPUnit testcase name "report_embedquestion_latest_attempt_table_testcase" does not match file name "latest_attempt_table_test"
(#58) Test method test_latest_attempt_table_no_filter() is missing any coverage information, own or at class level
(#65) Test method test_latest_attempt_table_filter_lookback() is missing any coverage information, own or at class level
(#76) Test method test_latest_attempt_table_filter_dates() is missing any coverage information, own or at class level
(#95) Test method test_latest_attempt_table_filter_datefrom() is missing any coverage information, own or at class level
(#110) Test method test_latest_attempt_table_filter_dateto() is missing any coverage information, own or at class level
(#127) Test method test_latest_attempt_table_filter_locations() is missing any coverage information, own or at class level
report/embedquestion/tests/lib_test.php
(#30) PHPUnit testcase name "report_embedquestion_lib_testcase" does not match file name "lib_test"
(#55) Test method test_report_embedquestion_extend_navigation_course() is missing any coverage information, own or at class level
(#81) Test method test_report_embedquestion_extend_navigation_module() is missing any coverage information, own or at class level
(#109) Test method test_report_embedquestion_questions_in_use_detects_question_in_use() is missing any coverage information, own or at class level
(#117) Test method test_report_embedquestion_questions_in_use_does_not_report_unattempted_question() is missing any coverage information, own or at class level
report/embedquestion/tests/privacy_provider_test.php
(#76) Test method test_get_contexts_for_userid_no_data() is missing any coverage information, own or at class level
(#87) Test method test_get_contexts_for_userid_with_attempt() is missing any coverage information, own or at class level
(#104) Test method test_get_users_in_context_no_data() is missing any coverage information, own or at class level
(#115) Test method test_get_users_in_context_with_attempt() is missing any coverage information, own or at class level
(#135) Test method test_export_user_data_no_data() is missing any coverage information, own or at class level
(#154) Test method test_export_user_data_with_data() is missing any coverage information, own or at class level
(#201) Test method test_delete_data_for_all_users_in_context_no_data() is missing any coverage information, own or at class level
(#214) Test method test_delete_data_for_all_users_in_context_with_data() is missing any coverage information, own or at class level
(#251) Test method test_delete_data_for_user_no_data() is missing any coverage information, own or at class level
(#265) Test method test_delete_data_for_user_with_data() is missing any coverage information, own or at class level
(#295) Test method test_delete_data_for_users() is missing any coverage information, own or at class level
(#318) Test method test_export_user_preferences() is missing any coverage information, own or at class level
report/embedquestion/tests/response_download_test.php
(#70) Test method test_get_zip_url_with_non_supported_qtype() is missing any coverage information, own or at class level
(#97) Test method test_get_zip_url_with_supported_qtype() is missing any coverage information, own or at class level
report/embedquestion/tests/utils_test.php
(#50) Test method test_get_activity_link() is missing any coverage information, own or at class level
(#68) Test method test_get_user_link() is missing any coverage information, own or at class level
(#78) Test method test_get_grade() is missing any coverage information, own or at class level
(#90) Test method test_get_url() is missing any coverage information, own or at class level
(#104) Test method test_get_filter_data() is missing any coverage information, own or at class level

Javascript coding style problems

(0 errors, 1 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

report/embedquestion/amd/src/download_responses.js
(#64) Missing JSDoc @returns for function. (valid-jsdoc)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(52 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

report/embedquestion/backup/moodle2/restore_report_embedquestion_plugin.class.php
(#82) Function restore_report_embedquestion_plugin::process_report_embedquestion_attempt is not documented
(#93) Function restore_report_embedquestion_plugin::process_question_attempt is not documented
(#115) Function restore_report_embedquestion_plugin::inform_new_usage_id is not documented
report/embedquestion/classes/attempt_storage.php
(#32) Function attempt_storage::find_existing_attempt is not documented
(#49) Function attempt_storage::update_timemodified is not documented
(#56) Function attempt_storage::make_new_usage is not documented
(#63) Function attempt_storage::new_usage_saved is not documented
(#83) Function attempt_storage::verify_usage is not documented
(#101) Function attempt_storage::delete_attempt is not documented
(#22) No one-line description found in phpdocs for class attempt_storage
report/embedquestion/classes/attempt_tracker.php
(#28) Constant attempt_tracker::CACHE_COMPONENT is not documented
(#29) Constant attempt_tracker::CACHE_AREA is not documented
report/embedquestion/classes/event/activity_report_viewed.php
(#39) Function activity_report_viewed::init is not documented
(#44) Function activity_report_viewed::get_name is not documented
(#48) Function activity_report_viewed::get_description is not documented
(#66) Function activity_report_viewed::get_url is not documented
(#76) Function activity_report_viewed::validate_data is not documented
(#92) Function activity_report_viewed::get_other_mapping is not documented
report/embedquestion/classes/event/course_report_viewed.php
(#39) Function course_report_viewed::init is not documented
(#44) Function course_report_viewed::get_name is not documented
(#48) Function course_report_viewed::get_description is not documented
(#66) Function course_report_viewed::get_url is not documented
(#76) Function course_report_viewed::validate_data is not documented
(#92) Function course_report_viewed::get_other_mapping is not documented
report/embedquestion/classes/form/filter.php
(#113) Function filter::validation is not documented
report/embedquestion/classes/latest_attempt_table.php
(#565) Function latest_attempt_table::query_db is not documented
report/embedquestion/classes/local/export/response_export.php
(#67) Phpdocs for function response_export::get_response_zip_file_info has incomplete parameters list
report/embedquestion/classes/local/report/activity_progress_report.php
(#55) Function activity_progress_report::get_title is not documented
(#59) Function activity_progress_report::get_url_report is not documented
report/embedquestion/classes/local/report/course_progress_report.php
(#52) Function course_progress_report::get_title is not documented
(#56) Function course_progress_report::get_url_report is not documented
report/embedquestion/classes/output/renderer.php
(#107) Phpdocs for function renderer::render_grade_link has incomplete parameters list
report/embedquestion/classes/privacy/provider.php
(#41) Function provider::get_metadata is not documented
(#64) Function provider::get_contexts_for_userid is not documented
(#76) Function provider::get_users_in_context is not documented
(#84) Function provider::export_user_data is not documented
(#123) Function provider::delete_data_for_all_users_in_context is not documented
(#134) Function provider::delete_data_for_user is not documented
(#158) Function provider::delete_data_for_users is not documented
report/embedquestion/classes/report_display_options.php
(#223) Function report_display_options::redirect_to_clean_url is not documented
report/embedquestion/classes/utils.php
(#125) There is no description in phpdocs for function get_user_link
(#137) There is no description in phpdocs for function get_question_link
(#38) Phpdocs for function utils::get_embed_location_summary has incomplete parameters list
(#126) Phpdocs for function utils::get_user_link has incomplete parameters list
(#138) Phpdocs for function utils::get_question_link has incomplete parameters list
(#201) Phpdocs for function utils::get_activity_link has incomplete parameters list
(#213) Phpdocs for function utils::get_attempt_summary_link has incomplete parameters list
(#263) Phpdocs for function utils::allow_downloadability_for_attempt_table has incomplete parameters list
(#324) Phpdocs for function utils::get_title has incomplete parameters list
report/embedquestion/db/upgrade.php
(#28) Phpdocs for function xmldb_report_embedquestion_upgrade has incomplete parameters list
report/embedquestion/tests/backup_test.php
(#32) Package is not specified for class backup_test. It is also not specified in file-level phpdocs
report/embedquestion/tests/response_download_test.php
(#93) Phpdocs for function response_download_test::test_get_zip_url_with_supported_qtype has incomplete parameters list

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


Missing changes in external functions or backup support for new detected tables or columns

(0 errors, 2 warnings)

This section shows potential problems detected when there are new database structures added in a patch and it is detected that nothing has been changed related with external functions (to be used by WS) or backup and restore. It must be checked that everything is correct and nothing is being missed in those areas. [More info]

report/embedquestion/db/upgrade.php
Database modifications (new tables or columns) detected in the patch without any change to some important areas.
No changes detected to external functions, that may affect apps and other web service integrations, please verify!

grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]