Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(4 errors, 7 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

report/deviceanalytics/admin/dashboard_time_form.php
(#32) Expected MOODLE_INTERNAL check or config.php inclusion
report/deviceanalytics/admin/settings.php
(#26) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
report/deviceanalytics/admin/settings_form.php
(#32) Expected MOODLE_INTERNAL check or config.php inclusion
report/deviceanalytics/ajaxcall.php
(#26) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
report/deviceanalytics/classes/deviceanalytics_data_object_class.php
(#32) Expected MOODLE_INTERNAL check or config.php inclusion
report/deviceanalytics/classes/deviceanalytics_data_storage_class.php
(#34) Expected MOODLE_INTERNAL check or config.php inclusion
report/deviceanalytics/db/events.php
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
report/deviceanalytics/db/install.php
(#28) Expected MOODLE_INTERNAL check or config.php inclusion
report/deviceanalytics/lib.php
(#26) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
report/deviceanalytics/redirector.php
(#32) Expected MOODLE_INTERNAL check or config.php inclusion
report/deviceanalytics/storage_helper_page.php
(#25) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.

Javascript coding style problems

(0 errors, 64 warnings)

This section shows the coding style problems detected in the code by jshint [More info]

report/deviceanalytics/js/dashboardcharts.js
(#70) Use '===' to compare with 'null'.
(#110) 'fkey' is already defined.
(#111) Use '===' to compare with 'null'.
(#150) 'getDisplayDatasets' was used before it was defined.
(#152) Creating global 'for' variable. Should be 'for (var ddata ...'.
(#159) 'getWindowDatasets' was used before it was defined.
(#161) Creating global 'for' variable. Should be 'for (var ddata ...'.
(#168) 'convertTChartData' was used before it was defined.
(#169) The object literal notation {} is preferable.
(#170) The array literal notation [] is preferable.
(#174) The object literal notation {} is preferable.
(#179) The object literal notation {} is preferable.
(#181) The array literal notation [] is preferable.
(#186) 'inObject' is already defined.
(#186) The object literal notation {} is preferable.
(#205) 'checkifexistsinArray' was used before it was defined.
(#227) 'getTypeLabels' was used before it was defined.
(#237) 'getSystemLabels' was used before it was defined.
(#247) 'getBrowserLabels' was used before it was defined.
(#257) 'getTypeDatas' was used before it was defined.
(#274) 'getSystemDatas' was used before it was defined.
(#291) 'getBrowserDatas' was used before it was defined.
(#316) 'getRandomColor' was used before it was defined.
(#320) 'getColorsNum' was used before it was defined.
(#328) 'getColorByValue' was used before it was defined.
(#6) 'Chart' is not defined.
(#12) '$' is not defined.
(#13) 'Chart' is not defined.
(#28) '$' is not defined.
(#29) 'Chart' is not defined.
(#56) '$' is not defined.
(#57) 'Chart' is not defined.
(#75) 'console' is not defined.
(#76) '$' is not defined.
(#77) 'Chart' is not defined.
(#116) '$' is not defined.
(#117) 'Chart' is not defined.
(#153) 'ddata' is not defined.
(#153) 'ddata' is not defined.
(#153) 'ddata' is not defined.
(#162) 'ddata' is not defined.
(#162) 'ddata' is not defined.
(#162) 'ddata' is not defined.
(#229) '$' is not defined.
(#230) '$' is not defined.
(#239) '$' is not defined.
(#240) '$' is not defined.
(#249) '$' is not defined.
(#250) '$' is not defined.
(#259) '$' is not defined.
(#276) '$' is not defined.
(#293) '$' is not defined.
(#310) 'i' is not defined.
(#310) 'i' is not defined.
(#310) 'i' is not defined.
(#322) 'i' is not defined.
(#322) 'i' is not defined.
(#322) 'i' is not defined.
(#5) 'createCharts' is defined but never used.
(#197) 'resizetocount' is defined but never used.
(#308) 'getRandomColors' is defined but never used.
(#13) 'devicetypechart' is defined but never used.
(#29) 'devicesystemchart' is defined but never used.
(#57) 'devicebrowserchart' is defined but never used.

CSS problems

(0 errors, 1 warnings)

This section shows CSS problems detected by csslint [More info]

report/deviceanalytics/css/storage_helper_page_css.css
(#2) Use of !important

PHPDocs style problems

(0 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]


Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]