Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]

PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]

PHP coding style problems

(84 errors, 140 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/quiz/accessrule/quiztimer/classes/hooks/output/before_standard_head_html_generation.php: (#62) Whitespace found at end of line; (#62) Functions must not contain multiple empty lines in a row; found 2 empty lines; (#63) Whitespace found at end of line
mod/quiz/accessrule/quiztimer/classes/observer.php: (#34) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/quiz/accessrule/quiztimer/classes/output/edit_renderer.php: (#220) Inline comments must start with a capital letter, digit or 3-dots sequence; (#220) This comment is 75% valid code; is this commented out code?; (#220) No space found before comment text; expected "// 'questionnumber' => $this->question_number_timer($structure->get_displayed_number_for_slot($slot))," but found "//'questionnumber' => $this->question_number_timer($structure->get_displayed_number_for_slot($slot)),"
mod/quiz/accessrule/quiztimer/classes/privacy/provider.php: (#43) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#45) Missing docblock for class provider; (#45) Line indented incorrectly; expected 0 spaces, found 1; (#93) Line indented incorrectly; expected 4 spaces, found 5; (#112) Functions must not contain multiple empty lines in a row; found 2 empty lines; (#130) Functions must not contain multiple empty lines in a row; found 2 empty lines; (#150) Line indented incorrectly; expected 4 spaces, found 5; (#186) Functions must not contain multiple empty lines in a row; found 2 empty lines; (#251) Line indented incorrectly; expected 4 spaces, found 5; (#251) Missing docblock for function delete_data_for_user; (#286) Closing brace indented incorrectly; expected 5 spaces, found 4; (#337) Line indented incorrectly; expected 4 spaces, found 5; (#341) Line indented incorrectly; expected 8 spaces, found 9; (#343) Line indented incorrectly; expected 8 spaces, found 9; (#344) Functions must not contain multiple empty lines in a row; found 2 empty lines; (#346) Line indented incorrectly; expected 8 spaces, found 9; (#350) Line indented incorrectly; expected 8 spaces, found 9; (#351) Line indented incorrectly; expected 4 spaces, found 5; (#354) File must end with a newline character; (#354) Line indented incorrectly; expected 0 spaces, found 1
mod/quiz/accessrule/quiztimer/externallib.php: (#125) Functions must not contain multiple empty lines in a row; found 2 empty lines
mod/quiz/accessrule/quiztimer/lang/en/quizaccess_quiztimer.php: (#43) Unexpected comment found. Auto-fixing will not work after this comment; (#45) The string key "minutes" is not in the correct order, it should be before "totaltime"; (#48) The string key "quiztime" is not in the correct order, it should be before "submit"; (#51) The string key "hours" is not in the correct order, it should be before "totalsectiontime"; (#54) The string key "distributesectiontime" is not in the correct order, it should be before "seconds"; (#56) The string key "sectiontime" is not in the correct order, it should be before "timelimit"; (#57) The string key "pagetime" is not in the correct order, it should be before "sectiontime"; (#67) The string key "quiztimer" is not in the correct order, it should be before "unitslots"; (#69) The string key "quizquiztimer" is not in the correct order, it should be before "requirequiztimermessage"; (#72) The string key "invalidsettedtime" is not in the correct order, it should be before "warningtime"; (#74) The string key "canteditquiztimes" is not in the correct order, it should be before "invalidsettedtime"; (#76) The string key "eventsectiontimerupdated" is not in the correct order, it should be before "eventslottimerupdated"; (#79) The string key "eventslottimerupdateddescription" is not in the correct order, it should be before "quiztimer:manage"; (#80) The string key "eventsectiontimerupdateddescription" is not in the correct order, it should be before "eventslottimerupdateddescription"; (#83) The string key "selecttypetimes" is not in the correct order, it should be before "timelimitedit"; (#85) The string key "repaginatewarning" is not in the correct order, it should be before "selecttypetimes"; (#90) The string key "pagingchangesnotapply" is not in the correct order, it should be before "repaginatewarning"; (#91) The string key "canteditquiztype" is not in the correct order, it should be before "pagingchangesnotapply"; (#94) The string key "configsavedsection" is not in the correct order, it should be before "disabledbycustomtimer"; (#95) The string key "configsavedquestion" is not in the correct order, it should be before "configsavedsection"; (#96) The string key "configsavedpage" is not in the correct order, it should be before "configsavedquestion"; (#103) The string key "privacy:metadata:timecreated" is not in the correct order, it should be before "privacy:metadata:usermodified"; (#106) The string key "privacy:metadata:quizid" is not in the correct order, it should be before "privacy:metadata:timemodified"; (#108) The string key "privacy:metadata:section" is not in the correct order, it should be before "privacy:metadata:slot"; (#110) The string key "privacy:metadata:attempt" is not in the correct order, it should be before "privacy:metadata:userid"; (#112) The string key "privacy:metadata:timefinish" is not in the correct order, it should be before "privacy:metadata:timestart"; (#114) The string key "privacy:metadata:quizaccess_quiztimer" is not in the correct order, it should be before "privacy:metadata:timefinish"; (#116) The string key "privacy:metadata:quizaccess_usertimedsections" is not in the correct order, it should be before "privacy:metadata:quizaccess_usertimedslots"
mod/quiz/accessrule/quiztimer/lang/es/quizaccess_quiztimer.php: (#42) Unexpected comment found. Auto-fixing will not work after this comment; (#44) The string key "minutes" is not in the correct order, it should be before "totaltime"; (#47) The string key "quiztime" is not in the correct order, it should be before "submit"; (#50) The string key "hours" is not in the correct order, it should be before "totalsectiontime"; (#53) The string key "distributesectiontime" is not in the correct order, it should be before "seconds"; (#55) The string key "sectiontime" is not in the correct order, it should be before "timelimit"; (#56) The string key "pagetime" is not in the correct order, it should be before "sectiontime"; (#66) The string key "quiztimer" is not in the correct order, it should be before "unitslots"; (#68) The string key "quizquiztimer" is not in the correct order, it should be before "requirequiztimermessage"; (#71) The string key "invalidsettedtime" is not in the correct order, it should be before "warningtime"; (#73) The string key "canteditquiztimes" is not in the correct order, it should be before "invalidsettedtime"; (#75) The string key "eventsectiontimerupdated" is not in the correct order, it should be before "eventslottimerupdated"; (#78) The string key "eventslottimerupdateddescription" is not in the correct order, it should be before "quiztimer:manage"; (#79) The string key "eventsectiontimerupdateddescription" is not in the correct order, it should be before "eventslottimerupdateddescription"; (#82) The string key "selecttypetimes" is not in the correct order, it should be before "timelimitedit"; (#84) The string key "repaginatewarning" is not in the correct order, it should be before "selecttypetimes"; (#89) The string key "pagingchangesnotapply" is not in the correct order, it should be before "repaginatewarning"; (#90) The string key "canteditquiztype" is not in the correct order, it should be before "pagingchangesnotapply"; (#93) The string key "configsavedsection" is not in the correct order, it should be before "disabledbycustomtimer"; (#94) The string key "configsavedquestion" is not in the correct order, it should be before "configsavedsection"; (#95) The string key "configsavedpage" is not in the correct order, it should be before "configsavedquestion"; (#101) The string key "privacy:metadata:timecreated" is not in the correct order, it should be before "privacy:metadata:usermodified"; (#104) The string key "privacy:metadata:quizid" is not in the correct order, it should be before "privacy:metadata:timemodified"; (#106) The string key "privacy:metadata:section" is not in the correct order, it should be before "privacy:metadata:slot"; (#108) The string key "privacy:metadata:attempt" is not in the correct order, it should be before "privacy:metadata:userid"; (#110) The string key "privacy:metadata:timefinish" is not in the correct order, it should be before "privacy:metadata:timestart"; (#112) The string key "privacy:metadata:quizaccess_quiztimer" is not in the correct order, it should be before "privacy:metadata:timefinish"; (#114) The string key "privacy:metadata:quizaccess_usertimedsections" is not in the correct order, it should be before "privacy:metadata:quizaccess_usertimedslots"
mod/quiz/accessrule/quiztimer/rule.php: (#497) Functions must not contain multiple empty lines in a row; found 3 empty lines; (#504) Functions must not contain multiple empty lines in a row; found 3 empty lines; (#523) Line indented incorrectly; expected at least 20 spaces, found 16; (#528) Line indented incorrectly; expected at least 20 spaces, found 16; (#530) Line indented incorrectly; expected 20 spaces, found 16; (#531) Line indented incorrectly; expected at least 24 spaces, found 20; (#532) Line indented incorrectly; expected at least 24 spaces, found 20; (#533) Line indented incorrectly; expected at least 24 spaces, found 20; (#534) Line indented incorrectly; expected at least 24 spaces, found 20; (#535) Line indented incorrectly; expected at least 24 spaces, found 20; (#536) Line indented incorrectly; expected at least 24 spaces, found 20; (#537) Line indented incorrectly; expected at least 24 spaces, found 20; (#538) Line indented incorrectly; expected at least 24 spaces, found 20; (#539) Line indented incorrectly; expected 20 spaces, found 16; (#545) There should be a comma after the last array item in a multi-line array.; (#601) Functions must not contain multiple empty lines in a row; found 2 empty lines; (#603) Variable "allSlots" must be all lower-case; (#604) Variable "slotIndex" must be all lower-case; (#604) Variable "allSlots" must be all lower-case; (#605) Variable "slotTime" must be all lower-case; (#605) Variable "slotIndex" must be all lower-case; (#606) Functions must not contain multiple empty lines in a row; found 2 empty lines; (#637) Variable "slotTime" must be all lower-case; (#644) There should be a comma after the last array item in a multi-line array.; (#775) Functions must not contain multiple empty lines in a row; found 2 empty lines; (#781) There should be a comma after the last array item in a multi-line array.; (#797) Expected "if (...) {\n"; found "if(...) {\n"
mod/quiz/accessrule/quiztimer/tests/behat/behat_quiztimer.php: (#17) Missing @copyright tag; (#34) Missing docblock for class behat_quiztimer; (#38) No one-line description found in phpdocs for docblock of function i_click_on_the_edit_icon; (#51) No one-line description found in phpdocs for docblock of function i_click_on_pencil_icon_to_edit_time_of_question; (#65) No one-line description found in phpdocs for docblock of function the_element_should_change_his_content; (#102) No one-line description found in phpdocs for docblock of function i_confirm_the_repaginate_warning_dialog
mod/quiz/accessrule/quiztimer/tests/phpunit/quiztimer_complete_attempt_set_time_question_test.php: (#37) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.; (#44) Unit test quiztimer_complete_attempt_set_time_question_test should be declared as final.; (#44) PHPUnit class "quiztimer_complete_attempt_set_time_question_test" does not have any namespace. It is recommended to add it to the "quizaccess_quiztimer" namespace, using more levels if needed, in order to match the code being tested; (#44) Missing docblock for class quiztimer_complete_attempt_set_time_question_test; (#83) Missing docblock for constant quiztimer_complete_attempt_set_time_question_test::COURSE_START; (#119) Test method test_complete_attempt_set_time_question() is missing a return type; (#148) Inline comments must end in full-stops, exclamation marks, or question marks; (#151) Inline comments must start with a capital letter, digit or 3-dots sequence; (#172) Inline comments must end in full-stops, exclamation marks, or question marks; (#179) Inline comments must start with a capital letter, digit or 3-dots sequence; (#179) Inline comments must end in full-stops, exclamation marks, or question marks; (#179) This comment is 72% valid code; is this commented out code?; (#182) Inline comments must end in full-stops, exclamation marks, or question marks; (#185) Missing docblock for function dataprovider in testcase
mod/quiz/accessrule/quiztimer/tests/phpunit/quiztimer_edit_renderer_test.php: (#37) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.; (#44) Unit test quiztimer_edit_renderer_test should be declared as final.; (#44) PHPUnit class "quiztimer_edit_renderer_test" does not have any namespace. It is recommended to add it to the "quizaccess_quiztimer" namespace, using more levels if needed, in order to match the code being tested; (#44) Missing docblock for class quiztimer_edit_renderer_test; (#48) Whitespace found at end of line; (#124) Test method test_edit_renderer() is missing a return type; (#153) Inline comments must start with a capital letter, digit or 3-dots sequence; (#153) This comment is 73% valid code; is this commented out code?; (#177) Inline comments must end in full-stops, exclamation marks, or question marks; (#179) Inline comments must start with a capital letter, digit or 3-dots sequence; (#179) This comment is 73% valid code; is this commented out code?; (#196) Whitespace found at end of line; (#200) Line exceeds 132 characters; contains 137 characters; (#202) Inline comments must start with a capital letter, digit or 3-dots sequence; (#202) This comment is 73% valid code; is this commented out code?; (#202) No space found before comment text; expected "// $editrender->get_action_icon($structure, 1, new \moodle_url('/mod/quiz/accessrule/quiztimer'));" but found "//$editrender->get_action_icon($structure, 1, new \moodle_url('/mod/quiz/accessrule/quiztimer'));"; (#206) Missing docblock for function dataprovider in testcase
mod/quiz/accessrule/quiztimer/tests/phpunit/quiztimer_events_test.php: (#37) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.; (#44) Unit test quiztimer_events_test should be declared as final.; (#44) PHPUnit class "quiztimer_events_test" does not have any namespace. It is recommended to add it to the "quizaccess_quiztimer" namespace, using more levels if needed, in order to match the code being tested; (#44) Missing docblock for class quiztimer_events_test; (#48) Whitespace found at end of line; (#78) Whitespace found at end of line; (#123) Test method test_events() is missing a return type; (#145) There should be a comma after the last array item in a multi-line array.; (#153) Missing docblock for function dataprovider in testcase
mod/quiz/accessrule/quiztimer/tests/phpunit/quiztimer_get_quiz_time_test.php: (#37) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.; (#44) Unit test quiztimer_get_quiz_time_test should be declared as final.; (#44) PHPUnit class "quiztimer_get_quiz_time_test" does not have any namespace. It is recommended to add it to the "quizaccess_quiztimer" namespace, using more levels if needed, in order to match the code being tested; (#44) Missing docblock for class quiztimer_get_quiz_time_test; (#48) Whitespace found at end of line; (#118) Test method test_get_quiz_time() is missing a return type; (#154) Missing docblock for function dataprovider in testcase
mod/quiz/accessrule/quiztimer/tests/phpunit/quiztimer_get_quiz_time_total_test.php: (#37) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.; (#45) Unit test quiztimer_get_quiz_time_total_test should be declared as final.; (#45) PHPUnit class "quiztimer_get_quiz_time_total_test" does not have any namespace. It is recommended to add it to the "quizaccess_quiztimer" namespace, using more levels if needed, in order to match the code being tested; (#45) Missing docblock for class quiztimer_get_quiz_time_total_test; (#49) Whitespace found at end of line; (#119) Test method test_get_quiz_time_total() is missing a return type; (#149) Missing docblock for function dataprovider in testcase
mod/quiz/accessrule/quiztimer/tests/phpunit/quiztimer_insert_question_time_test.php: (#37) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.; (#42) Unit test quiztimer_insert_question_time_test should be declared as final.; (#42) PHPUnit class "quiztimer_insert_question_time_test" does not have any namespace. It is recommended to add it to the "quizaccess_quiztimer" namespace, using more levels if needed, in order to match the code being tested; (#42) Missing docblock for class quiztimer_insert_question_time_test; (#46) Whitespace found at end of line; (#51) Whitespace found at end of line; (#66) Whitespace found at end of line; (#115) Test method test_insert_question_time() is missing a return type; (#141) Missing docblock for function dataprovider in testcase
mod/quiz/accessrule/quiztimer/tests/phpunit/quiztimer_insert_section_time_test.php: (#37) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.; (#45) Unit test quiztimer_insert_section_time_test should be declared as final.; (#45) PHPUnit class "quiztimer_insert_section_time_test" does not have any namespace. It is recommended to add it to the "quizaccess_quiztimer" namespace, using more levels if needed, in order to match the code being tested; (#45) Missing docblock for class quiztimer_insert_section_time_test; (#49) Whitespace found at end of line; (#59) Whitespace found at end of line; (#69) Whitespace found at end of line; (#119) Test method test_insert_section_time() is missing a return type; (#144) Inline comments must end in full-stops, exclamation marks, or question marks; (#159) Inline comments must start with a capital letter, digit or 3-dots sequence; (#159) This comment is 72% valid code; is this commented out code?; (#163) Missing docblock for function dataprovider in testcase
mod/quiz/accessrule/quiztimer/tests/phpunit/quiztimer_repaginate_slots_test.php: (#36) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.; (#42) Unit test quiztimer_repaginate_slots_test should be declared as final.; (#42) PHPUnit class "quiztimer_repaginate_slots_test" does not have any namespace. It is recommended to add it to the "quizaccess_quiztimer" namespace, using more levels if needed, in order to match the code being tested; (#42) Missing docblock for class quiztimer_repaginate_slots_test; (#46) Whitespace found at end of line; (#116) Test method test_repaginate_slots() is missing a return type; (#142) Inline comments must start with a capital letter, digit or 3-dots sequence; (#142) This comment is 72% valid code; is this commented out code?; (#152) Missing docblock for function dataprovider in testcase
mod/quiz/accessrule/quiztimer/tests/phpunit/quiztimer_set_nav_quiz_mode_test.php: (#37) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.; (#45) Unit test quiztimer_set_nav_quiz_mode_test should be declared as final.; (#45) PHPUnit class "quiztimer_set_nav_quiz_mode_test" does not have any namespace. It is recommended to add it to the "quizaccess_quiztimer" namespace, using more levels if needed, in order to match the code being tested; (#45) Missing docblock for class quiztimer_set_nav_quiz_mode_test; (#118) Test method test_set_nav_quiz_mode() is missing a return type; (#147) Inline comments must end in full-stops, exclamation marks, or question marks; (#150) Inline comments must start with a capital letter, digit or 3-dots sequence; (#171) Inline comments must end in full-stops, exclamation marks, or question marks; (#180) Inline comments must start with a capital letter, digit or 3-dots sequence; (#180) Inline comments must end in full-stops, exclamation marks, or question marks; (#180) This comment is 72% valid code; is this commented out code?; (#183) Inline comments must end in full-stops, exclamation marks, or question marks; (#187) Inline comments must end in full-stops, exclamation marks, or question marks; (#190) Missing docblock for function dataprovider in testcase
mod/quiz/accessrule/quiztimer/tests/phpunit/quiztimer_set_quiz_config_test.php: (#37) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.; (#43) Unit test quiztimer_set_quiz_config_test should be declared as final.; (#43) PHPUnit class "quiztimer_set_quiz_config_test" does not have any namespace. It is recommended to add it to the "quizaccess_quiztimer" namespace, using more levels if needed, in order to match the code being tested; (#43) Missing docblock for class quiztimer_set_quiz_config_test; (#47) Whitespace found at end of line; (#117) Test method test_set_quiz_config() is missing a return type; (#134) Inline comments must start with a capital letter, digit or 3-dots sequence; (#139) Inline comments must end in full-stops, exclamation marks, or question marks; (#156) Missing docblock for function dataprovider in testcase

CSS problems

(2 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]

mod/quiz/accessrule/quiztimer/styles.css: (#15) Expected no more than 2 empty lines (max-empty-lines); (#16) Expected no more than 2 empty lines (max-empty-lines)

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]

grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

: Problems running grunt; Task "eslint:amd" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]

Prechecker results: error

Overview

PHP lint problems

PHP coding style problems

Javascript coding style problems

CSS problems

PHPDocs style problems

Update savepoints problems

Third party library modification problems

grunt changes

shifter problems

Mustache template problems

Gherkin .feature problems