Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(47 errors, 32 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/quiz/accessrule/quizproctoring/ajax.php
(#36) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#67) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#75) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#83) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#88) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#96) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
mod/quiz/accessrule/quizproctoring/ajax_report.php
(#1) Whitespace found at end of line
(#1) The opening <?php tag must be followed by exactly one newline.
(#4) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
(#12) Commas (,) must be followed by white space.
(#16) Line exceeds maximum limit of 180 characters; contains 197 characters
(#16) Space found before semicolon; expected "" AND deleted = 0 ";" but found "" AND deleted = 0 " ;"
(#17) Variable "getImages" must be all lower-case
(#19) Expected 1 space before "="; 0 found
(#20) Line exceeds maximum limit of 180 characters; contains 201 characters
(#20) Space found before semicolon; expected "" AND deleted = 0 ";" but found "" AND deleted = 0 " ;"
(#26) Expected "foreach (...) {\n"; found "foreach(...) {\n"
(#26) Variable "getImages" must be all lower-case
(#27) Line indented incorrectly; expected 8 spaces, found 7
(#33) Closing brace indented incorrectly; expected 7 spaces, found 8
(#36) Line exceeds maximum limit of 180 characters; contains 238 characters
(#41) Line exceeds maximum limit of 180 characters; contains 197 characters
(#41) Space found before semicolon; expected "" AND deleted = 0 ";" but found "" AND deleted = 0 " ;"
(#42) Variable "getImages" must be all lower-case
(#43) Expected 1 space before "="; 0 found
(#44) Line exceeds maximum limit of 180 characters; contains 201 characters
(#44) Space found before semicolon; expected "" AND deleted = 0 ";" but found "" AND deleted = 0 " ;"
(#50) Expected "foreach (...) {\n"; found "foreach(...) {\n"
(#50) Variable "getImages" must be all lower-case
(#60) Line exceeds maximum limit of 180 characters; contains 263 characters
(#63) Whitespace found at end of line
mod/quiz/accessrule/quizproctoring/backup/moodle2/backup_quizaccess_quizproctoring_stepslib.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/quiz/accessrule/quizproctoring/classes/privacy/provider.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/quiz/accessrule/quizproctoring/db/upgrade.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#149) Line exceeds 132 characters; contains 164 characters
(#161) Line indented incorrectly; expected 4 spaces, found 5
(#192) Closing brace indented incorrectly; expected 5 spaces, found 4
mod/quiz/accessrule/quizproctoring/lang/en/quizaccess_quizproctoring.php
(#86) File must end with a newline character
mod/quiz/accessrule/quizproctoring/lang/fr/quizaccess_quizproctoring.php
(#69) File must end with a newline character
mod/quiz/accessrule/quizproctoring/lib.php
(#25) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
(#61) Logical operator "or" is prohibited; use "||" instead
(#78) Line exceeds 132 characters; contains 162 characters
(#80) Whitespace found at end of line
(#83) Line exceeds 132 characters; contains 141 characters
(#101) Line exceeds 132 characters; contains 166 characters
(#104) Line exceeds 132 characters; contains 166 characters
(#108) Whitespace found at end of line
(#122) Expected "if (...) {\n"; found "if(...){\n"
(#156) Line exceeds 132 characters; contains 166 characters
(#157) Line exceeds 132 characters; contains 174 characters
(#188) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#192) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
mod/quiz/accessrule/quizproctoring/proctoridentity.php
(#1) Whitespace found at end of line
(#1) The opening <?php tag must be followed by exactly one newline.
(#26) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
(#34) Expected "if (...) {\n"; found "if(...) {\n"
(#34) Expected 1 space before "=>"; 0 found
(#34) Line exceeds 132 characters; contains 165 characters
(#41) Line exceeds 132 characters; contains 161 characters
mod/quiz/accessrule/quizproctoring/rule.php
(#67) Variable "aws_key" must not contain underscores.
(#68) Variable "aws_secret" must not contain underscores.
(#71) Whitespace found at end of line
(#72) Expected "if (...) {\n"; found "if(...){\n"
(#72) Variable "aws_key" must not contain underscores.
(#72) Variable "aws_secret" must not contain underscores.
(#73) Expected "if (...) {\n"; found "if(...){ \n"
(#73) Whitespace found at end of line
(#74) Commas (,) must be followed by white space.
(#75) Expected "} else {\n"; found "}else{ \n"
(#75) Whitespace found at end of line
(#286) This comment is 79% valid code; is this commented out code?
(#306) Whitespace found at end of line
(#395) Line exceeds 132 characters; contains 174 characters
(#398) Line exceeds 132 characters; contains 166 characters
(#399) Line exceeds 132 characters; contains 153 characters
mod/quiz/accessrule/quizproctoring/settings.php
(#30) Inline comments must end in full-stops, exclamation marks, or question marks
(#31) Line exceeds 132 characters; contains 147 characters
(#49) Line exceeds 132 characters; contains 133 characters
(#51) Line exceeds 132 characters; contains 168 characters

Javascript coding style problems

(0 errors, 25 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

mod/quiz/accessrule/quizproctoring/amd/src/add_camera.js
(#20) Each then() should return a value or throw (promise/always-return)
(#109) Expected catch,fail() or return (promise/catch-or-return)
(#111) Each then() should return a value or throw (promise/always-return)
(#120) Unquoted reserved word 'class' used as key. (quote-props)
(#124) 'camera' used outside of binding context. (block-scoped-var)
(#125) 'camera' used outside of binding context. (block-scoped-var)
(#125) 'camera' used outside of binding context. (block-scoped-var)
(#127) 'camera' is already defined. (no-redeclare)
(#127) 'camera' used outside of binding context. (block-scoped-var)
(#129) 'camera' used outside of binding context. (block-scoped-var)
(#131) 'camera' used outside of binding context. (block-scoped-var)
(#134) 'camera' used outside of binding context. (block-scoped-var)
(#136) 'camera' used outside of binding context. (block-scoped-var)
(#141) Expected catch,fail() or return (promise/catch-or-return)
(#143) Each then() should return a value or throw (promise/always-return)
mod/quiz/accessrule/quizproctoring/amd/src/modal_response.js
(#42) The function binding is unnecessary. (no-extra-bind)
(#46) The function binding is unnecessary. (no-extra-bind)
mod/quiz/accessrule/quizproctoring/amd/src/response_panel.js
(#208) Expected catch,fail() or return (promise/catch-or-return)
(#208) Each then() should return a value or throw (promise/always-return)
(#257) Expected catch,fail() or return (promise/catch-or-return)
(#265) Each then() should return a value or throw (promise/always-return)
(#271) Expected catch,fail() or return (promise/catch-or-return)
(#274) Each then() should return a value or throw (promise/always-return)
(#297) Expected catch,fail() or return (promise/catch-or-return)
(#300) Each then() should return a value or throw (promise/always-return)

CSS problems

(4 errors, 2 warnings)

This section shows CSS problems detected by stylelint [More info]

mod/quiz/accessrule/quizproctoring/styles.css
(#9) Unexpected !important (declaration-no-important)
(#10) Unexpected !important (declaration-no-important)
(#13) Unexpected !important (declaration-no-important)
(#14) Unexpected !important (declaration-no-important)
(#3) Unexpected unit (length-zero-no-unit)
(#4) Unexpected unit (length-zero-no-unit)

PHPDocs style problems

(8 errors, 2 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

mod/quiz/accessrule/quizproctoring/ajax_report.php
(#2) Empty line found after PHP open tag
(#3) File-level phpdocs block is not found
mod/quiz/accessrule/quizproctoring/classes/aws/camera.php
(#64) Variable camera::$client is not documented
(#48) Phpdocs for variable camera::$amazonapikey does not contain @var or incorrect
(#53) Phpdocs for variable camera::$amazonapisecret does not contain @var or incorrect
mod/quiz/accessrule/quizproctoring/lib.php
(#89) Phpdocs for function quizproctoring_storeimage has incomplete parameters list
mod/quiz/accessrule/quizproctoring/proctoridentity.php
(#2) Empty line found after PHP open tag
mod/quiz/accessrule/quizproctoring/rule.php
(#45) Phpdocs for function quizaccess_quizproctoring::make has incomplete parameters list
(#118) Phpdocs for function quizaccess_quizproctoring::add_preflight_check_form_fields has incomplete parameters list
(#261) Phpdocs for function quizaccess_quizproctoring::add_settings_form_fields has incomplete parameters list

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "stylelint:css" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 5 warnings)

This section shows problems detected in mustache templates [More info]

mod/quiz/accessrule/quizproctoring/templates/response_modal.mustache
(#1) Example context missing (@template section not found.)
(#1) HTML Validation info, line 8: Empty heading. ( <h5 id="would-be-a-uniqid-modal-title" class="modal-title" data-region="title"></h5>)
(#1) HTML Validation info, line 15: Empty heading. ( <h5 class="imgheading"></h5>)
(#1) HTML Validation error, line 16: Element “img” is missing required attribute “src”. ( <img class="userimg"> )
(#1) HTML Validation error, line 16: An “img” element must have an “alt” attribute, except under certain conditions. For details, consult guidance on providing text alternatives for images. ( <img class="userimg"> )

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]