Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(0 errors, 10 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/quiz/accessrule/offlinemode/attempt.php
(#88) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
mod/quiz/accessrule/offlinemode/classes/form/upload_responses.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/quiz/accessrule/offlinemode/classes/privacy/provider.php
(#24) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/quiz/accessrule/offlinemode/db/install.php
(#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/quiz/accessrule/offlinemode/relogin.php
(#38) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
mod/quiz/accessrule/offlinemode/tests/rule_test.php
(#38) PHPUnit testcase name "quizaccess_offlinemode_rule_testcase" does not match file name "rule_test"
(#38) PHPUnit class "quizaccess_offlinemode_rule_testcase" does not have any namespace. It is recommended to add it to the "quizaccess_offlinemode" namespace, using more levels if needed, in order to match the code being tested
(#39) Test method test_is_compatible_behaviour() is missing any coverage information, own or at class level
(#44) Test method test_offlinemode_rule_creation() is missing any coverage information, own or at class level
mod/quiz/accessrule/offlinemode/upload.php
(#155) Inline comments must end in full-stops, exclamation marks, or question marks

Javascript coding style problems

(0 errors, 91 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

mod/quiz/accessrule/offlinemode/yui/src/autosave/js/autosave.js
(#29) Identifier 'quizaccess_offlinemode' is not in camel case. (camelcase)
(#85) Multiple spaces found before '// Must have s...'. (no-multi-spaces)
(#86) Multiple spaces found before '// Must have s...'. (no-multi-spaces)
(#155) Identifier 'delay_timer' is not in camel case. (camelcase)
(#165) Identifier 'save_transaction' is not in camel case. (camelcase)
(#175) Identifier 'last_successful_save' is not in camel case. (camelcase)
(#185) Identifier 'editor_change_handler' is not in camel case. (camelcase)
(#194) Identifier 'hidden_field_values' is not in camel case. (camelcase)
(#204) Identifier 'question_outer_div_id_prefix' is not in camel case. (camelcase)
(#205) Identifier 'question_outer_div_id_prefix' is not in camel case. (camelcase)
(#221) Multiple spaces found before 'this'. (no-multi-spaces)
(#221) Multiple spaces found before 'this'. (no-multi-spaces)
(#238) Identifier 'save_hidden_field_values' is not in camel case. (camelcase)
(#240) Multiple spaces found before '='. (no-multi-spaces)
(#248) Identifier 'watch_hidden_fields' is not in camel case. (camelcase)
(#253) Identifier 'detect_hidden_field_changes' is not in camel case. (camelcase)
(#255) Multiple spaces found before '='. (no-multi-spaces)
(#279) Identifier 'init_tinymce' is not in camel case. (camelcase)
(#290) Identifier 'editor_change_handler' is not in camel case. (camelcase)
(#301) Identifier 'init_tinymce_editor' is not in camel case. (camelcase)
(#309) Identifier 'value_changed' is not in camel case. (camelcase)
(#322) Identifier 'editor_changed' is not in camel case. (camelcase)
(#328) Identifier 'mark_question_changed_if_necessary' is not in camel case. (camelcase)
(#336) Identifier 'get_slot_from_id' is not in camel case. (camelcase)
(#344) Identifier 'set_question_state_string' is not in camel case. (camelcase)
(#356) Identifier 'update_question_state_strings' is not in camel case. (camelcase)
(#362) Identifier 'set_question_state_class' is not in camel case. (camelcase)
(#370) Identifier 'update_question_state_classes' is not in camel case. (camelcase)
(#376) Identifier 'start_save_timer_if_necessary' is not in camel case. (camelcase)
(#387) Identifier 'start_save_timer' is not in camel case. (camelcase)
(#389) Identifier 'delay_timer' is not in camel case. (camelcase)
(#392) Identifier 'cancel_delay' is not in camel case. (camelcase)
(#396) Identifier 'delay_timer' is not in camel case. (camelcase)
(#399) Identifier 'save_changes' is not in camel case. (camelcase)
(#413) Identifier 'save_transaction' is not in camel case. (camelcase)
(#427) Identifier 'save_done' is not in camel case. (camelcase)
(#438) Identifier 'save_transaction' is not in camel case. (camelcase)
(#450) Identifier 'save_transaction' is not in camel case. (camelcase)
(#463) Identifier 'save_failed' is not in camel case. (camelcase)
(#465) Identifier 'save_transaction' is not in camel case. (camelcase)
(#473) Identifier 'is_time_nearly_over' is not in camel case. (camelcase)
(#478) Identifier 'stop_autosaving' is not in camel case. (camelcase)
(#480) Identifier 'delay_timer' is not in camel case. (camelcase)
(#486) Missing JSDoc @returns for function. (valid-jsdoc)
(#491) Identifier 'warn_if_unsaved_data' is not in camel case. (camelcase)
(#498) Method 'warn_if_unsaved_data' expected no return value. (consistent-return)
(#506) Identifier 'submit_and_finish_clicked' is not in camel case. (camelcase)
(#532) Identifier 'submit_and_finish' is not in camel case. (camelcase)
(#549) Identifier 'save_transaction' is not in camel case. (camelcase)
(#561) Identifier 'submit_done' is not in camel case. (camelcase)
(#576) Identifier 'save_transaction' is not in camel case. (camelcase)
(#581) Identifier 'submit_failed' is not in camel case. (camelcase)
(#583) Identifier 'save_transaction' is not in camel case. (camelcase)
(#600) Identifier 'get_submit_progress' is not in camel case. (camelcase)
(#614) Identifier 'get_submit_failed_message' is not in camel case. (camelcase)
(#636) Identifier 'create_status_messages' is not in camel case. (camelcase)
(#649) Identifier 'update_status_for_successful_save' is not in camel case. (camelcase)
(#650) Missing JSDoc comment. (require-jsdoc)
(#653) Identifier 'last_successful_save' is not in camel case. (camelcase)
(#661) Identifier 'update_status_for_failed_save' is not in camel case. (camelcase)
(#670) Identifier 'try_to_restore_session' is not in camel case. (camelcase)
(#692) Identifier 'restore_session_complete' is not in camel case. (camelcase)
mod/quiz/accessrule/offlinemode/yui/src/download/js/download.js
(#29) Identifier 'quizaccess_offlinemode' is not in camel case. (camelcase)
(#71) Missing JSDoc for parameter 'filename'. (valid-jsdoc)
(#71) Missing JSDoc for parameter 'publicKey'. (valid-jsdoc)
(#92) Missing JSDoc for parameter 'e'. (valid-jsdoc)
(#118) Missing JSDoc return type. (valid-jsdoc)
(#126) Missing JSDoc comment. (require-jsdoc)
(#133) Missing JSDoc for parameter 'container'. (valid-jsdoc)
(#141) Missing JSDoc comment. (require-jsdoc)
(#150) Missing JSDoc return type. (valid-jsdoc)
(#150) Missing JSDoc for parameter 'data'. (valid-jsdoc)
(#161) There should be no space after '{'. (object-curly-spacing)
(#161) There should be no space before '}'. (object-curly-spacing)
mod/quiz/accessrule/offlinemode/yui/src/navigation/js/navigation.js
(#29) Identifier 'quizaccess_offlinemode' is not in camel case. (camelcase)
(#95) Expected JSDoc for 'currentpage' but found 'delay'. (valid-jsdoc)
(#107) Unexpected space before function parentheses. (space-before-function-paren)
(#153) Identifier 'preload_images' is not in camel case. (camelcase)
(#156) Missing JSDoc comment. (require-jsdoc)
(#156) Identifier 'preload_image' is not in camel case. (camelcase)
(#180) Identifier 'nav_button_click' is not in camel case. (camelcase)
(#197) Identifier 'finish_attempt_click' is not in camel case. (camelcase)
(#208) Identifier 'next_button_click' is not in camel case. (camelcase)
(#219) Identifier 'summary_button_click' is not in camel case. (camelcase)
(#227) Missing JSDoc return type. (valid-jsdoc)
(#231) Expected JSDoc for 'anchor' but found 'The'. (valid-jsdoc)
(#234) Identifier 'page_number_from_link' is not in camel case. (camelcase)
(#250) Identifier 'scroll_to_fragment_from_link' is not in camel case. (camelcase)
(#283) Identifier 'navigate_to_page' is not in camel case. (camelcase)
(#300) Unexpected space before function parentheses. (space-before-function-paren)
(#334) Identifier 'update_flag_on_summary_page' is not in camel case. (camelcase)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(10 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

mod/quiz/accessrule/offlinemode/backup/moodle2/backup_quizaccess_offlinemode_subplugin.class.php
(#43) Function backup_quizaccess_offlinemode_subplugin::define_quiz_subplugin_structure is not documented
mod/quiz/accessrule/offlinemode/backup/moodle2/restore_quizaccess_offlinemode_subplugin.class.php
(#43) Function restore_quizaccess_offlinemode_subplugin::define_quiz_subplugin_structure is not documented
mod/quiz/accessrule/offlinemode/classes/form/upload_responses.php
(#39) Function upload_responses::definition is not documented
mod/quiz/accessrule/offlinemode/rule.php
(#46) Function quizaccess_offlinemode::make is not documented
(#56) Function quizaccess_offlinemode::add_settings_form_fields is not documented
(#87) Function quizaccess_offlinemode::save_settings is not documented
(#101) Function quizaccess_offlinemode::delete_settings is not documented
(#106) Function quizaccess_offlinemode::get_settings_sql is not documented
(#113) Function quizaccess_offlinemode::description is not documented
(#124) Function quizaccess_offlinemode::setup_attempt_page is not documented

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


Missing changes in external functions or backup support for new detected tables or columns

(0 errors, 0 warnings)

This section shows potential problems detected when there are new database structures added in a patch and it is detected that nothing has been changed related with external functions (to be used by WS) or backup and restore. It must be checked that everything is correct and nothing is being missed in those areas. [More info]


grunt changes

(1 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt shifter

shifter problems

(2 errors, 0 warnings)

This section shows problems detected by shifter [More info]

mod/quiz/accessrule/offlinemode/yui/src/download/js/download.js
contains 4 lint errors
mod/quiz/accessrule/offlinemode/yui/src/autosave/js/autosave.js
contains 3 lint errors

Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]