Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(28 errors, 16 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/quiz/accessrule/delayed/backup/moodle2/backup_quizaccess_delayed_subplugin.class.php
(#41) Opening brace must not be followed by a blank line
(#43) Missing docblock for function define_quiz_subplugin_structure
(#48) Opening parenthesis of a multi-line function call must be the last content on the line
(#49) Multi-line function call not indented correctly; expected 8 spaces but found 16
(#49) Only one argument is allowed per line in a multi-line function call
(#49) Short array syntax must be used to define arrays
(#49) Closing parenthesis of a multi-line function call must be on a line by itself
(#56) Opening parenthesis of a multi-line function call must be the last content on the line
(#57) Multi-line function call not indented correctly; expected 8 spaces but found 16
(#57) Short array syntax must be used to define arrays
(#57) Closing parenthesis of a multi-line function call must be on a line by itself
mod/quiz/accessrule/delayed/backup/moodle2/restore_quizaccess_delayed_subplugin.class.php
(#41) Opening brace must not be followed by a blank line
(#43) Missing docblock for function define_quiz_subplugin_structure
(#45) Short array syntax must be used to define arrays
mod/quiz/accessrule/delayed/classes/privacy/provider.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#35) Opening brace must not be followed by a blank line
(#43) There must not be a space before the colon in a return type declaration
mod/quiz/accessrule/delayed/db/access.php
(#20) Incorrect @package tag for file access.php. Expected quizaccess_delayed, found quiz_delayed.
mod/quiz/accessrule/delayed/db/upgrade.php
(#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#29) Docblock tag "@global" is not recommended.
(#34) Inline doc block comments are not allowed; use "// Comment." instead
(#34) Docblock tag "@global" is not recommended.
(#39) Blank line found at start of control structure
(#49) Short array syntax must be used to define arrays
(#50) Short array syntax must be used to define arrays
(#50) Short array syntax must be used to define arrays
mod/quiz/accessrule/delayed/lang/eu/quizaccess_delayed.php
(#33) The string key "quizaccess_delayed_enabled" is not in the correct order, it should be before "quizwillstartinless"
(#34) The string key "quizaccess_delayed_allowdisable" is not in the correct order, it should be before "quizaccess_delayed_enabled"
(#37) The string key "quizaccess_delayed_dangerousquiznotice" is not in the correct order, it should be before "quizaccess_delayed_showdangerousquiznotice"
(#39) The string key "quizaccess_delayed_maxdelay" is not in the correct order, it should be before "quizaccess_delayed_startrate"
(#41) The string key "quizaccess_delayed_notice" is not in the correct order, it should be before "quizaccess_delayed_timelimitpercent"
(#43) The string key "quizaccess_delayed_countertype" is not in the correct order, it should be before "quizaccess_delayed_teachernotice"
(#43) Expected at least 1 space after "="; 0 found
(#43) Expected 1 space after "="; 0 found
(#44) The string key "pleasewait" is not in the correct order, it should be before "quizaccess_delayed_countertype"
(#45) The string key "noscriptwarning" is not in the correct order, it should be before "pleasewait"
(#47) The string key "pluginname" is not in the correct order, it should be before "pluginname_desc"
(#48) The string key "delayedattemptlock" is not in the correct order, it should be before "pluginname"
(#49) Whitespace found at end of line within string
(#54) The string key "flipdowncounter" is not in the correct order, it should be before "tooshorttimeguardadvice"
mod/quiz/accessrule/delayed/rule.php
(#351) Inline doc block comments are not allowed; use "// Comment." instead
(#424) This comment is 43% valid code; is this commented out code?
mod/quiz/accessrule/delayed/settings.php
(#52) Inline doc block comments are not allowed; use "// Comment." instead
mod/quiz/accessrule/delayed/version.php
(#35) Expected 1 newline at end of file; 0 found

Javascript coding style problems

(39 errors, 52 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

mod/quiz/accessrule/delayed/Gruntfile.js
(#26) 'module' is not defined. (no-undef)
(#29) 'process' is not defined. (no-undef)
(#29) 'process' is not defined. (no-undef)
(#35) '__dirname' is not defined. (no-undef)
(#36) '__dirname' is not defined. (no-undef)
(#59) Identifier 'uglify_rename' is not in camel case. (camelcase)
(#59) Unexpected space before function parentheses. (space-before-function-paren)
(#81) There should be no space after '{'. (@babel/object-curly-spacing)
(#81) There should be no space before '}'. (@babel/object-curly-spacing)
(#82) There should be no space after '{'. (@babel/object-curly-spacing)
(#82) There should be no space before '}'. (@babel/object-curly-spacing)
(#95) Identifier 'uglify_rename' is not in camel case. (camelcase)
(#113) Identifier 'uglify_rename' is not in camel case. (camelcase)
(#124) Identifier 'uglify_rename' is not in camel case. (camelcase)
(#177) Unexpected space before function parentheses. (space-before-function-paren)
(#179) There should be no space after this paren. (space-in-parens)
(#179) '__dirname' is not defined. (no-undef)
(#226) 'process' is not defined. (no-undef)
(#227) Unexpected space before function parentheses. (space-before-function-paren)
(#274) There should be no space after '{'. (@babel/object-curly-spacing)
(#274) Identifier 'uglify_rename' is not in camel case. (camelcase)
(#274) There should be no space before '}'. (@babel/object-curly-spacing)
(#275) There should be no space after '{'. (@babel/object-curly-spacing)
(#275) Identifier 'uglify_rename' is not in camel case. (camelcase)
(#275) There should be no space before '}'. (@babel/object-curly-spacing)
mod/quiz/accessrule/delayed/amd/src/timer_flipdown.js
(#20) @package should be empty. (jsdoc/empty-tags)
(#25) There should be no space after this paren. (space-in-parens)
(#25) Unexpected space before function parentheses. (space-before-function-paren)
(#29) Identifier 'get_string' is not in camel case. (camelcase)
(#29) Unexpected space before function parentheses. (space-before-function-paren)
(#29) 'param' is assigned a value but never used. (no-unused-vars)
(#32) Identifier 'set_strings' is not in camel case. (camelcase)
(#32) Unexpected space before function parentheses. (space-before-function-paren)
(#35) Missing JSDoc @param "actionlink" declaration. (jsdoc/require-param)
(#35) Missing JSDoc @param "cmid" declaration. (jsdoc/require-param)
(#35) Missing JSDoc @param "sessionkey" declaration. (jsdoc/require-param)
(#35) Missing JSDoc @param "attemptquiz" declaration. (jsdoc/require-param)
(#35) Missing JSDoc @param "diffmillisecs" declaration. (jsdoc/require-param)
(#35) Missing JSDoc @param "langstrings" declaration. (jsdoc/require-param)
(#37) Missing JSDoc @param "selector" type. (jsdoc/require-param-type)
(#39) Expected to return a value at the end of method 'init'. (consistent-return)
(#39) Unexpected space before function parentheses. (space-before-function-paren)
(#55) 'jQuery' is not defined. (no-undef)
(#92) Unexpected space before function parentheses. (space-before-function-paren)
(#93) 'FlipDown' is not defined. (no-undef)
(#102) Unexpected space before function parentheses. (space-before-function-paren)
(#118) Missing semicolon. (@babel/semi)
mod/quiz/accessrule/delayed/amd/src/timer_text.js
(#20) @package should be empty. (jsdoc/empty-tags)
(#25) There should be no space after this paren. (space-in-parens)
(#25) Unexpected space before function parentheses. (space-before-function-paren)
(#30) Identifier 'get_string' is not in camel case. (camelcase)
(#30) Unexpected space before function parentheses. (space-before-function-paren)
(#30) 'param' is assigned a value but never used. (no-unused-vars)
(#33) Identifier 'set_strings' is not in camel case. (camelcase)
(#33) Unexpected space before function parentheses. (space-before-function-paren)
(#36) Missing JSDoc @param "selector" declaration. (jsdoc/require-param)
(#36) Missing JSDoc @param "actionlink" declaration. (jsdoc/require-param)
(#36) Missing JSDoc @param "cmid" declaration. (jsdoc/require-param)
(#36) Missing JSDoc @param "sessionkey" declaration. (jsdoc/require-param)
(#36) Missing JSDoc @param "attemptquiz" declaration. (jsdoc/require-param)
(#36) Missing JSDoc @param "diffmillisecs" declaration. (jsdoc/require-param)
(#36) Missing JSDoc @param "langstrings" declaration. (jsdoc/require-param)
(#39) Expected to return a value at the end of method 'init'. (consistent-return)
(#39) Unexpected space before function parentheses. (space-before-function-paren)
(#80) Identifier 'update_time' is not in camel case. (camelcase)
(#80) Unexpected space before function parentheses. (space-before-function-paren)
(#100) Missing JSDoc @param "durationinseconds" declaration. (jsdoc/require-param)
(#100) Missing JSDoc @param "usemonths" declaration. (jsdoc/require-param)
(#100) Missing JSDoc @param "shortprecission" declaration. (jsdoc/require-param)
(#100) Missing JSDoc @param "depth" declaration. (jsdoc/require-param)
(#104) Expected @param names to be "durationinseconds, usemonths, shortprecission, depth". Got "int, boolean, boolean". (jsdoc/check-param-names)
(#104) Missing JSDoc @param "int" type. (jsdoc/require-param-type)
(#105) Missing JSDoc @param "boolean" type. (jsdoc/require-param-type)
(#106) Missing JSDoc @param "boolean" type. (jsdoc/require-param-type)
(#109) Identifier 'get_nice_duration' is not in camel case. (camelcase)
(#109) Method 'get_nice_duration' has a complexity of 23. Maximum allowed is 20. (complexity)
(#109) Unexpected space before function parentheses. (space-before-function-paren)
(#110) 'durationstring' is assigned a value but never used. (no-unused-vars)
(#113) 'durationinseconds' is already defined. (no-redeclare)
(#169) Missing semicolon. (@babel/semi)
mod/quiz/accessrule/delayed/gulpfile.js
(#6) 'GulpClient' is assigned a value but never used. (no-unused-vars)
(#15) There should be no space after '{'. (object-curly-spacing)
(#15) There should be no space before '}'. (object-curly-spacing)
(#16) There should be no space after '{'. (object-curly-spacing)
(#16) There should be no space before '}'. (object-curly-spacing)
(#18) Unexpected space before function parentheses. (space-before-function-paren)
(#28) Unexpected space before function parentheses. (space-before-function-paren)
(#34) Unexpected space before function parentheses. (space-before-function-paren)
(#40) There should be no space after '{'. (object-curly-spacing)
(#40) There should be no space before '}'. (object-curly-spacing)
(#49) Unexpected space before function parentheses. (space-before-function-paren)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(6 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

mod/quiz/accessrule/delayed/rule.php
(#219) Phpdocs for function quizaccess_delayed::get_time_span has incomplete parameters list
(#236) Inline phpdocs tag {@link mod_quiz_mod_form::definition()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#267) Inline phpdocs tag {@link quiz_after_add_or_update()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#283) Inline phpdocs tag {@link quiz_delete_instance()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#296) Inline phpdocs tag {@link quiz_access_manager::load_settings()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#299) Inline phpdocs tag {@link get_extra_settings()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "eslint:amd" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]