PHP lint problems
(0 errors, 0 warnings)
This section shows php lint problems in the code detected by php -l [More info]
PHP coding style problems
(0 errors, 25 warnings)
This section shows the coding style problems detected in the code by phpcs [More info]
- question/type/varnumunit/tests/privacy_provider_test.php
- (#25) PHPUnit class "qtype_varnumunit\tests\qtype_varnumunit_privacy_provider_testcase", with namespace "qtype_varnumunit\tests", currently located at "tests/" directory, does not match its expected location at "tests/tests"
- (#45) PHPUnit testcase name "qtype_varnumunit_privacy_provider_testcase" does not match file name "privacy_provider_test"
- (#48) Test method test_get_metadata() is missing any coverage information, own or at class level
- (#54) Test method test_export_user_preferences_no_pref() is missing any coverage information, own or at class level
- (#71) Test method test_export_user_preferences() is missing any coverage information, own or at class level
- question/type/varnumunit/tests/question_test.php
- (#38) PHPUnit testcase name "qtype_varnumunit_question_test" does not match file name "question_test"
- (#38) PHPUnit class "qtype_varnumunit_question_test" does not have any namespace. It is recommended to add it to the "qtype_varnumunit" namespace, using more levels if needed, in order to match the code being tested
- (#149) Test method test_question_responses() is missing any coverage information, own or at class level
- (#286) Test method test_classify_response_correct_response() is missing any coverage information, own or at class level
- question/type/varnumunit/tests/questiontype_test.php
- (#39) PHPUnit testcase name "qtype_varnumunit_test" does not match file name "questiontype_test"
- (#39) PHPUnit class "qtype_varnumunit_test" does not have any namespace. It is recommended to add it to the "qtype_varnumunit" namespace, using more levels if needed, in order to match the code being tested
- (#64) Test method test_get_random_guess_score() is missing any coverage information, own or at class level
- (#69) Test method test_get_possible_responses() is missing any coverage information, own or at class level
- (#86) Test method test_xml_import() is missing any coverage information, own or at class level
- (#295) Test method test_xml_import_legacy() is missing any coverage information, own or at class level
- question/type/varnumunit/tests/walkthrough_test.php
- (#40) PHPUnit testcase name "qtype_varnumunit_walkthrough_test" does not match file name "walkthrough_test"
- (#40) PHPUnit class "qtype_varnumunit_walkthrough_test" does not have any namespace. It is recommended to add it to the "qtype_varnumunit" namespace, using more levels if needed, in order to match the code being tested
- (#47) Test method test_validation_and_interactive_with_m_unit_submission_with_no_unit() is missing any coverage information, own or at class level
- (#129) Test method test_validation_and_interactive_with_m_unit_submission_with_no_unit_then_with_unit() is missing any coverage information, own or at class level
- (#197) Test method test_validation_and_interactive_with_m_unit_submission_with_wrong_unit_and_partially_correct_number() is missing any coverage information, own or at class level
- (#265) Test method test_validation_and_interactive_with_simple_1_m_question() is missing any coverage information, own or at class level
- (#334) Test method test_deferred_feedback_with_wrong_unit_and_wrong_number() is missing any coverage information, own or at class level
- (#381) Test method test_deferred_feedback_with_wrong_unit_but_correct_number() is missing any coverage information, own or at class level
- (#429) Test method test_deferred_feedback_with_correct_unit_but_wrong_number() is missing any coverage information, own or at class level
- (#476) Test method test_deferred_feedback_with_correct_unit_and_correct_number() is missing any coverage information, own or at class level
Javascript coding style problems
(4 errors, 2 warnings)
This section shows the coding style problems detected in the code by eslint [More info]
- question/type/varnumunit/mobile/varnumunit.js
- (#49) This line has a length of 140. Maximum allowed is 132. (max-len)
- (#51) This line has a length of 136. Maximum allowed is 132. (max-len)
- (#54) This line has a length of 145. Maximum allowed is 132. (max-len)
- (#68) Expected to return a value at the end of method 'getPreventSubmitMessage'. (consistent-return)
- (#68) Unexpected space before function parentheses. (space-before-function-paren)
- (#81) Expected an assignment or function call and instead saw an expression. (no-unused-expressions)
CSS problems
(0 errors, 0 warnings)
This section shows CSS problems detected by stylelint [More info]
PHPDocs style problems
(95 errors, 0 warnings)
This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]
- question/type/varnumunit/backup/moodle2/backup_qtype_varnumunit_plugin.class.php
- (#78) Function backup_qtype_varnumunit_plugin::add_question_qtype_varnumunit_vars is not documented
- (#100) Function backup_qtype_varnumunit_plugin::add_question_qtype_varnumunit_variants is not documented
- (#121) Function backup_qtype_varnumunit_plugin::add_question_qtype_varnumunit_answers is not documented
- (#149) Function backup_qtype_varnumunit_plugin::add_question_qtype_varnumunit_units is not documented
- (#17) No one-line description found in phpdocs for file
- (#173) Inline phpdocs tag {@link get_components_and_fileareas} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
- question/type/varnumunit/backup/moodle2/restore_qtype_varnumunit_plugin.class.php
- (#103) Function restore_qtype_varnumunit_plugin::process_qtype_varnumunit_var is not documented
- (#121) Function restore_qtype_varnumunit_plugin::process_qtype_varnumunit_unit is not documented
- (#144) Function restore_qtype_varnumunit_plugin::process_qtype_varnumunit_variant is not documented
- (#17) No one-line description found in phpdocs for file
- (#23) No one-line description found in phpdocs for class restore_qtype_varnumunit_plugin
- (#56) Phpdocs for function restore_qtype_varnumunit_plugin::process_qtype_varnumunit has incomplete parameters list
- (#83) Phpdocs for function restore_qtype_varnumunit_plugin::process_qtype_varnumunit_answer has incomplete parameters list
- question/type/varnumunit/calculator.php
- (#24) Package qtype is not valid
- question/type/varnumunit/classes/output/mobile.php
- (#28) Function mobile::varnumunit_view is not documented
- question/type/varnumunit/db/mobile.php
- (#20) Package qtype_varnumeric is not valid
- question/type/varnumunit/db/upgrade.php
- (#20) Package qtype is not valid
- (#26) Function xmldb_qtype_varnumunit_upgrade is not documented
- question/type/varnumunit/edit_varnumunit_form.php
- (#40) Function qtype_varnumunit_edit_form::qtype is not documented
- (#74) Function qtype_varnumunit_edit_form::data_preprocessing is not documented
- (#130) Function qtype_varnumunit_edit_form::unit_feedback_html_element_preprocess is not documented
- (#217) Function qtype_varnumunit_edit_form::add_answer_form_part is not documented
- (#226) Function qtype_varnumunit_edit_form::definition is not documented
- (#255) Function qtype_varnumunit_edit_form::definition_inner is not documented
- (#265) Function qtype_varnumunit_edit_form::grade_weighting is not documented
- (#307) Function qtype_varnumunit_edit_form::validation is not documented
- (#46) Phpdocs for function qtype_varnumunit_edit_form::get_per_unit_fields has incomplete parameters list
- (#152) Phpdocs for function qtype_varnumunit_edit_form::add_per_unit_fields has incomplete parameters list
- question/type/varnumunit/lib.php
- (#25) Phpdocs for function qtype_varnumunit_pluginfile has incomplete parameters list
- question/type/varnumunit/question.php
- (#20) Package qtype is not valid
- (#43) Function qtype_varnumunit_question::get_pre_post_validation_error is not documented
- (#51) Function qtype_varnumunit_question::get_matching_unit is not documented
- (#65) Function qtype_varnumunit_question::get_units is not documented
- (#73) Function qtype_varnumunit_question::remove_unwanted_chars_from_unit is not documented
- (#80) Function qtype_varnumunit_question::pmatch_options is not documented
- (#84) Function qtype_varnumunit_question::check_for_unit_in_response is not documented
- (#110) Function qtype_varnumunit_question::check_for_match_for_unit_pmatch_expression is not documented
- (#116) Function qtype_varnumunit_question::grade_response is not documented
- (#123) Function qtype_varnumunit_question::weight_grades_for_num_and_unit_part is not documented
- (#128) Function qtype_varnumunit_question::grade_unit_part_of_response is not documented
- (#137) Function qtype_varnumunit_question::grade_numeric_part_of_response is not documented
- (#142) Function qtype_varnumunit_question::summarise_response is not documented
- (#152) Function qtype_varnumunit_question::split_response_into_num_and_unit is not documented
- (#159) Function qtype_varnumunit_question::feedback_for_post_prefix_parts is not documented
- (#163) Function qtype_varnumunit_question::compute_final_grade is not documented
- (#203) Function qtype_varnumunit_question::classify_response is not documented
- question/type/varnumunit/questiontype.php
- (#49) Function qtype_varnumunit::initialise_question_instance is not documented
- (#56) Function qtype_varnumunit::recalculate_every_time is not documented
- (#60) Function qtype_varnumunit::db_table_prefix is not documented
- (#64) Function qtype_varnumunit::extra_question_fields is not documented
- (#68) Function qtype_varnumunit::delete_files_in_units is not documented
- (#79) Function qtype_varnumunit::move_files_in_units is not documented
- (#90) Function qtype_varnumunit::delete_question is not documented
- (#97) Function qtype_varnumunit::save_units is not documented
- (#156) Function qtype_varnumunit::save_unit is not documented
- (#191) Function qtype_varnumunit::save_defaults_for_new_questions is not documented
- (#197) Function qtype_varnumunit::save_question_options is not documented
- (#207) Function qtype_varnumunit::get_question_options is not documented
- (#212) Function qtype_varnumunit::load_units is not documented
- (#235) Function qtype_varnumunit::get_possible_responses is not documented
- (#256) Function qtype_varnumunit::get_random_guess_score is not documented
- (#273) Function qtype_varnumunit::import_from_xml is not documented
- (#313) Function qtype_varnumunit::import_html is not documented
- (#323) Function qtype_varnumunit::export_to_xml is not documented
- (#347) Function qtype_varnumunit::export_html is not documented
- (#397) Function qtype_varnumunit_unit::__construct is not documented
- (#384) Variable qtype_varnumunit_unit::$id is not documented
- (#389) Variable qtype_varnumunit_unit::$spaceinunit is not documented
- (#390) Variable qtype_varnumunit_unit::$spacingfeedback is not documented
- (#391) Variable qtype_varnumunit_unit::$spacingfeedbackformat is not documented
- (#392) Variable qtype_varnumunit_unit::$replacedash is not documented
- (#393) Variable qtype_varnumunit_unit::$fraction is not documented
- (#394) Variable qtype_varnumunit_unit::$feedback is not documented
- (#395) Variable qtype_varnumunit_unit::$feedbackformat is not documented
- (#41) Constant qtype_varnumunit::SUPERSCRIPT_SCINOTATION_REQUIRED is not documented
- (#42) Constant qtype_varnumunit::SUPERSCRIPT_ALLOWED is not documented
- (#43) Constant qtype_varnumunit::SUPERSCRIPT_NONE is not documented
- (#45) Constant qtype_varnumunit::SPACEINUNIT_REMOVE_ALL_SPACE is not documented
- (#46) Constant qtype_varnumunit::SPACEINUNIT_PRESERVE_SPACE_NOT_REQUIRE is not documented
- (#47) Constant qtype_varnumunit::SPACEINUNIT_PRESERVE_SPACE_REQUIRE is not documented
- (#375) No one-line description found in phpdocs for class qtype_varnumunit_unit
- question/type/varnumunit/renderer.php
- (#20) Package qtype is not valid
- (#39) Function qtype_varnumunit_renderer::specific_feedback is not documented
- (#53) Function qtype_varnumunit_renderer::correct_response is not documented
- question/type/varnumunit/tests/helper.php
- (#32) Function qtype_varnumunit_test_helper::get_test_questions is not documented
- (#273) Function qtype_varnumunit_test_helper::make_varnumunit_question_with_variables is not documented
- (#292) Function qtype_varnumunit_test_helper::get_varnumunit_question_form_data_with_variables is not documented
- (#37) There is no description in phpdocs for function make_varnumunit_question_3_sig_figs_with_m_unit
- (#109) There is no description in phpdocs for function make_varnumunit_question_3_sig_figs_with_units_meters_per_second
- (#190) There is no description in phpdocs for function make_varnumunit_question_simple_1_m
- (#248) There is no description in phpdocs for function make_varnumunit_question_require_space_between_number_n_unit
- question/type/varnumunit/tests/question_test.php
- (#144) Phpdocs for function qtype_varnumunit_question_test::test_question_responses has incomplete parameters list
- question/type/varnumunit/tests/questiontype_test.php
- (#51) Function qtype_varnumunit_test::get_test_question_data is not documented
- (#40) Variable qtype_varnumunit_test::$includecoverage is not documented
- (#45) Variable qtype_varnumunit_test::$qtype is not documented
Update savepoints problems
(0 errors, 0 warnings)
This section shows problems detected with the handling of upgrade savepoints [More info]
Third party library modification problems
(0 errors, 0 warnings)
This section shows problems detected with the modification of third party libraries [More info]
Missing changes in external functions or backup support for new detected tables or columns
(0 errors, 2 warnings)
This section shows potential problems detected when there are new database structures added in a patch and it is detected that nothing has been changed related with external functions (to be used by WS) or backup and restore. It must be checked that everything is correct and nothing is being missed in those areas. [More info]
- question/type/varnumunit/db/upgrade.php
- Database modifications (new tables or columns) detected in the patch without any change to some important areas.
- No changes detected to external functions, that may affect apps and other web service integrations, please verify!
grunt changes
(0 errors, 0 warnings)
This section shows files built by grunt and not commited [More info]
shifter problems
(0 errors, 0 warnings)
This section shows problems detected by shifter [More info]
Mustache template problems
(0 errors, 0 warnings)
This section shows problems detected in mustache templates [More info]
Gherkin .feature problems
(0 errors, 0 warnings)
This section shows problems detected in behat .feature files [More info]