Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(0 errors, 38 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

question/type/varnumericset/tests/evalmathsclass_test.php
(#38) PHPUnit testcase name "qtype_varnumericset_evalmath_test" does not match file name "evalmathsclass_test"
(#38) PHPUnit class "qtype_varnumericset_evalmath_test" does not have any namespace. It is recommended to add it to the "qtype_varnumericset" namespace, using more levels if needed, in order to match the code being tested
(#39) Test method test_basic_expressions() is missing any coverage information, own or at class level
(#51) Test method test_random_expressions() is missing any coverage information, own or at class level
question/type/varnumericset/tests/number_interpreter_test.php
(#40) PHPUnit testcase name "qtype_varnumericset_number_interpreter_test" does not match file name "number_interpreter_test"
(#40) PHPUnit class "qtype_varnumericset_number_interpreter_test" does not have any namespace. It is recommended to add it to the "qtype_varnumericset" namespace, using more levels if needed, in order to match the code being tested
(#41) Test method test_interpret_number_with_optional_decimal_place() is missing any coverage information, own or at class level
(#88) Test method test_interpret_number_with_optional_sci_notation_not_accepting_html_exponent() is missing any coverage information, own or at class level
(#152) Test method test_interpret_number_with_optional_sci_notation_accepting_html_exponent() is missing any coverage information, own or at class level
question/type/varnumericset/tests/question_test.php
(#40) PHPUnit testcase name "qtype_varnumericset_question_test" does not match file name "question_test"
(#40) PHPUnit class "qtype_varnumericset_question_test" does not have any namespace. It is recommended to add it to the "qtype_varnumericset" namespace, using more levels if needed, in order to match the code being tested
(#85) Test method test_num_within_allowed_error() is missing any coverage information, own or at class level
(#114) Test method test_wrong_by_a_factor_of_ten() is missing any coverage information, own or at class level
(#126) Test method test_has_number_of_sig_figs() is missing any coverage information, own or at class level
(#171) Test method test_has_too_many_sig_figs() is missing any coverage information, own or at class level
(#212) Test method test_rounding_incorrect() is missing any coverage information, own or at class level
(#256) Test method test_round_to() is missing any coverage information, own or at class level
(#273) Test method test_compare_response_with_answer() is missing any coverage information, own or at class level
(#311) Test method test_compare_num_as_string_with_answer() is missing any coverage information, own or at class level
(#360) Test method test_compare_num_as_string_with_answer_no_rounding() is missing any coverage information, own or at class level
(#380) Test method test_grade_response() is missing any coverage information, own or at class level
(#452) Test method test_get_question_summary() is missing any coverage information, own or at class level
question/type/varnumericset/tests/questiontype_test.php
(#40) PHPUnit testcase name "qtype_varnumericset_test" does not match file name "questiontype_test"
(#40) PHPUnit class "qtype_varnumericset_test" does not have any namespace. It is recommended to add it to the "qtype_varnumericset" namespace, using more levels if needed, in order to match the code being tested
(#62) Test method test_name() is missing any coverage information, own or at class level
(#66) Test method test_can_analyse_responses() is missing any coverage information, own or at class level
(#70) Test method test_get_random_guess_score() is missing any coverage information, own or at class level
(#75) Test method test_get_possible_responses() is missing any coverage information, own or at class level
question/type/varnumericset/tests/walkthrough_test.php
(#40) PHPUnit testcase name "qtype_varnumericset_walkthrough_testcase" does not match file name "walkthrough_test"
(#40) PHPUnit class "qtype_varnumericset_walkthrough_testcase" does not have any namespace. It is recommended to add it to the "qtype_varnumericset" namespace, using more levels if needed, in order to match the code being tested
(#41) Test method test_validation_and_interactive_with_one_try_for_3_sig_figs() is missing any coverage information, own or at class level
(#116) Test method test_validation_and_interactive_with_several_tries_for_3_sig_figs_with_standard_penalty() is missing any coverage information, own or at class level
(#179) Test method test_validation_and_interactive_with_several_tries_for_3_sig_figs_with_autocheck_penalty() is missing any coverage information, own or at class level
(#270) Test method test_deferred_feedback_for_3_sig_figs_blank_answer() is missing any coverage information, own or at class level
(#313) Test method test_deferred_feedback_for_3_sig_figs_answer_with_thousand_separator() is missing any coverage information, own or at class level
(#353) Test method test_deferred_feedback_for_3_sig_figs_answer_point_0() is missing any coverage information, own or at class level
(#390) Test method test_deferred_feedback_for_3_sig_figs_answer_with_correct_answer() is missing any coverage information, own or at class level
(#430) Test method test_deferred_feedback_custom_rounding_feebdack_should_still_show_with_unit() is missing any coverage information, own or at class level

Javascript coding style problems

(5 errors, 2 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

question/type/varnumericset/mobile/varnumset.js
(#50) This line has a length of 140. Maximum allowed is 132. (max-len)
(#52) This line has a length of 136. Maximum allowed is 132. (max-len)
(#55) This line has a length of 145. Maximum allowed is 132. (max-len)
(#55) Trailing spaces not allowed. (no-trailing-spaces)
(#68) Expected to return a value at the end of method 'getPreventSubmitMessage'. (consistent-return)
(#68) Unexpected space before function parentheses. (space-before-function-paren)
(#81) Expected an assignment or function call and instead saw an expression. (no-unused-expressions)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(197 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

question/type/varnumericset/backup/moodle2/backup_qtype_varnumericset_plugin.class.php
(#70) Function backup_qtype_varnumericset_plugin::add_question_qtype_varnumericset_vars is not documented
(#93) Function backup_qtype_varnumericset_plugin::add_question_qtype_varnumericset_variants is not documented
(#113) Function backup_qtype_varnumericset_plugin::add_question_qtype_varnumericset_answers is not documented
(#17) No one-line description found in phpdocs for file
question/type/varnumericset/backup/moodle2/restore_qtype_varnumericset_plugin.class.php
(#102) Function restore_qtype_varnumericset_plugin::process_qtype_varnumericset_var is not documented
(#120) Function restore_qtype_varnumericset_plugin::process_qtype_varnumericset_variant is not documented
(#17) No one-line description found in phpdocs for file
(#23) No one-line description found in phpdocs for class restore_qtype_varnumericset_plugin
(#55) Phpdocs for function restore_qtype_varnumericset_plugin::process_qtype_varnumericset has incomplete parameters list
(#82) Phpdocs for function restore_qtype_varnumericset_plugin::process_qtype_varnumericset_answer has incomplete parameters list
question/type/varnumericset/calculatorbase.php
(#29) Package is not specified for class qtype_varnumeric_calculator_base. It is also not specified in file-level phpdocs
(#29) Class qtype_varnumeric_calculator_base is not documented
(#72) Function qtype_varnumeric_calculator_base::add_variable is not documented
(#76) Function qtype_varnumeric_calculator_base::add_defined_variant is not documented
(#84) Function qtype_varnumeric_calculator_base::add_answer is not documented
(#91) Function qtype_varnumeric_calculator_base::add_text_with_embedded_variables is not documented
(#115) Function qtype_varnumeric_calculator_base::get_num_variants_in_form is not documented
(#124) Function qtype_varnumeric_calculator_base::get_errors is not documented
(#128) Function qtype_varnumeric_calculator_base::get_calculated_variants is not documented
(#132) Function qtype_varnumeric_calculator_base::get_defined_variant is not documented
(#171) Function qtype_varnumeric_calculator_base::evaluate is not documented
(#218) Function qtype_varnumeric_calculator_base::calculate_calculated_variant_values is not documented
(#243) Function qtype_varnumeric_calculator_base::load_state_from_qt_data is not documented
(#251) Function qtype_varnumeric_calculator_base::load_data_from_form is not documented
(#311) Function qtype_varnumeric_calculator_base::set_recalculate_rand is not documented
(#315) Function qtype_varnumeric_calculator_base::load_data_from_database is not documented
(#334) Function qtype_varnumeric_calculator_base::get_data_for_form is not documented
(#354) Function qtype_varnumeric_calculator_base::get_var_types is not documented
(#358) Function qtype_varnumeric_calculator_base::get_var_names is not documented
(#362) Function qtype_varnumeric_calculator_base::get_defined_variants is not documented
(#366) Function qtype_varnumeric_calculator_base::is_assignment is not documented
(#374) Function qtype_varnumeric_calculator_base::var_in_assignment is not documented
(#379) Function qtype_varnumeric_calculator_base::evaluate_variables_in_text is not documented
(#409) Function qtype_varnumeric_calculator_base::format_number is not documented
(#413) Function qtype_varnumeric_calculator_base::htmlize_exponent is not documented
(#64) Variable qtype_varnumeric_calculator_base::$noofvariants is not documented
(#66) Variable qtype_varnumeric_calculator_base::$answers is not documented
(#68) Variable qtype_varnumeric_calculator_base::$textswithembeddedvars is not documented
(#70) Variable qtype_varnumeric_calculator_base::$errors is not documented
(#232) Phpdocs for function qtype_varnumeric_calculator_base::save_state_as_qt_data has incomplete parameters list
question/type/varnumericset/classes/output/mobile.php
(#28) Function mobile::varnumset_view is not documented
question/type/varnumericset/db/mobile.php
(#20) Package qtype_varnumeric is not valid
question/type/varnumericset/edit_varnumericset_form.php
(#20) Package qtype is not valid
(#38) Function qtype_varnumericset_edit_form::qtype is not documented
(#42) Function qtype_varnumericset_edit_form::definition_inner is not documented
question/type/varnumericset/edit_varnumericset_form_base.php
(#38) Function qtype_varnumeric_edit_form_base::definition_inner is not documented
(#120) Function qtype_varnumeric_edit_form_base::add_value_form_fields is not documented
(#160) Function qtype_varnumeric_edit_form_base::add_value_form_last_field is not documented
(#174) Function qtype_varnumeric_edit_form_base::get_per_answer_fields is not documented
(#230) Function qtype_varnumeric_edit_form_base::get_hint_fields is not documented
(#243) Function qtype_varnumeric_edit_form_base::data_preprocessing is not documented
(#292) Function qtype_varnumeric_edit_form_base::validation is not documented
(#388) Function qtype_varnumeric_edit_form_base::qtype_obj is not documented
(#392) Function qtype_varnumeric_edit_form_base::db_table_prefix is not documented
(#269) Phpdocs for function qtype_varnumeric_edit_form_base::data_preprocessing_answers has incomplete parameters list
(#268) Inline phpdocs tag {@link add_per_answer_fields()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
question/type/varnumericset/lang/en/qtype_varnumericset.php
(#20) Package qtype is not valid
question/type/varnumericset/lib.php
(#21) Package qtype is not valid
(#27) Phpdocs for function qtype_varnumericset_pluginfile has incomplete parameters list
question/type/varnumericset/number_interpreter.php
(#67) Package is not specified for class qtype_varnumericset_number_interpreter_part_using_preg_pattern. It is also not specified in file-level phpdocs
(#127) Package is not specified for class qtype_varnumericset_number_interpreter_number_with_optional_decimal_place. It is also not specified in file-level phpdocs
(#197) Package is not specified for class qtype_varnumericset_number_interpreter_exponent_following_float_base. It is also not specified in file-level phpdocs
(#232) Package is not specified for class qtype_varnumericset_number_interpreter_nonhtml_exponent_following_float. It is also not specified in file-level phpdocs
(#242) Package is not specified for class qtype_varnumericset_number_interpreter_html_exponent_following_float. It is also not specified in file-level phpdocs
(#259) Package is not specified for class qtype_varnumericset_number_interpreter_number_with_optional_sci_notation. It is also not specified in file-level phpdocs
(#17) File-level phpdocs block is not found
(#67) Class qtype_varnumericset_number_interpreter_part_using_preg_pattern is not documented
(#232) Class qtype_varnumericset_number_interpreter_nonhtml_exponent_following_float is not documented
(#69) Function qtype_varnumericset_number_interpreter_part_using_preg_pattern::pattern is not documented
(#71) Function qtype_varnumericset_number_interpreter_part_using_preg_pattern::match_pattern is not documented
(#86) Function qtype_varnumericset_number_interpreter_part_using_preg_pattern::extract_part is not documented
(#105) Function qtype_varnumericset_number_interpreter_part_using_preg_pattern::parts_to_extract is not documented
(#111) Function qtype_varnumericset_number_interpreter_part_using_preg_pattern::get_normalised_sign is not documented
(#121) Function qtype_varnumericset_number_interpreter_part_using_preg_pattern::match is not documented
(#133) Function qtype_varnumericset_number_interpreter_number_with_optional_decimal_place::pattern is not documented
(#141) Function qtype_varnumericset_number_interpreter_number_with_optional_decimal_place::parts_to_extract is not documented
(#149) Function qtype_varnumericset_number_interpreter_number_with_optional_decimal_place::get_pre_dec_point is not documented
(#153) Function qtype_varnumericset_number_interpreter_number_with_optional_decimal_place::set_pre_dec_point is not documented
(#157) Function qtype_varnumericset_number_interpreter_number_with_optional_decimal_place::get_post_dec_point is not documented
(#161) Function qtype_varnumericset_number_interpreter_number_with_optional_decimal_place::set_post_dec_point is not documented
(#165) Function qtype_varnumericset_number_interpreter_number_with_optional_decimal_place::get_normalised is not documented
(#187) Function qtype_varnumericset_number_interpreter_number_with_optional_decimal_place::match_pattern is not documented
(#204) Function qtype_varnumericset_number_interpreter_exponent_following_float_base::parts_to_extract is not documented
(#210) Function qtype_varnumericset_number_interpreter_exponent_following_float_base::set_value is not documented
(#219) Function qtype_varnumericset_number_interpreter_exponent_following_float_base::get_value is not documented
(#227) Function qtype_varnumericset_number_interpreter_exponent_following_float_base::get_normalised is not documented
(#235) Function qtype_varnumericset_number_interpreter_nonhtml_exponent_following_float::pattern is not documented
(#249) Function qtype_varnumericset_number_interpreter_html_exponent_following_float::pattern is not documented
(#272) Function qtype_varnumericset_number_interpreter_number_with_optional_sci_notation::__construct is not documented
(#276) Function qtype_varnumericset_number_interpreter_number_with_optional_sci_notation::match is not documented
(#332) Function qtype_varnumericset_number_interpreter_number_with_optional_sci_notation::get_normalised is not documented
(#34) Variable qtype_varnumericset_number_interpreter_base::$prefix is not documented
(#35) Variable qtype_varnumericset_number_interpreter_base::$postfix is not documented
(#109) Variable qtype_varnumericset_number_interpreter_part_using_preg_pattern::$sign is not documented
(#145) Variable qtype_varnumericset_number_interpreter_number_with_optional_decimal_place::$predecpoint is not documented
(#147) Variable qtype_varnumericset_number_interpreter_number_with_optional_decimal_place::$postdecpoint is not documented
(#208) Variable qtype_varnumericset_number_interpreter_exponent_following_float_base::$exp is not documented
(#270) Variable qtype_varnumericset_number_interpreter_number_with_optional_sci_notation::$normalised is not documented
(#46) There is no description in phpdocs for function get_prefix
(#53) There is no description in phpdocs for function get_normalised
(#58) There is no description in phpdocs for function get_postfix
(#97) Phpdocs for function qtype_varnumericset_number_interpreter_part_using_preg_pattern::extract_parts has incomplete parameters list
(#308) Phpdocs for function qtype_varnumericset_number_interpreter_number_with_optional_sci_notation::normalise_coeff has incomplete parameters list
question/type/varnumericset/question.php
(#37) Function qtype_varnumericset_question::get_variants_selection_seed is not documented
question/type/varnumericset/questionbase.php
(#62) Function qtype_varnumeric_question_base::get_expected_data is not documented
(#66) Function qtype_varnumeric_question_base::get_question_summary is not documented
(#72) Function qtype_varnumeric_question_base::summarise_response is not documented
(#80) Function qtype_varnumeric_question_base::is_no_response is not documented
(#84) Function qtype_varnumeric_question_base::is_complete_response is not documented
(#88) Function qtype_varnumeric_question_base::get_validation_error is not documented
(#113) Function qtype_varnumeric_question_base::get_pre_post_validation_error is not documented
(#121) Function qtype_varnumeric_question_base::is_gradable_response is not documented
(#133) Function qtype_varnumeric_question_base::is_same_response is not documented
(#138) Function qtype_varnumeric_question_base::get_answers is not documented
(#143) Function qtype_varnumeric_question_base::get_matching_answer is not documented
(#154) Function qtype_varnumeric_question_base::grade_response is not documented
(#164) Function qtype_varnumeric_question_base::get_correct_response is not documented
(#175) Function qtype_varnumeric_question_base::get_correct_answer is not documented
(#198) Function qtype_varnumeric_question_base::get_first_answer_graded_correct is not documented
(#207) Function qtype_varnumeric_question_base::compare_response_with_answer is not documented
(#302) Function qtype_varnumeric_question_base::feedback_for_post_prefix_parts is not documented
(#310) Function qtype_varnumeric_question_base::num_within_allowed_error is not documented
(#355) Function qtype_varnumeric_question_base::round_to is not documented
(#430) Function qtype_varnumeric_question_base::rounding_incorrect is not documented
(#451) Function qtype_varnumeric_question_base::check_file_access is not documented
(#467) Function qtype_varnumeric_question_base::get_variants_selection_seed is not documented
(#471) Function qtype_varnumeric_question_base::get_num_variants is not documented
(#475) Function qtype_varnumeric_question_base::start_attempt is not documented
(#480) Function qtype_varnumeric_question_base::apply_attempt_state is not documented
(#491) Function qtype_varnumeric_question_base::format_text is not documented
(#498) Function qtype_varnumeric_question_base::get_hint is not documented
(#516) Function qtype_varnumeric_question_base::compute_final_grade is not documented
(#553) Function qtype_varnumeric_question_base::classify_response is not documented
(#586) Variable qtype_varnumericset_answer::$sigfigs is not documented
(#587) Variable qtype_varnumericset_answer::$error is not documented
(#588) Variable qtype_varnumericset_answer::$syserrorpenalty is not documented
(#589) Variable qtype_varnumericset_answer::$checknumerical is not documented
(#590) Variable qtype_varnumericset_answer::$checkscinotation is not documented
(#591) Variable qtype_varnumericset_answer::$checkpowerof10 is not documented
(#592) Variable qtype_varnumericset_answer::$checkrounding is not documented
(#578) No one-line description found in phpdocs for class qtype_varnumericset_answer
(#484) There is no description in phpdocs for function get_random_seed
(#318) Phpdocs for function qtype_varnumeric_question_base::wrong_by_a_factor_of_ten has incomplete parameters list
(#596) Phpdocs for function qtype_varnumericset_answer::__construct has incomplete parameters list
question/type/varnumericset/questiontype.php
(#20) Package qtype is not valid
(#43) Function qtype_varnumericset::recalculate_every_time is not documented
(#47) Function qtype_varnumericset::db_table_prefix is not documented
question/type/varnumericset/questiontypebase.php
(#20) Package qtype is not valid
(#49) Function qtype_varnumeric_base::db_table_prefix is not documented
(#51) Function qtype_varnumeric_base::calculator_name is not documented
(#55) Function qtype_varnumeric_base::extra_question_fields is not documented
(#59) Function qtype_varnumeric_base::extra_answer_fields is not documented
(#70) Function qtype_varnumeric_base::move_files is not documented
(#76) Function qtype_varnumeric_base::delete_files is not documented
(#82) Function qtype_varnumeric_base::delete_question is not documented
(#103) Function qtype_varnumeric_base::save_question_options is not documented
(#358) Function qtype_varnumeric_base::finished_edit_wizard is not documented
(#367) Function qtype_varnumeric_base::initialise_question_instance is not documented
(#373) Function qtype_varnumeric_base::load_var_and_variants_from_db is not documented
(#391) Function qtype_varnumeric_base::initialise_question_vars_and_variants is not documented
(#420) Function qtype_varnumeric_base::get_random_guess_score is not documented
(#429) Function qtype_varnumeric_base::get_possible_responses is not documented
(#451) Function qtype_varnumeric_base::make_hint is not documented
(#42) There is no description in phpdocs for function recalculate_every_time
(#230) Phpdocs for function qtype_varnumeric_base::save_variants has incomplete parameters list
(#292) Phpdocs for function qtype_varnumeric_base::save_vars has incomplete parameters list
(#457) Phpdocs for function qtype_varnumeric_base::import_from_xml has incomplete parameters list
(#502) Phpdocs for function qtype_varnumeric_base::export_to_xml has incomplete parameters list
question/type/varnumericset/renderer.php
(#20) Package qtype is not valid
question/type/varnumericset/rendererbase.php
(#20) Package qtype is not valid
(#33) Function qtype_varnumeric_renderer_base::formulation_and_controls is not documented
(#122) Function qtype_varnumeric_renderer_base::specific_feedback is not documented
(#134) Function qtype_varnumeric_renderer_base::correct_response is not documented
question/type/varnumericset/tests/evalmathsclass_test.php
(#17) No one-line description found in phpdocs for file
question/type/varnumericset/tests/helper.php
(#20) Package qtype is not valid
(#33) Function qtype_varnumericset_test_helper::get_test_questions is not documented
(#109) Function qtype_varnumericset_test_helper::make_varnumericset_question_3_sig_figs_2 is not documented
(#162) Function qtype_varnumericset_test_helper::make_varnumericset_question_3_sig_figs_point_0 is not documented
(#172) Function qtype_varnumericset_test_helper::make_varnumericset_question_with_variables is not documented
(#191) Function qtype_varnumericset_test_helper::get_varnumericset_question_form_data_with_variables is not documented
(#235) Function qtype_varnumericset_test_helper::make_varnumericset_question_custom_rounding_feebdack is not documented
(#39) There is no description in phpdocs for function make_varnumericset_question_no_accepted_error
(#85) There is no description in phpdocs for function make_varnumericset_question_numeric_accepted_error
(#96) There is no description in phpdocs for function make_varnumericset_question_3_sig_figs
(#119) There is no description in phpdocs for function make_varnumericset_question_3_sig_figs_trailing_zero
(#132) There is no description in phpdocs for function make_varnumericset_question_3_sig_figs_trailing_zero_negative_answer
(#145) There is no description in phpdocs for function make_varnumericset_question_1_sig_fig
question/type/varnumericset/tests/question_test.php
(#82) There is no description in phpdocs for function test_num_within_allowed_error
(#111) There is no description in phpdocs for function test_wrong_by_a_factor_of_ten
(#253) There is no description in phpdocs for function test_round_to
(#82) Phpdocs for function qtype_varnumericset_question_test::test_num_within_allowed_error has incomplete parameters list
(#111) Phpdocs for function qtype_varnumericset_question_test::test_wrong_by_a_factor_of_ten has incomplete parameters list
(#253) Phpdocs for function qtype_varnumericset_question_test::test_round_to has incomplete parameters list
question/type/varnumericset/tests/questiontype_test.php
(#20) Package qtype is not valid
(#52) Function qtype_varnumericset_test::get_test_question_data is not documented
(#41) Variable qtype_varnumericset_test::$includecoverage is not documented
(#46) Variable qtype_varnumericset_test::$qtype is not documented

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


Missing changes in external functions or backup support for new detected tables or columns

(0 errors, 0 warnings)

This section shows potential problems detected when there are new database structures added in a patch and it is detected that nothing has been changed related with external functions (to be used by WS) or backup and restore. It must be checked that everything is correct and nothing is being missed in those areas. [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]