Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(0 errors, 20 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

question/type/varnumeric/edit_varnumeric_form.php
(#42) Possible useless method overriding detected
question/type/varnumeric/tests/evalmathsclass_test.php
(#37) PHPUnit testcase name "qtype_varnumeric_evalmath_test" does not match file name "evalmathsclass_test"
(#37) PHPUnit class "qtype_varnumeric_evalmath_test" does not have any namespace. It is recommended to add it to the "qtype_varnumeric" namespace, using more levels if needed, in order to match the code being tested
(#39) Test method test_basic_expressions() is missing any coverage information, own or at class level
(#52) Test method test_random_expressions() is missing any coverage information, own or at class level
question/type/varnumeric/tests/question_test.php
(#39) PHPUnit testcase name "qtype_varnumeric_question_test" does not match file name "question_test"
(#39) PHPUnit class "qtype_varnumeric_question_test" does not have any namespace. It is recommended to add it to the "qtype_varnumeric" namespace, using more levels if needed, in order to match the code being tested
(#40) Test method test_wrong_by_a_factor_of_ten() is missing any coverage information, own or at class level
(#55) Test method test_has_number_of_sig_figs() is missing any coverage information, own or at class level
(#78) Test method test_has_too_many_sig_figs() is missing any coverage information, own or at class level
(#101) Test method test_rounding_incorrect() is missing any coverage information, own or at class level
question/type/varnumeric/tests/questiontype_test.php
(#39) PHPUnit testcase name "qtype_varnumeric_test" does not match file name "questiontype_test"
(#39) PHPUnit class "qtype_varnumeric_test" does not have any namespace. It is recommended to add it to the "qtype_varnumeric" namespace, using more levels if needed, in order to match the code being tested
(#61) Test method test_name() is missing any coverage information, own or at class level
(#65) Test method test_can_analyse_responses() is missing any coverage information, own or at class level
(#69) Test method test_get_random_guess_score() is missing any coverage information, own or at class level
(#74) Test method test_get_possible_responses() is missing any coverage information, own or at class level
question/type/varnumeric/tests/stats_from_steps_walkthrough_test.php
(#44) PHPUnit testcase name "qtype_varnumeric_statistics_from_steps_testcase" does not match file name "stats_from_steps_walkthrough_test"
(#44) PHPUnit class "qtype_varnumeric_statistics_from_steps_testcase" does not have any namespace. It is recommended to add it to the "qtype_varnumeric" namespace, using more levels if needed, in order to match the code being tested
(#64) Test method test_walkthrough_from_csv() is missing any coverage information, own or at class level

Javascript coding style problems

(4 errors, 2 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

question/type/varnumeric/mobile/varnum.js
(#50) This line has a length of 140. Maximum allowed is 132. (max-len)
(#52) This line has a length of 136. Maximum allowed is 132. (max-len)
(#55) This line has a length of 141. Maximum allowed is 132. (max-len)
(#68) Expected to return a value at the end of method 'getPreventSubmitMessage'. (consistent-return)
(#68) Unexpected space before function parentheses. (space-before-function-paren)
(#81) Expected an assignment or function call and instead saw an expression. (no-unused-expressions)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(55 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

question/type/varnumeric/backup/moodle2/backup_qtype_varnumeric_plugin.class.php
(#70) Function backup_qtype_varnumeric_plugin::add_question_qtype_varnumeric_vars is not documented
(#92) Function backup_qtype_varnumeric_plugin::add_question_qtype_varnumeric_variants is not documented
(#112) Function backup_qtype_varnumeric_plugin::add_question_qtype_varnumeric_answers is not documented
(#17) No one-line description found in phpdocs for file
question/type/varnumeric/backup/moodle2/restore_qtype_varnumeric_plugin.class.php
(#103) Function restore_qtype_varnumeric_plugin::process_qtype_varnumeric_var is not documented
(#121) Function restore_qtype_varnumeric_plugin::process_qtype_varnumeric_variant is not documented
(#17) No one-line description found in phpdocs for file
(#23) No one-line description found in phpdocs for class restore_qtype_varnumeric_plugin
(#55) Phpdocs for function restore_qtype_varnumeric_plugin::process_qtype_varnumeric has incomplete parameters list
(#82) Phpdocs for function restore_qtype_varnumeric_plugin::process_qtype_varnumeric_answer has incomplete parameters list
question/type/varnumeric/calculator.php
(#30) Function qtype_varnumeric_calculator::get_num_variants_in_form is not documented
(#34) Function qtype_varnumeric_calculator::get_defined_variant is not documented
question/type/varnumeric/classes/output/mobile.php
(#28) Function mobile::varnum_view is not documented
question/type/varnumeric/combinable/combinable.php
(#30) Class qtype_combined_combinable_type_varnumeric is not documented
(#54) Class qtype_combined_combinable_varnumeric is not documented
(#34) Function qtype_combined_combinable_type_varnumeric::extra_question_properties is not documented
(#38) Function qtype_combined_combinable_type_varnumeric::extra_answer_properties is not documented
(#44) Function qtype_combined_combinable_type_varnumeric::subq_form_fragment_question_option_fields is not documented
(#48) Function qtype_combined_combinable_type_varnumeric::third_param_for_default_question_text is not documented
(#56) Function qtype_combined_combinable_varnumeric::add_form_fragment is not documented
(#77) Function qtype_combined_combinable_varnumeric::data_to_form is not documented
(#89) Function qtype_combined_combinable_varnumeric::validate is not documented
(#105) Function qtype_combined_combinable_varnumeric::get_sup_sub_editor_option is not documented
(#113) Function qtype_combined_combinable_varnumeric::has_submitted_data is not documented
(#119) Function qtype_combined_combinable_varnumeric::make is not documented
(#32) Variable qtype_combined_combinable_type_varnumeric::$identifier is not documented
(#127) Phpdocs for function qtype_combined_combinable_varnumeric::submitted_data_array_not_empty has incomplete parameters list
question/type/varnumeric/combinable/renderer.php
(#26) Class qtype_varnumeric_embedded_renderer is not documented
question/type/varnumeric/edit_varnumeric_form.php
(#38) Function qtype_varnumeric_edit_form::qtype is not documented
(#42) Function qtype_varnumeric_edit_form::definition_inner is not documented
(#46) Function qtype_varnumeric_edit_form::add_value_form_fields is not documented
(#56) Function qtype_varnumeric_edit_form::validation is not documented
question/type/varnumeric/lib.php
(#26) Phpdocs for function qtype_varnumeric_pluginfile has incomplete parameters list
question/type/varnumeric/question.php
(#39) Function qtype_varnumeric_question::get_num_variants is not documented
question/type/varnumeric/questiontype.php
(#41) Function qtype_varnumeric::recalculate_every_time is not documented
(#45) Function qtype_varnumeric::db_table_prefix is not documented
(#49) Function qtype_varnumeric::save_question_options is not documented
(#54) Function qtype_varnumeric::break_down_stats_and_response_analysis_by_variant is not documented
question/type/varnumeric/tests/evalmathsclass_test.php
(#17) No one-line description found in phpdocs for file
question/type/varnumeric/tests/helper.php
(#20) Package qtype is not valid
(#33) Function qtype_varnumeric_test_helper::get_test_questions is not documented
(#99) Function qtype_varnumeric_test_helper::get_varnumeric_question_form_data_with_variables is not documented
(#143) Function qtype_varnumeric_test_helper::make_varnumeric_question_no_accepted_error is not documented
(#37) There is no description in phpdocs for function get_varnumeric_question_form_data_no_accepted_error
(#76) There is no description in phpdocs for function make_varnumeric_question_with_variables
question/type/varnumeric/tests/questiontype_test.php
(#51) Function qtype_varnumeric_test::get_test_question_data is not documented
(#40) Variable qtype_varnumeric_test::$includecoverage is not documented
(#45) Variable qtype_varnumeric_test::$qtype is not documented
question/type/varnumeric/tests/stats_from_steps_walkthrough_test.php
(#20) Package quiz_statistics is not valid
(#38) Package quiz_statistics is not valid
(#21) Category phpunit is not valid
(#39) Category phpunit is not valid
(#51) Function qtype_varnumeric_statistics_from_steps_testcase::get_full_path_of_csv_file is not documented
(#56) Variable qtype_varnumeric_statistics_from_steps_testcase::$files is not documented
(#61) Phpdocs for function qtype_varnumeric_statistics_from_steps_testcase::test_walkthrough_from_csv has incomplete parameters list

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


Missing changes in external functions or backup support for new detected tables or columns

(0 errors, 0 warnings)

This section shows potential problems detected when there are new database structures added in a patch and it is detected that nothing has been changed related with external functions (to be used by WS) or backup and restore. It must be checked that everything is correct and nothing is being missed in those areas. [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]