Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(7 errors, 40 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

question/type/sc/edit_sc_form.php
(#11) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".
(#15) Line 14 of the opening comment must start "// along with Moodle. If not, see <http://www.gnu.org/licenses/>.".
(#31) "require_once" must be immediately followed by an open parenthesis
(#32) "require_once" must be immediately followed by an open parenthesis
(#33) "require_once" must be immediately followed by an open parenthesis
(#34) "require_once" must be immediately followed by an open parenthesis
(#118) Line exceeds 132 characters; contains 134 characters
(#192) Line exceeds 132 characters; contains 134 characters
(#202) Line exceeds 132 characters; contains 136 characters
(#427) Line exceeds 132 characters; contains 135 characters
question/type/sc/grading/qtype_sc_grading.class.php
(#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
question/type/sc/lang/de/qtype_sc.php
(#91) File must end with a newline character
question/type/sc/question.php
(#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
question/type/sc/tests/question_test.php
(#41) PHPUnit testcase name "qtype_sc_question_test" does not match file name "question_test"
(#41) PHPUnit class "qtype_sc_question_test" does not have any namespace. It is recommended to add it to the "qtype_sc" namespace, using more levels if needed, in order to match the code being tested
(#115) Test method test_get_expected_data() is missing any coverage information, own or at class level
(#131) Test method test_is_complete_response() is missing any coverage information, own or at class level
(#167) Test method test_is_gradable_response_sconezero() is missing any coverage information, own or at class level
(#203) Test method test_is_gradable_response_aprime() is missing any coverage information, own or at class level
(#239) Test method test_is_gradable_response_subpoints() is missing any coverage information, own or at class level
(#275) Test method test_get_order() is missing any coverage information, own or at class level
(#289) Test method test_is_same_response() is missing any coverage information, own or at class level
(#321) Test method test_grading() is missing any coverage information, own or at class level
(#331) Test method test_summarise_response() is missing any coverage information, own or at class level
(#342) Test method test_classify_response() is missing any coverage information, own or at class level
(#365) Test method test_make_html_inline() is missing any coverage information, own or at class level
(#380) Test method test_get_hint() is missing any coverage information, own or at class level
(#390) Test method test_compute_final_grade_sconezero() is missing any coverage information, own or at class level
(#423) Test method test_compute_final_grade_aprime() is missing any coverage information, own or at class level
(#459) Test method test_compute_final_grade_subpoints() is missing any coverage information, own or at class level
(#495) Test method test_grade_response_sconezero() is missing any coverage information, own or at class level
(#511) Test method test_grade_response_aprime() is missing any coverage information, own or at class level
(#536) Test method test_grade_response_subpoints() is missing any coverage information, own or at class level
question/type/sc/tests/questiontype_test.php
(#44) PHPUnit testcase name "qtype_sc_test" does not match file name "questiontype_test"
(#44) PHPUnit class "qtype_sc_test" does not have any namespace. It is recommended to add it to the "qtype_sc" namespace, using more levels if needed, in order to match the code being tested
(#57) Test method test_name() is missing any coverage information, own or at class level
(#132) Test method test_can_analyse_responses() is missing any coverage information, own or at class level
(#139) Test method test_get_random_guess_score_sc() is missing any coverage information, own or at class level
(#147) Test method test_get_random_guess_score_sconzero() is missing any coverage information, own or at class level
(#156) Test method test_get_random_guess_score_aprime() is missing any coverage information, own or at class level
(#165) Test method test_get_possible_responses() is missing any coverage information, own or at class level
(#189) Test method test_question_saving_question_one() is missing any coverage information, own or at class level
(#206) Line exceeds 132 characters; contains 145 characters
(#236) Test method test_get_question_options() is missing any coverage information, own or at class level
question/type/sc/tests/walkthrough_test.php
(#43) PHPUnit testcase name "qtype_sc_walkthrough_test" does not match file name "walkthrough_test"
(#43) PHPUnit class "qtype_sc_walkthrough_test" does not have any namespace. It is recommended to add it to the "qtype_sc" namespace, using more levels if needed, in order to match the code being tested
(#127) Test method test_deferredfeedback_feedback_sc() is missing any coverage information, own or at class level

Javascript coding style problems

(5 errors, 5 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

question/type/sc/mobile/sc.js
(#4) Method 'componentInit' has a complexity of 21. Maximum allowed is 20. (complexity)
(#15) Missing semicolon. (semi)
(#26) Missing semicolon. (semi)
(#34) Expected space(s) after "if". (keyword-spacing)
(#56) Missing semicolon. (semi)
(#100) Do not nest ternary expressions. (no-nested-ternary)
(#106) This line has a length of 164. Maximum allowed is 132. (max-len)
(#106) Do not nest ternary expressions. (no-nested-ternary)
(#111) Do not nest ternary expressions. (no-nested-ternary)
(#138) Expected an assignment or function call and instead saw an expression. (no-unused-expressions)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(0 errors, 2 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

question/type/sc/question.php
(#78) Function qtype_sc_question::validate_can_regrade_with_other_version is not documented
(#89) Function qtype_sc_question::update_attempt_state_data_for_new_version is not documented

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(4 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]

question/type/sc/amd/build/question_behaviour.min.js
Uncommitted change detected.
question/type/sc/amd/build/question_behaviour.min.js.map
Uncommitted change detected.
question/type/sc/amd/build/question_edit.min.js
Uncommitted change detected.
question/type/sc/amd/build/question_edit.min.js.map
Uncommitted change detected.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]