Moodle plugins directory: Pattern match with molecular editor

Comments

• 

  Tim Hunt

  Fri, Aug 24, 2012, 5:50 PM

  Just to explain what is going on here. There are actually two different strings here: smiles_c and smiles_C. You can see those are different. I can see those are different. MySQL thinks they are identical.
  
  However, it is probably not a great idea to have two language strings that differ only be upper/lower case, so I will fix this.
• 

  Phil Butcher

  Fri, Aug 24, 2012, 5:59 PM

  Ah. Well of course in SMILES 'c' and 'C' have clear, and different, meanings. 'c' is aromatic (as in benzene rings); 'C' is aliphatic (straight chains). Which tells you what to call them to distinguish them for the SQL.
• 

  Jamie Pratt

  Fri, Aug 24, 2012, 6:08 PM

  Hi,
  
  Thanks for fixing this Tim. I was using get_string to fetch the human name for the SMILES character suffixing the character with 'smiles' and then passing it to get_string. I guess one way to fix this might be to prepend big_ onto an upper case character and convert it to a lower case character appending that to smiles and looking up the translation with get_string
  
• 

  Tim Hunt

  Fri, Aug 24, 2012, 6:09 PM

  That is roughly what I am doing. I will ask you to peer review the patch when it is done.
• 

  Tim Hunt

  Fri, Aug 24, 2012, 7:33 PM

  OK, Jamie liked my patch, so the code is now available from github. Download links like https://github.com/moodleou/moodle-qtype_pmatchjme/zipball/MOODLE_22_STABLE or https://github.com/moodleou/moodle-qtype_pmatchjme/zipball/master
• 

  Bohumil Havel

  Tue, Aug 28, 2012, 7:46 PM

  Now is OK, new install was without problem, upgrades problem was in history track.
• 

  George Chen

  Wed, Sep 19, 2012, 9:12 AM

  I had a client reported the following JME problem. Please help to identify the issue.
  "
  The JME editor now seems to work perfectly; however, the question engine does not recognize either of the correct answers when they are given. I assume this is a problem with the pattern match mechanism, since there is a function in the JME Editor to acquire the SMILES string and it is identical to the SMILES string entered in the question (although the question version requires escape characters, as per the manual: http://labspace.open.ac.uk/mod/oucontent/view.php?id=470268&section=5.5.2). "
• 

  Phil Butcher

  Wed, Sep 19, 2012, 4:25 PM

  George can you find out exactly what the molecule or the correct answers are so that I can try them.
• 

  Aparup Banerjee

  Wed, Jul 3, 2013, 7:53 PM

  Hi all,
  
  please read the following FAQ created recently, it hopefully explains how to clarify this plugin better.
  
  http://docs.moodle.org/dev/Plugin_validation#Q:_I.27ve_a_plugin_to_share_that_requires_closed_.28or_non-GPL_compatible.29_source_software._Can_i_share_this_in_the_plugins_directory.3F
• 

  Aparup Banerjee

  Wed, Jul 3, 2013, 8:06 PM

  Also see related : https://moodle.org/plugins/view.php?plugin=qtype_jme
• 

  Jason Behory

  Wed, Aug 27, 2014, 12:04 AM

  I am running into issues with this plugin on my moodle 2.6.4 installation. I have installed version 1.4 following the instructions listed here however when I create and preview a question of this type in moodle the JME applet does not load.
  
  I see in my access logs that a request is being made for /question/type/pmatchjme/jsme/jsme.nocache.js
  
  This file(s) are not included in this plugin. I have the jmol/jsmol filter installed in my moodle installation. Any help would be appreciated
• 

  Colin Chambers

  Thu, Aug 28, 2014, 5:41 PM

  Great spot jason. Sorry about that.
  
  It turns out that the zip in the Plugins directory is a bit out of date.
  
  The git repository https://github.com/moodleou/moodle-qtype_pmatchjme is more up to date but there are two fixes that still need to be deployed to it.
  
  I'm in the process of applying and testing the fixes. Then I will push to the repository and get the plugin zip in the plugins database updated.
• 

  Colin Chambers

  Thu, Aug 28, 2014, 9:10 PM

  I've updated the git repository with the latest fixes (There was a javascript problem in IE 8) You'll find the JSME folder with the jsme.nocache.js file in there.
  
  If you're comfortable with git just pull the latest version, visit admin > notification and pmatchjme will be updated (the caches need to be flushed to get the latest javascript files).
  
  I'll look at getting the version in the Moodle plugins directory changed.
• 

  Jason Behory

  Thu, Aug 28, 2014, 9:53 PM

  Thanks Colin. The version of github works. I should have spotted it sooner. I was assuming the zip here and on github were identical.
• 

  Tim Hunt

  Tue, Nov 11, 2014, 2:59 AM

  https://moodle.org/plugins/view.php?plugin=qtype_fwstructmatch looks to be a similar question type.