Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(23 errors, 138 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

question/type/ordering/backup/moodle1/lib.php
(#40) Short array syntax must be used to define arrays
(#62) Short array syntax must be used to define arrays
question/type/ordering/backup/moodle2/backup_qtype_ordering_plugin.class.php
(#52) Short array syntax must be used to define arrays
(#56) There should be a comma after the last array item in a multi-line array.
(#57) Short array syntax must be used to define arrays
(#63) Short array syntax must be used to define arrays
question/type/ordering/backup/moodle2/restore_qtype_ordering_plugin.class.php
(#38) Short array syntax must be used to define arrays
question/type/ordering/db/upgrade.php
(#40) Short array syntax must be used to define arrays
(#43) Short array syntax must be used to define arrays
(#45) Short array syntax must be used to define arrays
(#51) There should be a comma after the last array item in a multi-line array.
(#56) Short array syntax must be used to define arrays
(#58) Short array syntax must be used to define arrays
(#61) Short array syntax must be used to define arrays
(#87) Short array syntax must be used to define arrays
(#90) Short array syntax must be used to define arrays
(#102) Short array syntax must be used to define arrays
(#111) There should be a comma after the last array item in a multi-line array.
(#138) Short array syntax must be used to define arrays
(#142) Short array syntax must be used to define arrays
(#149) Short array syntax must be used to define arrays
(#160) Short array syntax must be used to define arrays
(#162) There should be a comma after the last array item in a multi-line array.
(#177) Short array syntax must be used to define arrays
(#178) There should be a comma after the last array item in a multi-line array.
(#187) Short array syntax must be used to define arrays
(#201) Short array syntax must be used to define arrays
(#266) Short array syntax must be used to define arrays
(#271) Short array syntax must be used to define arrays
(#274) Short array syntax must be used to define arrays
question/type/ordering/edit_ordering_form.php
(#97) Short array syntax must be used to define arrays
(#117) Short array syntax must be used to define arrays
(#118) There should be a comma after the last array item in a multi-line array.
(#130) Short array syntax must be used to define arrays
(#131) Short array syntax must be used to define arrays
(#136) Short array syntax must be used to define arrays
(#141) Short array syntax must be used to define arrays
(#142) Short array syntax must be used to define arrays
(#180) Short array syntax must be used to define arrays
(#182) There should be a comma after the last array item in a multi-line array.
(#192) Short array syntax must be used to define arrays
(#195) There should be a comma after the last array item in a multi-line array.
(#224) Short array syntax must be used to define arrays
(#229) Short array syntax must be used to define arrays
(#339) Short array syntax must be used to define arrays
(#340) Short array syntax must be used to define arrays
(#343) Short array syntax must be used to define arrays
(#355) Short array syntax must be used to define arrays
(#356) There should be a comma after the last array item in a multi-line array.
(#367) Short array syntax must be used to define arrays
(#369) There should be a comma after the last array item in a multi-line array.
(#375) Short array syntax must be used to define arrays
(#381) There should be a comma after the last array item in a multi-line array.
(#425) Short array syntax must be used to define arrays
(#441) Short array syntax must be used to define arrays
(#457) Short array syntax must be used to define arrays
(#458) There should be a comma after the last array item in a multi-line array.
(#494) Short array syntax must be used to define arrays
(#527) Short array syntax must be used to define arrays
(#570) Short array syntax must be used to define arrays
(#572) There should be a comma after the last array item in a multi-line array.
question/type/ordering/lib.php
(#36) Short array syntax must be used to define arrays
question/type/ordering/question.php
(#228) Short array syntax must be used to define arrays
(#246) Short array syntax must be used to define arrays
(#260) Short array syntax must be used to define arrays
(#262) Short array syntax must be used to define arrays
(#291) Short array syntax must be used to define arrays
(#472) Short array syntax must be used to define arrays
(#590) Short array syntax must be used to define arrays
(#615) Short array syntax must be used to define arrays
(#617) Short array syntax must be used to define arrays
(#620) Short array syntax must be used to define arrays
(#622) There should be a comma after the last array item in a multi-line array.
(#625) Short array syntax must be used to define arrays
(#626) Short array syntax must be used to define arrays
(#627) Short array syntax must be used to define arrays
(#627) There should be a comma after the last array item in a multi-line array.
(#648) Short array syntax must be used to define arrays
(#673) Short array syntax must be used to define arrays
(#691) Short array syntax must be used to define arrays
(#700) Short array syntax must be used to define arrays
(#734) Short array syntax must be used to define arrays
(#771) Short array syntax must be used to define arrays
(#774) There should be a comma after the last array item in a multi-line array.
(#787) Short array syntax must be used to define arrays
(#789) There should be a comma after the last array item in a multi-line array.
(#802) Short array syntax must be used to define arrays
(#811) There should be a comma after the last array item in a multi-line array.
(#825) Short array syntax must be used to define arrays
(#830) There should be a comma after the last array item in a multi-line array.
question/type/ordering/questiontype.php
(#39) Short array syntax must be used to define arrays
(#58) Short array syntax must be used to define arrays
(#60) There should be a comma after the last array item in a multi-line array.
(#100) Short array syntax must be used to define arrays
(#122) Short array syntax must be used to define arrays
(#125) Short array syntax must be used to define arrays
(#166) Short array syntax must be used to define arrays
(#195) Short array syntax must be used to define arrays
(#199) Short array syntax must be used to define arrays
(#206) There should be a comma after the last array item in a multi-line array.
(#212) Short array syntax must be used to define arrays
(#230) Short array syntax must be used to define arrays
(#318) Short array syntax must be used to define arrays
(#324) Short array syntax must be used to define arrays
(#369) Short array syntax must be used to define arrays
(#377) Short array syntax must be used to define arrays
(#394) Short array syntax must be used to define arrays
(#531) Short array syntax must be used to define arrays
(#532) Short array syntax must be used to define arrays
(#533) Short array syntax must be used to define arrays
(#534) Short array syntax must be used to define arrays
(#535) Short array syntax must be used to define arrays
(#563) Short array syntax must be used to define arrays
(#654) Short array syntax must be used to define arrays
(#765) Short array syntax must be used to define arrays
(#786) Short array syntax must be used to define arrays
(#787) Short array syntax must be used to define arrays
(#788) Short array syntax must be used to define arrays
(#789) Short array syntax must be used to define arrays
(#790) Short array syntax must be used to define arrays
(#791) Short array syntax must be used to define arrays
(#795) Short array syntax must be used to define arrays
(#796) Short array syntax must be used to define arrays
(#797) Short array syntax must be used to define arrays
(#798) Short array syntax must be used to define arrays
(#799) Short array syntax must be used to define arrays
(#802) Short array syntax must be used to define arrays
question/type/ordering/renderer.php
(#42) Short array syntax must be used to define arrays
(#106) Short array syntax must be used to define arrays
(#110) Short array syntax must be used to define arrays
(#117) Short array syntax must be used to define arrays
(#131) Short array syntax must be used to define arrays
(#132) Short array syntax must be used to define arrays
(#133) Short array syntax must be used to define arrays
(#169) Short array syntax must be used to define arrays
(#182) Short array syntax must be used to define arrays
(#185) There should be a comma after the last array item in a multi-line array.
(#208) Short array syntax must be used to define arrays
(#212) Short array syntax must be used to define arrays
(#222) Short array syntax must be used to define arrays
(#231) Short array syntax must be used to define arrays
(#236) Short array syntax must be used to define arrays
(#277) Short array syntax must be used to define arrays
(#287) Short array syntax must be used to define arrays
(#290) Short array syntax must be used to define arrays
(#322) Short array syntax must be used to define arrays
(#377) Short array syntax must be used to define arrays
(#383) Short array syntax must be used to define arrays
(#567) Short array syntax must be used to define arrays
question/type/ordering/tests/helper.php
(#40) Short array syntax must be used to define arrays
(#126) There should be a comma after the last array item in a multi-line array.
question/type/ordering/tests/questiontype_test.php
(#95) Short array syntax must be used to define arrays
(#125) Short array syntax must be used to define arrays
(#126) Short array syntax must be used to define arrays
(#134) Short array syntax must be used to define arrays
(#142) Short array syntax must be used to define arrays
(#150) Short array syntax must be used to define arrays
(#158) Short array syntax must be used to define arrays
(#166) Short array syntax must be used to define arrays
question/type/ordering/tests/walkthrough_test.php
(#117) Short array syntax must be used to define arrays
(#150) Short array syntax must be used to define arrays

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(26 errors, 3 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

question/type/ordering/classes/question_hint_ordering.php
(#47) Phpdocs for function question_hint_ordering::__construct has incomplete parameters list
(#41) Phpdocs for variable question_hint_ordering::$highlightresponse does not contain @var or incorrect
(#32) Inline phpdocs tag {@link question_hint} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
question/type/ordering/edit_ordering_form.php
(#216) Phpdocs for function qtype_ordering_edit_form::adjust_html_editors has incomplete parameters list
(#516) Phpdocs for function qtype_ordering_edit_form::get_addcount_options has incomplete parameters list
(#541) Phpdocs for function qtype_ordering_edit_form::add_repeat_elements has incomplete parameters list
(#323) Inline phpdocs tag {@link set_data()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
question/type/ordering/question.php
(#178) Function qtype_ordering_question::validate_can_regrade_with_other_version is not documented
(#191) Function qtype_ordering_question::update_attempt_state_data_for_new_version is not documented
(#816) There is no description in phpdocs for function get_numbering_styles
(#107) Inline phpdocs tag {@link question_attempt} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#110) Inline phpdocs tag {@link get_num_variants()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#161) Inline phpdocs tag {@link question_attempt} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#161) Inline phpdocs tag {@link question_attempt} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#220) Inline phpdocs tag {@link question_attempt::get_field_prefix()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#252) Inline phpdocs tag {@link grade_response()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#283) Inline phpdocs tag {@link grade_response()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#284) Inline phpdocs tag {@link question_classified_response} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#328) Inline phpdocs tag {@link question_attempt_step::get_qt_data()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#341) Inline phpdocs tag {@link question_attempt_step::get_qt_data()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#364) Inline phpdocs tag {@link question_attempt_step::get_qt_data()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#376) Inline phpdocs tag {@link question_state} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#380) Inline phpdocs tag {@link question_attempt_step::get_qt_data()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
question/type/ordering/questiontype.php
(#41) There is no description in phpdocs for function has_html_answers
(#866) Phpdocs for function qtype_ordering::set_options_for_import has incomplete parameters list
(#1013) Phpdocs for function qtype_ordering::get_numberingstyle has incomplete parameters list
(#88) Inline phpdocs tag {@link save_question()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
question/type/ordering/tests/helper.php
(#39) Function qtype_ordering_test_helper::get_test_questions is not documented
question/type/ordering/tests/walkthrough_test.php
(#53) Phpdocs for function walkthrough_test::get_response has incomplete parameters list

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]