Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(22 errors, 19 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

question/type/ordering/classes/privacy/provider.php
(#50) Method name "_get_reason" should not be prefixed with an underscore to indicate visibility
question/type/ordering/db/upgrade.php
(#278) This comment is 43% valid code; is this commented out code?
question/type/ordering/edit_ordering_form.php
(#387) Expected 1 space after "="; 2 found
(#430) Whitespace found at end of line
(#434) Inline comments must end in full-stops, exclamation marks, or question marks
(#437) Inline comments must end in full-stops, exclamation marks, or question marks
(#452) Inline comments must end in full-stops, exclamation marks, or question marks
(#455) Inline comments must end in full-stops, exclamation marks, or question marks
question/type/ordering/question.php
(#456) Inline comments must start with a capital letter, digit or 3-dots sequence
(#456) 55 slashes comments are not allowed; use "// Comment." instead
(#459) Inline comments must end in full-stops, exclamation marks, or question marks
(#459) 55 slashes comments are not allowed; use "// Comment." instead
(#489) 55 slashes comments are not allowed; use "// Comment." instead
(#491) Inline comments must end in full-stops, exclamation marks, or question marks
(#491) 55 slashes comments are not allowed; use "// Comment." instead
(#768) The static declaration must come after the visibility declaration
(#784) The static declaration must come after the visibility declaration
(#800) The static declaration must come after the visibility declaration
(#815) The static declaration must come after the visibility declaration
question/type/ordering/questiontype.php
(#419) Closing brace must be on a line by itself
(#420) Closing brace must be on a line by itself
(#421) Closing brace must be on a line by itself
(#422) Closing brace must be on a line by itself
(#444) Line exceeds 132 characters; contains 134 characters
(#596) Closing brace must be on a line by itself
(#597) Closing brace must be on a line by itself
(#598) Closing brace must be on a line by itself
(#599) Closing brace must be on a line by itself
(#699) Line exceeds 132 characters; contains 137 characters
(#761) Whitespace found at end of line
(#764) Inline comments must start with a capital letter, digit or 3-dots sequence
(#764) Inline comments must end in full-stops, exclamation marks, or question marks
(#811) Inline comments must start with a capital letter, digit or 3-dots sequence
(#811) Inline comments must end in full-stops, exclamation marks, or question marks
(#878) Whitespace found at end of line
question/type/ordering/renderer.php
(#59) global $PAGE cannot be used in renderers. Use $this->page.
(#85) Inline comments must start with a capital letter, digit or 3-dots sequence
(#85) This comment is 60% valid code; is this commented out code?
(#96) Inline comments must end in full-stops, exclamation marks, or question marks
(#103) global $PAGE cannot be used in renderers. Use $this->page.
(#133) Inline comments must end in full-stops, exclamation marks, or question marks

Javascript coding style problems

(0 errors, 43 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

question/type/ordering/amd/src/drag_reorder.js
(#105) Missing JSDoc parameter type for 'config'. (valid-jsdoc)
(#108) Multiple spaces found before '// Information...'. (no-multi-spaces)
(#109) Multiple spaces found before '// Array of id...'. (no-multi-spaces)
(#110) Multiple spaces found before '// Item being ...'. (no-multi-spaces)
(#111) Multiple spaces found before '// Item being ...'. (no-multi-spaces)
(#112) Multiple spaces found before '// Drag proxy ...'. (no-multi-spaces)
(#113) Multiple spaces found before '// Order list ...'. (no-multi-spaces)
(#152) Unexpected space before function parentheses. (space-before-function-paren)
(#173) Missing JSDoc parameter type for 'itemDragging'. (valid-jsdoc)
(#180) Comments should not begin with a lowercase character. (capitalized-comments)
(#180) Expected space or tab after '//' in comment. (spaced-comment)
(#192) Missing JSDoc parameter type for 'outer'. (valid-jsdoc)
(#193) Missing JSDoc parameter type for 'inner'. (valid-jsdoc)
(#233) Missing JSDoc parameter type for 'e'. (valid-jsdoc)
(#234) Missing JSDoc parameter type for 'item'. (valid-jsdoc)
(#234) Expected JSDoc for 'current' but found 'item'. (valid-jsdoc)
(#236) Unexpected space before function parentheses. (space-before-function-paren)
(#261) Missing JSDoc return type. (valid-jsdoc)
(#263) Missing JSDoc parameter type for 'jQuery'. (valid-jsdoc)
(#270) Missing JSDoc return type. (valid-jsdoc)
(#272) Missing JSDoc parameter type for 'jQuery'. (valid-jsdoc)
(#279) Missing JSDoc return type. (valid-jsdoc)
(#281) Missing JSDoc parameter type for 'element1'. (valid-jsdoc)
(#282) Missing JSDoc parameter type for 'element2'. (valid-jsdoc)
(#286) Expected variable declaration to be on a new line. (one-var-declaration-per-line)
(#292) Missing JSDoc return type. (valid-jsdoc)
(#298) Statement inside of curly braces should be on next line. (brace-style)
(#298) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
(#301) Missing JSDoc return type. (valid-jsdoc)
(#304) Missing JSDoc parameter type for 'a1'. (valid-jsdoc)
(#305) Missing JSDoc parameter type for 'a2'. (valid-jsdoc)
(#310) Statement inside of curly braces should be on next line. (brace-style)
(#310) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
question/type/ordering/amd/src/reorder.js
(#9) Unexpected space before function parentheses. (space-before-function-paren)
(#10) A constructor name should not start with a lowercase letter. (babel/new-cap)
(#17) Unexpected space before function parentheses. (space-before-function-paren)
(#17) Statement inside of curly braces should be on next line. (brace-style)
(#17) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
(#18) Unexpected space before function parentheses. (space-before-function-paren)
(#18) Statement inside of curly braces should be on next line. (brace-style)
(#18) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
(#19) Unexpected empty method 'reorderStart'. (no-empty-function)
(#20) Unexpected empty method 'reorderEnd'. (no-empty-function)

CSS problems

(37 errors, 8 warnings)

This section shows CSS problems detected by stylelint [More info]

question/type/ordering/styles.css
(#136) Unexpected empty block (block-no-empty)
(#19) Expected "#ffffff" to be "#fff" (color-hex-length)
(#102) Expected "#99ff66" to be "#9f6" (color-hex-length)
(#106) Expected "#ff9900" to be "#f90" (color-hex-length)
(#110) Expected "#ff9900" to be "#f90" (color-hex-length)
(#113) Expected "#ffdddd" to be "#fdd" (color-hex-length)
(#114) Expected "#ff9900" to be "#f90" (color-hex-length)
(#117) Expected "#ffdddd" to be "#fdd" (color-hex-length)
(#9) Unexpected whitespace before ":" (declaration-colon-space-before)
(#10) Unexpected whitespace before ":" (declaration-colon-space-before)
(#11) Unexpected whitespace before ":" (declaration-colon-space-before)
(#14) Unexpected whitespace before ":" (declaration-colon-space-before)
(#15) Unexpected whitespace before ":" (declaration-colon-space-before)
(#19) Unexpected whitespace before ":" (declaration-colon-space-before)
(#20) Unexpected whitespace before ":" (declaration-colon-space-before)
(#21) Unexpected whitespace before ":" (declaration-colon-space-before)
(#22) Unexpected whitespace before ":" (declaration-colon-space-before)
(#23) Unexpected whitespace before ":" (declaration-colon-space-before)
(#24) Unexpected whitespace before ":" (declaration-colon-space-before)
(#28) Unexpected whitespace before ":" (declaration-colon-space-before)
(#29) Unexpected whitespace before ":" (declaration-colon-space-before)
(#30) Unexpected whitespace before ":" (declaration-colon-space-before)
(#46) Unexpected whitespace before ":" (declaration-colon-space-before)
(#50) Unexpected whitespace before ":" (declaration-colon-space-before)
(#53) Unexpected whitespace before ":" (declaration-colon-space-before)
(#56) Unexpected whitespace before ":" (declaration-colon-space-before)
(#59) Unexpected whitespace before ":" (declaration-colon-space-before)
(#62) Unexpected whitespace before ":" (declaration-colon-space-before)
(#66) Unexpected whitespace before ":" (declaration-colon-space-before)
(#69) Unexpected whitespace before ":" (declaration-colon-space-before)
(#101) Unexpected whitespace before ":" (declaration-colon-space-before)
(#102) Unexpected whitespace before ":" (declaration-colon-space-before)
(#105) Unexpected whitespace before ":" (declaration-colon-space-before)
(#106) Unexpected whitespace before ":" (declaration-colon-space-before)
(#109) Unexpected whitespace before ":" (declaration-colon-space-before)
(#110) Unexpected whitespace before ":" (declaration-colon-space-before)
(#113) Unexpected whitespace before ":" (declaration-colon-space-before)
(#114) Unexpected whitespace before ":" (declaration-colon-space-before)
(#117) Unexpected whitespace before ":" (declaration-colon-space-before)
(#118) Unexpected whitespace before ":" (declaration-colon-space-before)
(#129) Unexpected whitespace before ":" (declaration-colon-space-before)
(#130) Unexpected whitespace before ":" (declaration-colon-space-before)
(#131) Unexpected whitespace before ":" (declaration-colon-space-before)
(#134) Unexpected whitespace before ":" (declaration-colon-space-before)
(#47) Unexpected unit (length-zero-no-unit)

PHPDocs style problems

(28 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

question/type/ordering/edit_ordering_form.php
(#216) Phpdocs for function qtype_ordering_edit_form::adjust_html_editors has incomplete parameters list
(#461) Phpdocs for function qtype_ordering_edit_form::get_addcount_options has incomplete parameters list
(#486) Phpdocs for function qtype_ordering_edit_form::add_repeat_elements has incomplete parameters list
(#290) Inline phpdocs tag {@link set_data()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
question/type/ordering/question.php
(#456) Found comment starting with three or more slashes
(#459) Found comment starting with three or more slashes
(#489) Found comment starting with three or more slashes
(#491) Found comment starting with three or more slashes
(#831) There is no description in phpdocs for function get_numbering_styles
(#108) Inline phpdocs tag {@link question_attempt} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
(#111) Inline phpdocs tag {@link get_num_variants()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
(#165) Inline phpdocs tag {@link question_attempt} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
(#165) Inline phpdocs tag {@link question_attempt} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
(#189) Inline phpdocs tag {@link question_attempt::get_field_prefix()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
(#221) Inline phpdocs tag {@link grade_response()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
(#252) Inline phpdocs tag {@link grade_response()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
(#253) Inline phpdocs tag {@link question_classified_response} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
(#281) Inline phpdocs tag {@link question_attempt_step::get_qt_data()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
(#294) Inline phpdocs tag {@link question_attempt_step::get_qt_data()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
(#317) Inline phpdocs tag {@link question_attempt_step::get_qt_data()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
(#329) Inline phpdocs tag {@link question_state} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
(#333) Inline phpdocs tag {@link question_attempt_step::get_qt_data()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
question/type/ordering/questiontype.php
(#38) There is no description in phpdocs for function has_html_answers
(#754) Phpdocs for function qtype_ordering::set_options_for_import has incomplete parameters list
(#901) Phpdocs for function qtype_ordering::get_numberingstyle has incomplete parameters list
(#73) Inline phpdocs tag {@link save_question()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
question/type/ordering/tests/helper.php
(#39) Function qtype_ordering_test_helper::get_test_questions is not documented
question/type/ordering/tests/walkthrough_test.php
(#45) Phpdocs for function qtype_ordering_walkthrough_test::get_response has incomplete parameters list

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "stylelint:css" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]