Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(0 errors, 8 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

question/type/opaque/tests/enginemanager_test.php
(#41) Test method test_is_same() is missing any coverage information, own or at class level
question/type/opaque/tests/questiontype_test.php
(#101) Test method test_name() is missing any coverage information, own or at class level
(#105) Test method test_can_analyse_responses() is missing any coverage information, own or at class level
(#109) Test method test_get_random_guess_score() is missing any coverage information, own or at class level
(#113) Test method test_get_possible_responses() is missing any coverage information, own or at class level
(#117) Test method test_xml_import_known_engine() is missing any coverage information, own or at class level
(#180) Test method test_xml_import_unknown_engine() is missing any coverage information, own or at class level
(#250) Test method test_xml_export() is missing any coverage information, own or at class level

Javascript coding style problems

(0 errors, 8 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

question/type/opaque/amd/src/changefocus.js
(#28) Extra space after key 'init'. (key-spacing)
(#29) There should be no space after this paren. (space-in-parens)
(#29) There should be no space before this paren. (space-in-parens)
(#38) Unexpected space before function parentheses. (space-before-function-paren)
(#54) Unexpected space before function parentheses. (space-before-function-paren)
(#66) Unexpected space before function parentheses. (space-before-function-paren)
(#71) Unexpected space before function parentheses. (space-before-function-paren)
(#76) Unexpected space before function parentheses. (space-before-function-paren)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(99 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

question/type/opaque/backup/moodle2/backup_qtype_opaque_plugin.class.php
(#17) No one-line description found in phpdocs for file
(#74) Inline phpdocs tag {@link get_components_and_fileareas} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
question/type/opaque/backup/moodle2/restore_qtype_opaque_plugin.class.php
(#40) Function restore_qtype_opaque_plugin::define_question_plugin_structure is not documented
(#37) Variable restore_qtype_opaque_plugin::$enginemanager is not documented
(#17) No one-line description found in phpdocs for file
(#29) No one-line description found in phpdocs for class restore_qtype_opaque_plugin
(#48) Phpdocs for function restore_qtype_opaque_plugin::process_opaque has incomplete parameters list
(#87) Phpdocs for function restore_qtype_opaque_plugin::process_engine has incomplete parameters list
(#94) Phpdocs for function restore_qtype_opaque_plugin::process_server has incomplete parameters list
question/type/opaque/classes/event/engine_created.php
(#34) Function engine_created::init is not documented
(#40) Function engine_created::get_name is not documented
(#44) Function engine_created::get_description is not documented
(#48) Function engine_created::get_url is not documented
(#52) Function engine_created::get_legacy_logdata is not documented
question/type/opaque/classes/event/engine_deleted.php
(#34) Function engine_deleted::init is not documented
(#40) Function engine_deleted::get_name is not documented
(#44) Function engine_deleted::get_description is not documented
(#48) Function engine_deleted::get_url is not documented
(#52) Function engine_deleted::get_legacy_logdata is not documented
question/type/opaque/classes/event/engine_edited.php
(#34) Function engine_edited::init is not documented
(#40) Function engine_edited::get_name is not documented
(#44) Function engine_edited::get_description is not documented
(#48) Function engine_edited::get_url is not documented
(#52) Function engine_edited::get_legacy_logdata is not documented
question/type/opaque/classes/local_systemcheck_remote.php
(#39) Function local_systemcheck_remote::__construct is not documented
(#44) Function local_systemcheck_remote::get_id is not documented
(#48) Function local_systemcheck_remote::get_name is not documented
(#52) Function local_systemcheck_remote::get_checks is not documented
(#62) Function local_systemcheck_remote::execute is not documented
question/type/opaque/connection.php
(#157) Function qtype_opaque_soap_client_with_timeout::__construct is not documented
(#170) Function qtype_opaque_soap_client_with_timeout::__doRequest is not documented
(#208) Function qtype_opaque_soap_client_with_logging::__call is not documented
(#222) Function qtype_opaque_soap_client_with_logging::__write_to_log is not documented
(#228) Function qtype_opaque_soap_client_with_logging::__write_to_short_log is not documented
(#234) Function qtype_opaque_soap_client_with_logging::__log_arguments is not documented
(#243) Function qtype_opaque_soap_client_with_logging::__log_result is not documented
(#253) Function qtype_opaque_soap_client_with_logging::__log_exception is not documented
(#263) Function qtype_opaque_soap_client_with_logging::__log_object is not documented
(#267) Function qtype_opaque_soap_client_with_logging::__log_rule is not documented
(#272) Function qtype_opaque_soap_client_with_logging::__log_thin_rule is not documented
(#277) Function qtype_opaque_soap_client_with_logging::__format_time is not documented
(#44) Variable qtype_opaque_connection::$questionbanks is not documented
(#45) Variable qtype_opaque_connection::$passkeysalt is not documented
(#46) Variable qtype_opaque_connection::$soapclient is not documented
(#35) No one-line description found in phpdocs for class qtype_opaque_connection
(#83) There is no description in phpdocs for function question_base_url
(#95) There is no description in phpdocs for function generate_passkey
(#105) There is no description in phpdocs for function get_engine_info
(#113) There is no description in phpdocs for function get_question_metadata
(#96) Phpdocs for function qtype_opaque_connection::generate_passkey has incomplete parameters list
(#50) Inline phpdocs tag {@link qtype_opaque_engine_manager::get_connection()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
question/type/opaque/edit_engine_form.php
(#43) Function qtype_opaque_engine_edit_form::definition is not documented
(#115) Function qtype_opaque_engine_edit_form::validation is not documented
(#81) Phpdocs for function qtype_opaque_engine_edit_form::validateurllist has incomplete parameters list
(#99) Phpdocs for function qtype_opaque_engine_edit_form::extracturllist has incomplete parameters list
(#101) Invalid inline phpdocs tag @return found
question/type/opaque/edit_opaque_form.php
(#41) Function qtype_opaque_edit_form::definition is not documented
(#52) Function qtype_opaque_edit_form::definition_inner is not documented
(#71) Function qtype_opaque_edit_form::validation is not documented
(#112) Function qtype_opaque_edit_form::set_data is not documented
(#124) Function qtype_opaque_edit_form::get_data is not documented
(#134) Function qtype_opaque_edit_form::qtype is not documented
(#31) No one-line description found in phpdocs for class qtype_opaque_edit_form
question/type/opaque/enginemanager.php
(#147) Function qtype_opaque_engine_manager::get_possibly_matching_engines is not documented
(#39) Variable qtype_opaque_engine_manager::$instance is not documented
(#41) There is no description in phpdocs for function get
(#49) There is no description in phpdocs for function choices
question/type/opaque/lib.php
(#25) Phpdocs for function qtype_opaque_pluginfile has incomplete parameters list
question/type/opaque/question.php
(#39) Function qtype_opaque_question::make_behaviour is not documented
(#43) Function qtype_opaque_question::get_expected_data is not documented
(#47) Function qtype_opaque_question::get_correct_response is not documented
(#52) Function qtype_opaque_question::get_variants_selection_seed is not documented
(#56) Function qtype_opaque_question::get_num_variants is not documented
(#61) Function qtype_opaque_question::is_complete_response is not documented
(#66) Function qtype_opaque_question::is_same_response is not documented
(#71) Function qtype_opaque_question::summarise_response is not documented
question/type/opaque/questiontype.php
(#44) Function qtype_opaque::__construct is not documented
(#59) Function qtype_opaque::can_analyse_responses is not documented
(#63) Function qtype_opaque::extra_question_fields is not documented
(#67) Function qtype_opaque::save_question is not documented
(#75) Function qtype_opaque::initialise_question_instance is not documented
(#87) Function qtype_opaque::get_random_guess_score is not documented
(#91) Function qtype_opaque::export_to_xml is not documented
(#111) Function qtype_opaque::import_from_xml is not documented
question/type/opaque/testengine.php
(#81) There is no description in phpdocs for function xml_to_dl
(#82) Phpdocs for function xml_to_dl has incomplete parameters list
question/type/opaque/tests/helper.php
(#38) Function qtype_opaque_test_helper::get_test_questions is not documented
(#67) Function qtype_opaque_test_helper::get_engine_id is not documented
question/type/opaque/tests/questiontype_test.php
(#49) Function qtype_opaque_engine_manager_mock::add_test_engine is not documented
(#53) Function qtype_opaque_engine_manager_mock::load is not documented
(#62) Function qtype_opaque_engine_manager_mock::save is not documented
(#68) Function qtype_opaque_engine_manager_mock::store_opaque_servers is not documented
(#72) Function qtype_opaque_engine_manager_mock::delete is not documented
(#77) Function qtype_opaque_engine_manager_mock::get_possibly_matching_engines is not documented
(#96) Function questiontype_test::assert_same_xml is not documented
(#47) Variable qtype_opaque_engine_manager_mock::$knownengines is not documented
(#90) Variable questiontype_test::$qtype is not documented
(#40) Inline phpdocs tag {@link qtype_opaque_engine_manager} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
question/type/opaque/tests/test_engine_configuration.php
(#32) Function qtype_opaque_test_config::is_test_config_available is not documented

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


Missing changes in external functions or backup support for new detected tables or columns

(0 errors, 2 warnings)

This section shows potential problems detected when there are new database structures added in a patch and it is detected that nothing has been changed related with external functions (to be used by WS) or backup and restore. It must be checked that everything is correct and nothing is being missed in those areas. [More info]

question/type/opaque/db/upgrade.php
Database modifications (new tables or columns) detected in the patch without any change to some important areas.
No changes detected to external functions, that may affect apps and other web service integrations, please verify!

grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]