Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]

PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]

PHP coding style problems

(114 errors, 163 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

question/type/molsimilarity/backup/moodle2/backup_qtype_molsimilarity_plugin.class.php: (#19) Incorrect @package tag for file backup_qtype_molsimilarity_plugin.class.php. Expected qtype_molsimilarity, found qtype.; (#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#60) Short array syntax must be used to define arrays; (#60) Short array syntax must be used to define arrays; (#71) Short array syntax must be used to define arrays
question/type/molsimilarity/backup/moodle2/restore_qtype_molsimilarity_plugin.class.php: (#19) Incorrect @package tag for file restore_qtype_molsimilarity_plugin.class.php. Expected qtype_molsimilarity, found qtype.
question/type/molsimilarity/classes/MolsimilarityException.php: (#20) Incorrect @package tag for file MolsimilarityException.php. Expected qtype_molsimilarity, found qtype.; (#28) Missing docblock for class MolsimilarityException; (#29) Missing docblock for function __construct; (#29) Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $previous.
question/type/molsimilarity/classes/output/mobile.php: (#20) Incorrect @package tag for file mobile.php. Expected qtype_molsimilarity, found qtype.; (#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#52) There should be a comma after the last array item in a multi-line array.; (#53) There should be a comma after the last array item in a multi-line array.; (#55) There should be a comma after the last array item in a multi-line array.
question/type/molsimilarity/classes/privacy/provider.php: (#17) Missing @copyright tag; (#17) Missing @license tag; (#19) Incorrect @package tag for file provider.php. Expected qtype_molsimilarity, found qtype.; (#33) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
question/type/molsimilarity/classes/test_connection.php: (#20) Incorrect @package tag for file test_connection.php. Expected qtype_molsimilarity, found qtype.; (#32) Missing docblock for class qtype_molsimilarity_test_connection; (#48) Short array syntax must be used to define arrays; (#56) Short array syntax must be used to define arrays
question/type/molsimilarity/config-test.php: (#16) Boilerplate comment must be followed by a single blank line or end of file; (#18) Incorrect @package tag for file config-test.php. Expected qtype_molsimilarity, found qtype.; (#25) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
question/type/molsimilarity/db/messages.php: (#16) Boilerplate comment must be followed by a single blank line or end of file; (#19) Incorrect @package tag for file messages.php. Expected qtype_molsimilarity, found qtype.; (#29) Short array syntax must be used to define arrays; (#31) Short array syntax must be used to define arrays; (#32) Short array syntax must be used to define arrays; (#34) There should be a comma after the last array item in a multi-line array.; (#35) There should be a comma after the last array item in a multi-line array.; (#37) Short array syntax must be used to define arrays; (#38) Short array syntax must be used to define arrays; (#40) There should be a comma after the last array item in a multi-line array.; (#41) There should be a comma after the last array item in a multi-line array.
question/type/molsimilarity/db/mobile.php: (#20) Incorrect @package tag for file mobile.php. Expected qtype_molsimilarity, found qtype.; (#45) There should be a comma after the last array item in a multi-line array.; (#46) There should be a comma after the last array item in a multi-line array.; (#47) There should be a comma after the last array item in a multi-line array.; (#52) There should be a comma after the last array item in a multi-line array.
question/type/molsimilarity/db/services.php: (#16) Boilerplate comment must be followed by a single blank line or end of file; (#19) Incorrect @package tag for file services.php. Expected qtype_molsimilarity, found qtype.; (#30) Short array syntax must be used to define arrays; (#31) Short array syntax must be used to define arrays; (#38) There should be a comma after the last array item in a multi-line array.; (#39) There should be a comma after the last array item in a multi-line array.
question/type/molsimilarity/db/upgrade.php: (#20) Incorrect @package tag for file upgrade.php. Expected qtype_molsimilarity, found qtype.; (#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#64) Functions must not contain multiple empty lines in a row; found 2 empty lines
question/type/molsimilarity/edit_molsimilarity_form.php: (#20) Incorrect @package tag for file edit_molsimilarity_form.php. Expected qtype_molsimilarity, found qtype.; (#34) Missing docblock for class qtype_molsimilarity_edit_form; (#53) Short array syntax must be used to define arrays; (#55) There should be a comma after the last array item in a multi-line array.; (#60) Short array syntax must be used to define arrays; (#112) Short array syntax must be used to define arrays; (#117) Missing docblock for function require_js; (#119) Short array syntax must be used to define arrays; (#122) Short array syntax must be used to define arrays; (#123) Short array syntax must be used to define arrays; (#123) There should be a comma after the last array item in a multi-line array.; (#125) Short array syntax must be used to define arrays; (#127) Short array syntax must be used to define arrays; (#132) Missing docblock for function require_js_preview; (#134) Short array syntax must be used to define arrays; (#137) Short array syntax must be used to define arrays; (#138) Short array syntax must be used to define arrays; (#138) There should be a comma after the last array item in a multi-line array.; (#146) Missing docblock for function require_js_scaffold; (#148) Short array syntax must be used to define arrays; (#151) Short array syntax must be used to define arrays; (#152) Short array syntax must be used to define arrays; (#152) There should be a comma after the last array item in a multi-line array.; (#154) Short array syntax must be used to define arrays; (#156) Short array syntax must be used to define arrays; (#161) Missing docblock for function get_per_answer_fields; (#163) Short array syntax must be used to define arrays; (#164) Short array syntax must be used to define arrays; (#165) Short array syntax must be used to define arrays; (#166) Short array syntax must be used to define arrays; (#169) Short array syntax must be used to define arrays; (#197) Short array syntax must be used to define arrays; (#207) Missing docblock for function data_preprocessing; (#212) Missing docblock for function qtype
question/type/molsimilarity/externallib.php: (#20) Incorrect @package tag for file externallib.php. Expected qtype_molsimilarity, found qtype.; (#32) Missing docblock for class qtype_molsimilarity_external; (#33) Opening brace should be on the same line as the declaration for class qtype_molsimilarity_external; (#34) Missing docblock for function modify_molfile_parameters; (#36) Short array syntax must be used to define arrays; (#41) There should be a comma after the last array item in a multi-line array.; (#46) Missing docblock for function molsimilarity_array_column_ext; (#47) Short array syntax must be used to define arrays; (#66) Missing docblock for function modify_molfile; (#68) Short array syntax must be used to define arrays; (#150) Short array syntax must be used to define arrays; (#163) Missing docblock for function modify_molfile_returns; (#165) Short array syntax must be used to define arrays
question/type/molsimilarity/lang/en/qtype_molsimilarity.php: (#20) Incorrect @package tag for file qtype_molsimilarity.php. Expected qtype_molsimilarity, found qtype.; (#35) The string key "pleaseenterananswer" is not in the correct order, it should be before "pluginnamesummary"; (#36) The string key "answernumber" is not in the correct order, it should be before "pleaseenterananswer"; (#40) The string key "insertfrom" is not in the correct order, it should be before "insertfromeditor"; (#43) The string key "clearanswer" is not in the correct order, it should be before "inserttoeditor"; (#47) The string key "caseno" is not in the correct order, it should be before "isidaurl_desc"; (#50) The string key "moleculeempty" is not in the correct order, it should be before "stereoselection"; (#52) The string key "isidaKEY" is not in the correct order, it should be before "privacy:metadata"; (#54) The string key "errorintestwhilegconnection" is not in the correct order, it should be before "isidaKEY_desc"; (#56) The string key "testerrorcode" is not in the correct order, it should be before "testerrormessage"; (#57) The string key "connectiontestresult" is not in the correct order, it should be before "testerrorcode"; (#58) The string key "connection-success" is not in the correct order, it should be before "connectiontestresult"; (#60) The string key "settings" is not in the correct order, it should be before "testconnection"; (#61) The string key "messageprovider:molsimilarity_down" is not in the correct order, it should be before "settings"; (#62) The string key "mailmsg" is not in the correct order, it should be before "messageprovider:molsimilarity_down"; (#64) The string key "mailmsg_isidaerror" is not in the correct order, it should be before "mailsubj"; (#67) The string key "mailsubj_security" is not in the correct order, it should be before "messageprovider:molsimilarity_security"; (#68) The string key "mailmsg_security" is not in the correct order, it should be before "mailsubj_security"; (#71) The string key "alphaselection" is not in the correct order, it should be before "threshold_help"
question/type/molsimilarity/lib.php: (#20) Incorrect @package tag for file lib.php. Expected qtype_molsimilarity, found qtype.; (#45) Short array syntax must be used to define arrays; (#51) Missing docblock for function qtype_molsimilarity_test_api_server
question/type/molsimilarity/question.php: (#20) Incorrect @package tag for file question.php. Expected qtype_molsimilarity, found qtype.; (#40) Missing docblock for class qtype_molsimilarity_question; (#42) Missing member variable doc comment; (#43) Missing member variable doc comment; (#44) Missing member variable doc comment; (#45) Missing member variable doc comment; (#46) Missing member variable doc comment; (#46) Short array syntax must be used to define arrays; (#60) Short array syntax must be used to define arrays; (#72) Missing docblock for function get_correct_response; (#75) Short array syntax must be used to define arrays; (#77) Short array syntax must be used to define arrays; (#80) Missing docblock for function get_correct_answer; (#157) Missing docblock for function grade_response; (#162) Short array syntax must be used to define arrays; (#166) Short array syntax must be used to define arrays; (#169) Short array syntax must be used to define arrays; (#173) Short array syntax must be used to define arrays; (#177) Missing docblock for function generate; (#186) There should be a comma after the last array item in a multi-line array.; (#220) Expected 0 spaces after "compare_mol"; 1 found; (#223) Short array syntax must be used to define arrays; (#231) Short array syntax must be used to define arrays; (#232) Short array syntax must be used to define arrays; (#240) Short array syntax must be used to define arrays; (#242) Short array syntax must be used to define arrays; (#270) No one-line description found in phpdocs for docblock of function call_api; (#274) Short array syntax must be used to define arrays; (#276) Short array syntax must be used to define arrays; (#276) There should be a comma after the last array item in a multi-line array.; (#320) Line exceeds 132 characters; contains 136 characters; (#344) No one-line description found in phpdocs for docblock of function check_file_access
question/type/molsimilarity/questiontype.php: (#20) Incorrect @package tag for file questiontype.php. Expected qtype_molsimilarity, found qtype.; (#50) Missing docblock for function extra_question_fields; (#51) Short array syntax must be used to define arrays; (#53) Missing docblock for function move_files; (#59) Missing docblock for function delete_files; (#65) Missing docblock for function save_question_options; (#89) No one-line description found in phpdocs for docblock of function get_random_guess_score; (#93) Missing docblock for function get_possible_responses; (#94) Short array syntax must be used to define arrays
question/type/molsimilarity/renderer.php: (#20) Incorrect @package tag for file renderer.php. Expected qtype_molsimilarity, found qtype.; (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#39) Missing docblock for class qtype_molsimilarity_renderer; (#40) Missing docblock for function formulation_and_controls; (#47) Short array syntax must be used to define arrays; (#74) Short array syntax must be used to define arrays; (#78) Short array syntax must be used to define arrays; (#84) Short array syntax must be used to define arrays; (#87) Short array syntax must be used to define arrays; (#89) Short array syntax must be used to define arrays; (#90) Short array syntax must be used to define arrays; (#96) Short array syntax must be used to define arrays; (#97) Short array syntax must be used to define arrays; (#100) Space found before semicolon; expected "scaffold;" but found "scaffold ;"; (#125) Missing docblock for function require_js; (#128) Short array syntax must be used to define arrays; (#131) Short array syntax must be used to define arrays; (#132) Short array syntax must be used to define arrays; (#132) There should be a comma after the last array item in a multi-line array.; (#136) Short array syntax must be used to define arrays; (#139) Short array syntax must be used to define arrays; (#149) Missing docblock for function hidden_fields; (#161) Missing docblock for function hidden_field_for_qt_var; (#164) Short array syntax must be used to define arrays; (#172) Missing docblock for function specific_feedback; (#189) Missing docblock for function correct_response; (#199) Short array syntax must be used to define arrays; (#202) Missing docblock for function require_js_correct; (#205) Short array syntax must be used to define arrays; (#208) Short array syntax must be used to define arrays; (#209) Short array syntax must be used to define arrays; (#209) There should be a comma after the last array item in a multi-line array.; (#215) Short array syntax must be used to define arrays
question/type/molsimilarity/settings.php: (#20) Incorrect @package tag for file settings.php. Expected qtype_molsimilarity, found qtype.
question/type/molsimilarity/test_connection.php: (#20) Incorrect @package tag for file test_connection.php. Expected qtype_molsimilarity, found qtype.
question/type/molsimilarity/tests/helper.php: (#16) Boilerplate comment must be followed by a single blank line or end of file; (#19) Incorrect @package tag for file helper.php. Expected qtype_molsimilarity, found qtype.; (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#39) Missing docblock for function get_test_questions; (#40) Short array syntax must be used to define arrays; (#43) Missing docblock for function make_molsimilarity_question_ethanollp; (#62) Short array syntax must be used to define arrays; (#63) There should be a comma after the last array item in a multi-line array.; (#69) Missing docblock for function make_molsimilarity_question_s1aminoethanol; (#89) Short array syntax must be used to define arrays; (#91) There should be a comma after the last array item in a multi-line array.; (#97) Missing docblock for function get_molsimilarity_question_data_ethanollp; (#115) Short array syntax must be used to define arrays; (#116) There should be a comma after the last array item in a multi-line array.; (#121) Missing docblock for function get_molsimilarity_question_form_data_ethanollp; (#125) Short array syntax must be used to define arrays; (#127) Short array syntax must be used to define arrays; (#140) Short array syntax must be used to define arrays; (#141) Short array syntax must be used to define arrays; (#142) Short array syntax must be used to define arrays; (#142) Short array syntax must be used to define arrays
question/type/molsimilarity/tests/question_test.php: (#20) Incorrect @package tag for file question_test.php. Expected qtype_molsimilarity, found qtype.; (#50) Unit test question_test should be declared as final.; (#58) Missing docblock for function set_isida_url in testcase; (#61) Expected "if (...) {\n"; found "if(...) {\n"; (#66) Test method test_get_expected_data() is missing any coverage information, own or at class level; (#66) Test method test_get_expected_data() is missing a return type; (#69) Short array syntax must be used to define arrays; (#72) Test method test_is_complete_response() is missing any coverage information, own or at class level; (#72) Test method test_is_complete_response() is missing a return type; (#74) Short array syntax must be used to define arrays; (#75) Short array syntax must be used to define arrays; (#76) Short array syntax must be used to define arrays; (#79) Test method test_get_correct_response() is missing any coverage information, own or at class level; (#79) Test method test_get_correct_response() is missing a return type; (#90) Short array syntax must be used to define arrays; (#93) Test method test_get_question_summary() is missing any coverage information, own or at class level; (#93) Test method test_get_question_summary() is missing a return type; (#99) Test method test_summarise_response() is missing any coverage information, own or at class level; (#99) Test method test_summarise_response() is missing a return type; (#110) Short array syntax must be used to define arrays; (#115) Test method test_get_validation_error() is missing any coverage information, own or at class level; (#115) Test method test_get_validation_error() is missing a return type; (#118) Short array syntax must be used to define arrays; (#120) Short array syntax must be used to define arrays; (#123) Test method test_compute_final_grade() is missing any coverage information, own or at class level; (#123) Test method test_compute_final_grade() is missing a return type; (#126) Short array syntax must be used to define arrays; (#136) Short array syntax must be used to define arrays; (#137) Short array syntax must be used to define arrays; (#138) Short array syntax must be used to define arrays; (#139) Short array syntax must be used to define arrays; (#140) Short array syntax must be used to define arrays; (#141) Short array syntax must be used to define arrays; (#142) Short array syntax must be used to define arrays; (#143) Short array syntax must be used to define arrays; (#146) Test method test_compute_final_grade_stereo() is missing any coverage information, own or at class level; (#146) Test method test_compute_final_grade_stereo() is missing a return type; (#162) Short array syntax must be used to define arrays; (#164) Short array syntax must be used to define arrays; (#165) Short array syntax must be used to define arrays; (#166) Short array syntax must be used to define arrays; (#167) Short array syntax must be used to define arrays
question/type/molsimilarity/tests/questiontype_test.php: (#16) Boilerplate comment must be followed by a single blank line or end of file; (#19) Incorrect @package tag for file questiontype_test.php. Expected qtype_molsimilarity, found qtype.; (#49) Unit test questiontype_test should be declared as final.; (#50) Missing member variable doc comment; (#50) Short array syntax must be used to define arrays; (#55) Missing member variable doc comment; (#57) There must not be a space before the colon in a return type declaration; (#57) There must be a single space between the colon and type in a return type declaration; (#61) There must not be a space before the colon in a return type declaration; (#65) Missing docblock for function get_test_question_data in testcase; (#69) Test method test_name() is missing any coverage information, own or at class level; (#69) Test method test_name() is missing a return type; (#73) Test method test_get_random_guess_score() is missing any coverage information, own or at class level; (#73) Test method test_get_random_guess_score() is missing a return type; (#78) Test method test_get_possible_responses() is missing any coverage information, own or at class level; (#78) Test method test_get_possible_responses() is missing a return type; (#80) Short array syntax must be used to define arrays
question/type/molsimilarity/version.php: (#20) Incorrect @package tag for file version.php. Expected qtype_molsimilarity, found qtype.

CSS problems

(1 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]

question/type/molsimilarity/styles.css: (#11) Invalid value for "position" (csstree/validator)

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]

grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

: Problems running grunt; Task "stylelint:css" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]

Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]

Prechecker results: error

Overview

PHP lint problems

PHP coding style problems

Javascript coding style problems

CSS problems

PHPDocs style problems

Update savepoints problems

Third party library modification problems

grunt changes

shifter problems

Mustache template problems

Gherkin .feature problems