Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(0 errors, 13 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

question/type/geogebra/tests/question_test.php
(#48) Test method test_is_complete_response() is missing any coverage information, own or at class level
(#88) Test method test_is_gradable_response() is missing any coverage information, own or at class level
(#130) Test method test_grading() is missing any coverage information, own or at class level
(#140) Test method test_summarise_response() is missing any coverage information, own or at class level
question/type/geogebra/tests/questiontype_test.php
(#95) Test method test_name() is missing any coverage information, own or at class level
(#99) Test method test_is_manual_graded() is missing any coverage information, own or at class level
(#103) Test method test_can_analyse_responses() is missing any coverage information, own or at class level
(#107) Test method test_get_random_guess_score() is missing any coverage information, own or at class level
(#112) Test method test_get_possible_responses() is missing any coverage information, own or at class level
(#126) Test method test_question_saving_point() is missing any coverage information, own or at class level
question/type/geogebra/tests/walkthrough_test.php
(#45) Test method test_interactive_point() is missing any coverage information, own or at class level
(#125) Test method test_deferredfeedback_point() is missing any coverage information, own or at class level
(#221) Test method test_interactive_manually() is missing any coverage information, own or at class level

Javascript coding style problems

(35 errors, 119 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

question/type/geogebra/amd/src/ggbq.js
(#12) Unexpected space before function parentheses. (space-before-function-paren)
(#47) Comments should not begin with a lowercase character. (capitalized-comments)
(#47) Expected space or tab after '//' in comment. (spaced-comment)
(#49) Comments should not begin with a lowercase character. (capitalized-comments)
(#49) Expected space or tab after '//' in comment. (spaced-comment)
(#51) Unexpected space before function parentheses. (space-before-function-paren)
(#58) Unexpected space before function parentheses. (space-before-function-paren)
(#81) Unexpected space before function parentheses. (space-before-function-paren)
(#93) Comments should not begin with a lowercase character. (capitalized-comments)
(#125) Comments should not begin with a lowercase character. (capitalized-comments)
question/type/geogebra/amd/src/ggbt.js
(#10) Unexpected space before function parentheses. (space-before-function-paren)
(#110) ["client_id"] is better written in dot notation. (dot-notation)
(#112) Comments should not begin with a lowercase character. (capitalized-comments)
(#152) Blocks are nested too deeply (5). Maximum allowed is 4. (max-depth)
(#153) Blocks are nested too deeply (6). Maximum allowed is 4. (max-depth)
(#166) Identifier 'update_feedback' is not in camel case. (camelcase)
(#193) Comments should not begin with a lowercase character. (capitalized-comments)
(#193) Expected space or tab after '//' in comment. (spaced-comment)
(#207) Identifier 'enable_right_click' is not in camel case. (camelcase)
(#208) Identifier 'enable_label_drags' is not in camel case. (camelcase)
(#209) Identifier 'show_reset_icon' is not in camel case. (camelcase)
(#210) Identifier 'enable_shift_drag_zoom' is not in camel case. (camelcase)
(#211) Identifier 'show_algebra_input' is not in camel case. (camelcase)
(#212) Identifier 'show_menu_bar' is not in camel case. (camelcase)
(#213) Identifier 'show_tool_bar' is not in camel case. (camelcase)
(#252) Comments should not begin with a lowercase character. (capitalized-comments)
(#275) Expected to return a value at the end of method 'handleDragOver'. (consistent-return)
(#303) Comments should not begin with a lowercase character. (capitalized-comments)
(#303) Expected space or tab after '//' in comment. (spaced-comment)
(#306) Comments should not begin with a lowercase character. (capitalized-comments)
(#306) Expected space or tab after '//' in comment. (spaced-comment)
question/type/geogebra/ggbq.js
(#5) Expected space or tab after '//' in comment. (spaced-comment)
(#6) Identifier 'form_ggbq' is not in camel case. (camelcase)
(#19) Unexpected space before function parentheses. (space-before-function-paren)
(#39) 'GGBApplet' is not defined. (no-undef)
(#56) Unexpected space before function parentheses. (space-before-function-paren)
(#56) 'Y' is defined but never used. (no-unused-vars)
(#56) 'options' is defined but never used. (no-unused-vars)
(#57) 'i' is not defined. (no-undef)
(#57) 'i' is not defined. (no-undef)
(#57) 'i' is not defined. (no-undef)
(#58) 'i' is not defined. (no-undef)
(#60) 'i' is not defined. (no-undef)
(#61) 'i' is not defined. (no-undef)
(#64) 'i' is not defined. (no-undef)
(#64) Function declared in a loop contains unsafe references to variable(s) 'ggbApplet', 'responsestring', 'ggbApplet', 'responsestring'. (no-loop-func)
(#64) Unexpected space before function parentheses. (space-before-function-paren)
(#71) 'i' is not defined. (no-undef)
(#72) 'i' is not defined. (no-undef)
(#78) Missing JSDoc comment. (require-jsdoc)
(#78) 'ggbAppletOnLoad' is defined but never used. (no-unused-vars)
(#91) Missing semicolon. (semi)
(#94) Unexpected space before function parentheses. (space-before-function-paren)
(#106) Missing JSDoc comment. (require-jsdoc)
question/type/geogebra/ggbt.js
(#1) Identifier 'form_ggbt' is not in camel case. (camelcase)
(#8) Identifier 'enable_label_drags' is not in camel case. (camelcase)
(#9) Identifier 'enable_right_click' is not in camel case. (camelcase)
(#10) Identifier 'enable_shift_drag_zoom' is not in camel case. (camelcase)
(#11) Identifier 'show_algebra_input' is not in camel case. (camelcase)
(#12) Identifier 'show_menu_bar' is not in camel case. (camelcase)
(#13) Identifier 'show_reset_icon' is not in camel case. (camelcase)
(#14) Identifier 'show_tool_bar' is not in camel case. (camelcase)
(#15) Unexpected space before function parentheses. (space-before-function-paren)
(#18) A function with a name starting with an uppercase letter should only be used as a constructor. (new-cap)
(#18) 'YUI' is not defined. (no-undef)
(#20) Expected space or tab after '//' in comment. (spaced-comment)
(#29) Unexpected space before function parentheses. (space-before-function-paren)
(#29) Identifier 'client_id' is not in camel case. (camelcase)
(#31) Identifier 'client_id' is not in camel case. (camelcase)
(#34) Unexpected space before function parentheses. (space-before-function-paren)
(#45) Unexpected space before function parentheses. (space-before-function-paren)
(#59) 'ggbcheckb' is not defined. (no-undef)
(#60) 'ggbcheckb' is not defined. (no-undef)
(#61) 'ggbcheckb' is not defined. (no-undef)
(#82) Unexpected space before function parentheses. (space-before-function-paren)
(#83) ["client_id"] is better written in dot notation. (dot-notation)
(#85) Comments should not begin with a lowercase character. (capitalized-comments)
(#95) Unexpected space before function parentheses. (space-before-function-paren)
(#104) 'GGBApplet' is not defined. (no-undef)
(#111) Unexpected space before function parentheses. (space-before-function-paren)
(#125) Blocks are nested too deeply (5). Maximum allowed is 4. (max-depth)
(#126) Blocks are nested too deeply (6). Maximum allowed is 4. (max-depth)
(#139) Identifier 'update_feedback' is not in camel case. (camelcase)
(#139) Unexpected space before function parentheses. (space-before-function-paren)
(#144) 'ggbApplet' is not defined. (no-undef)
(#151) 'fbstring' used outside of binding context. (block-scoped-var)
(#154) This line has a length of 133. Maximum allowed is 132. (max-len)
(#154) 'fbstring' used outside of binding context. (block-scoped-var)
(#154) Comments should not begin with a lowercase character. (capitalized-comments)
(#154) Expected space or tab after '//' in comment. (spaced-comment)
(#156) 'fbstring' used outside of binding context. (block-scoped-var)
(#160) Expected space or tab after '//' in comment. (spaced-comment)
(#161) Missing JSDoc comment. (require-jsdoc)
(#161) 'ggbAppletOnLoad' is defined but never used. (no-unused-vars)
(#161) 'id' is defined but never used. (no-unused-vars)
(#166) Unary word operator 'typeof' must be followed by whitespace. (space-unary-ops)
(#180) Unexpected space before function parentheses. (space-before-function-paren)
(#182) Missing semicolon. (semi)
(#199) Missing JSDoc comment. (require-jsdoc)
(#205) Missing JSDoc comment. (require-jsdoc)
(#206) Expected space or tab after '//' in comment. (spaced-comment)
(#207) Identifier 'enable_right_click' is not in camel case. (camelcase)
(#208) Identifier 'enable_label_drags' is not in camel case. (camelcase)
(#209) Identifier 'show_reset_icon' is not in camel case. (camelcase)
(#210) Identifier 'enable_shift_drag_zoom' is not in camel case. (camelcase)
(#211) Identifier 'show_algebra_input' is not in camel case. (camelcase)
(#212) Identifier 'show_menu_bar' is not in camel case. (camelcase)
(#213) Identifier 'show_tool_bar' is not in camel case. (camelcase)
(#216) Identifier 'enable_right_click' is not in camel case. (camelcase)
(#217) Identifier 'enable_label_drags' is not in camel case. (camelcase)
(#218) Identifier 'show_reset_icon' is not in camel case. (camelcase)
(#219) Identifier 'enable_shift_drag_zoom' is not in camel case. (camelcase)
(#220) Identifier 'show_algebra_input' is not in camel case. (camelcase)
(#221) Identifier 'show_menu_bar' is not in camel case. (camelcase)
(#222) Identifier 'show_tool_bar' is not in camel case. (camelcase)
(#225) Identifier 'enable_right_click' is not in camel case. (camelcase)
(#226) Identifier 'enable_label_drags' is not in camel case. (camelcase)
(#227) Identifier 'show_reset_icon' is not in camel case. (camelcase)
(#228) Identifier 'enable_shift_drag_zoom' is not in camel case. (camelcase)
(#229) Identifier 'show_algebra_input' is not in camel case. (camelcase)
(#230) Identifier 'show_menu_bar' is not in camel case. (camelcase)
(#231) Identifier 'show_tool_bar' is not in camel case. (camelcase)
(#234) Missing JSDoc comment. (require-jsdoc)
(#238) 'GGBApplet' is not defined. (no-undef)
(#242) 'ggbApplet' is not defined. (no-undef)
(#246) Missing JSDoc comment. (require-jsdoc)
(#256) Missing JSDoc comment. (require-jsdoc)
(#257) 'ggbcheckb' is not defined. (no-undef)
(#268) Missing JSDoc comment. (require-jsdoc)
(#269) Unary word operator 'typeof' must be followed by whitespace. (space-unary-ops)
(#269) 'ggbcheckb' is not defined. (no-undef)
(#275) Missing JSDoc comment. (require-jsdoc)
(#275) Expected to return a value at the end of function 'handleDragOver'. (consistent-return)
(#276) Unary word operator 'typeof' must be followed by whitespace. (space-unary-ops)
(#276) 'ggbcheckb' is not defined. (no-undef)
(#286) Missing JSDoc comment. (require-jsdoc)
(#287) Unary word operator 'typeof' must be followed by whitespace. (space-unary-ops)
(#287) 'ggbcheckb' is not defined. (no-undef)
(#293) Missing JSDoc comment. (require-jsdoc)
(#294) Unary word operator 'typeof' must be followed by whitespace. (space-unary-ops)
(#294) 'ggbcheckb' is not defined. (no-undef)
(#297) 'file' is not defined. (no-undef)
(#309) Unexpected space before function parentheses. (space-before-function-paren)
(#313) Comments should not begin with a lowercase character. (capitalized-comments)
(#314) Identifier 'enable_right_click' is not in camel case. (camelcase)
(#315) Identifier 'enable_label_drags' is not in camel case. (camelcase)
(#316) Identifier 'show_reset_icon' is not in camel case. (camelcase)
(#317) Identifier 'enable_shift_drag_zoom' is not in camel case. (camelcase)
(#318) Identifier 'show_algebra_input' is not in camel case. (camelcase)
(#319) Identifier 'show_menu_bar' is not in camel case. (camelcase)
(#320) Identifier 'show_tool_bar' is not in camel case. (camelcase)
(#322) 'GGBApplet' is not defined. (no-undef)
(#327) 'file' is not defined. (no-undef)
(#331) Missing JSDoc comment. (require-jsdoc)

CSS problems

(6 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]

question/type/geogebra/styles.css
(#2) Unexpected !important (declaration-no-important)
(#3) Unexpected !important (declaration-no-important)
(#14) Unexpected !important (declaration-no-important)
(#8) Expected single space after "," in a single-line function (function-comma-space-after)
(#8) Expected single space after "," in a single-line function (function-comma-space-after)
(#8) Expected single space after "," in a single-line function (function-comma-space-after)

PHPDocs style problems

(64 errors, 3 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

question/type/geogebra/backup/moodle2/backup_qtype_geogebra_plugin.class.php
(#18) Package moodlecore is not valid
(#17) No one-line description found in phpdocs for file
(#25) No one-line description found in phpdocs for class backup_qtype_geogebra_plugin
question/type/geogebra/backup/moodle2/restore_qtype_geogebra_plugin.class.php
(#18) Package moodlecore is not valid
(#17) No one-line description found in phpdocs for file
(#25) No one-line description found in phpdocs for class restore_qtype_geogebra_plugin
(#55) Phpdocs for function restore_qtype_geogebra_plugin::process_geogebra has incomplete parameters list
question/type/geogebra/edit_geogebra_form.php
(#539) Function qtype_geogebra_edit_form::add_applet_options is not documented
(#602) Function qtype_geogebra_edit_form::check_is_exercise_present is not documented
(#39) Variable qtype_geogebra_edit_form::$qtypeobj is not documented
(#41) Variable qtype_geogebra_edit_form::$reload is not documented
(#43) Variable qtype_geogebra_edit_form::$ggbturl is not documented
(#45) Variable qtype_geogebra_edit_form::$ggbparameters is not documented
(#47) Variable qtype_geogebra_edit_form::$ggbviews is not documented
(#49) Variable qtype_geogebra_edit_form::$ggbcodebaseversion is not documented
(#51) There is no description in phpdocs for function __construct
(#123) There is no description in phpdocs for function definition_inner
(#174) There is no description in phpdocs for function get_more_choices_string
(#181) There is no description in phpdocs for function data_preprocessing
(#224) There is no description in phpdocs for function qtype
(#259) There is no description in phpdocs for function check_is_applet_present
(#273) There is no description in phpdocs for function check_force_dimensions
(#289) There is no description in phpdocs for function check_randomized_vars
(#316) There is no description in phpdocs for function check_constraints
(#383) There is no description in phpdocs for function check_answer
(#414) There is no description in phpdocs for function check_fraction
(#458) There is no description in phpdocs for function add_hidden_inputs
(#481) There is no description in phpdocs for function add_randomizedvar_fields
(#504) There is no description in phpdocs for function add_applet_elements
(#578) There is no description in phpdocs for function add_geogebra_file
(#52) Phpdocs for function qtype_geogebra_edit_form::__construct has incomplete parameters list
(#85) Phpdocs for function qtype_geogebra_edit_form::get_per_answer_fields has incomplete parameters list
(#181) Phpdocs for function qtype_geogebra_edit_form::data_preprocessing has incomplete parameters list
(#260) Phpdocs for function qtype_geogebra_edit_form::check_is_applet_present has incomplete parameters list
(#274) Phpdocs for function qtype_geogebra_edit_form::check_force_dimensions has incomplete parameters list
(#290) Phpdocs for function qtype_geogebra_edit_form::check_randomized_vars has incomplete parameters list
(#317) Phpdocs for function qtype_geogebra_edit_form::check_constraints has incomplete parameters list
(#384) Phpdocs for function qtype_geogebra_edit_form::check_answer has incomplete parameters list
(#415) Phpdocs for function qtype_geogebra_edit_form::check_fraction has incomplete parameters list
(#175) Invalid phpdocs tag @inheritdoc used
(#182) Invalid phpdocs tag @inheritdoc used
question/type/geogebra/question.php
(#121) Function qtype_geogebra_question::calculate_all_expressions is not documented
(#38) Variable qtype_geogebra_question::$ggbturl is not documented
(#39) Variable qtype_geogebra_question::$ggbparameters is not documented
(#40) Variable qtype_geogebra_question::$ggbviews is not documented
(#41) Variable qtype_geogebra_question::$ggbcodebaseversion is not documented
(#42) Variable qtype_geogebra_question::$ggbxml is not documented
(#43) Variable qtype_geogebra_question::$israndomized is not documented
(#44) Variable qtype_geogebra_question::$isexercise is not documented
(#45) Variable qtype_geogebra_question::$randomizedvar is not documented
(#46) Variable qtype_geogebra_question::$constraints is not documented
(#47) Variable qtype_geogebra_question::$forcedimensions is not documented
(#48) Variable qtype_geogebra_question::$width is not documented
(#49) Variable qtype_geogebra_question::$height is not documented
(#51) Variable qtype_geogebra_question::$currentvals is not documented
(#130) There is no description in phpdocs for function get_expected_data
(#142) There is no description in phpdocs for function get_correct_response
(#74) Phpdocs for function qtype_geogebra_question::start_attempt has incomplete parameters list
(#131) Invalid phpdocs tag @inheritdoc used
question/type/geogebra/questiontype.php
(#86) There is no description in phpdocs for function is_manual_graded
(#93) There is no description in phpdocs for function get_random_guess_score
question/type/geogebra/tests/fixtures/ggbstringsfortesting.php
(#31) Variable ggbstringsfortesting::$views is not documented
(#33) Variable ggbstringsfortesting::$pointparameters is not documented
(#35) Variable ggbstringsfortesting::$pointxml is not documented
question/type/geogebra/tests/helper.php
(#41) There is no description in phpdocs for function get_test_questions
question/type/geogebra/tests/questiontype_test.php
(#53) Variable questiontype_test::$includecoverage is not documented
(#69) There is no description in phpdocs for function get_test_question_data

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "stylelint:css" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]