Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(54 errors, 365 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

question/type/drawing/backup/moodle2/backup_qtype_drawing_plugin.class.php
(#24) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#46) Short array syntax must be used to define arrays
(#47) Short array syntax must be used to define arrays
(#48) There should be a comma after the last array item in a multi-line array.
(#52) Short array syntax must be used to define arrays
(#53) Short array syntax must be used to define arrays
(#54) There should be a comma after the last array item in a multi-line array.
(#61) Short array syntax must be used to define arrays
(#63) Short array syntax must be used to define arrays
(#76) Short array syntax must be used to define arrays
question/type/drawing/backup/moodle2/restore_qtype_drawing_plugin.class.php
(#24) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#31) Short array syntax must be used to define arrays
(#137) Short array syntax must be used to define arrays
(#150) Short array syntax must be used to define arrays
(#153) Short array syntax must be used to define arrays
question/type/drawing/classes/privacy/provider.php
(#19) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#31) File must end with a newline character
question/type/drawing/db/install.php
(#24) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
question/type/drawing/db/uninstall.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
question/type/drawing/db/upgrade.php
(#23) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#40) Short array syntax must be used to define arrays
(#55) Short array syntax must be used to define arrays
question/type/drawing/drawingarea.php
(#46) Short array syntax must be used to define arrays
(#169) Line indented incorrectly; expected at least 12 spaces, found 8
(#186) Line indented incorrectly; expected at least 12 spaces, found 8
(#196) Line indented incorrectly; expected at least 12 spaces, found 8
(#236) Line indented incorrectly; expected at least 16 spaces, found 12
(#441) Line indented incorrectly; expected at least 16 spaces, found 12
(#481) Short array syntax must be used to define arrays
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#481) Line exceeds 132 characters; contains 156 characters
(#484) Short array syntax must be used to define arrays
(#601) Line indented incorrectly; expected at least 20 spaces, found 16
(#619) Line indented incorrectly; expected at least 20 spaces, found 16
(#967) Line indented incorrectly; expected at least 20 spaces, found 16
(#1115) Line indented incorrectly; expected at least 12 spaces, found 8
question/type/drawing/edit_drawing_form.php
(#11) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".
(#15) Line 14 of the opening comment must start "// along with Moodle. If not, see <http://www.gnu.org/licenses/>.".
(#27) "require_once" must be immediately followed by an open parenthesis
(#61) Short array syntax must be used to define arrays
(#65) Short array syntax must be used to define arrays
(#65) Short array syntax must be used to define arrays
(#71) Short array syntax must be used to define arrays
(#73) Short array syntax must be used to define arrays
(#73) Short array syntax must be used to define arrays
(#91) Short array syntax must be used to define arrays
(#91) Short array syntax must be used to define arrays
(#99) Line exceeds 132 characters; contains 134 characters
(#113) Short array syntax must be used to define arrays
(#117) Short array syntax must be used to define arrays
(#121) Short array syntax must be used to define arrays
(#121) Line exceeds 132 characters; contains 133 characters
(#124) Short array syntax must be used to define arrays
(#130) Short array syntax must be used to define arrays
(#163) Short array syntax must be used to define arrays
(#173) Line exceeds 132 characters; contains 134 characters
(#178) Short array syntax must be used to define arrays
(#183) Line exceeds 132 characters; contains 136 characters
(#184) Short array syntax must be used to define arrays
(#203) Short array syntax must be used to define arrays
(#205) Short array syntax must be used to define arrays
(#208) Short array syntax must be used to define arrays
(#212) Short array syntax must be used to define arrays
(#222) Short array syntax must be used to define arrays
(#224) Short array syntax must be used to define arrays
(#253) Short array syntax must be used to define arrays
(#271) Short array syntax must be used to define arrays
(#279) Short array syntax must be used to define arrays
(#296) Line exceeds 132 characters; contains 136 characters
(#308) Short array syntax must be used to define arrays
(#309) Short array syntax must be used to define arrays
(#309) There should be a comma after the last array item in a multi-line array.
(#318) Short array syntax must be used to define arrays
(#327) Short array syntax must be used to define arrays
(#330) Short array syntax must be used to define arrays
(#331) There should be a comma after the last array item in a multi-line array.
question/type/drawing/getannotation.php
(#39) Short array syntax must be used to define arrays
(#45) Short array syntax must be used to define arrays
(#49) Short array syntax must be used to define arrays
(#52) Short array syntax must be used to define arrays
(#53) Short array syntax must be used to define arrays
(#60) Short array syntax must be used to define arrays
(#60) Line exceeds 132 characters; contains 149 characters
(#62) Short array syntax must be used to define arrays
(#65) Short array syntax must be used to define arrays
(#68) Short array syntax must be used to define arrays
(#70) Short array syntax must be used to define arrays
(#77) Short array syntax must be used to define arrays
question/type/drawing/lang/de/qtype_drawing.php
(#203) File must end with a newline character
question/type/drawing/lang/en/qtype_drawing.php
(#203) File must end with a newline character
question/type/drawing/lib.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#34) Short array syntax must be used to define arrays
question/type/drawing/loadannotationdetails.php
(#44) Short array syntax must be used to define arrays
(#50) Short array syntax must be used to define arrays
(#54) Short array syntax must be used to define arrays
(#57) Short array syntax must be used to define arrays
(#58) Short array syntax must be used to define arrays
(#63) Short array syntax must be used to define arrays
(#66) Short array syntax must be used to define arrays
(#87) Short array syntax must be used to define arrays
question/type/drawing/question.php
(#43) Short array syntax must be used to define arrays
(#50) Short array syntax must be used to define arrays
question/type/drawing/questiontype.php
(#42) Short array syntax must be used to define arrays
(#43) There should be a comma after the last array item in a multi-line array.
(#70) Short array syntax must be used to define arrays
(#71) Short array syntax must be used to define arrays
(#72) Short array syntax must be used to define arrays
(#82) Short array syntax must be used to define arrays
(#82) There should be a comma after the last array item in a multi-line array.
(#111) Expected "if (...) {\n"; found "if(...){\n"
(#128) Short array syntax must be used to define arrays
(#147) Short array syntax must be used to define arrays
(#153) There should be a comma after the last array item in a multi-line array.
(#183) Short array syntax must be used to define arrays
(#200) Short array syntax must be used to define arrays
(#222) Expected "if (...) {\n"; found "if(...){\n"
(#223) Short array syntax must be used to define arrays
(#250) Short array syntax must be used to define arrays
(#250) Short array syntax must be used to define arrays
(#264) Short array syntax must be used to define arrays
(#270) Short array syntax must be used to define arrays
(#271) Short array syntax must be used to define arrays
(#272) Short array syntax must be used to define arrays
question/type/drawing/renderer.php
(#86) Short array syntax must be used to define arrays
(#95) Expected "if (...) {\n"; found "if(...){\n"
(#97) Short array syntax must be used to define arrays
(#99) Expected "if (...) {\n"; found "if(...){\n"
(#104) Expected "if (...) {\n"; found "if(...) {\n"
(#104) Short array syntax must be used to define arrays
(#107) Expected "if (...) {\n"; found "if(...) {\n"
(#126) Expected "if (...) {\n"; found "if(...){\n"
(#127) Short array syntax must be used to define arrays
(#141) Short array syntax must be used to define arrays
(#141) Line exceeds 132 characters; contains 143 characters
(#191) Expected "if (...) {\n"; found "if(...){\n"
(#202) Line exceeds 132 characters; contains 150 characters
(#207) Line indented incorrectly; expected 16 spaces, found 35
(#210) Line indented incorrectly; expected 16 spaces, found 35
(#215) Line exceeds 132 characters; contains 139 characters
(#220) Line indented incorrectly; expected 16 spaces, found 35
(#224) Short array syntax must be used to define arrays
(#224) Line exceeds 132 characters; contains 171 characters
(#225) Line indented incorrectly; expected 16 spaces, found 35
(#226) Line indented incorrectly; expected 20 spaces, found 39
(#228) Line indented incorrectly; expected 20 spaces, found 39
(#230) Line indented incorrectly; expected 16 spaces, found 35
(#232) Line indented incorrectly; expected 16 spaces, found 35
(#237) Line exceeds maximum limit of 180 characters; contains 200 characters
(#241) Line exceeds 132 characters; contains 169 characters
(#242) Line exceeds 132 characters; contains 162 characters
(#243) Line exceeds 132 characters; contains 157 characters
(#257) Line indented incorrectly; expected 16 spaces, found 35
(#257) Expected "if (...) {\n"; found "if(...) {\n"
(#258) Commas (,) must be followed by white space.
(#258) Line exceeds maximum limit of 180 characters; contains 329 characters
(#259) Line indented incorrectly; expected 16 spaces, found 35
(#261) Short array syntax must be used to define arrays
(#261) Line exceeds 132 characters; contains 168 characters
(#263) Line indented incorrectly; expected 16 spaces, found 35
(#265) Short array syntax must be used to define arrays
(#266) Short array syntax must be used to define arrays
(#267) Line indented incorrectly; expected 16 spaces, found 35
(#302) Short array syntax must be used to define arrays
(#302) Line exceeds 132 characters; contains 158 characters
(#405) Line exceeds 132 characters; contains 136 characters
(#407) Line exceeds 132 characters; contains 140 characters
(#439) Line exceeds 132 characters; contains 138 characters
(#523) Short array syntax must be used to define arrays
(#525) Line indented incorrectly; expected 8 spaces, found 18
(#527) Short array syntax must be used to define arrays
(#528) Short array syntax must be used to define arrays
(#529) Line indented incorrectly; expected 8 spaces, found 18
(#536) Short array syntax must be used to define arrays
(#576) Short array syntax must be used to define arrays
(#584) Short array syntax must be used to define arrays
(#635) Logical operator "and" is prohibited; use "&&" instead
question/type/drawing/saveannotation.php
(#44) Short array syntax must be used to define arrays
(#50) Short array syntax must be used to define arrays
(#54) Short array syntax must be used to define arrays
(#57) Short array syntax must be used to define arrays
(#58) Short array syntax must be used to define arrays
(#65) Expected "if (...) {\n"; found "if(...){\n"
(#66) Short array syntax must be used to define arrays
(#70) Short array syntax must be used to define arrays
(#70) Line exceeds 132 characters; contains 150 characters
question/type/drawing/tests/helper.php
(#37) Short array syntax must be used to define arrays
(#64) Short array syntax must be used to define arrays
(#66) There should be a comma after the last array item in a multi-line array.
(#68) Short array syntax must be used to define arrays
(#70) There should be a comma after the last array item in a multi-line array.
(#82) Expected 1 space before "="; 0 found
question/type/drawing/tests/question_test.php
(#38) PHPUnit testcase name "qtype_drawing_question_test" does not match file name "question_test"
(#38) PHPUnit class "qtype_drawing_question_test" does not have any namespace. It is recommended to add it to the "qtype_drawing" namespace, using more levels if needed, in order to match the code being tested
(#40) Test method test_get_question_summary() is missing any coverage information, own or at class level
question/type/drawing/tests/questiontype_test.php
(#41) PHPUnit testcase name "qtype_drawing_test" does not match file name "questiontype_test"
(#41) PHPUnit class "qtype_drawing_test" does not have any namespace. It is recommended to add it to the "qtype_drawing" namespace, using more levels if needed, in order to match the code being tested
(#59) Test method test_name() is missing any coverage information, own or at class level
(#63) Test method test_can_analyse_responses() is missing any coverage information, own or at class level
(#67) Test method test_get_random_guess_score() is missing any coverage information, own or at class level
question/type/drawing/tests/walkthrough_test.php
(#35) PHPUnit testcase name "qtype_drawing_walkthrough_testcase" does not match file name "walkthrough_test"
(#35) PHPUnit class "qtype_drawing_walkthrough_testcase" does not have any namespace. It is recommended to add it to the "qtype_drawing" namespace, using more levels if needed, in order to match the code being tested
(#37) Test method test_deferred_feedback_plain_text() is missing any coverage information, own or at class level
(#49) Short array syntax must be used to define arrays
(#59) Short array syntax must be used to define arrays
(#60) There should be a comma after the last array item in a multi-line array.

Javascript coding style problems

(55 errors, 113 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

question/type/drawing/yui/form/form.js
(#9) 'YUI' is not defined. (no-undef)
(#10) 'CSS' is assigned a value but never used. (no-unused-vars)
(#16) Missing space before value for key 'DRAWINGCANVASID'. (key-spacing)
(#69) Identifier 'filepicker_change_sub' is not in camel case. (camelcase)
(#70) Identifier 'choose_new_image_file_click_sub' is not in camel case. (camelcase)
(#71) Identifier 'eraser_click_sub' is not in camel case. (camelcase)
(#72) Identifier 'undo_click_sub' is not in camel case. (camelcase)
(#73) Identifier 'eraser_tool_click_sub' is not in camel case. (camelcase)
(#74) Identifier 'canvas_mousedown_sub' is not in camel case. (camelcase)
(#75) Identifier 'canvas_touchstart_sub' is not in camel case. (camelcase)
(#76) Identifier 'canvas_touchmove_sub' is not in camel case. (camelcase)
(#77) Identifier 'canvas_touchend_sub' is not in camel case. (camelcase)
(#79) Identifier 'canvas_pointerstart_sub' is not in camel case. (camelcase)
(#80) Identifier 'canvas_pointermove_sub' is not in camel case. (camelcase)
(#81) Identifier 'canvas_pointerend_sub' is not in camel case. (camelcase)
(#83) Identifier 'canvas_mouseup_sub' is not in camel case. (camelcase)
(#84) Identifier 'canvas_mouseout_sub' is not in camel case. (camelcase)
(#85) Identifier 'drawing_radius_change_sub' is not in camel case. (camelcase)
(#86) Identifier 'drawing_radius_mouseup_sub' is not in camel case. (camelcase)
(#87) Identifier 'drawing_color_change_sub' is not in camel case. (camelcase)
(#88) Identifier 'quickcolor1_click_sub' is not in camel case. (camelcase)
(#89) Identifier 'quickcolor2_click_sub' is not in camel case. (camelcase)
(#90) Identifier 'quickcolor3_click_sub' is not in camel case. (camelcase)
(#91) Identifier 'quickcolor4_click_sub' is not in camel case. (camelcase)
(#92) Identifier 'quickradius1_click_sub' is not in camel case. (camelcase)
(#93) Identifier 'quickradius2_click_sub' is not in camel case. (camelcase)
(#94) Identifier 'quickradius3_click_sub' is not in camel case. (camelcase)
(#95) Identifier 'quickradius4_click_sub' is not in camel case. (camelcase)
(#96) Identifier 'zoomcanvas_click_sub' is not in camel case. (camelcase)
(#97) Identifier 'closecanvasoverlay_click_sub' is not in camel case. (camelcase)
(#98) Identifier 'edit_mode' is not in camel case. (camelcase)
(#99) Identifier 'resize_sub' is not in camel case. (camelcase)
(#100) Identifier 'drawing_question_id' is not in camel case. (camelcase)
(#101) Identifier 'contextmenu_sub' is not in camel case. (camelcase)
(#102) Identifier 'resizecanvasw_sub' is not in camel case. (camelcase)
(#103) Identifier 'resizecanvash_sub' is not in camel case. (camelcase)
(#109) Identifier 'qtype_drawing_size_listener' is not in camel case. (camelcase)
(#109) Missing space before opening brace. (space-before-blocks)
(#112) Expected space(s) after "if". (keyword-spacing)
(#113) Identifier 'resizecanvasw_sub' is not in camel case. (camelcase)
(#113) Multiple spaces found before 'Y'. (no-multi-spaces)
(#115) Expected space(s) after "if". (keyword-spacing)
(#116) Identifier 'resizecanvash_sub' is not in camel case. (camelcase)
(#116) Multiple spaces found before 'Y'. (no-multi-spaces)
(#119) Missing space before opening brace. (space-before-blocks)
(#120) Missing space before opening brace. (space-before-blocks)
(#123) Expected space(s) after "if". (keyword-spacing)
(#123) Missing space before opening brace. (space-before-blocks)
(#127) Missing space before opening brace. (space-before-blocks)
(#128) Missing space before opening brace. (space-before-blocks)
(#131) Expected space(s) after "if". (keyword-spacing)
(#131) Missing space before opening brace. (space-before-blocks)
(#135) Missing space before opening brace. (space-before-blocks)
(#137) Expected space(s) after "if". (keyword-spacing)
(#137) Missing space before opening brace. (space-before-blocks)
(#142) Expected space(s) after "if". (keyword-spacing)
(#142) Missing space before opening brace. (space-before-blocks)
(#145) Expected space(s) after "if". (keyword-spacing)
(#145) Missing space before opening brace. (space-before-blocks)
(#148) 'naturalheight' is not defined. (no-undef)
(#149) 'naturalwidth' is not defined. (no-undef)
(#150) 'aspectratio' is not defined. (no-undef)
(#150) 'naturalheight' is not defined. (no-undef)
(#150) 'naturalwidth' is not defined. (no-undef)
(#151) 'aspectratio' is not defined. (no-undef)
(#154) Missing space before opening brace. (space-before-blocks)
(#155) Expected space(s) after "if". (keyword-spacing)
(#155) Missing space before opening brace. (space-before-blocks)
(#158) Expected space(s) after "if". (keyword-spacing)
(#158) Missing space before opening brace. (space-before-blocks)
(#161) Expected space(s) after "if". (keyword-spacing)
(#161) Missing space before opening brace. (space-before-blocks)
(#164) 'naturalheight' is not defined. (no-undef)
(#165) 'naturalwidth' is not defined. (no-undef)
(#166) 'aspectratio' is not defined. (no-undef)
(#166) 'naturalwidth' is not defined. (no-undef)
(#166) 'naturalheight' is not defined. (no-undef)
(#167) 'aspectratio' is not defined. (no-undef)
(#171) Identifier 'drawing_question_id' is not in camel case. (camelcase)
(#175) Use '===' to compare with null. (no-eq-null)
(#176) 'questionID' is not defined. (no-undef)
(#179) Identifier 'edit_mode' is not in camel case. (camelcase)
(#181) This line has a length of 160. Maximum allowed is 132. (max-len)
(#181) Statement inside of curly braces should be on next line. (brace-style)
(#181) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
(#183) Expected space(s) after "if". (keyword-spacing)
(#184) Identifier 'filepicker_change_sub' is not in camel case. (camelcase)
(#186) Expected space(s) after "if". (keyword-spacing)
(#187) This line has a length of 157. Maximum allowed is 132. (max-len)
(#187) Identifier 'choose_new_image_file_click_sub' is not in camel case. (camelcase)
(#190) This line has a length of 150. Maximum allowed is 132. (max-len)
(#190) Identifier 'contextmenu_sub' is not in camel case. (camelcase)
(#194) Identifier 'drawing_question_id' is not in camel case. (camelcase)
(#196) Use '===' to compare with null. (no-eq-null)
(#205) Identifier 'edit_mode' is not in camel case. (camelcase)
(#208) This line has a length of 160. Maximum allowed is 132. (max-len)
(#208) Statement inside of curly braces should be on next line. (brace-style)
(#208) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
(#210) Expected space(s) after "if". (keyword-spacing)
(#211) This line has a length of 139. Maximum allowed is 132. (max-len)
(#211) Identifier 'filepicker_change_sub' is not in camel case. (camelcase)
(#211) Multiple spaces found before 'this'. (no-multi-spaces)
(#211) Multiple spaces found before 'Y'. (no-multi-spaces)
(#213) Expected space(s) after "if". (keyword-spacing)
(#214) This line has a length of 157. Maximum allowed is 132. (max-len)
(#214) Identifier 'choose_new_image_file_click_sub' is not in camel case. (camelcase)
(#217) This line has a length of 150. Maximum allowed is 132. (max-len)
(#217) Identifier 'contextmenu_sub' is not in camel case. (camelcase)
(#221) 'questionID' is defined but never used. (no-unused-vars)
(#221) 'background' is defined but never used. (no-unused-vars)
(#221) 'width' is defined but never used. (no-unused-vars)
(#221) 'height' is defined but never used. (no-unused-vars)
(#221) 'datatype' is defined but never used. (no-unused-vars)
(#234) Identifier 'draw_correct_answer' is not in camel case. (camelcase)
(#236) A space is required after ','. (comma-spacing)
(#236) A space is required after ','. (comma-spacing)
(#239) Identifier 'choose_new_image_file_click' is not in camel case. (camelcase)
(#239) 'e' is defined but never used. (no-unused-vars)
(#241) Unexpected confirm. (no-alert)
(#246) Identifier 'is_canvas_empty' is not in camel case. (camelcase)
(#246) Statement inside of curly braces should be on next line. (brace-style)
(#246) Requires a space after '{'. (block-spacing)
(#246) Statement inside of curly braces should be on next line. (brace-style)
(#246) Requires a space before '}'. (block-spacing)
(#246) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
(#248) 'canvasNode' is not defined. (no-undef)
(#252) 'canvasNode' is not defined. (no-undef)
(#254) The function binding is unnecessary. (no-extra-bind)
(#256) This line has a length of 137. Maximum allowed is 132. (max-len)
(#256) 'canvasNode' is not defined. (no-undef)
(#261) Identifier 'filepicker_change' is not in camel case. (camelcase)
(#261) 'e' is defined but never used. (no-unused-vars)
(#270) Unexpected space before function parentheses. (space-before-function-paren)
(#271) 'questionID' is not defined. (no-undef)
(#273) Expected space(s) after "if". (keyword-spacing)
(#273) Missing space before opening brace. (space-before-blocks)
(#277) Expected space(s) after "if". (keyword-spacing)
(#277) Use '===' to compare with null. (no-eq-null)
(#277) Missing space before opening brace. (space-before-blocks)
(#287) This line has a length of 255. Maximum allowed is 132. (max-len)
(#291) Identifier 'create_canvas_new_question' is not in camel case. (camelcase)
(#293) 'Xtextarea' is not defined. (no-undef)
(#295) 'Xtextarea' is not defined. (no-undef)
(#297) 'image' is assigned a value but never used. (no-unused-vars)
(#298) 'Xtextarea' is not defined. (no-undef)
(#300) Identifier 'create_canvas_edit_question' is not in camel case. (camelcase)
(#301) 'Xtextarea' is not defined. (no-undef)
(#303) Identifier 'create_canvas_context' is not in camel case. (camelcase)
(#303) A space is required after ','. (comma-spacing)
(#303) 'originalBackGroundURL' is defined but never used. (no-unused-vars)
(#303) A space is required after ','. (comma-spacing)
(#303) 'correctAnswer' is defined but never used. (no-unused-vars)
(#308) 'Xtextarea' is not defined. (no-undef)
(#310) 'Xtextarea' is not defined. (no-undef)
(#313) 'image' is assigned a value but never used. (no-unused-vars)
(#314) Use '===' to compare with null. (no-eq-null)
(#314) 'Xtextarea' is not defined. (no-undef)
(#316) 'Xtextarea' is not defined. (no-undef)
(#319) Unexpected alert. (no-alert)
(#323) Identifier 'canvas_get_textarea' is not in camel case. (camelcase)
(#324) 'questionID' is not defined. (no-undef)
(#325) 'questionID' is not defined. (no-undef)
(#328) 'questionID' is not defined. (no-undef)
(#331) Identifier 'canvas_get_question_id' is not in camel case. (camelcase)
(#339) Identifier 'canvas_mouseup' is not in camel case. (camelcase)
(#339) 'e' is defined but never used. (no-unused-vars)
(#339) Unexpected empty method 'canvas_mouseup'. (no-empty-function)
(#348) There should be no space before '}'. (object-curly-spacing)

CSS problems

(70 errors, 2 warnings)

This section shows CSS problems detected by stylelint [More info]

question/type/drawing/styles.css
(#29) Unknown property `align`
(#77) Expected "#F6F7F8" to be "#f6f7f8" (color-hex-case)
(#49) Unexpected duplicate "cursor" (declaration-block-no-duplicate-properties)
(#57) Unexpected duplicate "cursor" (declaration-block-no-duplicate-properties)
(#64) Unexpected duplicate "cursor" (declaration-block-no-duplicate-properties)
(#49) Expected newline after ";" in a multi-line declaration block (declaration-block-semicolon-newline-after)
(#57) Expected newline after ";" in a multi-line declaration block (declaration-block-semicolon-newline-after)
(#64) Expected newline after ";" in a multi-line declaration block (declaration-block-semicolon-newline-after)
(#32) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#72) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#77) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#79) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#108) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#109) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#110) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#111) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#112) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#113) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#114) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#105) Unexpected URL scheme "data:" (function-url-scheme-blacklist)
(#84) Unexpected unit (length-zero-no-unit)
(#29) Unexpected unknown property "align" (property-no-unknown)
(#7) Expected newline after "," (selector-list-comma-newline-after)
(#8) Expected indentation of 4 spaces (indentation)
(#9) Expected indentation of 4 spaces (indentation)
(#16) Expected indentation of 4 spaces (indentation)
(#19) Expected indentation of 4 spaces (indentation)
(#23) Expected indentation of 4 spaces (indentation)
(#26) Expected indentation of 4 spaces (indentation)
(#29) Expected indentation of 4 spaces (indentation)
(#37) Expected indentation of 4 spaces (indentation)
(#38) Expected indentation of 4 spaces (indentation)
(#39) Expected indentation of 4 spaces (indentation)
(#40) Expected indentation of 4 spaces (indentation)
(#41) Expected indentation of 4 spaces (indentation)
(#44) Expected indentation of 4 spaces (indentation)
(#45) Expected indentation of 4 spaces (indentation)
(#46) Expected indentation of 4 spaces (indentation)
(#47) Expected indentation of 4 spaces (indentation)
(#52) Expected indentation of 4 spaces (indentation)
(#53) Expected indentation of 4 spaces (indentation)
(#54) Expected indentation of 4 spaces (indentation)
(#55) Expected indentation of 4 spaces (indentation)
(#60) Expected indentation of 4 spaces (indentation)
(#61) Expected indentation of 4 spaces (indentation)
(#62) Expected indentation of 4 spaces (indentation)
(#63) Expected indentation of 4 spaces (indentation)
(#64) Expected indentation of 4 spaces (indentation)
(#65) Expected indentation of 4 spaces (indentation)
(#66) Expected indentation of 4 spaces (indentation)
(#67) Expected indentation of 4 spaces (indentation)
(#70) Expected indentation of 4 spaces (indentation)
(#85) Expected indentation of 4 spaces (indentation)
(#86) Expected indentation of 4 spaces (indentation)
(#87) Expected indentation of 4 spaces (indentation)
(#95) Expected indentation of 4 spaces (indentation)
(#104) Expected indentation of 4 spaces (indentation)
(#105) Expected indentation of 4 spaces (indentation)
question/type/drawing/css/fonts.css
(#7) Expected empty line before at-rule (at-rule-empty-line-before)
(#13) Expected empty line before at-rule (at-rule-empty-line-before)
(#19) Expected empty line before at-rule (at-rule-empty-line-before)
(#25) Expected empty line before at-rule (at-rule-empty-line-before)
(#31) Expected empty line before at-rule (at-rule-empty-line-before)
(#37) Expected empty line before at-rule (at-rule-empty-line-before)
(#43) Expected empty line before at-rule (at-rule-empty-line-before)
(#49) Expected empty line before at-rule (at-rule-empty-line-before)
(#55) Expected empty line before at-rule (at-rule-empty-line-before)
(#61) Expected empty line before at-rule (at-rule-empty-line-before)
(#67) Expected empty line before at-rule (at-rule-empty-line-before)
(#73) Expected empty line before at-rule (at-rule-empty-line-before)
(#79) Expected empty line before at-rule (at-rule-empty-line-before)
question/type/drawing/css/method-draw.css
(#1115) Unknown word (CssSyntaxError)

PHPDocs style problems

(42 errors, 43 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

question/type/drawing/backup/moodle2/backup_qtype_drawing_plugin.class.php
(#25) Class backup_qtype_drawing_plugin is not documented
(#17) No one-line description found in phpdocs for file
(#72) Inline phpdocs tag {@link get_components_and_fileareas} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#19) Package qtype is not valid
question/type/drawing/backup/moodle2/restore_qtype_drawing_plugin.class.php
(#25) Class restore_qtype_drawing_plugin is not documented
(#116) Function restore_qtype_drawing_plugin::after_execute_question is not documented
(#122) Function restore_qtype_drawing_plugin::recode_response is not documented
(#17) No one-line description found in phpdocs for file
(#54) Phpdocs for function restore_qtype_drawing_plugin::process_drawing has incomplete parameters list
(#79) Phpdocs for function restore_qtype_drawing_plugin::process_drawingannotation has incomplete parameters list
(#19) Package qtype is not valid
question/type/drawing/classes/privacy/provider.php
(#20) Class provider is not documented
(#20) Package is not specified for class provider. It is also not specified in file-level phpdocs
question/type/drawing/db/upgrade.php
(#17) No one-line description found in phpdocs for file
(#17) File-level phpdocs block does not have @license tag
question/type/drawing/drawingarea.php
(#20) Package qtype is not valid
question/type/drawing/edit_drawing_form.php
(#28) Class qtype_drawing_edit_form is not documented
(#188) Function qtype_drawing_edit_form::definition_inner is not documented
(#314) Function qtype_drawing_edit_form::js_call is not documented
(#335) Function qtype_drawing_edit_form::data_preprocessing is not documented
(#344) Function qtype_drawing_edit_form::validation is not documented
(#20) Package qtype is not valid
question/type/drawing/getannotation.php
(#20) Package qtype is not valid
question/type/drawing/lang/de/qtype_drawing.php
(#20) Package qtype is not valid
question/type/drawing/lang/en/qtype_drawing.php
(#20) Package qtype is not valid
question/type/drawing/lib.php
(#31) Phpdocs for function qtype_drawing_pluginfile has incomplete parameters list
(#21) Package qtype is not valid
question/type/drawing/loadannotationdetails.php
(#20) Package qtype is not valid
question/type/drawing/question.php
(#45) Function qtype_drawing_question::__construct is not documented
(#49) Function qtype_drawing_question::get_expected_data is not documented
(#53) Function qtype_drawing_question::summarise_response is not documented
(#57) Function qtype_drawing_question::make_behaviour is not documented
(#60) Function qtype_drawing_question::is_complete_response is not documented
(#68) Function qtype_drawing_question::is_gradable_response is not documented
(#71) Function qtype_drawing_question::get_validation_error is not documented
(#78) Function qtype_drawing_question::is_same_response is not documented
(#83) Function qtype_drawing_question::get_answers is not documented
(#87) Function qtype_drawing_question::get_correct_response is not documented
(#90) Function qtype_drawing_question::get_right_answer_summary is not documented
(#93) Function qtype_drawing_question::compare_response_with_answer is not documented
(#105) Function qtype_drawing_question::check_file_access is not documented
(#20) Package qtype is not valid
question/type/drawing/questiontype.php
(#41) Function qtype_drawing::extra_question_fields is not documented
(#46) Function qtype_drawing::questionid_column_name is not documented
(#50) Function qtype_drawing::move_files is not documented
(#56) Function qtype_drawing::delete_files is not documented
(#75) Function qtype_drawing::save_question_options is not documented
(#173) Function qtype_drawing::initialise_question_instance is not documented
(#178) Function qtype_drawing::get_random_guess_score is not documented
(#182) Function qtype_drawing::get_possible_responses is not documented
(#203) Function qtype_drawing::export_to_xml is not documented
(#242) Function qtype_drawing::import_from_xml is not documented
(#61) Phpdocs for function qtype_drawing::delete_question has incomplete parameters list
(#20) Package qtype is not valid
question/type/drawing/renderer.php
(#610) Class drawing_blob_data_as_file_stream is not documented
(#38) Function qtype_drawing_renderer::translate_to_js is not documented
(#44) Function qtype_drawing_renderer::strstr_after is not documented
(#54) Function qtype_drawing_renderer::create_gd_image_from_string is not documented
(#58) Function qtype_drawing_renderer::isblue is not documented
(#65) Function qtype_drawing_renderer::gdimage_to_datauri is not documented
(#80) Function qtype_drawing_renderer::formulation_and_controls is not documented
(#533) Function qtype_drawing_renderer::specific_feedback is not documented
(#545) Function qtype_drawing_renderer::correct_response is not documented
(#560) Function qtype_drawing_renderer::get_image_for_question is not documented
(#564) Function qtype_drawing_renderer::get_image_for_files is not documented
(#589) Function qtype_drawing_renderer::isdataurlavaliddrawing is not documented
(#594) Function qtype_drawing_renderer::isimagetransparent is not documented
(#615) Function drawing_blob_data_as_file_stream::stream_open is not documented
(#620) Function drawing_blob_data_as_file_stream::stream_seek is not documented
(#643) Function drawing_blob_data_as_file_stream::stream_tell is not documented
(#647) Function drawing_blob_data_as_file_stream::stream_read is not documented
(#653) Function drawing_blob_data_as_file_stream::stream_write is not documented
(#660) Function drawing_blob_data_as_file_stream::stream_eof is not documented
(#612) Variable drawing_blob_data_as_file_stream::$blobdataposition is not documented
(#613) Variable drawing_blob_data_as_file_stream::$blobdatastream is not documented
(#20) Package qtype is not valid
question/type/drawing/saveannotation.php
(#20) Package qtype is not valid
question/type/drawing/settings.php
(#17) No one-line description found in phpdocs for file
(#17) File-level phpdocs block does not have @license tag
question/type/drawing/tests/helper.php
(#36) Function qtype_drawing_test_helper::get_test_questions is not documented
question/type/drawing/tests/question_test.php
(#20) Package qtype is not valid
question/type/drawing/tests/questiontype_test.php
(#52) Function qtype_drawing_test::get_test_question_data is not documented
(#42) Variable qtype_drawing_test::$qtype is not documented
(#20) Package qtype is not valid
question/type/drawing/version.php
(#20) Package qtype is not valid

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "gherkinlint" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(1 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]

question/type/drawing/tests/behat/add.feature
(#18) Multiple empty lines are not allowed