Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(11 errors, 7 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

question/type/ddmatch/classes/privacy/privacy.php
(#42) Opening brace should be on the same line as the declaration
question/type/ddmatch/db/upgrade.php
(#329) Whitespace found at end of line
question/type/ddmatch/tests/upgradelibnewqe_test.php
(#232) Line exceeds maximum limit of 180 characters; contains 493 characters
(#233) Line exceeds maximum limit of 180 characters; contains 309 characters
(#234) Line exceeds maximum limit of 180 characters; contains 313 characters
(#291) Line exceeds 132 characters; contains 143 characters
(#385) Line exceeds 132 characters; contains 134 characters
(#448) Line exceeds maximum limit of 180 characters; contains 407 characters
(#449) Line exceeds maximum limit of 180 characters; contains 330 characters
(#450) Line exceeds maximum limit of 180 characters; contains 334 characters
(#549) Line exceeds 132 characters; contains 162 characters
(#553) Line exceeds 132 characters; contains 161 characters
(#561) Line exceeds 132 characters; contains 170 characters
(#597) Line exceeds 132 characters; contains 133 characters
(#712) Line exceeds maximum limit of 180 characters; contains 407 characters
(#713) Line exceeds maximum limit of 180 characters; contains 330 characters
(#714) Line exceeds maximum limit of 180 characters; contains 333 characters
(#768) Inline comments must end in full-stops, exclamation marks, or question marks

Javascript coding style problems

(4 errors, 15 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

question/type/ddmatch/yui/dragdrop/dragdrop.js
(#1) 'YUI' is not defined. (no-undef)
(#1) 'NAME' is defined but never used. (no-unused-vars)
(#10) Extra space after key 'container'. (key-spacing)
(#11) Extra space after key 'delegation'. (key-spacing)
(#13) Extra space after key 'initializer'. (key-spacing)
(#24) Invalid typeof comparison value. (valid-typeof)
(#51) 'drop' is assigned a value but never used. (no-unused-vars)
(#53) There should be no space after '['. (array-bracket-spacing)
(#53) There should be no space before ']'. (array-bracket-spacing)
(#60) Extra space after key 'handleHit'. (key-spacing)
(#99) Extra space after key 'handleMiss'. (key-spacing)
(#121) Extra space after key 'setValue'. (key-spacing)
(#140) Extra space after key 'NAME'. (key-spacing)
(#141) Extra space after key 'ATTRS'. (key-spacing)
(#142) Extra space after key 'questionid'. (key-spacing)
(#143) Extra space after key 'type'. (key-spacing)
(#144) Extra space after key 'default'. (key-spacing)
(#151) Identifier 'init_dragdrop' is not in camel case. (camelcase)
(#158) Missing space before value for key 'requires'. (key-spacing)

CSS problems

(75 errors, 4 warnings)

This section shows CSS problems detected by stylelint [More info]

question/type/ddmatch/styles.css
(#149) Expected empty line before at-rule (at-rule-empty-line-before)
(#133) Expected newline before "}" (block-closing-brace-newline-before)
(#134) Expected newline before "}" (block-closing-brace-newline-before)
(#135) Expected newline before "}" (block-closing-brace-newline-before)
(#136) Expected newline before "}" (block-closing-brace-newline-before)
(#150) Expected newline before "}" (block-closing-brace-newline-before)
(#151) Expected newline before "}" (block-closing-brace-newline-before)
(#133) Expected single space before "}" of a single-line block (block-closing-brace-space-before)
(#134) Expected single space before "}" of a single-line block (block-closing-brace-space-before)
(#135) Expected single space before "}" of a single-line block (block-closing-brace-space-before)
(#136) Expected single space before "}" of a single-line block (block-closing-brace-space-before)
(#150) Expected single space before "}" of a single-line block (block-closing-brace-space-before)
(#151) Expected single space before "}" of a single-line block (block-closing-brace-space-before)
(#133) Expected newline after "{" (block-opening-brace-newline-after)
(#134) Expected newline after "{" (block-opening-brace-newline-after)
(#135) Expected newline after "{" (block-opening-brace-newline-after)
(#136) Expected newline after "{" (block-opening-brace-newline-after)
(#150) Expected newline after "{" (block-opening-brace-newline-after)
(#151) Expected newline after "{" (block-opening-brace-newline-after)
(#133) Expected single space after "{" of a single-line block (block-opening-brace-space-after)
(#134) Expected single space after "{" of a single-line block (block-opening-brace-space-after)
(#135) Expected single space after "{" of a single-line block (block-opening-brace-space-after)
(#136) Expected single space after "{" of a single-line block (block-opening-brace-space-after)
(#150) Expected single space after "{" of a single-line block (block-opening-brace-space-after)
(#151) Expected single space after "{" of a single-line block (block-opening-brace-space-after)
(#62) Expected single space before "{" (block-opening-brace-space-before)
(#133) Expected single space before "{" (block-opening-brace-space-before)
(#134) Expected single space before "{" (block-opening-brace-space-before)
(#135) Expected single space before "{" (block-opening-brace-space-before)
(#136) Expected single space before "{" (block-opening-brace-space-before)
(#137) Expected single space before "{" (block-opening-brace-space-before)
(#150) Expected single space before "{" (block-opening-brace-space-before)
(#151) Expected single space before "{" (block-opening-brace-space-before)
(#105) Expected "#EEE" to be "#eee" (color-hex-case)
(#106) Expected "#BBB" to be "#bbb" (color-hex-case)
(#119) Expected "#EEE" to be "#eee" (color-hex-case)
(#120) Expected "#BBB" to be "#bbb" (color-hex-case)
(#136) Expected no more than 1 declaration (declaration-block-single-line-max-declarations)
(#16) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#33) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#34) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#38) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#50) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#63) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#64) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#69) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#100) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#129) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#133) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#134) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#135) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#136) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#136) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#150) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#151) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#63) Unexpected !important (declaration-no-important)
(#64) Unexpected !important (declaration-no-important)
(#136) Unexpected !important (declaration-no-important)
(#138) Unexpected !important (declaration-no-important)
(#144) Unexpected !important (declaration-no-important)
(#56) Expected indentation of 4 spaces (indentation)
(#150) Expected indentation of 4 spaces (indentation)
(#151) Expected indentation of 4 spaces (indentation)
(#152) Expected indentation of 4 spaces (indentation)
(#156) Expected indentation of 4 spaces (indentation)
(#153) Expected indentation of 8 spaces (indentation)
(#154) Expected indentation of 8 spaces (indentation)
(#155) Expected indentation of 8 spaces (indentation)
(#157) Expected indentation of 4 spaces (indentation)
(#161) Expected indentation of 4 spaces (indentation)
(#158) Expected indentation of 8 spaces (indentation)
(#159) Expected indentation of 8 spaces (indentation)
(#160) Expected indentation of 8 spaces (indentation)
(#173) Expected indentation of 4 spaces (indentation)
(#174) Expected indentation of 4 spaces (indentation)
(#175) Expected indentation of 4 spaces (indentation)
(#176) Expected indentation of 4 spaces (indentation)
(#177) Expected indentation of 4 spaces (indentation)
(#178) Expected indentation of 4 spaces (indentation)

PHPDocs style problems

(71 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

question/type/ddmatch/backup/moodle1/lib.php
(#17) No one-line description found in phpdocs for file
(#30) There is no description in phpdocs for function get_question_subpaths
(#39) Phpdocs for function moodle1_qtype_ddmatch_handler::process_question has incomplete parameters list
question/type/ddmatch/backup/moodle2/backup_qtype_ddmatch_plugin.class.php
(#17) No one-line description found in phpdocs for file
(#78) Inline phpdocs tag {@link get_components_and_fileareas} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
question/type/ddmatch/backup/moodle2/restore_qtype_ddmatch_plugin.class.php
(#183) Function restore_qtype_ddmatch_plugin::recode_response is not documented
(#17) No one-line description found in phpdocs for file
(#27) No one-line description found in phpdocs for class restore_qtype_ddmatch_plugin
(#70) Phpdocs for function restore_qtype_ddmatch_plugin::process_matchoptions has incomplete parameters list
(#116) Phpdocs for function restore_qtype_ddmatch_plugin::process_match has incomplete parameters list
(#193) Phpdocs for function restore_qtype_ddmatch_plugin::recode_legacy_state_answer has incomplete parameters list
(#160) Inline phpdocs tag {@link xml_writer::xml_safe_utf8()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
question/type/ddmatch/db/upgrade.php
(#27) Function xmldb_qtype_ddmatch_upgrade is not documented
question/type/ddmatch/db/upgradelib.php
(#44) Function qtype_ddmatch_qe2_attempt_updater::question_summary is not documented
(#67) Function qtype_ddmatch_qe2_attempt_updater::right_answer is not documented
(#75) Function qtype_ddmatch_qe2_attempt_updater::explode_answer is not documented
(#88) Function qtype_ddmatch_qe2_attempt_updater::make_summary is not documented
(#96) Function qtype_ddmatch_qe2_attempt_updater::lookup_choice is not documented
(#109) Function qtype_ddmatch_qe2_attempt_updater::response_summary is not documented
(#137) Function qtype_ddmatch_qe2_attempt_updater::was_answered is not documented
(#147) Function qtype_ddmatch_qe2_attempt_updater::set_first_step_data_elements is not documented
(#164) Function qtype_ddmatch_qe2_attempt_updater::supply_missing_first_step_data is not documented
(#171) Function qtype_ddmatch_qe2_attempt_updater::set_data_elements_for_step is not documented
(#37) Variable qtype_ddmatch_qe2_attempt_updater::$stems is not documented
(#38) Variable qtype_ddmatch_qe2_attempt_updater::$choices is not documented
(#39) Variable qtype_ddmatch_qe2_attempt_updater::$right is not documented
(#40) Variable qtype_ddmatch_qe2_attempt_updater::$stemorder is not documented
(#41) Variable qtype_ddmatch_qe2_attempt_updater::$choiceorder is not documented
(#42) Variable qtype_ddmatch_qe2_attempt_updater::$flippedchoiceorder is not documented
(#27) No one-line description found in phpdocs for class qtype_ddmatch_qe2_attempt_updater
question/type/ddmatch/edit_ddmatch_form.php
(#36) Function qtype_ddmatch_edit_form::get_per_answer_fields is not documented
(#77) Function qtype_ddmatch_edit_form::data_preprocessing is not documented
(#126) Function qtype_ddmatch_edit_form::validation is not documented
(#160) Function qtype_ddmatch_edit_form::qtype is not documented
question/type/ddmatch/lib.php
(#27) Function qtype_ddmatch_pluginfile is not documented
(#17) File-level phpdocs block does not have @copyright tag
question/type/ddmatch/question.php
(#38) Function qtype_ddmatch_question::get_question_summary is not documented
(#55) Function qtype_ddmatch_question::summarise_response is not documented
(#76) Function qtype_ddmatch_question::check_file_access is not documented
(#96) Function qtype_ddmatch_question::get_field_name is not documented
(#30) No one-line description found in phpdocs for class qtype_ddmatch_question
question/type/ddmatch/questiontype.php
(#39) Function qtype_ddmatch::get_question_options is not documented
(#49) Function qtype_ddmatch::save_question_options is not documented
(#118) Function qtype_ddmatch::initialise_question_instance is not documented
(#145) Function qtype_ddmatch::make_hint is not documented
(#149) Function qtype_ddmatch::delete_question is not documented
(#158) Function qtype_ddmatch::get_random_guess_score is not documented
(#163) Function qtype_ddmatch::get_possible_responses is not documented
(#187) Function qtype_ddmatch::move_files is not documented
(#206) Function qtype_ddmatch::delete_files is not documented
(#225) Phpdocs for function qtype_ddmatch::export_to_xml has incomplete parameters list
(#259) Phpdocs for function qtype_ddmatch::import_from_xml has incomplete parameters list
question/type/ddmatch/renderer.php
(#86) Function qtype_ddmatch_renderer::specific_feedback is not documented
(#90) Function qtype_ddmatch_renderer::correct_response is not documented
(#193) Function qtype_ddmatch_renderer::construct_stem_cell is not documented
(#199) Function qtype_ddmatch_renderer::construct_choice_cell_select is not documented
(#204) Function qtype_ddmatch_renderer::construct_choice_cell_dragdrop is not documented
(#38) Phpdocs for function qtype_ddmatch_renderer::formulation_and_controls has incomplete parameters list
(#71) Phpdocs for function qtype_ddmatch_renderer::format_choices has incomplete parameters list
(#119) Phpdocs for function qtype_ddmatch_renderer::construct_questiontext has incomplete parameters list
(#131) Phpdocs for function qtype_ddmatch_renderer::construct_answerblock has incomplete parameters list
(#247) Phpdocs for function qtype_ddmatch_renderer::construct_available_dragdrop_choices has incomplete parameters list
(#17) File-level phpdocs block does not have @copyright tag
question/type/ddmatch/tests/helper.php
(#36) Function qtype_ddmatch_test_helper::get_test_questions is not documented
question/type/ddmatch/tests/question_test.php
(#20) Package qtype is not valid
question/type/ddmatch/tests/questiontype_test.php
(#52) Function qtype_ddmatch_test::get_test_question_data is not documented
(#20) Package qtype is not valid
question/type/ddmatch/tests/upgradelibnewqe_test.php
(#17) No one-line description found in phpdocs for file
question/type/ddmatch/tests/walkthrough_test.php
(#17) No one-line description found in phpdocs for file
(#21) Package qtype is not valid
question/type/ddmatch/version.php
(#17) No one-line description found in phpdocs for file

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "stylelint:css" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(1 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]

question/type/ddmatch/tests/behat/backup_and_restore.feature
(#28) Wrong indentation for "scenario tag", expected indentation level of 2, but got 0