Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(20 errors, 6 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

question/type/ddimageortext/backup/moodle2/restore_qtype_ddimageortext_plugin.class.php
(#149) Expected 1 space after "="; newline found
question/type/ddimageortext/edit_ddimageortext_form.php
(#251) Expected 1 space after "="; newline found
(#256) Expected 1 space after "="; newline found
(#258) Expected 1 space after "="; newline found
(#260) Expected 1 space after "="; newline found
(#266) Expected 1 space after "="; newline found
question/type/ddimageortext/question.php
(#95) Expected 1 space after "="; newline found
(#98) Expected 1 space after "="; newline found
question/type/ddimageortext/questiontype.php
(#202) Expected 1 space after "="; newline found
(#247) Expected 1 space after "="; newline found
(#250) Expected 1 space after "="; newline found
(#267) Expected 1 space after "="; newline found
(#269) Expected 1 space after "="; newline found
(#271) Expected 1 space after "="; newline found
(#273) Expected 1 space after "="; newline found
question/type/ddimageortext/questiontypebase.php
(#67) This comment is 50% valid code; is this commented out code?
(#128) Expected 1 space after "="; newline found
question/type/ddimageortext/tests/behat/behat_qtype_ddimageortext.php
(#63) Whitespace found at end of line
question/type/ddimageortext/tests/helper.php
(#155) Line exceeds maximum limit of 180 characters; contains 208 characters
(#160) Line exceeds 132 characters; contains 135 characters
(#176) Expected 1 space after "="; newline found
(#200) Expected 1 space after "="; 0 found
(#208) Line exceeds 132 characters; contains 133 characters
(#211) Line exceeds 132 characters; contains 135 characters
(#225) Line exceeds 132 characters; contains 133 characters
(#228) Line exceeds 132 characters; contains 135 characters

Javascript coding style problems

(0 errors, 1 warnings)

This section shows the coding style problems detected in the code by jshint [More info]

question/type/ddimageortext/yui/src/form/js/form.js
(#151) Don't make functions within a loop.

CSS problems

(2 errors, 2 warnings)

This section shows CSS problems detected by csslint [More info]

question/type/ddimageortext/styles.css
(#23) height can't be used with display: inline.
(#24) width can't be used with display: inline.
(#26) Duplicate property '*display' found.
(#82) Duplicate property '*font' found.

PHPDocs style problems

(81 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

question/type/ddimageortext/backup/moodle2/restore_qtype_ddimageortext_plugin.class.php
(#34) Function restore_qtype_ddimageortext_plugin::qtype_name is not documented
(#61) Phpdocs for function restore_qtype_ddimageortext_plugin::process_dds has incomplete parameters list
(#89) Phpdocs for function restore_qtype_ddimageortext_plugin::process_drag has incomplete parameters list
(#115) Phpdocs for function restore_qtype_ddimageortext_plugin::process_drop has incomplete parameters list
question/type/ddimageortext/edit_ddimageortext_form.php
(#39) Function qtype_ddimageortext_edit_form::qtype is not documented
(#43) Function qtype_ddimageortext_edit_form::data_preprocessing is not documented
(#110) Function qtype_ddimageortext_edit_form::js_call is not documented
(#130) Function qtype_ddimageortext_edit_form::definition_draggable_items is not documented
(#142) Function qtype_ddimageortext_edit_form::draggable_item is not documented
(#175) Function qtype_ddimageortext_edit_form::draggable_items_repeated_options is not documented
(#183) Function qtype_ddimageortext_edit_form::drop_zone is not documented
(#210) Function qtype_ddimageortext_edit_form::drop_zones_repeated_options is not documented
(#221) Function qtype_ddimageortext_edit_form::validation is not documented
question/type/ddimageortext/edit_ddtoimage_form_base.php
(#79) Function qtype_ddtoimage_edit_form_base::definition_drop_zones is not documented
(#100) Function qtype_ddtoimage_edit_form_base::drop_zone is not documented
(#102) Function qtype_ddtoimage_edit_form_base::drop_zones_repeated_options is not documented
(#104) Function qtype_ddtoimage_edit_form_base::definition_draggable_items is not documented
(#106) Function qtype_ddtoimage_edit_form_base::draggable_item is not documented
(#108) Function qtype_ddtoimage_edit_form_base::draggable_items_repeated_options is not documented
(#110) Function qtype_ddtoimage_edit_form_base::get_drag_item_repeats is not documented
(#131) Function qtype_ddtoimage_edit_form_base::js_call is not documented
(#133) Function qtype_ddtoimage_edit_form_base::file_uploaded is not documented
(#35) Constant qtype_ddtoimage_edit_form_base::MAX_GROUPS is not documented
(#36) Constant qtype_ddtoimage_edit_form_base::START_NUM_ITEMS is not documented
(#37) Constant qtype_ddtoimage_edit_form_base::ADD_NUM_ITEMS is not documented
(#20) Package qtype is not valid
question/type/ddimageortext/lang/en/qtype_ddimageortext.php
(#17) No one-line description found in phpdocs for file
(#19) Package qtype is not valid
question/type/ddimageortext/lib.php
(#31) Phpdocs for function qtype_ddimageortext_pluginfile has incomplete parameters list
(#21) Package qtype is not valid
question/type/ddimageortext/question.php
(#55) Function qtype_ddimageortext_drag_item::__construct is not documented
(#62) Function qtype_ddimageortext_drag_item::choice_group is not documented
(#66) Function qtype_ddimageortext_drag_item::summarise is not documented
(#86) Function qtype_ddimageortext_drop_zone::__construct is not documented
(#93) Function qtype_ddimageortext_drop_zone::summarise is not documented
(#49) Variable qtype_ddimageortext_drag_item::$id is not documented
(#50) Variable qtype_ddimageortext_drag_item::$text is not documented
(#51) Variable qtype_ddimageortext_drag_item::$no is not documented
(#52) Variable qtype_ddimageortext_drag_item::$group is not documented
(#53) Variable qtype_ddimageortext_drag_item::$infinite is not documented
(#81) Variable qtype_ddimageortext_drop_zone::$no is not documented
(#82) Variable qtype_ddimageortext_drop_zone::$text is not documented
(#83) Variable qtype_ddimageortext_drop_zone::$group is not documented
(#84) Variable qtype_ddimageortext_drop_zone::$xy is not documented
question/type/ddimageortext/questionbase.php
(#38) Function qtype_ddtoimage_question_base::clear_wrong_from_response is not documented
(#48) Function qtype_ddtoimage_question_base::get_right_choice_for is not documented
(#56) Function qtype_ddtoimage_question_base::summarise_response is not documented
(#77) Function qtype_ddtoimage_question_base::check_file_access is not documented
(#103) Function qtype_ddtoimage_question_base::get_validation_error is not documented
(#110) Function qtype_ddtoimage_question_base::classify_response is not documented
(#135) Function qtype_ddtoimage_question_base::get_random_guess_score is not documented
(#151) Function qtype_ddtoimage_question_base::get_question_summary is not documented
question/type/ddimageortext/questiontype.php
(#43) Function qtype_ddimageortext::make_choice is not documented
(#48) Function qtype_ddimageortext::make_place is not documented
(#54) Function qtype_ddimageortext::make_hint is not documented
(#58) Function qtype_ddimageortext::save_question_options is not documented
(#146) Function qtype_ddimageortext::move_files is not documented
(#170) Function qtype_ddimageortext::delete_files is not documented
(#187) Function qtype_ddimageortext::export_to_xml is not documented
(#227) Function qtype_ddimageortext::import_from_xml is not documented
question/type/ddimageortext/questiontypebase.php
(#40) Function qtype_ddtoimage_base::choice_group_key is not documented
(#44) Function qtype_ddtoimage_base::get_question_options is not documented
(#56) Function qtype_ddtoimage_base::initialise_question_instance is not documented
(#100) Function qtype_ddtoimage_base::constrain_image_size_in_draft_area is not documented
(#169) Function qtype_ddtoimage_base::get_possible_responses is not documented
(#188) Function qtype_ddtoimage_base::get_random_guess_score is not documented
(#192) Function qtype_ddtoimage_base::delete_question is not documented
(#148) Phpdocs for function qtype_ddtoimage_base::write_files has incomplete parameters list
question/type/ddimageortext/rendererbase.php
(#36) Function qtype_ddtoimage_renderer_base::clear_wrong is not documented
(#53) Function qtype_ddtoimage_renderer_base::formulation_and_controls is not documented
(#132) Function qtype_ddtoimage_renderer_base::get_url_for_image is not documented
(#157) Function qtype_ddtoimage_renderer_base::hidden_field_for_qt_var is not documented
(#173) Function qtype_ddtoimage_renderer_base::specific_feedback is not documented
(#177) Function qtype_ddtoimage_renderer_base::correct_response is not documented
question/type/ddimageortext/tests/behat/behat_qtype_ddimageortext.php
(#49) Phpdocs for function behat_qtype_ddimageortext::drop_xpath has incomplete parameters list
question/type/ddimageortext/tests/helper.php
(#36) Function qtype_ddimageortext_test_helper::get_test_questions is not documented
(#77) Function qtype_ddimageortext_test_helper::make_choice_structure is not documented
(#89) Function qtype_ddimageortext_test_helper::make_place_structure is not documented
(#40) There is no description in phpdocs for function make_ddimageortext_question_fox
(#97) There is no description in phpdocs for function make_ddimageortext_question_maths
(#132) There is no description in phpdocs for function get_ddimageortext_question_form_data_xsection

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt shifter

shifter problems

(1 errors, 0 warnings)

This section shows problems detected by shifter [More info]

question/type/ddimageortext/yui/src/form/js/form.js
contains 3 lint errors

Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]