Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]


Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(190 errors, 88 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

question/type/combined/backup/moodle2/backup_qtype_combined_plugin.class.php
(#60) Inline phpdocs tag {@link get_components_and_fileareas} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
question/type/combined/backup/moodle2/restore_qtype_combined_plugin.class.php
(#86) Function restore_qtype_combined_plugin::recode_response is not documented
(#21) No one-line description found in phpdocs for class restore_qtype_combined_plugin
(#47) Phpdocs for function restore_qtype_combined_plugin::process_combined has incomplete parameters list
question/type/combined/classes/utils.php
(#28) There is no description in phpdocs for function number_in_style
question/type/combined/combinable/combinablebase.php
(#234) Function qtype_combined_combinable_base::store_control_no is not documented
(#389) Function qtype_combined_combinable_base::delete is not documented
(#438) Function qtype_combined_combinable_base::get_id is not documented
(#533) Constant qtype_combined_combinable_text_entry::THIRD_PARAM_PATTERN is not documented
(#598) Constant qtype_combined_combinable_accepts_vertical_or_horizontal_layout_param::THIRD_PARAM_PATTERN is not documented
(#645) Constant qtype_combined_combinable_accepts_numerical_param::THIRD_PARAM_PATTERN is not documented
(#17) No one-line description found in phpdocs for file
(#38) No one-line description found in phpdocs for class qtype_combined_combinable_base
(#81) There is no description in phpdocs for function __construct
(#99) There is no description in phpdocs for function is_real_subquestion
(#106) There is no description in phpdocs for function form_field_name_prefix
(#114) There is no description in phpdocs for function form_field_name
(#123) There is no description in phpdocs for function step_data_name_prefix
(#130) There is no description in phpdocs for function step_data_name
(#147) There is no description in phpdocs for function add_form_fragment
(#238) There is no description in phpdocs for function get_control_nos
(#245) There is no description in phpdocs for function process_third_param
(#257) There is no description in phpdocs for function validate
(#281) There is no description in phpdocs for function is_in_question_text
(#288) There is no description in phpdocs for function is_in_db
(#295) There is no description in phpdocs for function is_in_form
(#302) There is no description in phpdocs for function get_identifier
(#309) There is no description in phpdocs for function found_in_db
(#316) There is no description in phpdocs for function preserve_submitted_data
(#338) There is no description in phpdocs for function html_field_has_submitted_data
(#347) There is no description in phpdocs for function has_submitted_question_option_data
(#367) There is no description in phpdocs for function submitted_data_array_not_empty
(#393) There is no description in phpdocs for function code_construction_instructions
(#399) There is no description in phpdocs for function message_in_form_if_not_included_in_question_text
(#414) There is no description in phpdocs for function question_text_embed_codes
(#432) There is no description in phpdocs for function get_third_params
(#480) There is no description in phpdocs for function process_third_param
(#494) There is no description in phpdocs for function store_third_param
(#499) There is no description in phpdocs for function error_string_when_third_param_fails_validation
(#535) There is no description in phpdocs for function error_string_when_third_param_fails_validation
(#544) There is no description in phpdocs for function code_construction_instructions
(#552) There is no description in phpdocs for function store_third_param
(#559) There is no description in phpdocs for function get_third_params
(#566) There is no description in phpdocs for function get_width
(#581) There is no description in phpdocs for function get_sup_sub_editor_option
(#600) There is no description in phpdocs for function error_string_when_third_param_fails_validation
(#609) There is no description in phpdocs for function code_construction_instructions
(#617) There is no description in phpdocs for function store_third_param
(#624) There is no description in phpdocs for function get_layout
(#631) There is no description in phpdocs for function get_third_params
(#647) There is no description in phpdocs for function error_string_when_third_param_fails_validation
(#185) Phpdocs for function qtype_combined_combinable_base::data_to_form has incomplete parameters list
(#220) Phpdocs for function qtype_combined_combinable_base::found_in_question_text has incomplete parameters list
(#246) Phpdocs for function qtype_combined_combinable_base::process_third_param has incomplete parameters list
(#310) Phpdocs for function qtype_combined_combinable_base::found_in_db has incomplete parameters list
(#339) Phpdocs for function qtype_combined_combinable_base::html_field_has_submitted_data has incomplete parameters list
(#368) Phpdocs for function qtype_combined_combinable_base::submitted_data_array_not_empty has incomplete parameters list
(#382) Phpdocs for function qtype_combined_combinable_base::save has incomplete parameters list
(#495) Phpdocs for function qtype_combined_combinable_accepts_third_param_validated_with_pattern::store_third_param has incomplete parameters list
(#500) Phpdocs for function qtype_combined_combinable_accepts_third_param_validated_with_pattern::error_string_when_third_param_fails_validation has incomplete parameters list
(#507) Phpdocs for function qtype_combined_combinable_accepts_third_param_validated_with_pattern::validate_third_param has incomplete parameters list
(#536) Phpdocs for function qtype_combined_combinable_text_entry::error_string_when_third_param_fails_validation has incomplete parameters list
(#601) Phpdocs for function qtype_combined_combinable_accepts_vertical_or_horizontal_layout_param::error_string_when_third_param_fails_validation has incomplete parameters list
(#618) Phpdocs for function qtype_combined_combinable_accepts_vertical_or_horizontal_layout_param::store_third_param has incomplete parameters list
(#648) Phpdocs for function qtype_combined_combinable_accepts_numerical_param::error_string_when_third_param_fails_validation has incomplete parameters list
question/type/combined/combinable/combinabletypebase.php
(#234) Function qtype_combined_combinable_type_base::embedded_code_for_default_question_text is not documented
(#17) No one-line description found in phpdocs for class qtype_combined_combinable_type_base
(#45) There is no description in phpdocs for function __construct
(#56) There is no description in phpdocs for function embedded_renderer
(#70) There is no description in phpdocs for function new_subq_instance
(#101) There is no description in phpdocs for function get_identifier
(#108) There is no description in phpdocs for function combined_feedback_properties
(#176) There is no description in phpdocs for function get_qtype_name
(#183) There is no description in phpdocs for function get_qtype_obj
(#190) There is no description in phpdocs for function get_question_options
(#197) There is no description in phpdocs for function delete_question
(#207) There is no description in phpdocs for function save
(#71) Phpdocs for function qtype_combined_combinable_type_base::new_subq_instance has incomplete parameters list
(#155) Phpdocs for function qtype_combined_combinable_type_base::add_question_properties has incomplete parameters list
(#191) Phpdocs for function qtype_combined_combinable_type_base::get_question_options has incomplete parameters list
(#40) Inline phpdocs tag not enclosed with curly brackets @link found
(#40) Inline phpdocs tag not enclosed with curly brackets @link found
question/type/combined/combinable/gapselect/combinable.php
(#28) Class qtype_combined_combinable_type_gapselect is not documented
(#58) Class qtype_combined_combinable_gapselect is not documented
(#32) Function qtype_combined_combinable_type_gapselect::extra_question_properties is not documented
(#36) Function qtype_combined_combinable_type_gapselect::extra_answer_properties is not documented
(#40) Function qtype_combined_combinable_type_gapselect::subq_form_fragment_question_option_fields is not documented
(#44) Function qtype_combined_combinable_type_gapselect::transform_subq_form_data_to_full is not documented
(#53) Function qtype_combined_combinable_type_gapselect::third_param_for_default_question_text is not documented
(#103) Function qtype_combined_combinable_gapselect::data_to_form is not documented
(#114) Function qtype_combined_combinable_gapselect::can_be_more_than_one_of_same_instance is not documented
(#118) Function qtype_combined_combinable_gapselect::validate_third_param is not documented
(#129) Function qtype_combined_combinable_gapselect::validate is not documented
(#155) Function qtype_combined_combinable_gapselect::code_construction_instructions is not documented
(#159) Function qtype_combined_combinable_gapselect::save is not documented
(#168) Function qtype_combined_combinable_gapselect::store_third_param is not documented
(#172) Function qtype_combined_combinable_gapselect::get_third_params is not documented
(#176) Function qtype_combined_combinable_gapselect::has_submitted_data is not documented
(#30) Variable qtype_combined_combinable_type_gapselect::$identifier is not documented
(#65) There is no description in phpdocs for function add_form_fragment
(#66) Phpdocs for function qtype_combined_combinable_gapselect::add_form_fragment has incomplete parameters list
question/type/combined/combinable/gapselect/renderer.php
(#28) Function qtype_combined_gapselect_embedded_renderer::box_id is not documented
(#32) Function qtype_combined_gapselect_embedded_renderer::subquestion is not documented
question/type/combined/combinable/multichoice/combinable.php
(#30) Class qtype_combined_combinable_type_multichoice is not documented
(#72) Class qtype_combined_combinable_multichoice is not documented
(#34) Function qtype_combined_combinable_type_multichoice::extra_question_properties is not documented
(#40) Function qtype_combined_combinable_type_multichoice::extra_answer_properties is not documented
(#44) Function qtype_combined_combinable_type_multichoice::subq_form_fragment_question_option_fields is not documented
(#51) Function qtype_combined_combinable_type_multichoice::transform_subq_form_data_to_full is not documented
(#62) Function qtype_combined_combinable_type_multichoice::third_param_for_default_question_text is not documented
(#66) Function qtype_combined_combinable_type_multichoice::get_clear_wrong_response_value is not documented
(#123) Function qtype_combined_combinable_multichoice::data_to_form is not documented
(#142) Function qtype_combined_combinable_multichoice::validate is not documented
(#180) Function qtype_combined_combinable_multichoice::has_submitted_data is not documented
(#32) Variable qtype_combined_combinable_type_multichoice::$identifier is not documented
(#74) There is no description in phpdocs for function add_form_fragment
(#75) Phpdocs for function qtype_combined_combinable_multichoice::add_form_fragment has incomplete parameters list
question/type/combined/combinable/multichoice/renderer.php
(#29) Class qtype_combined_multichoice_embedded_renderer is not documented
(#32) Function qtype_combined_multichoice_embedded_renderer::subquestion is not documented
question/type/combined/combinable/showworking/combinable.php
(#36) Function qtype_combined_combinable_type_showworking::extra_question_properties is not documented
(#40) Function qtype_combined_combinable_type_showworking::extra_answer_properties is not documented
(#44) Function qtype_combined_combinable_type_showworking::transform_subq_form_data_to_full is not documented
(#48) Function qtype_combined_combinable_type_showworking::third_param_for_default_question_text is not documented
(#52) Function qtype_combined_combinable_type_showworking::save is not documented
(#70) Function qtype_combined_combinable_showworking::is_real_subquestion is not documented
(#74) Function qtype_combined_combinable_showworking::add_form_fragment is not documented
(#77) Function qtype_combined_combinable_showworking::validate is not documented
(#81) Function qtype_combined_combinable_showworking::get_sup_sub_editor_option is not documented
(#85) Function qtype_combined_combinable_showworking::has_submitted_data is not documented
(#89) Function qtype_combined_combinable_showworking::store_third_param is not documented
(#93) Function qtype_combined_combinable_showworking::get_third_params is not documented
(#126) Function qtype_combined_combinable_showworking::validate_third_param is not documented
(#139) Function qtype_combined_combinable_showworking::error_string_when_third_param_fails_validation is not documented
(#145) Function qtype_combined_combinable_showworking::save is not documented
(#148) Function qtype_combined_combinable_showworking::delete is not documented
(#151) Function qtype_combined_combinable_showworking::make is not documented
(#34) Variable qtype_combined_combinable_type_showworking::$identifier is not documented
(#20) Package qtype_showworking is not valid
question/type/combined/combinable/showworking/fake_question.php
(#17) File-level phpdocs block is not found
(#41) Function qtype_combined_showworking_fake_question::__construct is not documented
(#19) No one-line description found in phpdocs for class qtype_combined_showworking_fake_question
(#231) No one-line description found in phpdocs for class qtype_combined_showworking_fake_qtype
(#49) Phpdocs for function qtype_combined_showworking_fake_question::start_attempt has incomplete parameters list
(#58) Phpdocs for function qtype_combined_showworking_fake_question::apply_attempt_state has incomplete parameters list
(#49) Inline phpdocs tag {@link question_attempt} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#130) Inline phpdocs tag {@link grade_response()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#131) Inline phpdocs tag {@link question_classified_response} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#231) Package is not specified for class qtype_combined_showworking_fake_qtype. It is also not specified in file-level phpdocs
(#23) Package qtype_showworking is not valid
question/type/combined/combinable/showworking/renderer.php
(#27) Function qtype_combined_showworking_embedded_renderer::subquestion is not documented
(#20) Package qtype_showworking is not valid
question/type/combined/combiner/base.php
(#56) Constant qtype_combined_combiner_base::EMBEDDED_CODE_POSTFIX is not documented
(#58) Constant qtype_combined_combiner_base::EMBEDDED_CODE_SEPARATOR is not documented
(#37) No one-line description found in phpdocs for class qtype_combined_combiner_base
(#110) There is no description in phpdocs for function find_duplicate_question_identifiers
(#218) There is no description in phpdocs for function load_subq_data_from_db
(#268) There is no description in phpdocs for function create_subqs_from_subq_data
(#279) There is no description in phpdocs for function aggregate_response_arrays
(#355) There is no description in phpdocs for function instantiate_type_class
(#365) There is no description in phpdocs for function is_identifier_known
(#374) There is no description in phpdocs for function new_subq_instance
(#385) There is no description in phpdocs for function translate_qtype_to_qtype_identifier
(#70) Phpdocs for function qtype_combined_combiner_base::find_included_subqs_in_question_text has incomplete parameters list
(#128) Phpdocs for function qtype_combined_combiner_base::make_combinable_instance_from_code_in_question_text has incomplete parameters list
(#175) Phpdocs for function qtype_combined_combiner_base::find_or_create_question_instance has incomplete parameters list
(#205) Phpdocs for function qtype_combined_combiner_base::get_subq_data_from_form_data has incomplete parameters list
(#269) Phpdocs for function qtype_combined_combiner_base::create_subqs_from_subq_data has incomplete parameters list
(#375) Phpdocs for function qtype_combined_type_manager::new_subq_instance has incomplete parameters list
(#386) Phpdocs for function qtype_combined_type_manager::translate_qtype_to_qtype_identifier has incomplete parameters list
(#420) Phpdocs for function qtype_combined_type_manager::response_id has incomplete parameters list
(#174) Inline phpdocs tag not enclosed with curly brackets @see found
question/type/combined/combiner/forform.php
(#107) Phpdocs for function qtype_combined_combiner_for_form::validate_subqs_data_in_form has incomplete parameters list
(#134) Phpdocs for function qtype_combined_combiner_for_form::validate_subqs has incomplete parameters list
(#178) Phpdocs for function qtype_combined_combiner_for_form::data_to_form has incomplete parameters list
question/type/combined/combiner/forquestiontype.php
(#57) Function qtype_combined_combiner_for_question_type::move_subq_files is not documented
(#39) Phpdocs for function qtype_combined_combiner_for_question_type::save_subqs has incomplete parameters list
question/type/combined/combiner/restore.php
(#35) There is no description in phpdocs for function get_subq_responses
(#47) There is no description in phpdocs for function get_subq_type
(#55) There is no description in phpdocs for function get_subq_id
(#48) Phpdocs for function qtype_combined_combiner_for_restore::get_subq_type has incomplete parameters list
(#56) Phpdocs for function qtype_combined_combiner_for_restore::get_subq_id has incomplete parameters list
question/type/combined/combiner/runtime.php
(#17) No one-line description found in phpdocs for file
(#314) No one-line description found in phpdocs for class qtype_combined_param_to_pass_through_to_subq_base
(#333) No one-line description found in phpdocs for class qtype_combined_response_array_param
(#360) No one-line description found in phpdocs for class qtype_combined_array_of_response_arrays_param
(#45) There is no description in phpdocs for function render_subqs
(#124) There is no description in phpdocs for function get_subq_property
(#133) There is no description in phpdocs for function compute_final_grade
(#196) There is no description in phpdocs for function find_subq_with_id
(#209) There is no description in phpdocs for function get_validation_error
(#321) There is no description in phpdocs for function __construct
(#326) There is no description in phpdocs for function for_subq
(#343) There is no description in phpdocs for function __construct
(#350) There is no description in phpdocs for function for_subq
(#370) There is no description in phpdocs for function __construct
(#377) There is no description in phpdocs for function for_subq
(#399) There is no description in phpdocs for function __construct
(#406) There is no description in phpdocs for function for_subq
(#89) Phpdocs for function qtype_combined_combiner_for_run_time_question_instance::call_all_subqs has incomplete parameters list
(#106) Phpdocs for function qtype_combined_combiner_for_run_time_question_instance::call_subq has incomplete parameters list
(#125) Phpdocs for function qtype_combined_combiner_for_run_time_question_instance::get_subq_property has incomplete parameters list
(#134) Phpdocs for function qtype_combined_combiner_for_run_time_question_instance::compute_final_grade has incomplete parameters list
(#162) Phpdocs for function qtype_combined_combiner_for_run_time_question_instance::responses_upto_first_response_identical_to_final_response has incomplete parameters list
(#179) Phpdocs for function qtype_combined_combiner_for_run_time_question_instance::compute_subq_final_grade has incomplete parameters list
(#197) Phpdocs for function qtype_combined_combiner_for_run_time_question_instance::find_subq_with_id has incomplete parameters list
(#210) Phpdocs for function qtype_combined_combiner_for_run_time_question_instance::get_validation_error has incomplete parameters list
(#322) Phpdocs for function qtype_combined_param_to_pass_through_to_subq_base::__construct has incomplete parameters list
(#327) Phpdocs for function qtype_combined_param_to_pass_through_to_subq_base::for_subq has incomplete parameters list
(#351) Phpdocs for function qtype_combined_response_array_param::for_subq has incomplete parameters list
(#371) Phpdocs for function qtype_combined_array_of_response_arrays_param::__construct has incomplete parameters list
(#378) Phpdocs for function qtype_combined_array_of_response_arrays_param::for_subq has incomplete parameters list
(#400) Phpdocs for function qtype_combined_step_param::__construct has incomplete parameters list
(#407) Phpdocs for function qtype_combined_step_param::for_subq has incomplete parameters list
question/type/combined/edit_combined_form.php
(#45) Function qtype_combined_edit_form::__construct is not documented
(#50) Function qtype_combined_edit_form::get_current_question_text is not documented
(#100) Function qtype_combined_edit_form::data_preprocessing is not documented
(#110) Function qtype_combined_edit_form::validation is not documented
(#119) Function qtype_combined_edit_form::qtype is not documented
(#58) There is no description in phpdocs for function definition_inner
question/type/combined/question.php
(#32) Function qtype_combined_question::start_attempt is not documented
(#36) Function qtype_combined_question::apply_attempt_state is not documented
(#40) Function qtype_combined_question::validate_can_regrade_with_other_version is not documented
(#49) Function qtype_combined_question::update_attempt_state_data_for_new_version is not documented
(#57) Function qtype_combined_question::get_expected_data is not documented
(#63) Function qtype_combined_question::get_correct_response is not documented
(#69) Function qtype_combined_question::summarise_response is not documented
(#79) Function qtype_combined_question::is_complete_response is not documented
(#86) Function qtype_combined_question::is_gradable_response is not documented
(#93) Function qtype_combined_question::get_validation_error is not documented
(#97) Function qtype_combined_question::is_same_response is not documented
(#105) Function qtype_combined_question::check_file_access is not documented
(#133) Function qtype_combined_question::grade_response is not documented
(#177) Function qtype_combined_question::compute_final_grade is not documented
(#181) Function qtype_combined_question::get_num_parts_right is not documented
(#198) Function qtype_combined_question::classify_response is not documented
(#152) There is no description in phpdocs for function overall_state
(#153) Phpdocs for function qtype_combined_question::overall_state has incomplete parameters list
question/type/combined/questiontype.php
(#44) Function qtype_combined::move_files is not documented
(#53) Function qtype_combined::delete_files is not documented
(#59) Function qtype_combined::save_question_options is not documented
(#181) Function qtype_combined::make_question is not documented
(#193) Function qtype_combined::make_hint is not documented
(#197) Function qtype_combined::initialise_question_instance is not documented
(#202) Function qtype_combined::get_question_options is not documented
(#212) Function qtype_combined::get_random_guess_score is not documented
(#221) Function qtype_combined::get_possible_responses is not documented
(#237) Function qtype_combined::export_to_xml is not documented
(#248) Function qtype_combined::import_from_xml is not documented
(#99) Phpdocs for function qtype_combined::save_imported_subquestion has incomplete parameters list
question/type/combined/renderer.php
(#156) Class qtype_combined_text_entry_renderer_base is not documented
(#38) Function qtype_combined_renderer::formulation_and_controls is not documented
(#57) Function qtype_combined_renderer::specific_feedback is not documented
(#61) Function qtype_combined_renderer::feedback is not documented
(#95) Function qtype_combined_renderer::feedback_for_suqs_not_graded_correct is not documented
(#113) Function qtype_combined_renderer::num_parts_correct is not documented
(#125) Function qtype_combined_renderer::clear_wrong is not documented
(#150) Function qtype_combined_subquestion_renderer_interface::subquestion is not documented
(#159) There is no description in phpdocs for function subquestion
(#160) Phpdocs for function qtype_combined_text_entry_renderer_base::subquestion has incomplete parameters list
question/type/combined/tests/form_test.php
(#223) Inline phpdocs tag {@link test_validate_question_text()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
question/type/combined/tests/helper.php
(#26) Function qtype_combined_test_helper::get_test_questions is not documented
(#271) There is no description in phpdocs for function safe_include_test_helpers
(#292) There is no description in phpdocs for function make_a_gapselect_question
(#307) There is no description in phpdocs for function make_a_combined_question_with_gapselect_subquestion
(#337) There is no description in phpdocs for function make_oumultiresponse_question_two_of_four
(#350) There is no description in phpdocs for function make_multichoice_question_one_of_four
(#361) There is no description in phpdocs for function make_a_combined_question_with_oumr_subquestion
(#391) There is no description in phpdocs for function make_a_combined_question_with_multichoice_subquestion
(#421) There is no description in phpdocs for function make_a_combined_question_with_oumr_and_gapselect_subquestion
(#459) There is no description in phpdocs for function make_a_combined_question_with_oumr_and_showworking_subquestion
(#495) There is no description in phpdocs for function make_a_pmatch_question
(#507) There is no description in phpdocs for function make_a_combined_question_with_oumr_pmatch_and_gapselect_subquestion
(#553) There is no description in phpdocs for function make_a_varnumericset_question
(#576) There is no description in phpdocs for function make_a_combined_question_with_oumr_pmatch_varnum_and_gapselect_subquestion
(#272) Phpdocs for function qtype_combined_test_helper::safe_include_test_helpers has incomplete parameters list
question/type/combined/tests/walkthrough_test.php
(#520) Function walkthrough_test::get_contains_num_parts_correct is not documented
(#1018) Function walkthrough_test::get_contains_text_expectation is not documented
(#1672) Function walkthrough_test::get_contains_subq_mc_radio_expectation is not documented

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]