Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(0 errors, 1 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

question/type/combined/tests/helper.php
(#52) Since PHP 7.0, functions inspecting arguments, like func_get_args(), no longer report the original value as passed to a parameter, but will instead provide the current value. The parameter "$qtypes" was used, and possibly changed (by reference), on line 44.

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(242 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

question/type/combined/backup/moodle2/backup_qtype_combined_plugin.class.php
(#17) No one-line description found in phpdocs for file
(#69) Inline phpdocs tag {@link get_components_and_fileareas} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
question/type/combined/backup/moodle2/restore_qtype_combined_plugin.class.php
(#92) Function restore_qtype_combined_plugin::recode_response is not documented
(#17) No one-line description found in phpdocs for file
(#28) No one-line description found in phpdocs for class restore_qtype_combined_plugin
(#53) Phpdocs for function restore_qtype_combined_plugin::process_combined has incomplete parameters list
question/type/combined/classes/utils.php
(#37) There is no description in phpdocs for function number_in_style
question/type/combined/combinable/combinablebase.php
(#228) Function qtype_combined_combinable_base::store_control_no is not documented
(#383) Function qtype_combined_combinable_base::delete is not documented
(#432) Function qtype_combined_combinable_base::get_id is not documented
(#527) Constant qtype_combined_combinable_text_entry::THIRD_PARAM_PATTERN is not documented
(#592) Constant qtype_combined_combinable_accepts_vertical_or_horizontal_layout_param::THIRD_PARAM_PATTERN is not documented
(#639) Constant qtype_combined_combinable_accepts_numerical_param::THIRD_PARAM_PATTERN is not documented
(#17) No one-line description found in phpdocs for file
(#38) No one-line description found in phpdocs for class qtype_combined_combinable_base
(#82) There is no description in phpdocs for function __construct
(#100) There is no description in phpdocs for function form_field_name_prefix
(#108) There is no description in phpdocs for function form_field_name
(#117) There is no description in phpdocs for function step_data_name_prefix
(#124) There is no description in phpdocs for function step_data_name
(#141) There is no description in phpdocs for function add_form_fragment
(#232) There is no description in phpdocs for function get_control_nos
(#239) There is no description in phpdocs for function process_third_param
(#251) There is no description in phpdocs for function validate
(#275) There is no description in phpdocs for function is_in_question_text
(#282) There is no description in phpdocs for function is_in_db
(#289) There is no description in phpdocs for function is_in_form
(#296) There is no description in phpdocs for function get_identifier
(#303) There is no description in phpdocs for function found_in_db
(#310) There is no description in phpdocs for function preserve_submitted_data
(#332) There is no description in phpdocs for function html_field_has_submitted_data
(#341) There is no description in phpdocs for function has_submitted_question_option_data
(#361) There is no description in phpdocs for function submitted_data_array_not_empty
(#387) There is no description in phpdocs for function code_construction_instructions
(#393) There is no description in phpdocs for function message_in_form_if_not_included_in_question_text
(#408) There is no description in phpdocs for function question_text_embed_codes
(#426) There is no description in phpdocs for function get_third_params
(#474) There is no description in phpdocs for function process_third_param
(#488) There is no description in phpdocs for function store_third_param
(#493) There is no description in phpdocs for function error_string_when_third_param_fails_validation
(#529) There is no description in phpdocs for function error_string_when_third_param_fails_validation
(#538) There is no description in phpdocs for function code_construction_instructions
(#546) There is no description in phpdocs for function store_third_param
(#553) There is no description in phpdocs for function get_third_params
(#560) There is no description in phpdocs for function get_width
(#575) There is no description in phpdocs for function get_sup_sub_editor_option
(#594) There is no description in phpdocs for function error_string_when_third_param_fails_validation
(#603) There is no description in phpdocs for function code_construction_instructions
(#611) There is no description in phpdocs for function store_third_param
(#618) There is no description in phpdocs for function get_layout
(#625) There is no description in phpdocs for function get_third_params
(#641) There is no description in phpdocs for function error_string_when_third_param_fails_validation
(#179) Phpdocs for function qtype_combined_combinable_base::data_to_form has incomplete parameters list
(#214) Phpdocs for function qtype_combined_combinable_base::found_in_question_text has incomplete parameters list
(#240) Phpdocs for function qtype_combined_combinable_base::process_third_param has incomplete parameters list
(#304) Phpdocs for function qtype_combined_combinable_base::found_in_db has incomplete parameters list
(#333) Phpdocs for function qtype_combined_combinable_base::html_field_has_submitted_data has incomplete parameters list
(#362) Phpdocs for function qtype_combined_combinable_base::submitted_data_array_not_empty has incomplete parameters list
(#376) Phpdocs for function qtype_combined_combinable_base::save has incomplete parameters list
(#489) Phpdocs for function qtype_combined_combinable_accepts_third_param_validated_with_pattern::store_third_param has incomplete parameters list
(#494) Phpdocs for function qtype_combined_combinable_accepts_third_param_validated_with_pattern::error_string_when_third_param_fails_validation has incomplete parameters list
(#501) Phpdocs for function qtype_combined_combinable_accepts_third_param_validated_with_pattern::validate_third_param has incomplete parameters list
(#530) Phpdocs for function qtype_combined_combinable_text_entry::error_string_when_third_param_fails_validation has incomplete parameters list
(#595) Phpdocs for function qtype_combined_combinable_accepts_vertical_or_horizontal_layout_param::error_string_when_third_param_fails_validation has incomplete parameters list
(#612) Phpdocs for function qtype_combined_combinable_accepts_vertical_or_horizontal_layout_param::store_third_param has incomplete parameters list
(#642) Phpdocs for function qtype_combined_combinable_accepts_numerical_param::error_string_when_third_param_fails_validation has incomplete parameters list
question/type/combined/combinable/combinabletypebase.php
(#240) Function qtype_combined_combinable_type_base::embedded_code_for_default_question_text is not documented
(#17) No one-line description found in phpdocs for file
(#30) No one-line description found in phpdocs for class qtype_combined_combinable_type_base
(#53) There is no description in phpdocs for function __construct
(#64) There is no description in phpdocs for function embedded_renderer
(#78) There is no description in phpdocs for function new_subq_instance
(#109) There is no description in phpdocs for function get_identifier
(#116) There is no description in phpdocs for function combined_feedback_properties
(#184) There is no description in phpdocs for function get_qtype_name
(#191) There is no description in phpdocs for function get_qtype_obj
(#198) There is no description in phpdocs for function get_question_options
(#205) There is no description in phpdocs for function delete_question
(#215) There is no description in phpdocs for function save
(#79) Phpdocs for function qtype_combined_combinable_type_base::new_subq_instance has incomplete parameters list
(#163) Phpdocs for function qtype_combined_combinable_type_base::add_question_properties has incomplete parameters list
(#199) Phpdocs for function qtype_combined_combinable_type_base::get_question_options has incomplete parameters list
(#48) Inline phpdocs tag not enclosed with curly brackets @link found
(#48) Inline phpdocs tag not enclosed with curly brackets @link found
question/type/combined/combinable/gapselect/combinable.php
(#28) Class qtype_combined_combinable_type_gapselect is not documented
(#58) Class qtype_combined_combinable_gapselect is not documented
(#32) Function qtype_combined_combinable_type_gapselect::extra_question_properties is not documented
(#36) Function qtype_combined_combinable_type_gapselect::extra_answer_properties is not documented
(#40) Function qtype_combined_combinable_type_gapselect::subq_form_fragment_question_option_fields is not documented
(#44) Function qtype_combined_combinable_type_gapselect::transform_subq_form_data_to_full is not documented
(#53) Function qtype_combined_combinable_type_gapselect::third_param_for_default_question_text is not documented
(#103) Function qtype_combined_combinable_gapselect::data_to_form is not documented
(#114) Function qtype_combined_combinable_gapselect::can_be_more_than_one_of_same_instance is not documented
(#118) Function qtype_combined_combinable_gapselect::validate_third_param is not documented
(#129) Function qtype_combined_combinable_gapselect::validate is not documented
(#155) Function qtype_combined_combinable_gapselect::code_construction_instructions is not documented
(#159) Function qtype_combined_combinable_gapselect::save is not documented
(#168) Function qtype_combined_combinable_gapselect::store_third_param is not documented
(#172) Function qtype_combined_combinable_gapselect::get_third_params is not documented
(#176) Function qtype_combined_combinable_gapselect::has_submitted_data is not documented
(#30) Variable qtype_combined_combinable_type_gapselect::$identifier is not documented
(#65) There is no description in phpdocs for function add_form_fragment
(#66) Phpdocs for function qtype_combined_combinable_gapselect::add_form_fragment has incomplete parameters list
question/type/combined/combinable/gapselect/renderer.php
(#30) Class qtype_combined_gapselect_embedded_renderer is not documented
(#33) Function qtype_combined_gapselect_embedded_renderer::box_id is not documented
(#37) Function qtype_combined_gapselect_embedded_renderer::subquestion is not documented
question/type/combined/combinable/multichoice/combinable.php
(#30) Class qtype_combined_combinable_type_multichoice is not documented
(#67) Class qtype_combined_combinable_multichoice is not documented
(#34) Function qtype_combined_combinable_type_multichoice::extra_question_properties is not documented
(#40) Function qtype_combined_combinable_type_multichoice::extra_answer_properties is not documented
(#44) Function qtype_combined_combinable_type_multichoice::subq_form_fragment_question_option_fields is not documented
(#51) Function qtype_combined_combinable_type_multichoice::transform_subq_form_data_to_full is not documented
(#62) Function qtype_combined_combinable_type_multichoice::third_param_for_default_question_text is not documented
(#118) Function qtype_combined_combinable_multichoice::data_to_form is not documented
(#137) Function qtype_combined_combinable_multichoice::validate is not documented
(#175) Function qtype_combined_combinable_multichoice::has_submitted_data is not documented
(#32) Variable qtype_combined_combinable_type_multichoice::$identifier is not documented
(#69) There is no description in phpdocs for function add_form_fragment
(#70) Phpdocs for function qtype_combined_combinable_multichoice::add_form_fragment has incomplete parameters list
question/type/combined/combinable/multichoice/renderer.php
(#29) Class qtype_combined_multichoice_embedded_renderer is not documented
(#32) Function qtype_combined_multichoice_embedded_renderer::subquestion is not documented
question/type/combined/combiner/base.php
(#55) Constant qtype_combined_combiner_base::EMBEDDED_CODE_POSTFIX is not documented
(#57) Constant qtype_combined_combiner_base::EMBEDDED_CODE_SEPARATOR is not documented
(#35) No one-line description found in phpdocs for class qtype_combined_combiner_base
(#101) There is no description in phpdocs for function find_duplicate_question_identifiers
(#209) There is no description in phpdocs for function load_subq_data_from_db
(#242) There is no description in phpdocs for function create_subqs_from_subq_data
(#253) There is no description in phpdocs for function aggregate_response_arrays
(#331) There is no description in phpdocs for function instantiate_type_class
(#341) There is no description in phpdocs for function is_identifier_known
(#350) There is no description in phpdocs for function new_subq_instance
(#361) There is no description in phpdocs for function translate_qtype_to_qtype_identifier
(#70) Phpdocs for function qtype_combined_combiner_base::find_included_subqs_in_question_text has incomplete parameters list
(#119) Phpdocs for function qtype_combined_combiner_base::make_combinable_instance_from_code_in_question_text has incomplete parameters list
(#166) Phpdocs for function qtype_combined_combiner_base::find_or_create_question_instance has incomplete parameters list
(#196) Phpdocs for function qtype_combined_combiner_base::get_subq_data_from_form_data has incomplete parameters list
(#243) Phpdocs for function qtype_combined_combiner_base::create_subqs_from_subq_data has incomplete parameters list
(#351) Phpdocs for function qtype_combined_type_manager::new_subq_instance has incomplete parameters list
(#362) Phpdocs for function qtype_combined_type_manager::translate_qtype_to_qtype_identifier has incomplete parameters list
(#399) Phpdocs for function qtype_combined_type_manager::response_id has incomplete parameters list
(#165) Inline phpdocs tag not enclosed with curly brackets @see found
question/type/combined/combiner/forform.php
(#101) Phpdocs for function qtype_combined_combiner_for_form::validate_subqs_data_in_form has incomplete parameters list
(#128) Phpdocs for function qtype_combined_combiner_for_form::validate_subqs has incomplete parameters list
(#169) Phpdocs for function qtype_combined_combiner_for_form::data_to_form has incomplete parameters list
question/type/combined/combiner/forquestiontype.php
(#57) Function qtype_combined_combiner_for_question_type::move_subq_files is not documented
(#39) Phpdocs for function qtype_combined_combiner_for_question_type::save_subqs has incomplete parameters list
question/type/combined/combiner/restore.php
(#35) There is no description in phpdocs for function get_subq_responses
(#47) There is no description in phpdocs for function get_subq_type
(#55) There is no description in phpdocs for function get_subq_id
(#48) Phpdocs for function qtype_combined_combiner_for_restore::get_subq_type has incomplete parameters list
(#56) Phpdocs for function qtype_combined_combiner_for_restore::get_subq_id has incomplete parameters list
question/type/combined/combiner/runtime.php
(#17) No one-line description found in phpdocs for file
(#244) No one-line description found in phpdocs for class qtype_combined_param_to_pass_through_to_subq_base
(#263) No one-line description found in phpdocs for class qtype_combined_response_array_param
(#290) No one-line description found in phpdocs for class qtype_combined_array_of_response_arrays_param
(#45) There is no description in phpdocs for function render_subqs
(#124) There is no description in phpdocs for function get_subq_property
(#133) There is no description in phpdocs for function compute_final_grade
(#196) There is no description in phpdocs for function find_subq_with_id
(#210) There is no description in phpdocs for function get_validation_error
(#251) There is no description in phpdocs for function __construct
(#256) There is no description in phpdocs for function for_subq
(#273) There is no description in phpdocs for function __construct
(#280) There is no description in phpdocs for function for_subq
(#300) There is no description in phpdocs for function __construct
(#307) There is no description in phpdocs for function for_subq
(#329) There is no description in phpdocs for function __construct
(#336) There is no description in phpdocs for function for_subq
(#89) Phpdocs for function qtype_combined_combiner_for_run_time_question_instance::call_all_subqs has incomplete parameters list
(#106) Phpdocs for function qtype_combined_combiner_for_run_time_question_instance::call_subq has incomplete parameters list
(#125) Phpdocs for function qtype_combined_combiner_for_run_time_question_instance::get_subq_property has incomplete parameters list
(#134) Phpdocs for function qtype_combined_combiner_for_run_time_question_instance::compute_final_grade has incomplete parameters list
(#162) Phpdocs for function qtype_combined_combiner_for_run_time_question_instance::responses_upto_first_response_identical_to_final_response has incomplete parameters list
(#179) Phpdocs for function qtype_combined_combiner_for_run_time_question_instance::compute_subq_final_grade has incomplete parameters list
(#197) Phpdocs for function qtype_combined_combiner_for_run_time_question_instance::find_subq_with_id has incomplete parameters list
(#211) Phpdocs for function qtype_combined_combiner_for_run_time_question_instance::get_validation_error has incomplete parameters list
(#252) Phpdocs for function qtype_combined_param_to_pass_through_to_subq_base::__construct has incomplete parameters list
(#257) Phpdocs for function qtype_combined_param_to_pass_through_to_subq_base::for_subq has incomplete parameters list
(#281) Phpdocs for function qtype_combined_response_array_param::for_subq has incomplete parameters list
(#301) Phpdocs for function qtype_combined_array_of_response_arrays_param::__construct has incomplete parameters list
(#308) Phpdocs for function qtype_combined_array_of_response_arrays_param::for_subq has incomplete parameters list
(#330) Phpdocs for function qtype_combined_step_param::__construct has incomplete parameters list
(#337) Phpdocs for function qtype_combined_step_param::for_subq has incomplete parameters list
question/type/combined/edit_combined_form.php
(#45) Function qtype_combined_edit_form::__construct is not documented
(#50) Function qtype_combined_edit_form::get_current_question_text is not documented
(#58) Function qtype_combined_edit_form::definition_inner is not documented
(#83) Function qtype_combined_edit_form::data_preprocessing is not documented
(#93) Function qtype_combined_edit_form::validation is not documented
(#102) Function qtype_combined_edit_form::qtype is not documented
question/type/combined/question.php
(#44) Function qtype_combined_question::start_attempt is not documented
(#48) Function qtype_combined_question::apply_attempt_state is not documented
(#52) Function qtype_combined_question::get_expected_data is not documented
(#58) Function qtype_combined_question::get_correct_response is not documented
(#64) Function qtype_combined_question::summarise_response is not documented
(#74) Function qtype_combined_question::is_complete_response is not documented
(#81) Function qtype_combined_question::is_gradable_response is not documented
(#88) Function qtype_combined_question::get_validation_error is not documented
(#92) Function qtype_combined_question::is_same_response is not documented
(#101) Function qtype_combined_question::check_file_access is not documented
(#129) Function qtype_combined_question::grade_response is not documented
(#170) Function qtype_combined_question::compute_final_grade is not documented
(#174) Function qtype_combined_question::get_num_parts_right is not documented
(#192) Function qtype_combined_question::classify_response is not documented
(#148) There is no description in phpdocs for function overall_state
(#149) Phpdocs for function qtype_combined_question::overall_state has incomplete parameters list
question/type/combined/questiontype.php
(#44) Function qtype_combined::move_files is not documented
(#53) Function qtype_combined::delete_files is not documented
(#59) Function qtype_combined::save_question_options is not documented
(#163) Function qtype_combined::make_question is not documented
(#175) Function qtype_combined::make_hint is not documented
(#179) Function qtype_combined::initialise_question_instance is not documented
(#184) Function qtype_combined::get_question_options is not documented
(#194) Function qtype_combined::get_random_guess_score is not documented
(#203) Function qtype_combined::get_possible_responses is not documented
(#219) Function qtype_combined::export_to_xml is not documented
(#230) Function qtype_combined::import_from_xml is not documented
(#94) Phpdocs for function qtype_combined::save_imported_question has incomplete parameters list
question/type/combined/renderer.php
(#140) Class qtype_combined_text_entry_renderer_base is not documented
(#38) Function qtype_combined_renderer::formulation_and_controls is not documented
(#57) Function qtype_combined_renderer::specific_feedback is not documented
(#61) Function qtype_combined_renderer::feedback is not documented
(#95) Function qtype_combined_renderer::feedback_for_suqs_not_graded_correct is not documented
(#113) Function qtype_combined_renderer::num_parts_correct is not documented
(#134) Function subquestion is not documented
(#143) There is no description in phpdocs for function subquestion
(#144) Phpdocs for function qtype_combined_text_entry_renderer_base::subquestion has incomplete parameters list
question/type/combined/tests/helper.php
(#37) There is no description in phpdocs for function safe_include_test_helpers
(#58) There is no description in phpdocs for function make_a_gapselect_question
(#77) There is no description in phpdocs for function make_a_combined_question_with_gapselect_subquestion
(#107) There is no description in phpdocs for function make_oumultiresponse_question_two_of_four
(#118) There is no description in phpdocs for function make_multichoice_question_one_of_four
(#129) There is no description in phpdocs for function make_a_combined_question_with_oumr_subquestion
(#159) There is no description in phpdocs for function make_a_combined_question_with_multichoice_subquestion
(#189) There is no description in phpdocs for function make_a_combined_question_with_oumr_and_gapselect_subquestion
(#227) There is no description in phpdocs for function make_a_pmatch_question
(#239) There is no description in phpdocs for function make_a_combined_question_with_oumr_pmatch_and_gapselect_subquestion
(#285) There is no description in phpdocs for function make_a_varnumericset_question
(#308) There is no description in phpdocs for function make_a_combined_question_with_oumr_pmatch_varnum_and_gapselect_subquestion
(#38) Phpdocs for function qtype_combined_test_helper::safe_include_test_helpers has incomplete parameters list
question/type/combined/tests/walkthrough_test.php
(#478) Function qtype_combined_walkthrough_test::get_contains_num_parts_correct is not documented
(#967) Function qtype_combined_walkthrough_test::get_contains_text_expectation is not documented
(#1601) Function qtype_combined_walkthrough_test::get_contains_subq_mc_radio_expectation is not documented

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]