Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(25 errors, 6 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

question/type/combined/backup/moodle2/restore_qtype_combined_plugin.class.php
(#102) Expected 1 space after "="; newline found
question/type/combined/combinable/combinablebase.php
(#39) Expected MOODLE_INTERNAL check or config.php inclusion
(#169) Expected 1 space after "=>"; 2 found
(#181) Expected 1 space after "="; 0 found
question/type/combined/combinable/combinabletypebase.php
(#31) Expected MOODLE_INTERNAL check or config.php inclusion
question/type/combined/combiner/base.php
(#30) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#122) Expected 1 space after "="; newline found
(#269) Expected 1 space before "="; 0 found
question/type/combined/combiner/forform.php
(#26) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#61) Expected 1 space before "/"; 0 found
(#61) Expected 1 space after "/"; 0 found
(#72) Expected 1 space after "="; 0 found
(#159) Expected 1 space after "=>"; newline found
question/type/combined/combiner/forquestiontype.php
(#26) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
question/type/combined/combiner/restore.php
(#26) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
question/type/combined/combiner/runtime.php
(#27) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#91) This comment is 67% valid code; is this commented out code?
(#109) This comment is 67% valid code; is this commented out code?
(#145) Expected 1 space after "="; newline found
(#169) Expected 1 space before "+"; 0 found
(#169) Expected 1 space after "+"; 0 found
question/type/combined/question.php
(#131) Expected 1 space after "="; newline found
(#137) Expected 1 space after "="; newline found
(#183) Expected 1 space before "?"; 0 found
(#183) Expected 1 space after "?"; 0 found
(#183) Expected 1 space before ":"; 0 found
(#183) Expected 1 space after ":"; 0 found
question/type/combined/renderer.php
(#191) Expected 1 space before "=>"; 0 found
(#191) Expected 1 space after "=>"; 0 found
question/type/combined/tests/behat/behat_qtype_combined.php
(#44) Line exceeds 132 characters; contains 143 characters
question/type/combined/tests/helper.php
(#41) This comment is 100% valid code; is this commented out code?

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by jshint [More info]


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by csslint [More info]


PHPDocs style problems

(235 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

question/type/combined/backup/moodle2/backup_qtype_combined_plugin.class.php
(#17) No one-line description found in phpdocs for file
question/type/combined/backup/moodle2/restore_qtype_combined_plugin.class.php
(#92) Function restore_qtype_combined_plugin::recode_response is not documented
(#17) No one-line description found in phpdocs for file
(#28) No one-line description found in phpdocs for class restore_qtype_combined_plugin
(#53) Phpdocs for function restore_qtype_combined_plugin::process_combined has incomplete parameters list
question/type/combined/combinable/combinablebase.php
(#221) Function qtype_combined_combinable_base::store_control_no is not documented
(#376) Function qtype_combined_combinable_base::delete is not documented
(#425) Function qtype_combined_combinable_base::get_id is not documented
(#492) Constant qtype_combined_combinable_text_entry::THIRD_PARAM_PATTERN is not documented
(#557) Constant qtype_combined_combinable_accepts_vertical_or_horizontal_layout_param::THIRD_PARAM_PATTERN is not documented
(#604) Constant qtype_combined_combinable_accepts_numerical_param::THIRD_PARAM_PATTERN is not documented
(#17) No one-line description found in phpdocs for file
(#35) No one-line description found in phpdocs for class qtype_combined_combinable_base
(#79) There is no description in phpdocs for function __construct
(#97) There is no description in phpdocs for function form_field_name_prefix
(#105) There is no description in phpdocs for function form_field_name
(#114) There is no description in phpdocs for function step_data_name_prefix
(#121) There is no description in phpdocs for function step_data_name
(#138) There is no description in phpdocs for function add_form_fragment
(#225) There is no description in phpdocs for function get_control_nos
(#232) There is no description in phpdocs for function process_third_param
(#244) There is no description in phpdocs for function validate
(#268) There is no description in phpdocs for function is_in_question_text
(#275) There is no description in phpdocs for function is_in_db
(#282) There is no description in phpdocs for function is_in_form
(#289) There is no description in phpdocs for function get_identifier
(#296) There is no description in phpdocs for function found_in_db
(#303) There is no description in phpdocs for function preserve_submitted_data
(#325) There is no description in phpdocs for function html_field_has_submitted_data
(#334) There is no description in phpdocs for function has_submitted_question_option_data
(#354) There is no description in phpdocs for function submitted_data_array_not_empty
(#380) There is no description in phpdocs for function code_construction_instructions
(#386) There is no description in phpdocs for function message_in_form_if_not_included_in_question_text
(#401) There is no description in phpdocs for function question_text_embed_codes
(#419) There is no description in phpdocs for function get_third_params
(#439) There is no description in phpdocs for function process_third_param
(#453) There is no description in phpdocs for function store_third_param
(#458) There is no description in phpdocs for function error_string_when_third_param_fails_validation
(#494) There is no description in phpdocs for function error_string_when_third_param_fails_validation
(#503) There is no description in phpdocs for function code_construction_instructions
(#511) There is no description in phpdocs for function store_third_param
(#518) There is no description in phpdocs for function get_third_params
(#525) There is no description in phpdocs for function get_width
(#540) There is no description in phpdocs for function get_sup_sub_editor_option
(#559) There is no description in phpdocs for function error_string_when_third_param_fails_validation
(#568) There is no description in phpdocs for function code_construction_instructions
(#576) There is no description in phpdocs for function store_third_param
(#583) There is no description in phpdocs for function get_layout
(#590) There is no description in phpdocs for function get_third_params
(#606) There is no description in phpdocs for function error_string_when_third_param_fails_validation
(#176) Phpdocs for function qtype_combined_combinable_base::data_to_form has incomplete parameters list
(#207) Phpdocs for function qtype_combined_combinable_base::found_in_question_text has incomplete parameters list
(#233) Phpdocs for function qtype_combined_combinable_base::process_third_param has incomplete parameters list
(#297) Phpdocs for function qtype_combined_combinable_base::found_in_db has incomplete parameters list
(#326) Phpdocs for function qtype_combined_combinable_base::html_field_has_submitted_data has incomplete parameters list
(#355) Phpdocs for function qtype_combined_combinable_base::submitted_data_array_not_empty has incomplete parameters list
(#369) Phpdocs for function qtype_combined_combinable_base::save has incomplete parameters list
(#454) Phpdocs for function qtype_combined_combinable_accepts_third_param_validated_with_pattern::store_third_param has incomplete parameters list
(#459) Phpdocs for function qtype_combined_combinable_accepts_third_param_validated_with_pattern::error_string_when_third_param_fails_validation has incomplete parameters list
(#466) Phpdocs for function qtype_combined_combinable_accepts_third_param_validated_with_pattern::validate_third_param has incomplete parameters list
(#495) Phpdocs for function qtype_combined_combinable_text_entry::error_string_when_third_param_fails_validation has incomplete parameters list
(#560) Phpdocs for function qtype_combined_combinable_accepts_vertical_or_horizontal_layout_param::error_string_when_third_param_fails_validation has incomplete parameters list
(#577) Phpdocs for function qtype_combined_combinable_accepts_vertical_or_horizontal_layout_param::store_third_param has incomplete parameters list
(#607) Phpdocs for function qtype_combined_combinable_accepts_numerical_param::error_string_when_third_param_fails_validation has incomplete parameters list
(#35) Class qtype_combined_combinable_base does not have @copyright tag
(#430) Class qtype_combined_combinable_accepts_third_param_validated_with_pattern does not have @copyright tag
(#481) Class qtype_combined_combinable_text_entry does not have @copyright tag
(#546) Class qtype_combined_combinable_accepts_vertical_or_horizontal_layout_param does not have @copyright tag
(#598) Class qtype_combined_combinable_accepts_numerical_param does not have @copyright tag
(#35) Class qtype_combined_combinable_base does not have @license tag
(#430) Class qtype_combined_combinable_accepts_third_param_validated_with_pattern does not have @license tag
(#481) Class qtype_combined_combinable_text_entry does not have @license tag
(#546) Class qtype_combined_combinable_accepts_vertical_or_horizontal_layout_param does not have @license tag
(#598) Class qtype_combined_combinable_accepts_numerical_param does not have @license tag
question/type/combined/combinable/combinabletypebase.php
(#237) Function qtype_combined_combinable_type_base::embedded_code_for_default_question_text is not documented
(#17) No one-line description found in phpdocs for file
(#27) No one-line description found in phpdocs for class qtype_combined_combinable_type_base
(#50) There is no description in phpdocs for function __construct
(#61) There is no description in phpdocs for function embedded_renderer
(#75) There is no description in phpdocs for function new_subq_instance
(#106) There is no description in phpdocs for function get_identifier
(#113) There is no description in phpdocs for function combined_feedback_properties
(#181) There is no description in phpdocs for function get_qtype_name
(#188) There is no description in phpdocs for function get_qtype_obj
(#195) There is no description in phpdocs for function get_question_options
(#202) There is no description in phpdocs for function delete_question
(#212) There is no description in phpdocs for function save
(#76) Phpdocs for function qtype_combined_combinable_type_base::new_subq_instance has incomplete parameters list
(#160) Phpdocs for function qtype_combined_combinable_type_base::add_question_properties has incomplete parameters list
(#196) Phpdocs for function qtype_combined_combinable_type_base::get_question_options has incomplete parameters list
(#27) Class qtype_combined_combinable_type_base does not have @copyright tag
(#27) Class qtype_combined_combinable_type_base does not have @license tag
(#45) Inline phpdocs tag not enclosed with curly brackets @link found
(#45) Inline phpdocs tag not enclosed with curly brackets @link found
question/type/combined/combiner/base.php
(#53) Constant qtype_combined_combiner_base::EMBEDDED_CODE_POSTFIX is not documented
(#55) Constant qtype_combined_combiner_base::EMBEDDED_CODE_SEPARATOR is not documented
(#33) No one-line description found in phpdocs for class qtype_combined_combiner_base
(#99) There is no description in phpdocs for function find_duplicate_question_identifiers
(#203) There is no description in phpdocs for function load_subq_data_from_db
(#236) There is no description in phpdocs for function create_subqs_from_subq_data
(#247) There is no description in phpdocs for function aggregate_response_arrays
(#322) There is no description in phpdocs for function instantiate_type_class
(#332) There is no description in phpdocs for function is_identifier_known
(#341) There is no description in phpdocs for function new_subq_instance
(#352) There is no description in phpdocs for function translate_qtype_to_qtype_identifier
(#369) There is no description in phpdocs for function default_question_text
(#68) Phpdocs for function qtype_combined_combiner_base::find_included_subqs_in_question_text has incomplete parameters list
(#117) Phpdocs for function qtype_combined_combiner_base::make_combinable_instance_from_code_in_question_text has incomplete parameters list
(#164) Phpdocs for function qtype_combined_combiner_base::find_or_create_question_instance has incomplete parameters list
(#194) Phpdocs for function qtype_combined_combiner_base::get_subq_data_from_form_data has incomplete parameters list
(#237) Phpdocs for function qtype_combined_combiner_base::create_subqs_from_subq_data has incomplete parameters list
(#342) Phpdocs for function qtype_combined_type_manager::new_subq_instance has incomplete parameters list
(#353) Phpdocs for function qtype_combined_type_manager::translate_qtype_to_qtype_identifier has incomplete parameters list
(#389) Phpdocs for function qtype_combined_type_manager::response_id has incomplete parameters list
(#33) Class qtype_combined_combiner_base does not have @copyright tag
(#278) Class qtype_combined_type_manager does not have @copyright tag
(#33) Class qtype_combined_combiner_base does not have @license tag
(#278) Class qtype_combined_type_manager does not have @license tag
(#163) Invalid inline phpdocs tag @see found
question/type/combined/combiner/forform.php
(#102) Phpdocs for function qtype_combined_combiner_for_form::validate_subqs_data_in_form has incomplete parameters list
(#129) Phpdocs for function qtype_combined_combiner_for_form::validate_subqs has incomplete parameters list
(#170) Phpdocs for function qtype_combined_combiner_for_form::data_to_form has incomplete parameters list
(#28) Class qtype_combined_combiner_for_form does not have @copyright tag
(#28) Class qtype_combined_combiner_for_form does not have @license tag
question/type/combined/combiner/forquestiontype.php
(#48) Function qtype_combined_combiner_for_question_type::move_subq_files is not documented
(#36) Phpdocs for function qtype_combined_combiner_for_question_type::save_subqs has incomplete parameters list
(#28) Class qtype_combined_combiner_for_question_type does not have @copyright tag
(#28) Class qtype_combined_combiner_for_question_type does not have @license tag
question/type/combined/combiner/restore.php
(#32) There is no description in phpdocs for function get_subq_responses
(#44) There is no description in phpdocs for function get_subq_type
(#52) There is no description in phpdocs for function get_subq_id
(#45) Phpdocs for function qtype_combined_combiner_for_restore::get_subq_type has incomplete parameters list
(#53) Phpdocs for function qtype_combined_combiner_for_restore::get_subq_id has incomplete parameters list
(#28) Class qtype_combined_combiner_for_restore does not have @copyright tag
(#28) Class qtype_combined_combiner_for_restore does not have @license tag
question/type/combined/combiner/runtime.php
(#17) No one-line description found in phpdocs for file
(#243) No one-line description found in phpdocs for class qtype_combined_param_to_pass_through_to_subq_base
(#262) No one-line description found in phpdocs for class qtype_combined_response_array_param
(#289) No one-line description found in phpdocs for class qtype_combined_array_of_response_arrays_param
(#43) There is no description in phpdocs for function render_subqs
(#123) There is no description in phpdocs for function get_subq_property
(#132) There is no description in phpdocs for function compute_final_grade
(#195) There is no description in phpdocs for function find_subq_with_id
(#209) There is no description in phpdocs for function get_validation_error
(#250) There is no description in phpdocs for function __construct
(#255) There is no description in phpdocs for function for_subq
(#272) There is no description in phpdocs for function __construct
(#279) There is no description in phpdocs for function for_subq
(#299) There is no description in phpdocs for function __construct
(#306) There is no description in phpdocs for function for_subq
(#328) There is no description in phpdocs for function __construct
(#335) There is no description in phpdocs for function for_subq
(#87) Phpdocs for function qtype_combined_combiner_for_run_time_question_instance::call_all_subqs has incomplete parameters list
(#104) Phpdocs for function qtype_combined_combiner_for_run_time_question_instance::call_subq has incomplete parameters list
(#124) Phpdocs for function qtype_combined_combiner_for_run_time_question_instance::get_subq_property has incomplete parameters list
(#133) Phpdocs for function qtype_combined_combiner_for_run_time_question_instance::compute_final_grade has incomplete parameters list
(#161) Phpdocs for function qtype_combined_combiner_for_run_time_question_instance::responses_upto_first_response_identical_to_final_response has incomplete parameters list
(#178) Phpdocs for function qtype_combined_combiner_for_run_time_question_instance::compute_subq_final_grade has incomplete parameters list
(#196) Phpdocs for function qtype_combined_combiner_for_run_time_question_instance::find_subq_with_id has incomplete parameters list
(#210) Phpdocs for function qtype_combined_combiner_for_run_time_question_instance::get_validation_error has incomplete parameters list
(#251) Phpdocs for function qtype_combined_param_to_pass_through_to_subq_base::__construct has incomplete parameters list
(#256) Phpdocs for function qtype_combined_param_to_pass_through_to_subq_base::for_subq has incomplete parameters list
(#280) Phpdocs for function qtype_combined_response_array_param::for_subq has incomplete parameters list
(#300) Phpdocs for function qtype_combined_array_of_response_arrays_param::__construct has incomplete parameters list
(#307) Phpdocs for function qtype_combined_array_of_response_arrays_param::for_subq has incomplete parameters list
(#329) Phpdocs for function qtype_combined_step_param::__construct has incomplete parameters list
(#336) Phpdocs for function qtype_combined_step_param::for_subq has incomplete parameters list
(#29) Class qtype_combined_combiner_for_run_time_question_instance does not have @copyright tag
(#243) Class qtype_combined_param_to_pass_through_to_subq_base does not have @copyright tag
(#262) Class qtype_combined_response_array_param does not have @copyright tag
(#289) Class qtype_combined_array_of_response_arrays_param does not have @copyright tag
(#319) Class qtype_combined_step_param does not have @copyright tag
(#29) Class qtype_combined_combiner_for_run_time_question_instance does not have @license tag
(#243) Class qtype_combined_param_to_pass_through_to_subq_base does not have @license tag
(#262) Class qtype_combined_response_array_param does not have @license tag
(#289) Class qtype_combined_array_of_response_arrays_param does not have @license tag
(#319) Class qtype_combined_step_param does not have @license tag
question/type/combined/edit_combined_form.php
(#45) Function qtype_combined_edit_form::__construct is not documented
(#50) Function qtype_combined_edit_form::get_current_question_text is not documented
(#60) Function qtype_combined_edit_form::definition_inner is not documented
(#81) Function qtype_combined_edit_form::data_preprocessing is not documented
(#99) Function qtype_combined_edit_form::validation is not documented
(#108) Function qtype_combined_edit_form::qtype is not documented
question/type/combined/question.php
(#45) Function qtype_combined_question::start_attempt is not documented
(#49) Function qtype_combined_question::apply_attempt_state is not documented
(#53) Function qtype_combined_question::get_expected_data is not documented
(#59) Function qtype_combined_question::get_correct_response is not documented
(#65) Function qtype_combined_question::summarise_response is not documented
(#75) Function qtype_combined_question::is_complete_response is not documented
(#82) Function qtype_combined_question::is_gradable_response is not documented
(#89) Function qtype_combined_question::get_validation_error is not documented
(#93) Function qtype_combined_question::is_same_response is not documented
(#102) Function qtype_combined_question::check_file_access is not documented
(#130) Function qtype_combined_question::grade_response is not documented
(#171) Function qtype_combined_question::compute_final_grade is not documented
(#175) Function qtype_combined_question::get_num_parts_right is not documented
(#193) Function qtype_combined_question::classify_response is not documented
(#149) There is no description in phpdocs for function overall_state
(#150) Phpdocs for function qtype_combined_question::overall_state has incomplete parameters list
question/type/combined/questiontype.php
(#44) Function qtype_combined::move_files is not documented
(#53) Function qtype_combined::delete_files is not documented
(#59) Function qtype_combined::save_question_options is not documented
(#161) Function qtype_combined::make_question is not documented
(#173) Function qtype_combined::make_hint is not documented
(#177) Function qtype_combined::initialise_question_instance is not documented
(#182) Function qtype_combined::get_question_options is not documented
(#192) Function qtype_combined::get_random_guess_score is not documented
(#201) Function qtype_combined::get_possible_responses is not documented
(#217) Function qtype_combined::export_to_xml is not documented
(#228) Function qtype_combined::import_from_xml is not documented
(#93) Phpdocs for function qtype_combined::save_imported_question has incomplete parameters list
question/type/combined/renderer.php
(#140) Class qtype_combined_text_entry_renderer_base is not documented
(#38) Function qtype_combined_renderer::formulation_and_controls is not documented
(#57) Function qtype_combined_renderer::specific_feedback is not documented
(#61) Function qtype_combined_renderer::feedback is not documented
(#95) Function qtype_combined_renderer::feedback_for_suqs_not_graded_correct is not documented
(#113) Function qtype_combined_renderer::num_parts_correct is not documented
(#134) Function subquestion is not documented
(#143) There is no description in phpdocs for function subquestion
(#144) Phpdocs for function qtype_combined_text_entry_renderer_base::subquestion has incomplete parameters list
question/type/combined/tests/behat/behat_qtype_combined.php
(#40) Phpdocs for function behat_qtype_combined::part_xpath has incomplete parameters list
question/type/combined/tests/helper.php
(#37) There is no description in phpdocs for function safe_include_test_helpers
(#58) There is no description in phpdocs for function make_a_gapselect_question
(#72) There is no description in phpdocs for function make_a_combined_question_with_gapselect_subquestion
(#102) There is no description in phpdocs for function make_oumultiresponse_question_two_of_four
(#113) There is no description in phpdocs for function make_a_combined_question_with_oumr_subquestion
(#143) There is no description in phpdocs for function make_a_combined_question_with_oumr_and_gapselect_subquestion
(#181) There is no description in phpdocs for function make_a_pmatch_question
(#193) There is no description in phpdocs for function make_a_combined_question_with_oumr_pmatch_and_gapselect_subquestion
(#236) There is no description in phpdocs for function make_a_varnumericset_question
(#259) There is no description in phpdocs for function make_a_combined_question_with_oumr_pmatch_varnum_and_gapselect_subquestion
(#38) Phpdocs for function qtype_combined_test_helper::safe_include_test_helpers has incomplete parameters list
question/type/combined/tests/walkthrough_test.php
(#484) Function qtype_combined_walkthrough_test::get_contains_num_parts_correct is not documented
(#984) Function qtype_combined_walkthrough_test::get_contains_text_expectation is not documented
(#38) Invalid phpdocs tag @group used

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]