Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(44 errors, 17 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

question/bank/quiztimer/classes/privacy/provider.php
(#36) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#38) Missing docblock for class provider
(#41) Missing docblock for function get_reason
(#45) File must end with a newline character
question/bank/quiztimer/classes/quiztimer_column.php
(#75) Variable "questionId" must be all lower-case
(#76) Variable "dropdownOption" must be all lower-case
(#78) Variable "questionId" must be all lower-case
(#79) Variable "questionId" must be all lower-case
(#88) Variable "dropdownOption" must be all lower-case
(#123) Variable "dropdownOption" must be all lower-case
(#124) Variable "dropdownOption" must be all lower-case
(#139) Variable "timeValue" must be all lower-case
(#140) Variable "unitTime" must be all lower-case
(#141) Variable "unitTime" must be all lower-case
(#142) Variable "timeValueDisplay" must be all lower-case
(#142) Variable "timeValue" must be all lower-case
(#143) Variable "unitTime" must be all lower-case
(#144) Variable "timeValueDisplay" must be all lower-case
(#144) Variable "timeValue" must be all lower-case
(#145) Variable "unitTime" must be all lower-case
(#146) Variable "timeValueDisplay" must be all lower-case
(#146) Variable "timeValue" must be all lower-case
(#148) Variable "timeValueDisplay" must be all lower-case
(#148) Variable "timeValue" must be all lower-case
(#152) Variable "timeValueDisplay" must be all lower-case
(#156) Variable "timeValueDisplay" must be all lower-case
(#156) Line exceeds maximum limit of 180 characters; contains 192 characters
(#166) Line exceeds 132 characters; contains 159 characters
(#189) Line exceeds 132 characters; contains 145 characters
question/bank/quiztimer/lang/en/qbank_quiztimer.php
(#41) The string key "setting:time" is not in the correct order, it should be before "setting:title"
(#44) The string key "hours" is not in the correct order, it should be before "setting:unitime"
(#48) The string key "privacy:metadata" is not in the correct order, it should be before "seconds"
question/bank/quiztimer/lang/es/qbank_quiztimer.php
(#41) The string key "setting:time" is not in the correct order, it should be before "setting:title"
(#44) The string key "hours" is not in the correct order, it should be before "setting:unitime"
(#48) The string key "privacy:metadata" is not in the correct order, it should be before "seconds"
question/bank/quiztimer/tests/behat/behat_qbank_quiztimer.php
(#49) No one-line description found in phpdocs for docblock of function i_should_see_input_element_with_value
question/bank/quiztimer/tests/phpunit/quiztimer_helper_test.php
(#37) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
(#43) Unit test quiztimer_helper_test should be declared as final.
(#43) PHPUnit class "quiztimer_helper_test" does not have any namespace. It is recommended to add it to the "qbank_quiztimer" namespace, using more levels if needed, in order to match the code being tested
(#43) Missing docblock for class quiztimer_helper_test
(#47) You must use "/**" style comments for a member variable comment
(#48) Missing member variable doc comment
(#49) Missing member variable doc comment
(#51) Missing member variable doc comment
(#52) Missing member variable doc comment
(#53) Missing docblock for constant quiztimer_helper_test::COURSE_START
(#54) Missing docblock for constant quiztimer_helper_test::COURSE_END
(#81) Test method test_helper() is missing a return type
question/bank/quiztimer/tests/phpunit/quiztimer_manage_test.php
(#37) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
(#43) Unit test quiztimer_manage_test should be declared as final.
(#43) PHPUnit class "quiztimer_manage_test" does not have any namespace. It is recommended to add it to the "qbank_quiztimer" namespace, using more levels if needed, in order to match the code being tested
(#43) Missing docblock for class quiztimer_manage_test
(#47) You must use "/**" style comments for a member variable comment
(#48) Missing member variable doc comment
(#49) Missing member variable doc comment
(#51) Missing member variable doc comment
(#52) Missing member variable doc comment
(#53) Missing docblock for constant quiztimer_manage_test::COURSE_START
(#54) Missing docblock for constant quiztimer_manage_test::COURSE_END
(#82) Test method test_manage() is missing a return type
question/bank/quiztimer/version.php
(#43) There should be a comma after the last array item in a multi-line array.

Javascript coding style problems

(3 errors, 1 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

question/bank/quiztimer/amd/src/savedata.js
(#26) @package should be empty. (jsdoc/empty-tags)
(#35) Missing JSDoc comment. (jsdoc/require-jsdoc)
(#50) Missing JSDoc comment. (jsdoc/require-jsdoc)
(#66) Empty block statement. (no-empty)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(3 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

question/bank/quiztimer/tests/behat/behat_qbank_quiztimer.php
(#46) Phpdocs for function behat_qbank_quiztimer::i_should_see_input_element_with_value has incomplete parameters list
question/bank/quiztimer/tests/phpunit/quiztimer_helper_test.php
(#78) Phpdocs for function quiztimer_helper_test::test_helper has incomplete parameters list
question/bank/quiztimer/tests/phpunit/quiztimer_manage_test.php
(#79) Phpdocs for function quiztimer_manage_test::test_manage has incomplete parameters list

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "eslint:amd" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]