Comments

• 

  Plugins bot

  Wed, 4 Feb 2015, 5:15 AM

  Prechecker results: http://integration.moodle.org/job/Precheck%20remote%20branch/10456/artifact/work/smurf.html
• 

  Tomasz Muras

  Tue, 10 Feb 2015, 5:51 AM

  Hi Shamim,
  
  Thank you for your contribution - I'll review it in the next cuple of days.
  
  Tomek
• 

  Tomasz Muras

  Mon, 16 Feb 2015, 1:29 AM

  Hi Shamim,
  
  I've tested and code reviewed the plugin. It's written very nicely, well done. I'd say it's good to go to our plugins directory.
  
  As a bonus you could consider:
  1. Creating and adding a link to English documentation (e.g. you could use Moodle Docs - https://docs.moodle.org/dev/Plugin_documentation).
  2. I think profile_field_associated class has wrong @param classes for $mform passed to the functions - it should be MoodleQuickForm instead of moodleform.
  
  Thank you for your contribution,
  Tomek
• 

  David Mudrák

  Tue, 17 Feb 2015, 5:16 AM

  Thanks Shamim for contributing this plugin, and thanks Tomek for the peer-review. I also like the idea and the possibilities of this plugin. You are cleared to land, welcome to the Plugins directory.
• 

  Erich Forler

  Tue, 16 Jun 2015, 7:21 PM

  This is a handy plug-in and gives us a much better registration page. One quirk we're noticing though is that if a field is set to be required it works fine when a new user registers. However, the required status is not respected if you access the registration page after you've logged in. This is a somewhat uncommon use case scenario (why would a logged-in user register?) but it's still incorrect behaviour and we have had a customer that is concerned about this behaviour.
  
  Other than that, it's a great quick fix for a registration page with more fields.
• 

  Shamim Rezaie

  Thu, 18 Jun 2015, 4:39 PM

  Thank Erich,
  I'll look into it.
• 

  Shamim Rezaie

  Sun, 19 Jul 2015, 6:11 PM

  Erich,
  Can you please let me know what Moodle version you are using?
  I tried to replicate your scenario but when I accessed /login/signup.php, Moodle said "You cannot create a new account because you are already logged in as firstname lastname".