Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(345 errors, 27 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

lib/editor/atto/plugins/generico/db/access.php
(#33) Spaces must be used to indent lines; tabs are not allowed
(#33) Tab found within whitespace
(#34) Spaces must be used to indent lines; tabs are not allowed
(#34) Tab found within whitespace
(#36) Spaces must be used to indent lines; tabs are not allowed
(#36) Tab found within whitespace
lib/editor/atto/plugins/generico/lib.php
(#49) Spaces must be used to indent lines; tabs are not allowed
(#49) Tab found within whitespace
(#49) Line indented incorrectly; expected at least 4 spaces, found 1
(#50) Spaces must be used to indent lines; tabs are not allowed
(#50) Tab found within whitespace
(#50) Whitespace found at end of line
(#51) Spaces must be used to indent lines; tabs are not allowed
(#51) Tab found within whitespace
(#51) Inline comments must start with a capital letter, digit or 3-dots sequence
(#51) Inline comments must end in full-stops, exclamation marks, or question marks
(#51) Line indented incorrectly; expected at least 4 spaces, found 1
(#51) No space found before comment text; expected "// coursecontext" but found "//coursecontext"
(#52) Spaces must be used to indent lines; tabs are not allowed
(#52) Tab found within whitespace
(#52) Line indented incorrectly; expected at least 4 spaces, found 1
(#52) Expected 1 space before "="; 0 found
(#52) Expected 1 space after "="; 0 found
(#52) Spaces must be used for alignment; tabs are not allowed
(#52) Tab found within whitespace
(#52) Whitespace found at end of line
(#53) Spaces must be used for alignment; tabs are not allowed
(#53) Tab found within whitespace
(#53) Whitespace found at end of line
(#54) Spaces must be used for alignment; tabs are not allowed
(#54) Tab found within whitespace
(#54) Inline comments must start with a capital letter, digit or 3-dots sequence
(#54) Inline comments must end in full-stops, exclamation marks, or question marks
(#54) Line indented incorrectly; expected at least 4 spaces, found 1
(#54) No space found before comment text; expected "// generico specific" but found "//generico specific"
(#55) Spaces must be used for alignment; tabs are not allowed
(#55) Tab found within whitespace
(#55) Line indented incorrectly; expected at least 4 spaces, found 1
(#56) Spaces must be used for alignment; tabs are not allowed
(#56) Tab found within whitespace
(#56) Whitespace found at end of line
(#57) Spaces must be used for alignment; tabs are not allowed
(#57) Tab found within whitespace
(#57) Line indented incorrectly; expected at least 4 spaces, found 1
(#58) Spaces must be used for alignment; tabs are not allowed
(#58) Tab found within whitespace
(#58) Line indented incorrectly; expected at least 4 spaces, found 1
(#59) Spaces must be used for alignment; tabs are not allowed
(#59) Tab found within whitespace
(#59) Line indented incorrectly; expected at least 4 spaces, found 1
(#60) Spaces must be used for alignment; tabs are not allowed
(#60) Tab found within whitespace
(#60) Whitespace found at end of line
(#61) Spaces must be used for alignment; tabs are not allowed
(#61) Tab found within whitespace
(#61) Inline comments must start with a capital letter, digit or 3-dots sequence
(#61) Inline comments must end in full-stops, exclamation marks, or question marks
(#61) Line indented incorrectly; expected at least 4 spaces, found 1
(#61) No space found before comment text; expected "// put our template into a form thats easy to process in JS" but found "//put our template into a form thats easy to process in JS"
(#62) Spaces must be used for alignment; tabs are not allowed
(#62) Tab found within whitespace
(#62) Line indented incorrectly; expected 4 spaces, found 1
(#62) Expected "for (...) {\n"; found "for(...){\n"
(#62) Expected 1 space after first semicolon of FOR loop; 0 found
(#62) Expected 1 space after second semicolon of FOR loop; 0 found
(#62) Expected 1 space before "="; 0 found
(#62) Expected 1 space after "="; 0 found
(#62) Expected 1 space before "<"; 0 found
(#62) Expected 1 space after "<"; 0 found
(#63) Spaces must be used for alignment; tabs are not allowed
(#63) Tab found within whitespace
(#63) Line indented incorrectly; expected 8 spaces, found 3
(#63) Expected "if (...) {\n"; found "if(...){\n"
(#64) Spaces must be used for alignment; tabs are not allowed
(#64) Tab found within whitespace
(#64) Line indented incorrectly; expected at least 12 spaces, found 4
(#65) Spaces must be used for alignment; tabs are not allowed
(#65) Tab found within whitespace
(#65) Line indented incorrectly; expected 8 spaces, found 3
(#66) Spaces must be used for alignment; tabs are not allowed
(#66) Tab found within whitespace
(#66) Whitespace found at end of line
(#67) Spaces must be used for alignment; tabs are not allowed
(#67) Tab found within whitespace
(#67) Inline comments must start with a capital letter, digit or 3-dots sequence
(#67) Inline comments must end in full-stops, exclamation marks, or question marks
(#67) Line indented incorrectly; expected at least 8 spaces, found 3
(#67) No space found before comment text; expected "// stash the key for this tempalte" but found "//stash the key for this tempalte"
(#68) Spaces must be used for alignment; tabs are not allowed
(#68) Tab found within whitespace
(#68) Line indented incorrectly; expected at least 8 spaces, found 3
(#69) Spaces must be used for alignment; tabs are not allowed
(#69) Tab found within whitespace
(#69) Whitespace found at end of line
(#70) Spaces must be used for alignment; tabs are not allowed
(#70) Tab found within whitespace
(#70) Line indented incorrectly; expected at least 8 spaces, found 3
(#70) No space found before comment text; expected "// NB each of the $allvariables contains an array of variables (not a string)" but found "//NB each of the $allvariables contains an array of variables (not a string)"
(#70) Whitespace found at end of line
(#71) Spaces must be used for alignment; tabs are not allowed
(#71) Tab found within whitespace
(#71) Line indented incorrectly; expected at least 8 spaces, found 3
(#71) No space found before comment text; expected "// there might be duplicates where the variable is used multiple times in a template" but found "//there might be duplicates where the variable is used multiple times in a template"
(#72) Spaces must be used for alignment; tabs are not allowed
(#72) Tab found within whitespace
(#72) Inline comments must end in full-stops, exclamation marks, or question marks
(#72) Line indented incorrectly; expected at least 8 spaces, found 3
(#72) No space found before comment text; expected "// se we uniqu'ify it. That makes it look complicated. But we are just removing doubles" but found "//se we uniqu'ify it. That makes it look complicated. But we are just removing doubles"
(#73) Spaces must be used for alignment; tabs are not allowed
(#73) Tab found within whitespace
(#73) Line indented incorrectly; expected at least 8 spaces, found 3
(#73) Line exceeds 132 characters; contains 133 characters
(#74) Spaces must be used for alignment; tabs are not allowed
(#74) Tab found within whitespace
(#74) Line indented incorrectly; expected at least 8 spaces, found 3
(#75) Spaces must be used for alignment; tabs are not allowed
(#75) Tab found within whitespace
(#75) Line indented incorrectly; expected at least 8 spaces, found 3
(#75) Expected 1 space before "="; 0 found
(#75) Expected 1 space after "="; 0 found
(#76) Spaces must be used for alignment; tabs are not allowed
(#76) Tab found within whitespace
(#76) Whitespace found at end of line
(#77) Spaces must be used for alignment; tabs are not allowed
(#77) Tab found within whitespace
(#77) Inline comments must start with a capital letter, digit or 3-dots sequence
(#77) Line indented incorrectly; expected at least 8 spaces, found 3
(#77) No space found before comment text; expected "// we need to reallocate array keys if the array size was changed in unique'ifying it" but found "//we need to reallocate array keys if the array size was changed in unique'ifying it"
(#78) Spaces must be used for alignment; tabs are not allowed
(#78) Tab found within whitespace
(#78) Line indented incorrectly; expected at least 8 spaces, found 3
(#78) No space found before comment text; expected "// we also take the opportunity to remove user variables, since they aren't needed here." but found "//we also take the opportunity to remove user variables, since they aren't needed here."
(#79) Spaces must be used for alignment; tabs are not allowed
(#79) Tab found within whitespace
(#79) Line indented incorrectly; expected 8 spaces, found 3
(#79) Expected "while (...) {\n"; found "while(...){\n"
(#79) Expected 1 space before ">"; 0 found
(#79) Expected 1 space after ">"; 0 found
(#80) Spaces must be used for alignment; tabs are not allowed
(#80) Tab found within whitespace
(#80) Line indented incorrectly; expected at least 12 spaces, found 5
(#81) Spaces must be used for alignment; tabs are not allowed
(#81) Tab found within whitespace
(#81) Line indented incorrectly; expected 12 spaces, found 5
(#81) Expected "if (...) {\n"; found "if(...){\n"
(#81) Expected 1 space before "==="; 0 found
(#81) Expected 1 space after "==="; 0 found
(#81) Expected 1 space before "!="; 0 found
(#81) Expected 1 space after "!="; 0 found
(#82) Spaces must be used for alignment; tabs are not allowed
(#82) Tab found within whitespace
(#82) Line indented incorrectly; expected at least 16 spaces, found 6
(#83) Spaces must be used for alignment; tabs are not allowed
(#83) Tab found within whitespace
(#83) Line indented incorrectly; expected 12 spaces, found 5
(#84) Spaces must be used for alignment; tabs are not allowed
(#84) Tab found within whitespace
(#84) Line indented incorrectly; expected 8 spaces, found 3
(#85) Spaces must be used for alignment; tabs are not allowed
(#85) Tab found within whitespace
(#85) Line indented incorrectly; expected at least 8 spaces, found 3
(#86) Spaces must be used for alignment; tabs are not allowed
(#86) Tab found within whitespace
(#86) Whitespace found at end of line
(#87) Spaces must be used for alignment; tabs are not allowed
(#87) Tab found within whitespace
(#87) Inline comments must start with a capital letter, digit or 3-dots sequence
(#87) Line indented incorrectly; expected at least 8 spaces, found 3
(#87) No space found before comment text; expected "// stash the defaults for this template" but found "//stash the defaults for this template"
(#88) Spaces must be used for alignment; tabs are not allowed
(#88) Tab found within whitespace
(#88) Inline comments must end in full-stops, exclamation marks, or question marks
(#88) This comment is 60% valid code; is this commented out code?
(#88) Line indented incorrectly; expected at least 8 spaces, found 3
(#88) No space found before comment text; expected "// $defaults[] = $templates['templatedefaults_' . $tempindex];" but found "//$defaults[] = $templates['templatedefaults_' . $tempindex];"
(#89) Spaces must be used for alignment; tabs are not allowed
(#89) Tab found within whitespace
(#89) Line indented incorrectly; expected at least 8 spaces, found 3
(#90) Spaces must be used for alignment; tabs are not allowed
(#90) Tab found within whitespace
(#90) Whitespace found at end of line
(#91) Spaces must be used for alignment; tabs are not allowed
(#91) Tab found within whitespace
(#91) Line indented incorrectly; expected at least 8 spaces, found 3
(#92) Spaces must be used for alignment; tabs are not allowed
(#92) Tab found within whitespace
(#92) Line indented incorrectly; expected 4 spaces, found 1
(#93) Spaces must be used for alignment; tabs are not allowed
(#93) Tab found within whitespace
(#93) Whitespace found at end of line
(#93) Functions must not contain multiple empty lines in a row; found 3 empty lines
(#95) Spaces must be used for alignment; tabs are not allowed
(#95) Tab found within whitespace
(#95) Whitespace found at end of line
(#96) Spaces must be used for alignment; tabs are not allowed
(#96) Tab found within whitespace
(#96) Inline comments must start with a capital letter, digit or 3-dots sequence
(#96) Inline comments must end in full-stops, exclamation marks, or question marks
(#96) Line indented incorrectly; expected at least 4 spaces, found 1
(#96) No space found before comment text; expected "// config our array of data" but found "//config our array of data"
(#97) Spaces must be used for alignment; tabs are not allowed
(#97) Tab found within whitespace
(#97) Line indented incorrectly; expected at least 4 spaces, found 1
(#98) Spaces must be used for alignment; tabs are not allowed
(#98) Tab found within whitespace
(#98) Line indented incorrectly; expected at least 4 spaces, found 1
(#99) Spaces must be used for alignment; tabs are not allowed
(#99) Tab found within whitespace
(#99) Line indented incorrectly; expected at least 4 spaces, found 1
(#100) Spaces must be used for alignment; tabs are not allowed
(#100) Tab found within whitespace
(#100) Line indented incorrectly; expected at least 4 spaces, found 1
(#101) Spaces must be used for alignment; tabs are not allowed
(#101) Tab found within whitespace
(#101) Line indented incorrectly; expected at least 4 spaces, found 1
(#103) Spaces must be used for alignment; tabs are not allowed
(#103) Tab found within whitespace
(#103) Inline comments must end in full-stops, exclamation marks, or question marks
(#103) Line indented incorrectly; expected at least 4 spaces, found 1
(#103) No space found before comment text; expected "// If they don't have permission don't show it" but found "//If they don't have permission don't show it"
(#104) Spaces must be used for alignment; tabs are not allowed
(#104) Tab found within whitespace
(#104) Line indented incorrectly; expected at least 4 spaces, found 1
(#105) Spaces must be used for alignment; tabs are not allowed
(#105) Tab found within whitespace
(#105) Line indented incorrectly; expected 4 spaces, found 1
(#105) Expected "if (...) {\n"; found "if(...){\n"
(#106) Spaces must be used for alignment; tabs are not allowed
(#106) Tab found within whitespace
(#106) Line indented incorrectly; expected at least 8 spaces, found 2
(#106) Expected 1 space before "="; 0 found
(#106) Expected 1 space after "="; 0 found
(#107) Spaces must be used for alignment; tabs are not allowed
(#107) Tab found within whitespace
(#107) Line indented incorrectly; expected 4 spaces, found 2
(#107) Closing brace indented incorrectly; expected 1 spaces, found 2
(#108) Spaces must be used for alignment; tabs are not allowed
(#108) Tab found within whitespace
(#108) Whitespace found at end of line
(#109) Spaces must be used for alignment; tabs are not allowed
(#109) Tab found within whitespace
(#109) Inline comments must start with a capital letter, digit or 3-dots sequence
(#109) Inline comments must end in full-stops, exclamation marks, or question marks
(#109) Line indented incorrectly; expected at least 4 spaces, found 1
(#109) No space found before comment text; expected "// add our disabled param" but found "//add our disabled param"
(#110) Spaces must be used for alignment; tabs are not allowed
(#110) Tab found within whitespace
(#110) Line indented incorrectly; expected at least 4 spaces, found 1
(#111) Functions must not contain multiple empty lines in a row; found 2 empty lines
(#118) Whitespace found at end of line
(#121) Expected 1 space after closing parenthesis; found 0
(#122) Spaces must be used for alignment; tabs are not allowed
(#122) Tab found within whitespace
(#122) Line indented incorrectly; expected at least 4 spaces, found 1
(#123) Spaces must be used for alignment; tabs are not allowed
(#123) Tab found within whitespace
(#123) Line indented incorrectly; expected at least 4 spaces, found 1
(#124) Spaces must be used for alignment; tabs are not allowed
(#124) Tab found within whitespace
(#124) Line indented incorrectly; expected 4 spaces, found 1
(#124) Expected "if (...) {\n"; found "if(...){\n"
(#124) Expected 1 space before ">"; 0 found
(#124) Expected 1 space after ">"; 0 found
(#125) Spaces must be used for alignment; tabs are not allowed
(#125) Tab found within whitespace
(#125) Line indented incorrectly; expected at least 8 spaces, found 2
(#126) Spaces must be used for alignment; tabs are not allowed
(#126) Tab found within whitespace
(#126) Line indented incorrectly; expected 4 spaces, found 1
(#126) Expected "} else {\n"; found "}else{\n"
(#127) Spaces must be used for alignment; tabs are not allowed
(#127) Tab found within whitespace
(#127) Line indented incorrectly; expected at least 8 spaces, found 2
(#128) Spaces must be used for alignment; tabs are not allowed
(#128) Tab found within whitespace
(#128) Line indented incorrectly; expected 4 spaces, found 1
(#131) Expected 1 space after closing parenthesis; found 0
(#132) Spaces must be used for alignment; tabs are not allowed
(#132) Tab found within whitespace
(#132) Line indented incorrectly; expected at least 4 spaces, found 1
(#132) No space found before comment text; expected "// Now we just have our properties string" but found "//Now we just have our properties string"
(#133) Spaces must be used for alignment; tabs are not allowed
(#133) Tab found within whitespace
(#133) Line indented incorrectly; expected at least 4 spaces, found 1
(#133) No space found before comment text; expected "// Lets run our regular expression over them" but found "//Lets run our regular expression over them"
(#134) Spaces must be used for alignment; tabs are not allowed
(#134) Tab found within whitespace
(#134) Line indented incorrectly; expected at least 4 spaces, found 1
(#134) No space found before comment text; expected "// string should be property=value,property=value" but found "//string should be property=value,property=value"
(#135) Spaces must be used for alignment; tabs are not allowed
(#135) Tab found within whitespace
(#135) Inline comments must end in full-stops, exclamation marks, or question marks
(#135) Line indented incorrectly; expected at least 4 spaces, found 1
(#135) No space found before comment text; expected "// got this regexp from http://stackoverflow.com/questions/168171/regular-expression-for-parsing-name-value-pairs" but found "//got this regexp from http://stackoverflow.com/questions/168171/regular-expression-for-parsing-name-value-pairs"
(#136) Spaces must be used for alignment; tabs are not allowed
(#136) Tab found within whitespace
(#136) Line indented incorrectly; expected at least 4 spaces, found 1
(#136) Expected 1 space before "="; 0 found
(#136) Expected 1 space after "="; 0 found
(#137) Spaces must be used for alignment; tabs are not allowed
(#137) Tab found within whitespace
(#137) Line indented incorrectly; expected at least 4 spaces, found 1
(#137) Spaces must be used for alignment; tabs are not allowed
(#137) Tab found within whitespace
(#137) Whitespace found at end of line
(#139) Spaces must be used for alignment; tabs are not allowed
(#139) Tab found within whitespace
(#139) Inline comments must start with a capital letter, digit or 3-dots sequence
(#139) Line indented incorrectly; expected at least 4 spaces, found 1
(#139) No space found before comment text; expected "// here we match the filter string and split into name array (matches[1]) and value array (matches[2])" but found "//here we match the filter string and split into name array (matches[1]) and value array (matches[2])"
(#140) Spaces must be used for alignment; tabs are not allowed
(#140) Tab found within whitespace
(#140) Line indented incorrectly; expected at least 4 spaces, found 1
(#140) No space found before comment text; expected "// we then add those to a name value array." but found "//we then add those to a name value array."
(#141) Spaces must be used for alignment; tabs are not allowed
(#141) Tab found within whitespace
(#141) Line indented incorrectly; expected at least 4 spaces, found 1
(#142) Spaces must be used for alignment; tabs are not allowed
(#142) Tab found within whitespace
(#142) Line indented incorrectly; expected 4 spaces, found 1
(#142) Expected "if (...) {\n"; found "if (...){\t\t\n"
(#142) Commas (,) must be followed by white space.
(#142) Commas (,) must be followed by white space.
(#142) Spaces must be used for alignment; tabs are not allowed
(#142) Tab found within whitespace
(#142) Whitespace found at end of line
(#143) Spaces must be used for alignment; tabs are not allowed
(#143) Tab found within whitespace
(#143) Line indented incorrectly; expected at least 8 spaces, found 2
(#144) Spaces must be used for alignment; tabs are not allowed
(#144) Tab found within whitespace
(#144) Line indented incorrectly; expected 8 spaces, found 2
(#144) Expected "for (...) {\n"; found "for (...){\n"
(#144) Expected 1 space after "="; 0 found
(#145) Spaces must be used for alignment; tabs are not allowed
(#145) Tab found within whitespace
(#145) Inline comments must start with a capital letter, digit or 3-dots sequence
(#145) Inline comments must end in full-stops, exclamation marks, or question marks
(#145) This comment is 63% valid code; is this commented out code?
(#145) Line indented incorrectly; expected at least 12 spaces, found 3
(#146) Spaces must be used for alignment; tabs are not allowed
(#146) Tab found within whitespace
(#146) Line indented incorrectly; expected at least 12 spaces, found 3
(#147) Spaces must be used for alignment; tabs are not allowed
(#147) Tab found within whitespace
(#147) Inline comments must start with a capital letter, digit or 3-dots sequence
(#147) Line indented incorrectly; expected at least 12 spaces, found 3
(#147) No space found before comment text; expected "// this could be done better, I am sure. WE are removing the quotes from start and end" but found "//this could be done better, I am sure. WE are removing the quotes from start and end"
(#148) Spaces must be used for alignment; tabs are not allowed
(#148) Tab found within whitespace
(#148) Inline comments must end in full-stops, exclamation marks, or question marks
(#148) Line indented incorrectly; expected at least 12 spaces, found 3
(#148) No space found before comment text; expected "// this wil however remove multiple quotes id they exist at start and end. NG really" but found "//this wil however remove multiple quotes id they exist at start and end. NG really"
(#149) Spaces must be used for alignment; tabs are not allowed
(#149) Tab found within whitespace
(#149) Line indented incorrectly; expected at least 12 spaces, found 3
(#149) Commas (,) must be followed by white space.
(#150) Spaces must be used for alignment; tabs are not allowed
(#150) Tab found within whitespace
(#150) Line indented incorrectly; expected at least 12 spaces, found 3
(#150) Expected 1 space before "="; 0 found
(#150) Expected 1 space after "="; 0 found
(#151) Spaces must be used for alignment; tabs are not allowed
(#151) Tab found within whitespace
(#151) Line indented incorrectly; expected 8 spaces, found 2
(#152) Spaces must be used for alignment; tabs are not allowed
(#152) Tab found within whitespace
(#152) Line indented incorrectly; expected 4 spaces, found 1
(#153) Spaces must be used for alignment; tabs are not allowed
(#153) Tab found within whitespace
(#153) Line indented incorrectly; expected at least 4 spaces, found 1
lib/editor/atto/plugins/generico/version.php
(#31) Inline comments must end in full-stops, exclamation marks, or question marks

Javascript coding style problems

(0 errors, 16 warnings)

This section shows the coding style problems detected in the code by jshint [More info]

lib/editor/atto/plugins/generico/yui/src/button/js/button.js
(#37) Redefinition of 'CSS'.
(#66) Line is too long.
(#194) 'useheadertext' is already defined.
(#199) 'useheadertext' used out of scope.
(#218) Missing semicolon.
(#299) 'content' is already defined.
(#308) 'content' used out of scope.
(#424) Comma warnings can be turned off with 'laxcomma'.
(#423) Bad line breaking before ','.
(#35) 'LOGNAME' is defined but never used.
(#45) 'SELECTORS' is defined but never used.
(#194) 'useheadertext' is defined but never used.
(#258) 'thekey' is defined but never used.
(#299) 'content' is defined but never used.
(#286) 'htmloptions' is defined but never used.
(#288) 'optindex' is defined but never used.
(#325) 'clickedicon' is defined but never used.

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by csslint [More info]


PHPDocs style problems

(4 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

lib/editor/atto/plugins/generico/lib.php
(#131) Function atto_generico_fetch_filter_properties is not documented
(#30) Phpdocs for function atto_generico_strings_for_js has incomplete parameters list
(#44) Phpdocs for function atto_generico_params_for_js has incomplete parameters list
(#118) Phpdocs for function atto_generico_fetch_variables has incomplete parameters list

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt shifter

shifter problems

(1 errors, 0 warnings)

This section shows problems detected by shifter [More info]

lib/editor/atto/plugins/generico/yui/src/button/js/button.js
contains 60 lint errors

Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]