Prechecker results: error


PHP lint problems

(5 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]

auth/saml2/extlib/simplesamlphp/vendor/symfony/debug/Resources/ext/tests/003.phpt
(#10) PHP Fatal error: Namespace declaration statement has to be the very first statement or after any declare call in the script in /auth/saml2/extlib/simplesamlphp/vendor/symfony/debug/Resources/ext/tests/003.phpt on line 10
auth/saml2/extlib/simplesamlphp/vendor/symfony/debug/Tests/phpt/debug_class_loader.phpt
(#6) PHP Fatal error: Namespace declaration statement has to be the very first statement or after any declare call in the script in /auth/saml2/extlib/simplesamlphp/vendor/symfony/debug/Tests/phpt/debug_class_loader.phpt on line 6
auth/saml2/extlib/simplesamlphp/vendor/symfony/debug/Tests/phpt/decorate_exception_hander.phpt
(#8) PHP Fatal error: Namespace declaration statement has to be the very first statement or after any declare call in the script in /auth/saml2/extlib/simplesamlphp/vendor/symfony/debug/Tests/phpt/decorate_exception_hander.phpt on line 8
auth/saml2/extlib/simplesamlphp/vendor/symfony/debug/Tests/phpt/exception_rethrown.phpt
(#6) PHP Fatal error: Namespace declaration statement has to be the very first statement or after any declare call in the script in /auth/saml2/extlib/simplesamlphp/vendor/symfony/debug/Tests/phpt/exception_rethrown.phpt on line 6
auth/saml2/extlib/simplesamlphp/vendor/symfony/debug/Tests/phpt/fatal_with_nested_handlers.phpt
(#6) PHP Fatal error: Namespace declaration statement has to be the very first statement or after any declare call in the script in /auth/saml2/extlib/simplesamlphp/vendor/symfony/debug/Tests/phpt/fatal_with_nested_handlers.phpt on line 6

PHP coding style problems

(0 errors, 21 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

auth/saml2/auth.php
(#529) Inline comments must end in full-stops, exclamation marks, or question marks
auth/saml2/classes/form/availableidps.php
(#80) Inline comments must end in full-stops, exclamation marks, or question marks
auth/saml2/config/config.php
(#79) Line exceeds 132 characters; contains 174 characters
auth/saml2/login.php
(#31) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
auth/saml2/logout.php
(#25) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
auth/saml2/selectidp.php
(#28) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
auth/saml2/settings.php
(#237) Inline comments must end in full-stops, exclamation marks, or question marks
(#245) Inline comments must end in full-stops, exclamation marks, or question marks
(#253) Inline comments must end in full-stops, exclamation marks, or question marks
auth/saml2/setup.php
(#25) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
auth/saml2/setuplib.php
(#27) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
auth/saml2/sp/module.php
(#26) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
auth/saml2/sp/saml1-acs.php
(#25) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
auth/saml2/sp/saml2-acs.php
(#25) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
auth/saml2/sp/saml2-logout.php
(#25) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
auth/saml2/test.php
(#25) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
auth/saml2/tester.php
(#25) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
auth/saml2/tests/phpunit/metadata_refresh_test.php
(#48) Line exceeds 132 characters; contains 146 characters
auth/saml2/tests/phpunit/ssl_algorithm_test.php
(#30) Line exceeds 132 characters; contains 155 characters
(#34) Line exceeds 132 characters; contains 152 characters
(#38) Line exceeds 132 characters; contains 160 characters

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(168 errors, 1 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

auth/saml2/auth.php
(#107) Function auth_plugin_saml2::get_saml2_directory is not documented
(#116) Function auth_plugin_saml2::get_file is not documented
(#120) Function auth_plugin_saml2::get_file_sp_metadata_file is not documented
(#924) Function auth_plugin_saml2::can_be_manually_set is not documented
(#124) There is no description in phpdocs for function get_file_idp_metadata_file
(#689) Phpdocs for function auth_plugin_saml2::simplify_attr has incomplete parameters list
(#713) Phpdocs for function auth_plugin_saml2::update_user_profile_fields has incomplete parameters list
(#793) Phpdocs for function auth_plugin_saml2::is_email_taken has incomplete parameters list
(#872) Phpdocs for function auth_plugin_saml2::user_login has incomplete parameters list
(#978) Phpdocs for function auth_plugin_saml2::execute_callback has incomplete parameters list
auth/saml2/classes/admin/saml2_settings.php
(#35) Constant saml2_settings::OPTION_DUAL_LOGIN_NO is not documented
(#37) Constant saml2_settings::OPTION_DUAL_LOGIN_YES is not documented
(#39) Constant saml2_settings::OPTION_DUAL_LOGIN_PASSIVE is not documented
(#41) Constant saml2_settings::OPTION_MULTI_IDP_DISPLAY_DROPDOWN is not documented
(#43) Constant saml2_settings::OPTION_MULTI_IDP_DISPLAY_BUTTONS is not documented
(#45) Constant saml2_settings::OPTION_FLAGGED_LOGIN_MESSAGE is not documented
(#47) Constant saml2_settings::OPTION_FLAGGED_LOGIN_REDIRECT is not documented
(#17) No one-line description found in phpdocs for file
(#28) No one-line description found in phpdocs for class saml2_settings
auth/saml2/classes/admin/setting_button.php
(#57) Phpdocs for function setting_button::output_html has incomplete parameters list
auth/saml2/classes/admin/setting_idpmetadata.php
(#46) Function setting_idpmetadata::__construct is not documented
(#106) Function setting_idpmetadata::process_idp_metadata is not documented
(#121) Function setting_idpmetadata::process_idp_xml is not documented
(#171) Function setting_idpmetadata::remove_old_idps is not documented
(#233) Function setting_idpmetadata::save_idp_metadata_xml is not documented
(#17) No one-line description found in phpdocs for file
(#82) There is no description in phpdocs for function process_all_idps_metadata
(#181) There is no description in phpdocs for function get_idps_data
(#207) There is no description in phpdocs for function get_idp_xml_path
(#224) There is no description in phpdocs for function find_all_idp_sso_descriptors
(#182) Phpdocs for function setting_idpmetadata::get_idps_data has incomplete parameters list
(#208) Phpdocs for function setting_idpmetadata::get_idp_xml_path has incomplete parameters list
auth/saml2/classes/admin/setting_idpmetadata_exception.php
(#30) Class setting_idpmetadata_exception is not documented
(#17) No one-line description found in phpdocs for file
auth/saml2/classes/admin/setting_textonly.php
(#38) Phpdocs for function setting_textonly::output_html has incomplete parameters list
auth/saml2/classes/form/selectidp_buttons.php
(#71) Function selectidp_buttons::get_idpbutton is not documented
auth/saml2/classes/idp_data.php
(#30) Package is not specified for class idp_data. It is also not specified in file-level phpdocs
(#17) File-level phpdocs block is not found
(#30) Class idp_data is not documented
(#53) Function idp_data::get_rawxml is not documented
(#57) Function idp_data::set_rawxml is not documented
(#31) Variable idp_data::$idpname is not documented
(#33) Variable idp_data::$idpurl is not documented
(#35) Variable idp_data::$idpicon is not documented
(#37) Variable idp_data::$rawxml is not documented
(#42) Phpdocs for function idp_data::__construct has incomplete parameters list
auth/saml2/classes/idp_parser.php
(#29) Class idp_parser is not documented
(#59) Function idp_parser::check_xml is not documented
(#68) Function idp_parser::parse_xml is not documented
(#74) Function idp_parser::parse_urls is not documented
(#44) Phpdocs for function idp_parser::parse has incomplete parameters list
auth/saml2/classes/metadata_fetcher.php
(#54) There is no description in phpdocs for function fetch
(#101) There is no description in phpdocs for function get_curlinfo
(#108) There is no description in phpdocs for function get_curlerrorno
(#115) There is no description in phpdocs for function get_curlerror
(#55) Phpdocs for function metadata_fetcher::fetch has incomplete parameters list
auth/saml2/classes/metadata_parser.php
(#47) There is no description in phpdocs for function parse
(#73) There is no description in phpdocs for function get_entityid
(#80) There is no description in phpdocs for function get_idpdefaultname
auth/saml2/classes/metadata_writer.php
(#55) There is no description in phpdocs for function write
auth/saml2/classes/redis_store.php
(#51) Function redis_store::__construct is not documented
(#62) There is no description in phpdocs for function set
(#72) There is no description in phpdocs for function get
(#86) There is no description in phpdocs for function delete
(#126) There is no description in phpdocs for function make_key
(#135) There is no description in phpdocs for function get_set_options
auth/saml2/classes/ssl_algorithms.php
(#30) Class ssl_algorithms is not documented
(#34) Function ssl_algorithms::get_default_saml_signature_algorithm is not documented
(#42) Function ssl_algorithms::get_valid_saml_signature_algorithms is not documented
(#54) Function ssl_algorithms::convert_signature_algorithm_to_digest_alg_format is not documented
(#17) No one-line description found in phpdocs for file
auth/saml2/classes/task/metadata_refresh.php
(#69) Function metadata_refresh::get_name is not documented
(#73) Function metadata_refresh::execute is not documented
(#106) There is no description in phpdocs for function set_fetcher
(#113) There is no description in phpdocs for function set_parser
(#120) There is no description in phpdocs for function set_writer
(#127) There is no description in phpdocs for function set_idpmetadata
auth/saml2/classes/test/mock_settings.php
(#42) Function mock_settings::add is not documented
(#17) No one-line description found in phpdocs for file
(#32) No one-line description found in phpdocs for class mock_settings
auth/saml2/tests/behat/behat_auth_saml2.php
(#148) Function behat_auth_saml2::apply_defaults is not documented
(#180) Function behat_auth_saml2::initialise_saml2 is not documented
(#253) Function behat_auth_saml2::visit_saml2_login_page is not documented
(#257) Function behat_auth_saml2::reset_saml2_session is not documented
(#262) Function behat_auth_saml2::reset_moodle_session is not documented
(#267) Function behat_auth_saml2::execute is not documented
(#17) No one-line description found in phpdocs for file
(#34) No one-line description found in phpdocs for class behat_auth_saml2
(#71) There is no description in phpdocs for function theAuthenticationPluginIsEnabledAuth_saml
(#95) There is no description in phpdocs for function iGoToTheLoginPageAuth_saml
(#112) There is no description in phpdocs for function iGoToTheLoginPageWithAuth_saml
(#119) There is no description in phpdocs for function iAmAnAdministratorAuth_saml
(#126) There is no description in phpdocs for function iGoToTheSamlsettingsPageAuth_saml
(#134) There is no description in phpdocs for function iChangeTheSettingToAuth_saml
(#141) There is no description in phpdocs for function theSettingShouldBeAuth_saml
(#194) There is no description in phpdocs for function theSamlsettingIsSetToAuth_saml
(#242) There is no description in phpdocs for function iAmAlreadyLoggedInAsInSAMLAuth_saml
(#42) Phpdocs for function behat_auth_saml2::take_screenshot_after_failure has incomplete parameters list
(#71) Phpdocs for function behat_auth_saml2::theAuthenticationPluginIsEnabledAuth_saml has incomplete parameters list
(#95) Phpdocs for function behat_auth_saml2::iGoToTheLoginPageAuth_saml has incomplete parameters list
(#112) Phpdocs for function behat_auth_saml2::iGoToTheLoginPageWithAuth_saml has incomplete parameters list
(#134) Phpdocs for function behat_auth_saml2::iChangeTheSettingToAuth_saml has incomplete parameters list
(#141) Phpdocs for function behat_auth_saml2::theSettingShouldBeAuth_saml has incomplete parameters list
(#194) Phpdocs for function behat_auth_saml2::theSamlsettingIsSetToAuth_saml has incomplete parameters list
(#242) Phpdocs for function behat_auth_saml2::iAmAlreadyLoggedInAsInSAMLAuth_saml has incomplete parameters list
(#22) Invalid phpdocs tag @codingStandardsIgnoreFile used
(#34) Invalid phpdocs tag @SuppressWarnings(public) used
(#45) Invalid phpdocs tag @AfterStep used
auth/saml2/tests/phpunit/autoloader_test.php
(#35) Function auth_saml2_autoloader_test::test_it_loads_classes is not documented
(#17) No one-line description found in phpdocs for file
(#28) No one-line description found in phpdocs for class auth_saml2_autoloader_test
auth/saml2/tests/phpunit/locallib_test.php
(#59) Function auth_saml2_locallib_testcase::test_auth_saml2_sp_metadata is not documented
(#366) Function auth_saml2_locallib_testcase::test_is_configured_works_with_multi_idp_in_one_xml is not documented
(#398) Function auth_saml2_locallib_testcase::test_get_email_from_attributes is not documented
(#419) Function auth_saml2_locallib_testcase::test_is_email_taken is not documented
(#162) Phpdocs for function auth_saml2_locallib_testcase::test_update_custom_user_profile_fields has incomplete parameters list
(#221) Phpdocs for function auth_saml2_locallib_testcase::test_missing_user_custom_profile_fields has incomplete parameters list
(#269) Phpdocs for function auth_saml2_locallib_testcase::test_invalid_map_user_profile_fields has incomplete parameters list
auth/saml2/tests/phpunit/metadata_fetcher_test.php
(#38) Function auth_saml2_metadata_fetcher_testcase::test_fetch_metadata_404 is not documented
(#51) Function auth_saml2_metadata_fetcher_testcase::test_fetch_metadata_success is not documented
(#61) Function auth_saml2_metadata_fetcher_testcase::test_fetch_metadata_curlerrorno is not documented
(#85) Function auth_saml2_metadata_fetcher_testcase::test_fetch_metadata_nohttpstatus is not documented
(#107) Function auth_saml2_metadata_fetcher_testcase::test_fetch_metadata_override_ssl_options is not documented
auth/saml2/tests/phpunit/metadata_parser_test.php
(#38) Function auth_saml2_metadata_parser_testcase::test_parse_metadata is not documented
(#48) There is no description in phpdocs for function test_parse_metadata_fail
auth/saml2/tests/phpunit/metadata_refresh_test.php
(#39) Function auth_saml2_metadata_refresh_testcase::setUp is not documented
(#43) Function auth_saml2_metadata_refresh_testcase::test_metadata_refresh_disabled is not documented
(#52) Function auth_saml2_metadata_refresh_testcase::test_metadata_refresh_idpmetadata_non_url is not documented
(#66) Function auth_saml2_metadata_refresh_testcase::test_metadata_refresh_idpmetadata_notconfigured is not documented
(#121) Function auth_saml2_metadata_refresh_testcase::test_metadata_refresh_parse_no_entityid is not documented
(#144) Function auth_saml2_metadata_refresh_testcase::test_metadata_refresh_parse_no_idpname is not documented
(#76) There is no description in phpdocs for function test_metadata_refresh_fetch_fails
(#97) There is no description in phpdocs for function test_metadata_refresh_parse_fails
(#170) There is no description in phpdocs for function test_metadata_refresh_write_fails
auth/saml2/tests/phpunit/metadata_writer_test.php
(#38) Function auth_saml2_metadata_writer_testcase::test_write_default_path is not documented
(#61) Function auth_saml2_metadata_writer_testcase::test_write_non_dataroot_path is not documented
(#76) Function auth_saml2_metadata_writer_testcase::test_write_trailing_slash is not documented
(#50) There is no description in phpdocs for function test_write_empty_filename
auth/saml2/tests/phpunit/redis_store_test.php
(#43) Function auth_saml2_redis_store_testcase::setUp is not documented
(#54) Function auth_saml2_redis_store_testcase::tearDown is not documented
(#58) Function auth_saml2_redis_store_testcase::test_set_with_expire is not documented
(#69) Function auth_saml2_redis_store_testcase::test_set_no_expire is not documented
(#79) Function auth_saml2_redis_store_testcase::test_get_key_exists is not documented
(#88) Function auth_saml2_redis_store_testcase::test_get_key_not_exists is not documented
(#94) Function auth_saml2_redis_store_testcase::test_delete is not documented
(#104) Function auth_saml2_redis_store_testcase::test_delete_key_not_exists is not documented
(#109) Function auth_saml2_redis_store_testcase::test_bootstrap_redis is not documented
auth/saml2/tests/phpunit/saml2_sitedata_test.php
(#28) Class auth_saml2_sitedata_test is not documented
(#29) Function auth_saml2_sitedata_test::test_it_creates_the_directory_if_it_does_not_exist is not documented
(#17) No one-line description found in phpdocs for file
auth/saml2/tests/phpunit/setting_idpmetadata_test.php
(#31) Class setting_idpmetadata_test is not documented
(#35) Function setting_idpmetadata_test::setUp is not documented
(#40) Function setting_idpmetadata_test::get_test_metadata_url is not documented
(#47) Function setting_idpmetadata_test::test_it_validates_the_xml is not documented
(#54) Function setting_idpmetadata_test::test_it_saves_all_idp_information is not documented
(#82) Function setting_idpmetadata_test::test_it_saves_all_idps_information_from_single_xml is not documented
(#114) Function setting_idpmetadata_test::test_it_allows_empty_values is not documented
(#120) Function setting_idpmetadata_test::test_it_gets_idp_data_for_xml is not documented
(#127) Function setting_idpmetadata_test::test_it_gets_idp_data_for_two_urls is not documented
(#135) Function setting_idpmetadata_test::test_it_returns_error_if_metadata_url_is_not_valid is not documented
(#17) No one-line description found in phpdocs for file
(#141) There is no description in phpdocs for function validate_idp_data_array
(#154) Not recommended phpdocs tag @static used
auth/saml2/tests/phpunit/ssl_algorithm_test.php
(#28) Class auth_saml2_ssl_algorithms_test is not documented
(#29) Function auth_saml2_ssl_algorithms_test::test_default_saml_signature_algorithm_is_valid_saml_signature_algorithm is not documented
(#33) Function auth_saml2_ssl_algorithms_test::test_sha256_is_valid_saml_signature_algorithm is not documented
(#37) Function auth_saml2_ssl_algorithms_test::test_sha256_is_matching_digest_algorithm_for_default_saml_algorithm is not documented
(#41) Function auth_saml2_ssl_algorithms_test::test_sha256_is_matching_digest_algorithm_for_garbage_algorithm is not documented
(#17) No one-line description found in phpdocs for file

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "stylelint:scss" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]