Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(60 errors, 28 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

auth/saml/check_course_mappings_duplicates.php
(#30) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
auth/saml/classes/admin_setting_configtext_trim.php
(#40) Inline comments must start with a capital letter, digit or 3-dots sequence
(#40) Inline comments must end in full-stops, exclamation marks, or question marks
(#40) Line indented incorrectly; expected at least 12 spaces, found 8
(#43) Inline comments must start with a capital letter, digit or 3-dots sequence
(#43) Inline comments must end in full-stops, exclamation marks, or question marks
(#50) Whitespace found at end of line
(#51) Inline comments must start with a capital letter, digit or 3-dots sequence
(#51) Inline comments must end in full-stops, exclamation marks, or question marks
auth/saml/classes/admin_setting_configtextarea_trim.php
(#40) Inline comments must start with a capital letter, digit or 3-dots sequence
(#40) Inline comments must end in full-stops, exclamation marks, or question marks
(#40) Line indented incorrectly; expected at least 12 spaces, found 8
(#43) Inline comments must start with a capital letter, digit or 3-dots sequence
(#43) Inline comments must end in full-stops, exclamation marks, or question marks
(#50) Whitespace found at end of line
(#51) Inline comments must start with a capital letter, digit or 3-dots sequence
(#51) Inline comments must end in full-stops, exclamation marks, or question marks
auth/saml/classes/admin_setting_special_javascript.php
(#56) Line exceeds 132 characters; contains 150 characters
auth/saml/classes/admin_setting_special_link.php
(#91) Expected 1 space before ":"; 0 found
auth/saml/cli/remove_course_mappings.php
(#40) Variable "configTable" must be all lower-case
(#41) Variable "configTable" must be all lower-case
auth/saml/cli/sync_course_mapping.php
(#38) Expected 1 space before "=>"; 0 found
(#54) Whitespace found at end of line within string
(#55) Whitespace found at end of line within string
auth/saml/cli/sync_role_mapping.php
(#38) Expected 1 space before "=>"; 0 found
(#54) Whitespace found at end of line within string
(#55) Whitespace found at end of line within string
auth/saml/cli/sync_users.php
(#68) The use of function error_log() is forbidden
(#132) The use of function error_log() is forbidden
(#135) The use of function error_log() is forbidden
auth/saml/course_mappings_to_csv.php
(#30) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
auth/saml/custom_hook.php
(#66) Variable "saml_attributes" must not contain underscores.
(#68) This comment is 68% valid code; is this commented out code?
(#85) Variable "saml_attributes" must not contain underscores.
(#86) Variable "saml_attributes" must not contain underscores.
(#87) Variable "saml_attributes" must not contain underscores.
(#87) Variable "saml_attributes" must not contain underscores.
(#92) Variable "saml_attributes" must not contain underscores.
(#93) Variable "saml_attributes" must not contain underscores.
(#94) Variable "saml_attributes" must not contain underscores.
(#94) Variable "saml_attributes" must not contain underscores.
(#95) Variable "saml_attributes" must not contain underscores.
(#96) Variable "saml_attributes" must not contain underscores.
(#96) Variable "saml_attributes" must not contain underscores.
(#97) Variable "saml_attributes" must not contain underscores.
(#98) Variable "saml_attributes" must not contain underscores.
(#98) Variable "saml_attributes" must not contain underscores.
(#115) Variable "saml_attributes" must not contain underscores.
(#115) Variable "user_exists" must not contain underscores.
(#133) Variable "saml_attributes" must not contain underscores.
(#133) Variable "authorize_user" must not contain underscores.
(#147) Variable "saml_attributes" must not contain underscores.
(#199) This comment is 60% valid code; is this commented out code?
(#200) This comment is 54% valid code; is this commented out code?
(#201) This comment is 79% valid code; is this commented out code?
(#202) This comment is 70% valid code; is this commented out code?
(#202) Expected 1 space before comment text but found 4; use block comment if you need indentation
(#203) Inline comments must end in full-stops, exclamation marks, or question marks
(#203) This comment is 50% valid code; is this commented out code?
auth/saml/error.php
(#107) The use of function error_log() is forbidden
auth/saml/index.php
(#31) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#90) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
(#115) Variable "SAML_COURSE_INFO" must be all lower-case
(#115) Variable "SAML_COURSE_INFO" must not contain underscores.
(#202) Variable "SAML_COURSE_INFO" must be all lower-case
(#202) Variable "SAML_COURSE_INFO" must not contain underscores.
(#203) Variable "SAML_COURSE_INFO" must be all lower-case
(#203) Variable "SAML_COURSE_INFO" must not contain underscores.
(#205) Variable "SAML_COURSE_INFO" must be all lower-case
(#205) Variable "SAML_COURSE_INFO" must not contain underscores.
(#206) Variable "SAML_COURSE_INFO" must be all lower-case
(#206) Variable "SAML_COURSE_INFO" must not contain underscores.
(#312) Variable "errorMsg" must be all lower-case
(#313) Variable "errorMsg" must be all lower-case
auth/saml/locallib.php
(#96) This comment is 58% valid code; is this commented out code?
(#132) Commas (,) must be followed by white space.
(#132) Commas (,) must be followed by white space.
(#133) Commas (,) must be followed by white space.
(#133) Commas (,) must be followed by white space.
auth/saml/login.php
(#29) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
auth/saml/role_mappings_to_csv.php
(#30) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
auth/saml/saml_config.php
(#1) No PHP code was found in this file and short open tags are not allowed by this install of PHP. This file may be using short open tags but PHP does not allow them.
auth/saml/settings.php
(#236) Whitespace found at end of line
(#280) Whitespace found at end of line
auth/saml/utils.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#5) Whitespace found at end of line
(#8) Whitespace found at end of line
(#13) Expected MOODLE_INTERNAL check or config.php inclusion

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(97 errors, 3 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

auth/saml/auth.php
(#114) Function auth_plugin_saml::get_attributes is not documented
(#157) Function auth_plugin_saml::pre_loginpage_hook is not documented
(#166) Function auth_plugin_saml::loginpage_hook is not documented
(#177) Function auth_plugin_saml::logoutpage_hook is not documented
(#82) Phpdocs for function auth_plugin_saml::get_userinfo has incomplete parameters list
(#17) File-level phpdocs block does not have @copyright tag
(#36) Class auth_plugin_saml does not have @copyright tag
(#36) Class auth_plugin_saml does not have @license tag
(#20) Package auth/saml is not valid
auth/saml/check_course_mappings_duplicates.php
(#17) File-level phpdocs block does not have @copyright tag
(#20) Package auth/saml is not valid
auth/saml/classes/admin_setting_configtext_trim.php
(#38) Function admin_setting_configtext_trim::write_setting is not documented
(#17) File-level phpdocs block does not have @copyright tag
(#31) Class admin_setting_configtext_trim does not have @copyright tag
(#20) Package auth/saml is not valid
auth/saml/classes/admin_setting_configtextarea_trim.php
(#38) Function admin_setting_configtextarea_trim::write_setting is not documented
(#17) File-level phpdocs block does not have @copyright tag
(#31) Class admin_setting_configtextarea_trim does not have @copyright tag
(#20) Package auth/saml is not valid
auth/saml/classes/admin_setting_special_export_link.php
(#39) Variable auth_saml_admin_setting_export_link::$link is not documented
(#71) Phpdocs for function auth_saml_admin_setting_export_link::write_setting has incomplete parameters list
(#80) Phpdocs for function auth_saml_admin_setting_export_link::output_html has incomplete parameters list
(#17) File-level phpdocs block does not have @copyright tag
(#31) Class auth_saml_admin_setting_export_link does not have @copyright tag
(#20) Package auth/saml is not valid
auth/saml/classes/admin_setting_special_javascript.php
(#38) Function auth_saml_admin_setting_javascript::__construct is not documented
(#43) Function auth_saml_admin_setting_javascript::output_html is not documented
(#17) File-level phpdocs block does not have @copyright tag
(#31) Class auth_saml_admin_setting_javascript does not have @copyright tag
(#20) Package auth/saml is not valid
auth/saml/classes/admin_setting_special_link.php
(#39) Variable auth_saml_admin_setting_special_link::$link is not documented
(#73) Phpdocs for function auth_saml_admin_setting_special_link::write_setting has incomplete parameters list
(#82) Phpdocs for function auth_saml_admin_setting_special_link::output_html has incomplete parameters list
(#17) File-level phpdocs block does not have @copyright tag
(#31) Class auth_saml_admin_setting_special_link does not have @copyright tag
(#20) Package auth/saml is not valid
auth/saml/cli/create_courses.php
(#17) File-level phpdocs block does not have @copyright tag
(#20) Package auth/saml is not valid
auth/saml/cli/extract_old_course_mapping_table_data_to_csv.php
(#17) File-level phpdocs block does not have @copyright tag
(#20) Package auth/saml is not valid
auth/saml/cli/extract_old_role_mapping_table_data_to_csv.php
(#17) File-level phpdocs block does not have @copyright tag
(#20) Package auth/saml is not valid
auth/saml/cli/remove_course_mappings.php
(#17) File-level phpdocs block does not have @copyright tag
(#20) Package auth/saml is not valid
auth/saml/cli/sync_course_mapping.php
(#17) File-level phpdocs block does not have @copyright tag
(#20) Package auth/saml is not valid
auth/saml/cli/sync_role_mapping.php
(#17) File-level phpdocs block does not have @copyright tag
(#20) Package auth/saml is not valid
auth/saml/cli/sync_users.php
(#17) File-level phpdocs block does not have @copyright tag
(#20) Package auth/saml is not valid
auth/saml/course_and_role_mapping.php
(#17) File-level phpdocs block does not have @copyright tag
(#20) Package auth/saml is not valid
auth/saml/course_mappings_to_csv.php
(#17) File-level phpdocs block does not have @copyright tag
(#20) Package auth/saml is not valid
auth/saml/custom_hook.php
(#66) Function saml_hook_attribute_filter is not documented
(#115) Function saml_hook_user_exists is not documented
(#133) Function saml_hook_authorize_user is not documented
(#147) Function saml_hook_post_user_created is not documented
(#187) Function saml_hook_get_course_info is not documented
(#17) File-level phpdocs block does not have @copyright tag
(#20) Package auth/saml is not valid
auth/saml/db/upgrade.php
(#30) There is no description in phpdocs for function xmldb_auth_saml_upgrade
(#17) File-level phpdocs block does not have @copyright tag
(#20) Package auth/saml is not valid
auth/saml/error.php
(#34) Function auth_saml_error is not documented
(#92) Function auth_saml_log_error is not documented
(#111) Function auth_saml_log_info is not documented
(#126) Function auth_saml_decorate_log is not documented
(#17) File-level phpdocs block does not have @copyright tag
(#20) Package auth/saml is not valid
auth/saml/index.php
(#17) File-level phpdocs block does not have @copyright tag
(#20) Package auth/saml is not valid
auth/saml/lang/en/auth_saml.php
(#17) File-level phpdocs block does not have @copyright tag
(#20) Package auth/saml is not valid
auth/saml/lang/es/auth_saml.php
(#17) File-level phpdocs block does not have @copyright tag
(#20) Package auth/saml is not valid
auth/saml/lang/es_es/auth_saml.php
(#17) File-level phpdocs block does not have @copyright tag
(#20) Package auth/saml is not valid
auth/saml/locallib.php
(#79) Function get_role_mapping_for_sync is not documented
(#95) Function get_all_courses_available is not documented
(#104) Function get_course_mapping_for_sync is not documented
(#121) Function clean_values is not documented
(#128) Function convert_to_valid_setting_name is not documented
(#17) File-level phpdocs block does not have @copyright tag
(#34) Not recommended phpdocs tag @global used
(#20) Package auth/saml is not valid
auth/saml/login.php
(#17) File-level phpdocs block does not have @copyright tag
(#20) Package auth/saml is not valid
auth/saml/role_mappings_to_csv.php
(#17) File-level phpdocs block does not have @copyright tag
(#20) Package auth/saml is not valid
auth/saml/saml_config.php
(#1) File-level phpdocs block is not found
auth/saml/settings.php
(#33) Function save_in_saml_config_file is not documented
(#17) File-level phpdocs block does not have @copyright tag
(#20) Package auth/saml is not valid
auth/saml/utils.php
(#2) Empty line found after PHP open tag
(#3) File-level phpdocs block is not found
(#6) Not recommended phpdocs tag @global used
(#3) Package is not specified for function resolve_samlhookfile. It is also not specified in file-level phpdocs
auth/saml/version.php
(#17) File-level phpdocs block does not have @copyright tag
(#20) Package auth/saml is not valid

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]