Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(179 errors, 52 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/assign/submission/mahara/backup/moodle2/backup_assignsubmission_mahara_subplugin.class.php
(#45) Inline comments must start with a capital letter, digit or 3-dots sequence
(#46) Inline comments must end in full-stops, exclamation marks, or question marks
(#48) Line exceeds 132 characters; contains 136 characters
(#50) Inline comments must start with a capital letter, digit or 3-dots sequence
(#50) Inline comments must end in full-stops, exclamation marks, or question marks
(#54) Inline comments must start with a capital letter, digit or 3-dots sequence
(#54) Inline comments must end in full-stops, exclamation marks, or question marks
mod/assign/submission/mahara/backup/moodle2/restore_assignsubmission_mahara_subplugin.class.php
(#32) Expected MOODLE_INTERNAL check or config.php inclusion
(#47) Inline comments must end in full-stops, exclamation marks, or question marks
mod/assign/submission/mahara/classes/observers.php
(#33) Line indented incorrectly; expected at least 4 spaces, found 3
(#58) Expected 1 space before "=>"; 0 found
(#58) Expected 1 space after "=>"; 0 found
(#77) Line indented incorrectly; expected at least 4 spaces, found 3
(#101) Expected 1 space before "=>"; 0 found
(#101) Expected 1 space after "=>"; 0 found
(#114) Line indented incorrectly; expected at least 4 spaces, found 3
(#130) Usage of "$this" in static methods will cause runtime errors
(#130) "$this" can no longer be used in a plain function or method since PHP 7.1.
(#132) Line exceeds 132 characters; contains 140 characters
mod/assign/submission/mahara/db/access.php
(#25) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
mod/assign/submission/mahara/db/events.php
(#25) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
mod/assign/submission/mahara/db/upgrade.php
(#30) Expected MOODLE_INTERNAL check or config.php inclusion
(#72) Line exceeds 132 characters; contains 152 characters
(#73) Line exceeds 132 characters; contains 157 characters
(#91) Inline comments must end in full-stops, exclamation marks, or question marks
(#100) Inline comments must end in full-stops, exclamation marks, or question marks
(#131) Inline comments must end in full-stops, exclamation marks, or question marks
(#134) Expected 1 space before "=>"; 0 found
(#134) Expected 1 space after "=>"; 0 found
(#143) Line exceeds maximum limit of 180 characters; contains 188 characters
(#146) Expected "} else {\n"; found "}\n else {\n"
(#146) Empty ELSE statement detected
(#168) Line exceeds 132 characters; contains 177 characters
mod/assign/submission/mahara/lib.php
(#67) Expected 1 space before "=>"; 0 found
(#67) Expected 1 space after "=>"; 0 found
mod/assign/submission/mahara/locallib.php
(#38) Inline comments must end in full-stops, exclamation marks, or question marks
(#41) Inline comments must end in full-stops, exclamation marks, or question marks
(#45) Inline comments must end in full-stops, exclamation marks, or question marks
(#57) Line indented incorrectly; expected at least 4 spaces, found 3
(#67) Expected 1 space before "=>"; 0 found
(#67) Expected 1 space after "=>"; 0 found
(#86) Inline comments must end in full-stops, exclamation marks, or question marks
(#92) Inline comments must end in full-stops, exclamation marks, or question marks
(#96) Inline comments must end in full-stops, exclamation marks, or question marks
(#97) Line exceeds 132 characters; contains 134 characters
(#101) Inline comments must end in full-stops, exclamation marks, or question marks
(#107) Line exceeds 132 characters; contains 145 characters
(#113) Line exceeds maximum limit of 180 characters; contains 187 characters
(#163) Expected "} else {\n"; found "}\n else {\n"
(#178) Spaces must be used to indent lines; tabs are not allowed
(#178) Tab found within whitespace
(#178) Inline comments must end in full-stops, exclamation marks, or question marks
(#178) Line indented incorrectly; expected at least 8 spaces, found 5
(#179) Spaces must be used to indent lines; tabs are not allowed
(#179) Tab found within whitespace
(#179) Line indented incorrectly; expected 8 spaces, found 5
(#180) Spaces must be used to indent lines; tabs are not allowed
(#180) Tab found within whitespace
(#180) Line indented incorrectly; expected 12 spaces, found 9
(#181) Spaces must be used to indent lines; tabs are not allowed
(#181) Tab found within whitespace
(#182) Spaces must be used to indent lines; tabs are not allowed
(#182) Tab found within whitespace
(#183) Spaces must be used to indent lines; tabs are not allowed
(#183) Tab found within whitespace
(#184) Spaces must be used to indent lines; tabs are not allowed
(#184) Tab found within whitespace
(#185) Spaces must be used to indent lines; tabs are not allowed
(#185) Tab found within whitespace
(#186) Spaces must be used to indent lines; tabs are not allowed
(#186) Tab found within whitespace
(#187) Spaces must be used to indent lines; tabs are not allowed
(#187) Tab found within whitespace
(#187) Line indented incorrectly; expected at least 15 spaces, found 9
(#188) Spaces must be used to indent lines; tabs are not allowed
(#188) Tab found within whitespace
(#188) Line indented incorrectly; expected at least 19 spaces, found 13
(#189) Spaces must be used to indent lines; tabs are not allowed
(#189) Tab found within whitespace
(#189) Line indented incorrectly; expected at least 19 spaces, found 13
(#190) Spaces must be used to indent lines; tabs are not allowed
(#190) Tab found within whitespace
(#190) Line indented incorrectly; expected at least 19 spaces, found 13
(#191) Spaces must be used to indent lines; tabs are not allowed
(#191) Tab found within whitespace
(#191) Line indented incorrectly; expected 12 spaces, found 9
(#192) Spaces must be used to indent lines; tabs are not allowed
(#192) Tab found within whitespace
(#192) Line indented incorrectly; expected 8 spaces, found 5
(#193) Spaces must be used to indent lines; tabs are not allowed
(#193) Tab found within whitespace
(#193) Inline comments must end in full-stops, exclamation marks, or question marks
(#193) Line indented incorrectly; expected at least 8 spaces, found 5
(#194) Spaces must be used to indent lines; tabs are not allowed
(#194) Tab found within whitespace
(#194) Line indented incorrectly; expected 8 spaces, found 5
(#195) Spaces must be used to indent lines; tabs are not allowed
(#195) Tab found within whitespace
(#195) Line indented incorrectly; expected 12 spaces, found 9
(#196) Spaces must be used to indent lines; tabs are not allowed
(#196) Tab found within whitespace
(#197) Spaces must be used to indent lines; tabs are not allowed
(#197) Tab found within whitespace
(#198) Spaces must be used to indent lines; tabs are not allowed
(#198) Tab found within whitespace
(#199) Spaces must be used to indent lines; tabs are not allowed
(#199) Tab found within whitespace
(#200) Spaces must be used to indent lines; tabs are not allowed
(#200) Tab found within whitespace
(#201) Spaces must be used to indent lines; tabs are not allowed
(#201) Tab found within whitespace
(#202) Spaces must be used to indent lines; tabs are not allowed
(#202) Tab found within whitespace
(#203) Spaces must be used to indent lines; tabs are not allowed
(#203) Tab found within whitespace
(#203) Line indented incorrectly; expected at least 15 spaces, found 9
(#204) Spaces must be used to indent lines; tabs are not allowed
(#204) Tab found within whitespace
(#204) Line indented incorrectly; expected at least 19 spaces, found 13
(#205) Spaces must be used to indent lines; tabs are not allowed
(#205) Tab found within whitespace
(#205) Line indented incorrectly; expected at least 19 spaces, found 13
(#206) Spaces must be used to indent lines; tabs are not allowed
(#206) Tab found within whitespace
(#206) Line indented incorrectly; expected 12 spaces, found 9
(#207) Spaces must be used to indent lines; tabs are not allowed
(#207) Tab found within whitespace
(#207) Line indented incorrectly; expected 8 spaces, found 5
(#208) Spaces must be used to indent lines; tabs are not allowed
(#208) Tab found within whitespace
(#208) Line indented incorrectly; expected at least 8 spaces, found 5
(#211) Expected 1 space before "=>"; 0 found
(#211) Expected 1 space after "=>"; 0 found
(#218) Line exceeds 132 characters; contains 136 characters
(#220) Inline comments must end in full-stops, exclamation marks, or question marks
(#260) Expected "} else {\n"; found "}\n else {\n"
(#295) Inline comments must end in full-stops, exclamation marks, or question marks
(#298) Inline comments must end in full-stops, exclamation marks, or question marks
(#300) Expected 1 space before "=>"; 0 found
(#300) Expected 1 space after "=>"; 0 found
(#300) Line exceeds 132 characters; contains 136 characters
(#347) Expected "} else {\n"; found "}\n else {\n"
(#348) Expected 1 space before "=>"; 0 found
(#348) Expected 1 space after "=>"; 0 found
(#386) "require_once" must be immediately followed by an open parenthesis
(#387) "require_once" must be immediately followed by an open parenthesis
(#401) Commas (,) must be followed by white space.
(#420) Line indented incorrectly; expected 4 spaces, found 5
(#424) Inline comments must end in full-stops, exclamation marks, or question marks
(#436) Inline comments must end in full-stops, exclamation marks, or question marks
(#462) Inline comments must end in full-stops, exclamation marks, or question marks
(#468) Inline comments must end in full-stops, exclamation marks, or question marks
(#502) Inline comments must end in full-stops, exclamation marks, or question marks
(#504) Line exceeds 132 characters; contains 140 characters
(#509) Inline comments must end in full-stops, exclamation marks, or question marks
(#512) Inline comments must end in full-stops, exclamation marks, or question marks
(#532) Functions must not contain multiple empty lines in a row; found 2 empty lines
(#573) Line exceeds 132 characters; contains 140 characters
(#602) Spaces must be used to indent lines; tabs are not allowed
(#602) Tab found within whitespace
(#602) Line indented incorrectly; expected at least 20 spaces, found 14
(#603) Spaces must be used to indent lines; tabs are not allowed
(#603) Tab found within whitespace
(#603) Line indented incorrectly; expected at least 20 spaces, found 14
(#604) Spaces must be used to indent lines; tabs are not allowed
(#604) Tab found within whitespace
(#604) Line indented incorrectly; expected at least 20 spaces, found 14
(#605) Spaces must be used to indent lines; tabs are not allowed
(#605) Tab found within whitespace
(#605) Line indented incorrectly; expected at least 20 spaces, found 14
(#606) Spaces must be used to indent lines; tabs are not allowed
(#606) Tab found within whitespace
(#606) Line indented incorrectly; expected at least 20 spaces, found 14
(#607) Spaces must be used to indent lines; tabs are not allowed
(#607) Tab found within whitespace
(#607) Line indented incorrectly; expected at least 20 spaces, found 14
(#608) Spaces must be used to indent lines; tabs are not allowed
(#608) Tab found within whitespace
(#608) Line indented incorrectly; expected at least 20 spaces, found 14
(#609) Spaces must be used to indent lines; tabs are not allowed
(#609) Tab found within whitespace
(#609) Line indented incorrectly; expected at least 20 spaces, found 14
(#613) Closing brace indented incorrectly; expected 5 spaces, found 4
(#640) Inline comments must end in full-stops, exclamation marks, or question marks
(#657) Line exceeds 132 characters; contains 136 characters
(#668) Expected 5 space(s) before asterisk; 6 found
(#669) Expected 5 space(s) before asterisk; 6 found
(#670) Expected 5 space(s) before asterisk; 6 found
(#671) Expected 5 space(s) before asterisk; 6 found
(#672) Expected 5 space(s) before asterisk; 6 found
(#673) Expected 5 space(s) before asterisk; 6 found
(#681) Inline comments must end in full-stops, exclamation marks, or question marks
(#691) Inline comments must end in full-stops, exclamation marks, or question marks
(#692) Line exceeds 132 characters; contains 145 characters
(#701) Expected 5 space(s) before asterisk; 6 found
(#702) Expected 5 space(s) before asterisk; 6 found
(#703) Expected 5 space(s) before asterisk; 6 found
(#704) Expected 5 space(s) before asterisk; 6 found
(#705) Expected 5 space(s) before asterisk; 6 found
(#706) Expected 5 space(s) before asterisk; 6 found
(#710) Inline comments must end in full-stops, exclamation marks, or question marks
(#731) Expected 5 space(s) before asterisk; 6 found
(#732) Expected 5 space(s) before asterisk; 6 found
(#733) Expected 5 space(s) before asterisk; 6 found
(#734) Expected 5 space(s) before asterisk; 6 found
(#735) Expected 5 space(s) before asterisk; 6 found
(#736) Expected 5 space(s) before asterisk; 6 found
(#741) Inline comments must end in full-stops, exclamation marks, or question marks
(#780) Expected 1 space before "=>"; 0 found
(#780) Expected 1 space after "=>"; 0 found
(#802) Variable "popup_icon" must not contain underscores.
(#808) Variable "popup_icon" must not contain underscores.
(#838) Inline comments must end in full-stops, exclamation marks, or question marks
(#839) Expected 1 space before "=>"; 0 found
(#839) Expected 1 space after "=>"; 0 found
(#859) Expected 6 space(s) before asterisk; 5 found
(#860) Expected 6 space(s) before asterisk; 5 found
(#861) Expected 6 space(s) before asterisk; 5 found
(#862) Expected 6 space(s) before asterisk; 5 found
(#863) Expected 6 space(s) before asterisk; 5 found
(#864) Expected 6 space(s) before asterisk; 5 found
(#929) Expected 1 space before "=>"; 0 found
(#929) Expected 1 space after "=>"; 0 found
(#963) Expected 1 space before "=>"; 0 found
(#963) Expected 1 space after "=>"; 0 found
mod/assign/submission/mahara/mnetlib.php
(#28) Expected MOODLE_INTERNAL check or config.php inclusion
mod/assign/submission/mahara/settings.php
(#11) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".
(#15) Line 14 of the opening comment must start "// along with Moodle. If not, see <http://www.gnu.org/licenses/>.".
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#24) "require_once" must be immediately followed by an open parenthesis
mod/assign/submission/mahara/version.php
(#28) Inline comments must end in full-stops, exclamation marks, or question marks

Javascript coding style problems

(4 errors, 3 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

mod/assign/submission/mahara/js/filter.js
(#26) There should be no spaces inside this paren. (space-in-parens)
(#36) Unnecessary semicolon. (no-extra-semi)
(#39) 'e' is defined but never used. (no-unused-vars)
mod/assign/submission/mahara/js/popup.js
(#24) Infix operators must be spaced. (space-infix-ops)
(#32) 'e' is defined but never used. (no-unused-vars)
(#54) Expected { after 'if' condition. (curly)
(#109) Expected space(s) after "for". (keyword-spacing)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(24 errors, 16 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

mod/assign/submission/mahara/backup/moodle2/backup_assignsubmission_mahara_subplugin.class.php
(#36) Class backup_assignsubmission_mahara_subplugin is not documented
mod/assign/submission/mahara/classes/event/assessable_uploaded.php
(#21) Inline phpdocs tag not enclosed with curly brackets @link found
(#39) Inline phpdocs tag not enclosed with curly brackets @link found
mod/assign/submission/mahara/classes/event/submission_created.php
(#21) Inline phpdocs tag not enclosed with curly brackets @link found
(#39) Inline phpdocs tag not enclosed with curly brackets @link found
mod/assign/submission/mahara/classes/event/submission_updated.php
(#21) Inline phpdocs tag not enclosed with curly brackets @link found
(#39) Inline phpdocs tag not enclosed with curly brackets @link found
mod/assign/submission/mahara/classes/observers.php
(#37) Phpdocs for function assignsubmission_mahara_observers::submission_graded has incomplete parameters list
(#81) Phpdocs for function assignsubmission_mahara_observers::workflow_state_updated has incomplete parameters list
(#28) Class assignsubmission_mahara_observers does not have @copyright tag
(#28) Class assignsubmission_mahara_observers does not have @license tag
mod/assign/submission/mahara/lang/en/assignsubmission_mahara.php
(#21) Inline phpdocs tag not enclosed with curly brackets @link found
mod/assign/submission/mahara/locallib.php
(#39) Constant assign_submission_mahara::STATUS_SELECTED is not documented
(#42) Constant assign_submission_mahara::STATUS_SUBMITTED is not documented
(#46) Constant assign_submission_mahara::STATUS_RELEASED is not documented
(#847) There is no description in phpdocs for function view_summary
(#318) Phpdocs for function assign_submission_mahara::mnet_submit_view has incomplete parameters list
(#671) Phpdocs for function assign_submission_mahara::lock has incomplete parameters list
(#704) Phpdocs for function assign_submission_mahara::unlock has incomplete parameters list
(#775) Phpdocs for function assign_submission_mahara::get_view_url has incomplete parameters list
(#60) Not recommended phpdocs tag @global used
(#73) Not recommended phpdocs tag @global used
(#73) Not recommended phpdocs tag @global used
(#277) Not recommended phpdocs tag @global used
(#317) Not recommended phpdocs tag @global used
(#356) Not recommended phpdocs tag @global used
(#370) Not recommended phpdocs tag @global used
(#415) Not recommended phpdocs tag @global used
(#633) Not recommended phpdocs tag @global used
(#670) Not recommended phpdocs tag @global used
(#703) Not recommended phpdocs tag @global used
(#733) Not recommended phpdocs tag @global used
(#814) Not recommended phpdocs tag @global used
(#814) Not recommended phpdocs tag @global used
(#923) Not recommended phpdocs tag @global used
(#942) Not recommended phpdocs tag @global used
mod/assign/submission/mahara/mnetlib.php
(#28) Class mnetservice_assign_submission_mahara is not documented
(#29) Function mnetservice_assign_submission_mahara::donothing is not documented
mod/assign/submission/mahara/settings.php
(#21) Inline phpdocs tag not enclosed with curly brackets @link found
(#20) Package assignsubmission_file is not valid

Update savepoints problems

(2 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]

mod/assign/submission/mahara/db/upgrade.php
Detected more 'if' blocks (5) than 'savepoint' calls (4)
version 2015021003 is missing corresponding savepoint call

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]