PHP lint problems
(0 errors, 0 warnings)
This section shows php lint problems in the code detected by php -l [More info]
PHP coding style problems
(28 errors, 24 warnings)
This section shows the coding style problems detected in the code by phpcs [More info]
- blocks/xp/ajax.php
- (#32) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
- blocks/xp/classes/form/duration.php
- (#62) Variable "elementName" must be all lower-case
- (#62) Variable "elementLabel" must be all lower-case
- (#66) Variable "elementName" must be all lower-case
- (#66) Variable "elementLabel" must be all lower-case
- (#77) Visibility must be declared on method "block_xp_form_duration"
- (#77) Variable "elementName" must be all lower-case
- (#77) Variable "elementLabel" must be all lower-case
- (#81) Variable "elementName" must be all lower-case
- (#81) Variable "elementLabel" must be all lower-case
- blocks/xp/classes/form/itemspertime.php
- (#68) Variable "elementName" must be all lower-case
- (#68) Variable "elementLabel" must be all lower-case
- (#71) Variable "elementName" must be all lower-case
- (#71) Variable "elementLabel" must be all lower-case
- (#82) Visibility must be declared on method "block_xp_form_itemspertime"
- (#82) Variable "elementName" must be all lower-case
- (#82) Variable "elementLabel" must be all lower-case
- (#85) Variable "elementName" must be all lower-case
- (#85) Variable "elementLabel" must be all lower-case
- (#137) method name "block_xp_form_itemspertime::_createElements" must be in lower-case letters only
- (#137) Visibility must be declared on method "_createElements"
- (#196) method name "block_xp_form_itemspertime::onQuickFormEvent" must be in lower-case letters only
- (#196) Visibility must be declared on method "onQuickFormEvent"
- (#270) method name "block_xp_form_itemspertime::exportValue" must be in lower-case letters only
- (#270) Visibility must be declared on method "exportValue"
- (#270) Variable "submitValues" must be all lower-case
- (#274) Variable "submitValues" must be all lower-case
- blocks/xp/classes/local/leaderboard/neighboured_leaderboard.php
- (#103) Expected 1 space after "="; 2 found
- (#108) Expected 1 space after "="; 2 found
- blocks/xp/config.php
- (#26) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
- blocks/xp/db/upgrade.php
- (#159) Line exceeds 132 characters; contains 139 characters
- (#174) Line exceeds 132 characters; contains 140 characters
- (#189) Line exceeds 132 characters; contains 134 characters
- (#204) Line exceeds 132 characters; contains 140 characters
- blocks/xp/index.php
- (#36) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
- blocks/xp/infos.php
- (#26) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
- blocks/xp/ladder.php
- (#26) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
- blocks/xp/lang/en/block_xp.php
- (#222) The use of backticks in strings is not recommended
- (#224) The use of backticks in strings is not recommended
- (#226) The use of backticks in strings is not recommended
- (#228) The use of backticks in strings is not recommended
- (#230) The use of backticks in strings is not recommended
- (#232) The use of backticks in strings is not recommended
- (#234) The use of backticks in strings is not recommended
- (#236) The use of backticks in strings is not recommended
- (#246) The use of backticks in strings is not recommended
- (#267) The use of backticks in strings is not recommended
- blocks/xp/levels.php
- (#26) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
- blocks/xp/log.php
- (#26) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
- blocks/xp/report.php
- (#26) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
- blocks/xp/rules.php
- (#26) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
- blocks/xp/visuals.php
- (#26) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
Javascript coding style problems
(0 errors, 20 warnings)
This section shows the coding style problems detected in the code by eslint [More info]
- blocks/xp/yui/src/filters/js/dnd.js
- (#49) Unexpected @return tag; function has no return statement. (valid-jsdoc)
- (#95) Identifier 'global_drop_over' is not in camel case. (camelcase)
- (#121) Identifier 'drag_end' is not in camel case. (camelcase)
- (#130) Identifier 'drop_hit' is not in camel case. (camelcase)
- (#139) Identifier 'drop_over' is not in camel case. (camelcase)
- (#143) Unexpected @return tag; function has no return statement. (valid-jsdoc)
- blocks/xp/yui/src/filters/js/filters.js
- (#84) Unexpected @return tag; function has no return statement. (valid-jsdoc)
- (#122) Unexpected @return tag; function has no return statement. (valid-jsdoc)
- (#142) Unexpected @return tag; function has no return statement. (valid-jsdoc)
- (#159) Unexpected @return tag; function has no return statement. (valid-jsdoc)
- (#179) Unexpected @return tag; function has no return statement. (valid-jsdoc)
- (#201) Unexpected @return tag; function has no return statement. (valid-jsdoc)
- (#226) Closing curly brace does not appear on the same line as the subsequent block. (brace-style)
- (#232) Closing curly brace does not appear on the same line as the subsequent block. (brace-style)
- (#237) Closing curly brace does not appear on the same line as the subsequent block. (brace-style)
- (#249) Unexpected @return tag; function has no return statement. (valid-jsdoc)
- (#344) Unexpected @return tag; function has no return statement. (valid-jsdoc)
- (#363) Unexpected @return tag; function has no return statement. (valid-jsdoc)
- (#382) Unexpected @return tag; function has no return statement. (valid-jsdoc)
- (#382) Missing JSDoc for parameter 'filterNode'. (valid-jsdoc)
CSS problems
(18 errors, 0 warnings)
This section shows CSS problems detected by stylelint [More info]
- blocks/xp/styles.css
- (#101) Unexpected duplicate "display" (declaration-block-no-duplicate-properties)
- (#102) Unexpected duplicate "display" (declaration-block-no-duplicate-properties)
- (#192) Unexpected duplicate "background-image" (declaration-block-no-duplicate-properties)
- (#193) Unexpected duplicate "background-image" (declaration-block-no-duplicate-properties)
- (#194) Unexpected duplicate "background-image" (declaration-block-no-duplicate-properties)
- (#195) Unexpected duplicate "background-image" (declaration-block-no-duplicate-properties)
- (#197) Expected "DXImageTransform.Microsoft.gradient" to be "dximagetransform.microsoft.gradient" (function-name-case)
- (#14) Expected indentation of 4 spaces (indentation)
- (#15) Expected indentation of 4 spaces (indentation)
- (#16) Expected indentation of 4 spaces (indentation)
- (#17) Expected indentation of 4 spaces (indentation)
- (#18) Expected indentation of 4 spaces (indentation)
- (#64) Expected indentation of 4 spaces (indentation)
- (#65) Expected indentation of 4 spaces (indentation)
- (#66) Expected indentation of 4 spaces (indentation)
- (#67) Expected indentation of 4 spaces (indentation)
- (#68) Expected indentation of 4 spaces (indentation)
- (#356) Expected newline after "," (selector-list-comma-newline-after)
PHPDocs style problems
(130 errors, 0 warnings)
This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]
- blocks/xp/backup/moodle2/backup_xp_block_task.class.php
- (#67) Phpdocs for function backup_xp_block_task::encode_content_links has incomplete parameters list
- blocks/xp/backup/moodle2/restore_xp_stepslib.php
- (#74) Phpdocs for function restore_xp_block_structure_step::process_block has incomplete parameters list
- (#81) Phpdocs for function restore_xp_block_structure_step::process_config has incomplete parameters list
- (#100) Phpdocs for function restore_xp_block_structure_step::process_filter has incomplete parameters list
- (#109) Phpdocs for function restore_xp_block_structure_step::process_log has incomplete parameters list
- (#119) Phpdocs for function restore_xp_block_structure_step::process_xp has incomplete parameters list
- blocks/xp/classes/filter.php
- (#317) Phpdocs for function block_xp_filter::validate_ruledata has incomplete parameters list
- blocks/xp/classes/form/config.php
- (#224) Phpdocs for function config::set_data has incomplete parameters list
- blocks/xp/classes/form/promo.php
- (#43) Function promo::definition is not documented
- blocks/xp/classes/form/visuals.php
- (#41) Function visuals::definition is not documented
- blocks/xp/classes/local/config/config.php
- (#55) Phpdocs for function has has incomplete parameters list
- blocks/xp/classes/local/controller/admin_levels_controller.php
- (#48) Function admin_levels_controller::post_login is not documented
- (#53) Function admin_levels_controller::pre_content is not documented
- (#74) Function admin_levels_controller::get_form is not documented
- (#81) Function admin_levels_controller::content is not documented
- blocks/xp/classes/local/controller/admin_rules_controller.php
- (#51) Function admin_rules_controller::define_optional_params is not documented
- (#58) Function admin_rules_controller::pre_content is not documented
- blocks/xp/classes/local/controller/admin_visuals_controller.php
- (#106) Function admin_visuals_controller::pre_content is not documented
- blocks/xp/classes/local/controller/config_controller.php
- (#75) Function config_controller::pre_content is not documented
- (#117) Function config_controller::get_page_html_head_title is not documented
- (#121) Function config_controller::get_page_heading is not documented
- (#125) Function config_controller::page_content is not documented
- blocks/xp/classes/local/controller/infos_controller.php
- (#48) Function infos_controller::permissions_checks is not documented
- (#55) Function infos_controller::get_page_html_head_title is not documented
- (#59) Function infos_controller::get_page_heading is not documented
- (#63) Function infos_controller::page_content is not documented
- (#45) Variable infos_controller::$requiremanage is not documented
- (#46) Variable infos_controller::$routename is not documented
- blocks/xp/classes/local/controller/ladder_controller.php
- (#45) Function ladder_controller::permissions_checks is not documented
- (#52) Function ladder_controller::page_setup is not documented
- (#88) Function ladder_controller::get_page_html_head_title is not documented
- (#92) Function ladder_controller::get_page_heading is not documented
- (#96) Function ladder_controller::page_content is not documented
- (#41) Variable ladder_controller::$requiremanage is not documented
- (#42) Variable ladder_controller::$supportsgroups is not documented
- (#43) Variable ladder_controller::$routename is not documented
- blocks/xp/classes/local/controller/levels_controller.php
- (#45) Function levels_controller::pre_content is not documented
- (#77) Function levels_controller::get_form is not documented
- (#86) Function levels_controller::get_page_html_head_title is not documented
- (#90) Function levels_controller::get_page_heading is not documented
- (#94) Function levels_controller::page_content is not documented
- blocks/xp/classes/local/controller/log_controller.php
- (#44) Function log_controller::get_table is not documented
- (#53) Function log_controller::get_page_html_head_title is not documented
- (#57) Function log_controller::get_page_heading is not documented
- (#61) Function log_controller::page_content is not documented
- (#41) Variable log_controller::$routename is not documented
- (#42) Variable log_controller::$supportsgroups is not documented
- blocks/xp/classes/local/controller/promo_controller.php
- (#60) Function promo_controller::define_optional_params is not documented
- (#76) Function promo_controller::require_login is not documented
- (#86) Function promo_controller::post_login is not documented
- (#121) Function promo_controller::content is not documented
- blocks/xp/classes/local/controller/report_controller.php
- (#53) Function report_controller::define_optional_params is not documented
- (#63) Function report_controller::pre_content is not documented
- (#95) Function report_controller::get_page_html_head_title is not documented
- (#99) Function report_controller::get_page_heading is not documented
- (#103) Function report_controller::get_form is not documented
- (#113) Function report_controller::get_table is not documented
- (#127) Function report_controller::page_content is not documented
- blocks/xp/classes/local/controller/route_controller.php
- (#199) Phpdocs for function route_controller::handle has incomplete parameters list
- blocks/xp/classes/local/controller/rules_controller.php
- (#57) Function rules_controller::post_login is not documented
- (#63) Function rules_controller::pre_content is not documented
- (#78) Function rules_controller::save_filters is not documented
- (#110) Function rules_controller::get_page_html_head_title is not documented
- (#114) Function rules_controller::get_page_heading is not documented
- (#166) Function rules_controller::page_content is not documented
- blocks/xp/classes/local/controller/visuals_controller.php
- (#94) Function visuals_controller::pre_content is not documented
- (#149) Function visuals_controller::get_page_html_head_title is not documented
- (#153) Function visuals_controller::get_page_heading is not documented
- (#166) Function visuals_controller::page_content is not documented
- blocks/xp/classes/local/course_world.php
- (#93) Function course_world::get_access_permissions is not documented
- (#97) Function course_world::get_config is not documented
- (#101) Function course_world::get_collection_strategy is not documented
- (#164) Function course_world::get_levels_info is not documented
- (#188) Function course_world::get_store is not documented
- (#72) Phpdocs for function course_world::__construct has incomplete parameters list
- blocks/xp/classes/local/factory/default_course_world_factory.php
- (#57) Phpdocs for function default_course_world_factory::__construct has incomplete parameters list
- blocks/xp/classes/local/factory/default_course_world_navigation_factory.php
- (#51) Phpdocs for function default_course_world_navigation_factory::__construct has incomplete parameters list
- blocks/xp/classes/local/indicator/prefs_user_indicator.php
- (#122) Phpdocs for function prefs_user_indicator::user_has_flag has incomplete parameters list
- blocks/xp/classes/local/indicator/proxy_user_indicator.php
- (#100) Phpdocs for function proxy_user_indicator::user_has_flag has incomplete parameters list
- blocks/xp/classes/local/indicator/user_indicator.php
- (#77) Phpdocs for function user_has_flag has incomplete parameters list
- blocks/xp/classes/local/leaderboard/anonymised_leaderboard.php
- (#75) Phpdocs for function anonymised_leaderboard::anonymise_rank has incomplete parameters list
- blocks/xp/classes/local/leaderboard/neighboured_leaderboard.php
- (#53) Phpdocs for function neighboured_leaderboard::__construct has incomplete parameters list
- blocks/xp/classes/local/observer/default_observer_rules_maker.php
- (#39) Function default_observer_rules_maker::get_observer_rules is not documented
- blocks/xp/classes/local/task/default_tasks_definition_maker.php
- (#39) Function default_tasks_definition_maker::get_tasks_definition is not documented
- blocks/xp/classes/local/xp/algo_levels_info.php
- (#175) Function algo_levels_info::load is not documented
- (#200) Phpdocs for function algo_levels_info::make_from_defaults has incomplete parameters list
- blocks/xp/classes/local/xp/course_user_state_store.php
- (#66) Phpdocs for function course_user_state_store::__construct has incomplete parameters list
- blocks/xp/classes/local/xp/course_user_state_store_leaderboard.php
- (#143) Phpdocs for function course_user_state_store_leaderboard::get_rank has incomplete parameters list
- blocks/xp/classes/local/xp/user_state.php
- (#65) Function user_state::get_id is not documented
- (#69) Function user_state::get_level is not documented
- (#76) Function user_state::get_ratio_in_level is not documented
- (#84) Function user_state::get_total_xp_in_level is not documented
- (#103) Function user_state::get_xp is not documented
- (#107) Function user_state::get_xp_in_level is not documented
- blocks/xp/classes/manager.php
- (#112) Phpdocs for function block_xp_manager::can_capture_event has incomplete parameters list
- (#382) Phpdocs for function block_xp_manager::recalculate_levels has incomplete parameters list
- blocks/xp/classes/output/dismissable_notice.php
- (#43) Function dismissable_notice::__construct is not documented
- (#41) Variable dismissable_notice::$name is not documented
- blocks/xp/classes/output/filters_widget.php
- (#56) Phpdocs for function filters_widget::__construct has incomplete parameters list
- blocks/xp/classes/output/leaderboard_table.php
- (#120) Phpdocs for function leaderboard_table::out has incomplete parameters list
- blocks/xp/classes/output/notice.php
- (#52) Function notice::__construct is not documented
- (#48) Variable notice::$message is not documented
- (#49) Variable notice::$name is not documented
- (#50) Variable notice::$type is not documented
- (#43) Constant notice::SUCCESS is not documented
- (#44) Constant notice::WARNING is not documented
- (#45) Constant notice::INFO is not documented
- (#46) Constant notice::ERROR is not documented
- blocks/xp/classes/output/xp_widget.php
- (#61) Function xp_widget::__construct is not documented
- (#76) Function xp_widget::add_manager_notice is not documented
- (#80) Function xp_widget::set_force_recent_activity is not documented
- blocks/xp/classes/task/collection_logger_purge.php
- (#41) Function collection_logger_purge::get_name is not documented
- (#45) Function collection_logger_purge::execute is not documented
- blocks/xp/db/shortcodes.php
- (#20) Package filter_shortcodes is not valid
- blocks/xp/renderer.php
- (#70) Phpdocs for function block_xp_renderer::level_badge_with_options has incomplete parameters list
- (#465) Phpdocs for function block_xp_renderer::render_filters_widget has incomplete parameters list
- (#616) Phpdocs for function block_xp_renderer::render_xp_widget has incomplete parameters list
- blocks/xp/tests/base_testcase.php
- (#38) Function block_xp_base_testcase::setUp is not documented
- (#43) Function block_xp_base_testcase::reset_container is not documented
- blocks/xp/tests/course_world_test.php
- (#40) Function block_xp_course_world_testcase::get_world is not documented
- blocks/xp/tests/filters_test.php
- (#42) Function block_xp_filters_testcase::get_filter_manager is not documented
- blocks/xp/tests/fixtures/events.php
- (#28) Class something_happened is not documented
- (#29) Function something_happened::init is not documented
- (#32) Function something_happened::mock is not documented
- (#20) Package core is not valid
- blocks/xp/tests/leaderboard_test.php
- (#48) Function block_xp_leaderboard_testcase::get_leaderboard is not documented
- (#60) Function block_xp_leaderboard_testcase::get_world is not documented
- (#391) Function block_xp_leaderboard_testcase::assert_ranking is not documented
- blocks/xp/tests/privacy_provider_test.php
- (#58) Function block_xp_privacy_provider_testcase::get_world is not documented
- (#330) Function block_xp_privacy_provider_testcase::assert_contextlist_equals is not documented
Update savepoints problems
(0 errors, 0 warnings)
This section shows problems detected with the handling of upgrade savepoints [More info]
Third party library modification problems
(0 errors, 0 warnings)
This section shows problems detected with the modification of third party libraries [More info]
grunt changes
(1 errors, 1 warnings)
This section shows files built by grunt and not commited [More info]
- Task "stylelint:css" failed. Use --force to continue.
- Problems running grunt
shifter problems
(0 errors, 0 warnings)
This section shows problems detected by shifter [More info]
Mustache template problems
(0 errors, 0 warnings)
This section shows problems detected in mustache templates [More info]