Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(14 errors, 6 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

blocks/progress/backup/moodle2/backup_html_block_task.class.php
(#32) Expected MOODLE_INTERNAL check or config.php inclusion
blocks/progress/backup/moodle2/restore_progress_block_task.class.php
(#32) Expected MOODLE_INTERNAL check or config.php inclusion
blocks/progress/block_progress.php
(#27) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
(#212) Expected "} else {\n"; found "}\n\n // Gather content for block on regular course.\n else {\n"
blocks/progress/db/upgrade.php
(#45) Expected MOODLE_INTERNAL check or config.php inclusion
blocks/progress/edit_form.php
(#27) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
(#256) Expected "} else if (...) {\n"; found "}\n\n // If positioned in a weekly format, use 5min before end of week.\n else if (...) {\n"
(#261) Expected "} else {\n"; found "}\n\n // Assume 5min before the end of the current week.\n else {\n"
(#429) Expected "} else {\n"; found "}\n\n // When there are no activities that can be monitored, prompt teacher to create some.\n else {\n"
blocks/progress/lib.php
(#76) Expected MOODLE_INTERNAL check or config.php inclusion
(#1289) Expected "} else if (...) {\n"; found "}\n\n // Checked view actions in the log table/store/cache.\n else if (...) {\n"
(#1298) Expected "} else {\n"; found "}\n\n // Check in the logs.\n else {\n"
(#1341) Expected "} else {\n"; found "}\n\n // Determine the set action and develop a query.\n else {\n"
(#1342) Expected 1 space after "?"; newline found
(#1343) Expected 1 space after ":"; newline found
(#1491) Expected 1 space after "?"; newline found
(#1492) Expected 1 space after ":"; newline found
(#1580) Expected 1 space after "?"; newline found
(#1581) Expected 1 space after ":"; newline found
blocks/progress/version.php
(#27) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.

Javascript coding style problems

(6 errors, 22 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

blocks/progress/module.js
(#1) Identifier 'block_progress' is not in camel case. (camelcase)
(#5) Unexpected space before function parentheses. (space-before-function-paren)
(#13) 'e' is defined but never used (no-unused-vars)
(#13) Requires a space after '{'. (block-spacing)
(#13) Statement inside of curly braces should be on next line. (brace-style)
(#13) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
(#13) Requires a space before '}'. (block-spacing)
(#16) Unexpected space before function parentheses. (space-before-function-paren)
(#26) Unexpected space before function parentheses. (space-before-function-paren)
(#32) A space is required after ','. (comma-spacing)
(#40) 'YUIObject' is defined but never used (no-unused-vars)
(#48) Expected space(s) after "if". (keyword-spacing)
(#53) Expected space(s) after "if". (keyword-spacing)
(#55) Line 55 exceeds the maximum line length of 132. (max-len)
(#55) Requires a space after '{'. (block-spacing)
(#55) Statement inside of curly braces should be on next line. (brace-style)
(#55) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
(#55) This line has too many statements. Maximum allowed is 2. (max-statements-per-line)
(#55) Requires a space before '}'. (block-spacing)
(#55) Missing semicolon. (semi)
(#56) Line 56 exceeds the maximum line length of 132. (max-len)
(#56) Requires a space after '{'. (block-spacing)
(#56) Statement inside of curly braces should be on next line. (brace-style)
(#56) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
(#56) This line has too many statements. Maximum allowed is 2. (max-statements-per-line)
(#56) Requires a space before '}'. (block-spacing)
(#56) Missing semicolon. (semi)
(#96) Closing curly brace does not appear on the same line as the subsequent block. (brace-style)

CSS problems

(0 errors, 7 warnings)

This section shows CSS problems detected by csslint [More info]

blocks/progress/styles.css
(#19) Unknown property 'fill'.
(#20) Unknown property 'stroke'.
(#21) Unknown property 'stroke-width'.
(#74) Expected (<margin-width> | inherit) but found 'initial'.
(#85) Expected (<margin-width> | inherit) but found 'initial'.
(#182) Use of !important
(#205) margin can't be used with display: inline.

PHPDocs style problems

(27 errors, 2 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

blocks/progress/backup/moodle2/backup_html_block_task.class.php
(#34) Function backup_progress_block_task::define_my_settings is not documented
(#37) Function backup_progress_block_task::define_my_steps is not documented
(#40) Function backup_progress_block_task::get_fileareas is not documented
(#44) Function backup_progress_block_task::get_configdata_encoded_attributes is not documented
(#48) Function backup_progress_block_task::encode_content_links is not documented
(#17) No one-line description found in phpdocs for file
(#18) Package contrib is not valid
(#27) Package contrib is not valid
blocks/progress/backup/moodle2/restore_progress_block_task.class.php
(#17) No one-line description found in phpdocs for file
(#37) Not recommended phpdocs tag @global used
(#18) Package contrib is not valid
(#27) Package contrib is not valid
blocks/progress/block_progress.php
(#21) Package contrib is not valid
blocks/progress/db/access.php
(#20) Package contrib is not valid
blocks/progress/db/caches.php
(#20) Package contrib is not valid
blocks/progress/db/upgrade.php
(#40) There is no description in phpdocs for function xmldb_block_progress_upgrade
(#41) Not recommended phpdocs tag @global used
(#34) Package contrib is not valid
blocks/progress/edit_form.php
(#38) Function block_progress_edit_form::specific_definition is not documented
(#21) Package contrib is not valid
blocks/progress/lang/en/block_progress.php
(#20) Package contrib is not valid
blocks/progress/lib.php
(#1091) Phpdocs for function block_progress_modules_in_use has incomplete parameters list
(#1383) Phpdocs for function block_progress_bar has incomplete parameters list
(#1644) Phpdocs for function block_progress_course_sections has incomplete parameters list
(#1754) Phpdocs for function block_progress_get_block_context has incomplete parameters list
(#1768) Phpdocs for function block_progress_get_coursemodule has incomplete parameters list
(#54) Package contrib is not valid
blocks/progress/overview.php
(#21) Package contrib is not valid
blocks/progress/version.php
(#21) Package contrib is not valid

Update savepoints problems

(2 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]

blocks/progress/db/upgrade.php
Detected more 'if' blocks (1) than 'savepoint' calls (0)
version 2015111200 is missing corresponding savepoint call

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]