Comments

• 

  Plugins bot

  Thu, 3 Sept 2015, 2:42 AM

  Prechecker results: 245 errors/80 warnings
  http://integration.moodle.org/job/Precheck%20remote%20branch/15894/artifact/work/smurf.html
• 

  David Mudrák

  Thu, 3 Sept 2015, 4:11 AM

  Hi Mikhail. Thanks for sharing this plugin with the community. While reviewing the code, I spotted couple of not-really-serious issues and reported them into your tracker. I also asked our plagiarism API expert Dan Marsden for a peer-review of your code so he might provide you with more valuable feedback. Thanks for your patience with the review and approval process.

• 

  Dan Marsden

  Thu, 3 Sept 2015, 6:12 AM

  Thanks David - personally I think issues #1 and #4 should block approval, I also think the overall quality of the code should be improved before we accept this. Especially as there is a commercial aspect to this plugin the expectations of code quality and stability should be quite high.
  
  The bigger issue I have is that this plugin relies on the legacy logs feature being enabled which has been deprecated since Moodle 2.7 - this is not documented within the plugin and I don't think we should approve any new plugins in the official repository that rely on deprecated functions. I have previously communicated this to Unplag and provided examples of the correct usage of the new events api.
• 

  David Mudrák

  Thu, 3 Sept 2015, 6:23 AM

  Thanks Dan for the comments. I agree and I believe Mikhail will be happy to improve the plugin according these suggestions. Marking as needing more work for now.

• 

  Ben Larson

  Thu, 3 Sept 2015, 11:12 PM

  I fixed all issues created on github bug tracker. I'll implement new events api in next release of the plugin.
• 

  Dan Marsden

  Wed, 9 Sept 2015, 9:19 AM

  Thanks, please let us know when you have resolved the issues with the legacy logs and we will take another look.