Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(224 errors, 8 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

plagiarism/compilatio/admin_forms.php
(#38) Opening brace must not be followed by a blank line
(#63) Opening parenthesis of a multi-line function call must be the last content on the line
(#63) Only one argument is allowed per line in a multi-line function call
(#64) Multi-line function call not indented correctly; expected 12 spaces but found 27
(#65) Multi-line function call not indented correctly; expected 8 spaces but found 27
(#65) Closing parenthesis of a multi-line function call must be on a line by itself
(#85) Opening parenthesis of a multi-line function call must be the last content on the line
(#85) Only one argument is allowed per line in a multi-line function call
(#86) Multi-line function call not indented correctly; expected 8 spaces but found 27
(#86) Closing parenthesis of a multi-line function call must be on a line by itself
(#94) Opening parenthesis of a multi-line function call must be the last content on the line
(#94) Only one argument is allowed per line in a multi-line function call
(#95) Multi-line function call not indented correctly; expected 16 spaces but found 20
(#95) Closing parenthesis of a multi-line function call must be on a line by itself
(#115) Opening parenthesis of a multi-line function call must be the last content on the line
(#116) Multi-line function call not indented correctly; expected 8 spaces but found 12
(#116) Only one argument is allowed per line in a multi-line function call
(#116) Only one argument is allowed per line in a multi-line function call
(#116) Only one argument is allowed per line in a multi-line function call
(#116) Closing parenthesis of a multi-line function call must be on a line by itself
(#117) Opening parenthesis of a multi-line function call must be the last content on the line
(#119) Multi-line function call not indented correctly; expected 8 spaces but found 12
(#119) Closing parenthesis of a multi-line function call must be on a line by itself
(#120) Opening parenthesis of a multi-line function call must be the last content on the line
(#121) Multi-line function call not indented correctly; expected 8 spaces but found 12
(#121) Only one argument is allowed per line in a multi-line function call
(#121) Only one argument is allowed per line in a multi-line function call
(#121) Only one argument is allowed per line in a multi-line function call
(#121) Closing parenthesis of a multi-line function call must be on a line by itself
(#122) Opening parenthesis of a multi-line function call must be the last content on the line
(#124) Multi-line function call not indented correctly; expected 8 spaces but found 12
(#124) Closing parenthesis of a multi-line function call must be on a line by itself
(#132) The closing brace for the class must go on the next line after the body
(#139) Each class must be in a file by itself
(#139) Opening brace must not be followed by a blank line
(#157) Each class must be in a file by itself
(#157) Opening brace must not be followed by a blank line
plagiarism/compilatio/admin_tab_default_settings.php
(#27) Expected at least 1 space before "."; 0 found
(#27) Expected at least 1 space after "."; 0 found
(#28) Expected at least 1 space before "."; 0 found
(#28) Expected at least 1 space after "."; 0 found
(#29) Expected at least 1 space before "."; 0 found
(#29) Expected at least 1 space after "."; 0 found
plagiarism/compilatio/admin_tab_export_compilatio_database_tables.php
(#27) Expected at least 1 space before "."; 0 found
(#27) Expected at least 1 space after "."; 0 found
plagiarism/compilatio/admin_tabs.php
(#42) Expected at least 1 space before "."; 0 found
plagiarism/compilatio/ajax/set_indexing_state.php
(#47) Short form type keywords must be used. Found: (boolean)
plagiarism/compilatio/ajax/start_analysis.php
(#69) Expected 1 blank line at end of file; 3 found
plagiarism/compilatio/ajax/start_multiple_analyses.php
(#111) Expected at least 1 space before "."; 0 found
(#111) Expected at least 1 space after "."; 0 found
(#111) Expected at least 1 space before "."; 0 found
(#111) Expected at least 1 space after "."; 0 found
plagiarism/compilatio/backup/moodle2/backup_plagiarism_compilatio_plugin.class.php
(#29) Opening brace must not be followed by a blank line
plagiarism/compilatio/backup/moodle2/restore_plagiarism_compilatio_plugin.class.php
(#29) Opening brace must not be followed by a blank line
(#78) Function closing brace must go on the next line following the body; found 1 blank lines before brace
plagiarism/compilatio/classes/compilatio/analysis.php
(#53) Blank line found at end of control structure
(#56) Blank line found at end of control structure
(#59) Blank line found at end of control structure
(#60) Blank line found at start of control structure
(#62) The first expression of a multi-line control structure must be on the line after the opening parenthesis
(#63) The closing parenthesis of a multi-line control structure must be on the line after the last expression
(#70) Blank line found at end of control structure
(#139) Blank line found at end of control structure
plagiarism/compilatio/classes/compilatio/api.php
(#1043) The first expression of a multi-line control structure must be on the line after the opening parenthesis
(#1046) Each line in a multi-line control structure must be indented at least once; expected at least 12 spaces, but found 8
(#1046) The closing parenthesis of a multi-line control structure must be on the line after the last expression
plagiarism/compilatio/classes/compilatio/course_module_settings.php
(#65) The first expression of a multi-line control structure must be on the line after the opening parenthesis
plagiarism/compilatio/classes/compilatio/csv_generator.php
(#33) Opening brace must not be followed by a blank line
(#103) Blank line found at start of control structure
(#127) Expected 1 space after FUNCTION keyword; 0 found
plagiarism/compilatio/classes/compilatio/event_handler.php
(#127) Blank line found at start of control structure
(#202) Blank line found at end of control structure
(#206) Expected at least 1 space before "."; 0 found
(#215) Blank line found at end of control structure
(#245) Blank line found at end of control structure
(#314) Blank line found at end of control structure
(#326) Blank line found at start of control structure
(#395) Multi-line function call not indented correctly; expected 12 spaces but found 24
(#396) Multi-line function call not indented correctly; expected 12 spaces but found 24
(#397) Multi-line function call not indented correctly; expected 12 spaces but found 24
(#398) Multi-line function call not indented correctly; expected 12 spaces but found 24
(#399) Multi-line function call not indented correctly; expected 12 spaces but found 24
(#400) Multi-line function call not indented correctly; expected 8 spaces but found 20
(#496) Blank line found at start of control structure
(#568) Blank line found at start of control structure
(#596) The first expression of a multi-line control structure must be on the line after the opening parenthesis
(#597) The closing parenthesis of a multi-line control structure must be on the line after the last expression
(#597) Blank line found at start of control structure
(#605) The first expression of a multi-line control structure must be on the line after the opening parenthesis
(#608) Each line in a multi-line control structure must be indented at least once; expected at least 16 spaces, but found 12
(#608) The closing parenthesis of a multi-line control structure must be on the line after the last expression
plagiarism/compilatio/classes/compilatio/file.php
(#40) Opening brace must not be followed by a blank line
(#82) The first expression of a multi-line control structure must be on the line after the opening parenthesis
(#87) Multi-line function call not indented correctly; expected 8 spaces but found 12
(#87) Closing parenthesis of a multi-line function call must be on a line by itself
(#88) Expected 0 spaces before closing parenthesis; newline found
(#95) The first expression of a multi-line control structure must be on the line after the opening parenthesis
(#203) Expected 0 spaces before closing parenthesis; newline found
(#271) Opening parenthesis of a multi-line function call must be the last content on the line
(#275) Multi-line function call not indented correctly; expected 12 spaces but found 16
(#275) Closing parenthesis of a multi-line function call must be on a line by itself
(#391) Multi-line function declaration not indented correctly; expected 8 spaces but found 12
(#392) Multi-line function declaration not indented correctly; expected 8 spaces but found 12
(#393) Multi-line function declaration not indented correctly; expected 8 spaces but found 12
(#394) Multi-line function declaration not indented correctly; expected 8 spaces but found 12
(#395) Multi-line function declaration not indented correctly; expected 8 spaces but found 12
(#396) Multi-line function declaration not indented correctly; expected 8 spaces but found 12
(#397) Multi-line function declaration not indented correctly; expected 4 spaces but found 8
(#440) Blank line found at start of control structure
plagiarism/compilatio/classes/compilatio/identifier.php
(#34) Opening brace must not be followed by a blank line
plagiarism/compilatio/classes/compilatio/submission.php
(#35) Opening brace must not be followed by a blank line
plagiarism/compilatio/classes/observer.php
(#31) Opening brace must not be followed by a blank line
(#39) Multi-line function declaration not indented correctly; expected 8 spaces but found 4
(#39) The closing parenthesis of a multi-line function declaration must be on a new line
(#56) Multi-line function declaration not indented correctly; expected 8 spaces but found 4
(#56) The closing parenthesis of a multi-line function declaration must be on a new line
(#73) Multi-line function declaration not indented correctly; expected 8 spaces but found 4
(#73) The closing parenthesis of a multi-line function declaration must be on a new line
(#88) Multi-line function declaration not indented correctly; expected 8 spaces but found 4
(#88) The closing parenthesis of a multi-line function declaration must be on a new line
(#103) The closing parenthesis of a multi-line function declaration must be on a new line
(#118) The closing parenthesis of a multi-line function declaration must be on a new line
(#133) The closing parenthesis of a multi-line function declaration must be on a new line
(#148) The closing parenthesis of a multi-line function declaration must be on a new line
(#163) The closing parenthesis of a multi-line function declaration must be on a new line
(#178) The closing parenthesis of a multi-line function declaration must be on a new line
(#193) The closing parenthesis of a multi-line function declaration must be on a new line
(#208) The closing parenthesis of a multi-line function declaration must be on a new line
(#223) The closing parenthesis of a multi-line function declaration must be on a new line
(#238) The closing parenthesis of a multi-line function declaration must be on a new line
(#253) The closing parenthesis of a multi-line function declaration must be on a new line
(#268) The closing parenthesis of a multi-line function declaration must be on a new line
(#283) The closing parenthesis of a multi-line function declaration must be on a new line
(#298) The closing parenthesis of a multi-line function declaration must be on a new line
(#313) The closing parenthesis of a multi-line function declaration must be on a new line
(#335) The closing brace for the class must go on the next line after the body
plagiarism/compilatio/classes/output/compilatio_frame.php
(#44) Opening brace must not be followed by a blank line
(#136) Blank line found at end of control structure
(#301) The first expression of a multi-line control structure must be on the line after the opening parenthesis
(#302) The closing parenthesis of a multi-line control structure must be on the line after the last expression
(#302) Blank line found at start of control structure
(#323) Opening parenthesis of a multi-line function call must be the last content on the line
(#323) Only one argument is allowed per line in a multi-line function call
(#324) Multi-line function call not indented correctly; expected 16 spaces but found 20
(#324) Closing parenthesis of a multi-line function call must be on a line by itself
(#339) Opening parenthesis of a multi-line function call must be the last content on the line
(#339) Only one argument is allowed per line in a multi-line function call
(#340) Multi-line function call not indented correctly; expected 16 spaces but found 20
(#340) Closing parenthesis of a multi-line function call must be on a line by itself
(#356) Expected at least 1 space before "."; 0 found
(#357) Expected at least 1 space before "."; 0 found
(#416) Expected at least 1 space after "."; 0 found
(#416) Expected at least 1 space before "."; 0 found
(#489) Opening parenthesis of a multi-line function call must be the last content on the line
(#489) Only one argument is allowed per line in a multi-line function call
(#490) Multi-line function call not indented correctly; expected 8 spaces but found 12
(#490) Closing parenthesis of a multi-line function call must be on a line by itself
(#519) Opening parenthesis of a multi-line function call must be the last content on the line
(#519) Only one argument is allowed per line in a multi-line function call
(#520) Multi-line function call not indented correctly; expected 8 spaces but found 12
(#520) Closing parenthesis of a multi-line function call must be on a line by itself
(#554) Opening parenthesis of a multi-line function call must be the last content on the line
(#554) Only one argument is allowed per line in a multi-line function call
(#555) Multi-line function call not indented correctly; expected 12 spaces but found 16
(#555) Closing parenthesis of a multi-line function call must be on a line by itself
(#572) Expected at least 1 space before "."; 0 found
(#596) Opening parenthesis of a multi-line function call must be the last content on the line
(#596) Only one argument is allowed per line in a multi-line function call
(#597) Multi-line function call not indented correctly; expected 8 spaces but found 12
(#597) Closing parenthesis of a multi-line function call must be on a line by itself
(#661) Expected 1 blank line at end of file; 2 found
plagiarism/compilatio/classes/output/document_frame.php
(#37) Opening brace must not be followed by a blank line
(#49) The first expression of a multi-line control structure must be on the line after the opening parenthesis
(#147) Blank line found at start of control structure
(#177) Only one argument is allowed per line in a multi-line function call
(#177) Only one argument is allowed per line in a multi-line function call
(#177) Only one argument is allowed per line in a multi-line function call
(#177) Only one argument is allowed per line in a multi-line function call
(#182) Multi-line function call not indented correctly; expected 12 spaces but found 16
(#182) Only one argument is allowed per line in a multi-line function call
(#182) Only one argument is allowed per line in a multi-line function call
(#182) Only one argument is allowed per line in a multi-line function call
(#182) Only one argument is allowed per line in a multi-line function call
(#182) Closing parenthesis of a multi-line function call must be on a line by itself
(#187) Multi-line function call not indented correctly; expected 12 spaces but found 16
(#187) Only one argument is allowed per line in a multi-line function call
(#187) Only one argument is allowed per line in a multi-line function call
(#187) Closing parenthesis of a multi-line function call must be on a line by itself
(#308) Blank line found at start of control structure
(#328) Expected at least 1 space after "."; 0 found
(#341) Blank line found at end of control structure
(#373) Blank line found at end of control structure
(#399) Blank line found at start of control structure
plagiarism/compilatio/classes/output/icons.php
(#31) Opening brace must not be followed by a blank line
plagiarism/compilatio/classes/output/statistics.php
(#96) Blank line found at end of control structure
(#116) Blank line found at end of control structure
(#137) Expected at least 1 space before "."; 0 found
(#137) Expected at least 1 space after "."; 0 found
(#347) Blank line found at start of control structure
(#574) Expected at least 1 space before "."; 0 found
(#574) Expected at least 1 space after "."; 0 found
(#591) Expected at least 1 space before "."; 0 found
plagiarism/compilatio/classes/privacy/provider.php
(#48) Opening brace must not be followed by a blank line
(#57) Duplicate interface name "plagiarism_compilatio\privacy\user_provider" found; first defined in /var/lib/jenkins/git_repositories/prechecker/plagiarism/compilatio/classes/privacy/provider.php on line 48
(#57) Each interface must be in a file by itself
(#57) Opening brace must not be followed by a blank line
(#67) Each interface must be in a file by itself
(#67) Opening brace must not be followed by a blank line
(#69) The first trait import statement must be declared on the first non-comment line after the class opening brace
(#69) Each imported trait must have its own "use" import statement
plagiarism/compilatio/classes/task/get_scores.php
(#33) Opening brace must not be followed by a blank line
plagiarism/compilatio/classes/task/trigger_analyses.php
(#33) Opening brace must not be followed by a blank line
plagiarism/compilatio/classes/task/update_meta.php
(#33) Opening brace must not be followed by a blank line
plagiarism/compilatio/db/upgrade.php
(#73) Blank line found at start of control structure
(#129) The first expression of a multi-line control structure must be on the line after the opening parenthesis
(#129) Opening parenthesis of a multi-line function call must be the last content on the line
(#130) Multi-line function call not indented correctly; expected 20 spaces but found 24
(#130) Closing parenthesis of a multi-line function call must be on a line by itself
(#130) The closing parenthesis of a multi-line control structure must be on the line after the last expression
(#212) Blank line found at start of control structure
plagiarism/compilatio/lang/en/plagiarism_compilatio.php
(#472) The string key "tabs_title_notifications" is not in the correct order, it should be before "tabs_title_technical_tools"
plagiarism/compilatio/lib.php
(#263) Blank line found at end of control structure
plagiarism/compilatio/settings.php
(#134) The first expression of a multi-line control structure must be on the line after the opening parenthesis
(#135) The closing parenthesis of a multi-line control structure must be on the line after the last expression
(#135) Blank line found at start of control structure
plagiarism/compilatio/tests/privacy/provider_test.php
(#26) PHPUnit class "plagiarism_compilatio\tests\privacy\provider_test", with namespace "plagiarism_compilatio\tests\privacy", currently located at "tests/privacy" directory, does not match its expected location at "tests/tests/privacy"
(#41) Unit test provider_test should be declared as final.
(#41) Opening brace must not be followed by a blank line
(#47) Test method test_get_metadata() is missing a return type
(#96) Test method test_get_contexts_for_userid() is missing a return type
(#119) Test method test_export_plagiarism_user_data() is missing a return type
(#147) Test method test_delete_plagiarism_for_user_owner_school() is missing a return type

Javascript coding style problems

(6 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

plagiarism/compilatio/amd/src/compilatio_ajax_api.js
(#83) Unexpected console statement. (no-console)
(#160) Expected an assignment or function call and instead saw an expression. (@babel/no-unused-expressions)
(#280) Unexpected console statement. (no-console)
(#516) 'markdown' is not defined. (no-undef)
plagiarism/compilatio/js/statistics_functions.js
(#7) 'compilatioPercentage' is defined but never used. (no-unused-vars)
(#18) 'compilatioUrlSorter' is defined but never used. (no-unused-vars)

CSS problems

(8 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]

plagiarism/compilatio/styles.css
(#41) Unexpected !important (declaration-no-important)
(#59) Unexpected !important (declaration-no-important)
(#215) Unexpected !important (declaration-no-important)
(#219) Unexpected !important (declaration-no-important)
(#307) Unexpected !important (declaration-no-important)
(#353) Unexpected !important (declaration-no-important)
(#377) Unexpected !important (declaration-no-important)
(#372) Expected newline after "," (selector-list-comma-newline-after)

PHPDocs style problems

(4 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

plagiarism/compilatio/classes/compilatio/cmpfile.php
(#155) Phpdocs for function cmpfile::createfilename has incomplete parameters list
plagiarism/compilatio/classes/compilatio/file.php
(#509) Phpdocs for function file::checkisfilevalid has incomplete parameters list
plagiarism/compilatio/classes/compilatio/submission.php
(#53) Phpdocs for function submission::get has incomplete parameters list
plagiarism/compilatio/classes/output/document_frame.php
(#572) Phpdocs for function document_frame::formatstring has incomplete parameters list

Update savepoints problems

(1 errors, 1 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]

plagiarism/compilatio/db/upgrade.php
Detected fewer 'if' blocks (7) than 'savepoint' calls (8). Repeated savepoints?
Wrong order in versions: 2024030100 and 2024011700

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "eslint:amd" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]