PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]

PHP coding style problems

(342 errors, 53 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

payment/gateway/bank/classes/attachtransfer_form.php: (#32) "require_once" must be immediately followed by an open parenthesis; (#35) Missing docblock for class attachtransfer_form; (#36) Opening brace should be on the same line as the declaration for class attachtransfer_form; (#42) Opening brace should be on the same line as the declaration; (#66) Short array syntax must be used to define arrays; (#66) Short array syntax must be used to define arrays; (#66) Commas (,) must be followed by white space.; (#72) Missing docblock for function validation; (#73) Opening brace should be on the same line as the declaration
payment/gateway/bank/classes/bank_helper.php: (#31) "require_once" must be immediately followed by an open parenthesis; (#36) Missing docblock for class bank_helper; (#37) Opening brace should be on the same line as the declaration for class bank_helper; (#40) Missing docblock for function get_openbankentry; (#41) Opening brace should be on the same line as the declaration; (#46) Missing docblock for function check_hasfiles; (#47) Opening brace should be on the same line as the declaration; (#58) Missing docblock for function aprobe_pay; (#59) Opening brace should be on the same line as the declaration; (#63) Line exceeds 132 characters; contains 136 characters; (#81) Variable "send_email" must not contain underscores.; (#82) Variable "send_email" must not contain underscores.; (#84) Expected 1 space before "="; 0 found; (#84) Expected 1 space after "="; 0 found; (#84) Must use "self::" for local static member reference; (#86) Expected 1 space before "="; 0 found; (#86) Expected 1 space after "="; 0 found; (#87) Expected 1 space before "="; 0 found; (#87) Expected 1 space after "="; 0 found; (#95) Expected 1 space before "="; 0 found; (#95) Expected 1 space after "="; 0 found; (#97) Variable "send_email" must not contain underscores.; (#98) Expected 1 space before "="; 0 found; (#98) Expected 1 space after "="; 0 found; (#99) Variable "send_email" must not contain underscores.; (#115) Missing docblock for function files; (#116) Opening brace should be on the same line as the declaration; (#119) Expected 1 space before "="; 0 found; (#119) Expected 1 space after "="; 0 found; (#119) Short array syntax must be used to define arrays; (#121) Expected "if (...) {\n"; found "if(...) {\n"; (#121) Expected 1 space before "!="; 0 found; (#121) Expected 1 space after "!="; 0 found; (#127) Missing docblock for function get_user; (#128) Opening brace should be on the same line as the declaration; (#132) Missing docblock for function deny_pay; (#133) Opening brace should be on the same line as the declaration; (#137) Line exceeds 132 characters; contains 136 characters; (#139) Expected 1 space before "="; 0 found; (#139) Expected 1 space after "="; 0 found; (#139) Must use "self::" for local static member reference; (#144) Variable "send_email" must not contain underscores.; (#145) Variable "send_email" must not contain underscores.; (#148) Expected 1 space before "="; 0 found; (#148) Expected 1 space after "="; 0 found; (#149) Expected 1 space before "="; 0 found; (#149) Expected 1 space after "="; 0 found; (#150) Whitespace found at end of line; (#158) Expected 1 space before "="; 0 found; (#158) Expected 1 space after "="; 0 found; (#164) Missing docblock for function get_pending; (#165) Opening brace should be on the same line as the declaration; (#170) Missing docblock for function get_user_pending; (#171) Opening brace should be on the same line as the declaration; (#176) Missing docblock for function has_openbankentry; (#177) Opening brace should be on the same line as the declaration; (#185) Missing docblock for function create_bankentry; (#185) Line exceeds 132 characters; contains 137 characters; (#186) Opening brace should be on the same line as the declaration; (#188) Must use "self::" for local static member reference; (#206) Must use "self::" for local static member reference; (#208) Variable "send_email" must not contain underscores.; (#209) Expected 1 space before "="; 0 found; (#209) Expected 1 space after "="; 0 found; (#211) Variable "send_email" must not contain underscores.; (#225) Missing docblock for function create_code; (#226) Opening brace should be on the same line as the declaration
payment/gateway/bank/classes/external/get_config_for_js.php: (#36) "require_once" must be immediately followed by an open parenthesis; (#38) Missing docblock for class get_config_for_js; (#39) Opening brace should be on the same line as the declaration for class get_config_for_js; (#47) Opening brace should be on the same line as the declaration; (#66) Opening brace should be on the same line as the declaration; (#93) Opening brace should be on the same line as the declaration; (#103) File must end with a newline character
payment/gateway/bank/classes/gateway.php: (#33) Opening brace should be on the same line as the declaration for class gateway; (#34) Missing docblock for function get_supported_currencies; (#35) Opening brace should be on the same line as the declaration; (#38) Expected 1 space before "="; 0 found; (#38) Expected 1 space after "="; 0 found; (#39) Expected 1 space before "="; 0 found; (#39) Expected 1 space after "="; 0 found; (#40) Expected 1 space before "="; 0 found; (#40) Expected 1 space after "="; 0 found; (#40) Short array syntax must be used to define arrays; (#41) Expected "if (...) {\n"; found "if(...) {\n"; (#41) Expected 1 space before ">"; 0 found; (#41) Expected 1 space after ">"; 0 found; (#42) Expected 1 space before "="; 0 found; (#42) Expected 1 space after "="; 0 found; (#44) Expected 1 space before "="; 0 found; (#44) Expected 1 space after "="; 0 found; (#46) There should be a comma after the last array item in a multi-line array.; (#59) Opening brace should be on the same line as the declaration
payment/gateway/bank/classes/pay_form.php: (#32) "require_once" must be immediately followed by an open parenthesis; (#35) Missing docblock for class pay_form; (#36) Opening brace should be on the same line as the declaration for class pay_form; (#42) Opening brace should be on the same line as the declaration; (#62) Missing docblock for function validation; (#63) Opening brace should be on the same line as the declaration
payment/gateway/bank/classes/privacy/provider.php: (#36) Opening brace should be on the same line as the declaration for class provider; (#44) There must not be a space before the colon in a return type declaration; (#45) Opening brace should be on the same line as the declaration; (#57) Opening brace should be on the same line as the declaration; (#79) Opening brace should be on the same line as the declaration
payment/gateway/bank/db/access.php: (#1) Missing @copyright tag; (#1) Missing @license tag; (#1) Missing docblock for file access.php; (#2) Line 1 of the opening comment must start "// This file is part of".; (#2) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.; (#2) Line 2 of the opening comment must start "//".; (#2) Line 3 of the opening comment must start "// Moodle is free software: you can redistribute it and/or modify".; (#2) Line 4 of the opening comment must start "// it under the terms of the GNU General Public License as published by".; (#2) Short array syntax must be used to define arrays; (#2) Line 5 of the opening comment must start "// the Free Software Foundation, either version 3 of the License, or".; (#2) Line 6 of the opening comment must start "// (at your option) any later version.".; (#2) Line 7 of the opening comment must start "//".; (#3) Line 8 of the opening comment must start "// Moodle is distributed in the hope that it will be useful,".; (#4) Line 9 of the opening comment must start "// but WITHOUT ANY WARRANTY; without even the implied warranty of".; (#4) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".; (#4) Line 11 of the opening comment must start "// GNU General Public License for more details.".; (#4) Line 12 of the opening comment must start "//".; (#4) Line 13 of the opening comment must start "// You should have received a copy of the GNU General Public License".; (#4) Short array syntax must be used to define arrays; (#4) Line 14 of the opening comment must start "// along with Moodle. If not, see <http://www.gnu.org/licenses/>.".; (#7) Short array syntax must be used to define arrays; (#11) There should be a comma after the last array item in a multi-line array.
payment/gateway/bank/db/install.php: (#24) Missing @copyright tag; (#24) Missing @license tag; (#24) Missing docblock for function xmldb_paygw_bank_install; (#25) Opening brace should be on the same line as the declaration
payment/gateway/bank/db/services.php: (#32) There should be a comma after the last array item in a multi-line array.; (#33) There should be a comma after the last array item in a multi-line array.
payment/gateway/bank/db/upgrade.php: (#23) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#32) Opening brace should be on the same line as the declaration; (#34) Whitespace found at end of line; (#37) Expected 1 space after "<"; 2 found; (#41) Whitespace found at end of line; (#48) Expected 1 space after "<"; 2 found
payment/gateway/bank/lib.php: (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#28) Missing docblock for function paygw_bank_myprofile_navigation; (#29) Opening brace should be on the same line as the declaration; (#43) Missing docblock for function paygw_bank_pluginfile; (#43) Short array syntax must be used to define arrays; (#44) Opening brace should be on the same line as the declaration; (#49) Line exceeds 132 characters; contains 137 characters; (#61) Inline comments must start with a capital letter, digit or 3-dots sequence; (#71) Whitespace found at end of line; (#76) Missing docblock for function str_ends_with; (#77) Opening brace should be on the same line as the declaration
payment/gateway/bank/manage.php: (#1) Missing @copyright tag; (#1) Missing @license tag; (#1) Missing docblock for file manage.php; (#2) The opening <?php tag must be followed by exactly one newline.; (#8) "require_once" must be immediately followed by an open parenthesis; (#9) "require_once" must be immediately followed by an open parenthesis; (#42) Variable "post_url" must not contain underscores.; (#42) Expected 1 space before "="; 0 found; (#42) Short array syntax must be used to define arrays; (#42) Expected 1 space before "=>"; 0 found; (#42) Expected 1 space after "=>"; 0 found; (#43) Variable "bank_entries" must not contain underscores.; (#44) Variable "bank_entries" must not contain underscores.; (#45) Short array syntax must be used to define arrays; (#51) Short array syntax must be used to define arrays; (#53) Line exceeds 132 characters; contains 168 characters; (#53) There should be a comma after the last array item in a multi-line array.; (#55) Line exceeds 132 characters; contains 171 characters; (#55) Inline comments must start with a capital letter, digit or 3-dots sequence; (#55) This comment is 78% valid code; is this commented out code?; (#55) No space found before comment text; expected "// $headarray=array(get_string('date'),get_string('code', 'paygw_bank'), get_string('concept', 'paygw_bank'),get_string('amount', 'paygw_bank'),get_string('currency'));" but found "//$headarray=array(get_string('date'),get_string('code', 'paygw_bank'), get_string('concept', 'paygw_bank'),get_string('amount', 'paygw_bank'),get_string('currency'));"; (#57) Variable "bank_entries" must not contain underscores.; (#57) Variable "bank_entry" must not contain underscores.; (#58) Variable "bank_entry" must not contain underscores.; (#58) Variable "bank_entry" must not contain underscores.; (#58) Variable "bank_entry" must not contain underscores.; (#58) Line exceeds 132 characters; contains 140 characters; (#59) Variable "bank_entry" must not contain underscores.; (#59) Variable "bank_entry" must not contain underscores.; (#59) Variable "bank_entry" must not contain underscores.; (#61) Short array syntax must be used to define arrays; (#61) Variable "bank_entry" must not contain underscores.; (#67) Variable "bank_entry" must not contain underscores.; (#69) Variable "bank_entry" must not contain underscores.; (#74) Variable "bank_entry" must not contain underscores.; (#76) Variable "bank_entry" must not contain underscores.; (#84) Variable "bank_entry" must not contain underscores.; (#85) Variable "bank_entry" must not contain underscores.; (#85) Expected 1 space before ">"; 0 found; (#85) Expected 1 space after ">"; 0 found; (#87) Variable "bank_entry" must not contain underscores.; (#87) Variable "bank_entry" must not contain underscores.; (#87) Line exceeds maximum limit of 180 characters; contains 184 characters; (#90) Variable "bank_entry" must not contain underscores.; (#90) Variable "bank_entry" must not contain underscores.; (#90) Line exceeds 132 characters; contains 159 characters; (#94) Variable "bank_entry" must not contain underscores.; (#100) Inline comments must start with a capital letter, digit or 3-dots sequence; (#101) Line exceeds maximum limit of 180 characters; contains 182 characters; (#102) Line exceeds 132 characters; contains 154 characters; (#122) Short array syntax must be used to define arrays; (#123) Variable "bank_entry" must not contain underscores.; (#123) Variable "bank_entry" must not contain underscores.; (#123) Variable "bank_entry" must not contain underscores.; (#124) There should be a comma after the last array item in a multi-line array.
payment/gateway/bank/my_pending_pay.php: (#1) Missing @copyright tag; (#1) Missing @license tag; (#1) Missing docblock for file my_pending_pay.php; (#2) Line 1 of the opening comment must start "// This file is part of".; (#2) Line 2 of the opening comment must start "//".; (#2) Line 3 of the opening comment must start "// Moodle is free software: you can redistribute it and/or modify".; (#2) Line 4 of the opening comment must start "// it under the terms of the GNU General Public License as published by".; (#2) Line 5 of the opening comment must start "// the Free Software Foundation, either version 3 of the License, or".; (#2) Line 6 of the opening comment must start "// (at your option) any later version.".; (#2) Line 7 of the opening comment must start "//".; (#3) Line 8 of the opening comment must start "// Moodle is distributed in the hope that it will be useful,".; (#3) Line 9 of the opening comment must start "// but WITHOUT ANY WARRANTY; without even the implied warranty of".; (#3) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".; (#3) Line 11 of the opening comment must start "// GNU General Public License for more details.".; (#3) Line 12 of the opening comment must start "//".; (#3) Line 13 of the opening comment must start "// You should have received a copy of the GNU General Public License".; (#3) Line 14 of the opening comment must start "// along with Moodle. If not, see <http://www.gnu.org/licenses/>.".; (#5) "require_once" must be immediately followed by an open parenthesis; (#6) "require_once" must be immediately followed by an open parenthesis; (#11) Expected 1 space before "="; 0 found; (#11) Expected 1 space after "="; 0 found; (#17) Short array syntax must be used to define arrays; (#21) Variable "bank_entries" must not contain underscores.; (#21) Expected 1 space before "="; 0 found; (#22) Variable "bank_entries" must not contain underscores.; (#23) Short array syntax must be used to define arrays; (#27) Expected "} else {\n"; found "} else\n{\n"; (#30) Expected 1 space before "="; 0 found; (#30) Expected 1 space after "="; 0 found; (#31) Expected 1 space before "="; 0 found; (#31) Expected 1 space after "="; 0 found; (#31) Short array syntax must be used to define arrays; (#31) Commas (,) must be followed by white space.; (#31) Commas (,) must be followed by white space.; (#31) Commas (,) must be followed by white space.; (#31) Line exceeds 132 characters; contains 173 characters; (#32) Expected "if (...) {\n"; found "if(...) {\n"; (#36) Expected 1 space before "="; 0 found; (#36) Expected 1 space after "="; 0 found; (#37) Expected "foreach (...) {\n"; found "foreach(...)\n {\n"; (#37) Variable "bank_entries" must not contain underscores.; (#37) Variable "bank_entry" must not contain underscores.; (#39) Variable "bank_entry" must not contain underscores.; (#39) Variable "bank_entry" must not contain underscores.; (#39) Variable "bank_entry" must not contain underscores.; (#39) Line exceeds 132 characters; contains 140 characters; (#40) Variable "bank_entry" must not contain underscores.; (#40) Variable "bank_entry" must not contain underscores.; (#40) Variable "bank_entry" must not contain underscores.; (#42) Short array syntax must be used to define arrays; (#42) Variable "bank_entry" must not contain underscores.; (#43) Whitespace found at end of line; (#48) Variable "bank_entry" must not contain underscores.; (#49) Variable "bank_entry" must not contain underscores.; (#50) Variable "bank_entry" must not contain underscores.; (#51) Variable "bank_entry" must not contain underscores.; (#52) Expected 1 space before "="; 0 found; (#52) Expected 1 space after "="; 0 found; (#52) Short array syntax must be used to define arrays; (#52) Commas (,) must be followed by white space.; (#52) Commas (,) must be followed by white space.; (#52) Commas (,) must be followed by white space.; (#52) Line exceeds 132 characters; contains 178 characters; (#53) Expected 1 space before "="; 0 found; (#53) Expected 1 space after "="; 0 found; (#54) Expected 1 space before "="; 0 found; (#54) Expected 1 space after "="; 0 found; (#54) Short array syntax must be used to define arrays; (#54) Variable "bank_entry" must not contain underscores.; (#54) Variable "bank_entry" must not contain underscores.; (#54) Commas (,) must be followed by white space.; (#54) Variable "bank_entry" must not contain underscores.; (#55) Commas (,) must be followed by white space.; (#56) Whitespace found at end of line; (#57) Expected "if (...) {\n"; found "if(...) {\n"; (#59) Whitespace found at end of line; (#60) Expected 1 space before "="; 0 found; (#60) Expected 1 space after "="; 0 found; (#60) Variable "bank_entry" must not contain underscores.; (#61) Expected 1 space before ">"; 0 found; (#61) Expected 1 space after ">"; 0 found; (#67) Expected 1 space before "="; 0 found; (#72) File must end with a newline character
payment/gateway/bank/pay.php: (#1) Missing @copyright tag; (#1) Missing @license tag; (#1) Missing docblock for file pay.php; (#2) The opening <?php tag must be followed by exactly one newline.; (#8) "require_once" must be immediately followed by an open parenthesis; (#9) "require_once" must be immediately followed by an open parenthesis; (#12) Expected "if (...) {\n"; found "if(...) {\n"; (#13) Expected 1 space before "="; 0 found; (#13) Expected 1 space after "="; 0 found; (#22) Expected 1 space before "="; 0 found; (#22) Expected 1 space after "="; 0 found; (#27) There should be a comma after the last array item in a multi-line array.; (#29) Short array syntax must be used to define arrays; (#29) Line exceeds 132 characters; contains 161 characters; (#31) Variable "at_form" must not contain underscores.; (#32) Variable "at_form" must not contain underscores.; (#34) Variable "at_dataform" must not contain underscores.; (#34) Variable "at_form" must not contain underscores.; (#43) Variable "at_dataform" must not contain underscores.; (#44) Variable "at_dataform" must not contain underscores.; (#45) Variable "at_dataform" must not contain underscores.; (#46) Variable "at_dataform" must not contain underscores.; (#47) Variable "at_dataform" must not contain underscores.; (#48) Variable "at_dataform" must not contain underscores.; (#63) Variable "bank_entry" must not contain underscores.; (#83) Variable "bank_entry" must not contain underscores.; (#84) Variable "bank_entry" must not contain underscores.; (#91) Variable "bank_entry" must not contain underscores.; (#91) Line exceeds 132 characters; contains 137 characters; (#97) Variable "bank_entry" must not contain underscores.; (#105) Whitespace found at end of line; (#114) Variable "bank_entry" must not contain underscores.; (#116) Variable "bank_entry" must not contain underscores.; (#126) Variable "at_form" must not contain underscores.; (#127) Variable "at_form" must not contain underscores.; (#129) Variable "at_form" must not contain underscores.; (#131) Whitespace found at end of line; (#133) Expected 1 space before "="; 0 found; (#133) Expected 1 space after "="; 0 found; (#134) Expected 1 space before "="; 0 found; (#134) Expected 1 space after "="; 0 found; (#134) Variable "bank_entry" must not contain underscores.; (#135) Expected "if (...) {\n"; found "if(...) {\n"; (#135) Expected 1 space before ">="; 0 found; (#135) Expected 1 space after ">="; 0 found; (#138) Expected "} else {\n"; found "}\n else\n {\n"; (#141) Whitespace found at end of line; (#142) Expected 1 space before "="; 0 found; (#143) Expected "if (...) {\n"; found "if(...) {\n"; (#143) Expected 1 space before "=="; 0 found; (#143) Expected 1 space after "=="; 0 found; (#144) Expected 1 space before "="; 0 found; (#144) Expected 1 space after "="; 0 found; (#147) Expected "if (...) {\n"; found "if(...) {\n"; (#148) Whitespace found at end of line; (#150) Expected "} else {\n"; found "}\n else\n {\n"; (#154) Variable "at_form" must not contain underscores.; (#155) Short array syntax must be used to define arrays; (#160) Expected 1 space after "=>"; 2 found; (#161) Variable "bank_entry" must not contain underscores.; (#163) There should be a comma after the last array item in a multi-line array.; (#166) Variable "bank_entry" must not contain underscores.; (#167) Variable "send_email" must not contain underscores.; (#168) Expected 1 space before "="; 0 found; (#168) Expected 1 space after "="; 0 found; (#169) Whitespace found at end of line; (#170) Variable "send_email" must not contain underscores.; (#187) Variable "bank_entry" must not contain underscores.; (#188) Expected "if (...) {\n"; found "if(...) {\n"; (#188) Expected 1 space before ">"; 0 found; (#188) Expected 1 space after ">"; 0 found; (#192) Expected 1 space before "="; 0 found; (#192) Expected 1 space after "="; 0 found; (#193) Inline comments must start with a capital letter, digit or 3-dots sequence; (#195) Whitespace found at end of line; (#196) Line exceeds maximum limit of 180 characters; contains 182 characters; (#197) Line exceeds maximum limit of 180 characters; contains 254 characters; (#197) Whitespace found at end of line; (#198) Whitespace found at end of line; (#202) Expected "} else {\n"; found "}\n else\n {\n"; (#209) Whitespace found at end of line; (#211) Expected "if (...) {\n"; found "if(...) {\n"; (#211) Expected 1 space before "<"; 0 found; (#211) Expected 1 space after "<"; 0 found; (#212) Variable "at_form" must not contain underscores.
payment/gateway/bank/settings.php: (#31) Line exceeds 132 characters; contains 144 characters; (#32) Line exceeds 132 characters; contains 147 characters; (#33) Line exceeds maximum limit of 180 characters; contains 209 characters; (#34) Line exceeds 132 characters; contains 139 characters; (#36) Commas (,) must be followed by white space.; (#36) Line exceeds 132 characters; contains 174 characters; (#37) Line exceeds 132 characters; contains 150 characters; (#38) Whitespace found at end of line; (#39) Line exceeds 132 characters; contains 144 characters; (#40) Line exceeds 132 characters; contains 152 characters; (#41) Line exceeds 132 characters; contains 155 characters; (#42) Whitespace found at end of line; (#43) Whitespace found at end of line
payment/gateway/bank/version.php: (#26) Whitespace found at end of line

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]

PHPDocs style problems

(0 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]

grunt changes

(4 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]

payment/gateway/bank/amd/build/gateways_modal.min.js: Uncommitted change detected.
payment/gateway/bank/amd/build/gateways_modal.min.js.map: Uncommitted change detected.
payment/gateway/bank/amd/build/repository.min.js: Uncommitted change detected.
payment/gateway/bank/amd/build/repository.min.js.map: Uncommitted change detected.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]

Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]

payment/gateway/bank/templates/bank_button_placeholder.mustache: (#1) Template produced no content

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]