Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(168 errors, 110 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/vinapse/backup/moodle2/backup_vinapse_activity_task.class.php
(#1) No one-line description found in phpdocs for docblock of file backup_vinapse_activity_task.class.php
(#11) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".
(#15) Line 14 of the opening comment must start "// along with Moodle. If not, see <https://www.gnu.org/licenses/>.".
(#30) Missing docblock for class backup_vinapse_activity_task
(#31) Opening brace should be on the same line as the declaration for class backup_vinapse_activity_task
(#32) Missing docblock for function define_my_settings
(#33) Opening brace should be on the same line as the declaration
(#36) Missing docblock for function define_my_steps
(#37) Opening brace should be on the same line as the declaration
(#41) The static declaration must come after the visibility declaration
(#41) Missing docblock for function encode_content_links
(#42) Opening brace should be on the same line as the declaration
mod/vinapse/backup/moodle2/backup_vinapse_stepslib.php
(#1) No one-line description found in phpdocs for docblock of file backup_vinapse_stepslib.php
(#11) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".
(#15) Line 14 of the opening comment must start "// along with Moodle. If not, see <https://www.gnu.org/licenses/>.".
(#24) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#26) Missing docblock for class backup_vinapse_activity_structure_step
(#27) Opening brace should be on the same line as the declaration for class backup_vinapse_activity_structure_step
(#28) Missing docblock for function define_structure
(#29) Opening brace should be on the same line as the declaration
(#32) Short array syntax must be used to define arrays
(#33) Short array syntax must be used to define arrays
(#38) Short array syntax must be used to define arrays
(#39) There should be a comma after the last array item in a multi-line array.
mod/vinapse/backup/moodle2/restore_vinapse_activity_task.class.php
(#1) No one-line description found in phpdocs for docblock of file restore_vinapse_activity_task.class.php
(#11) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".
(#15) Line 14 of the opening comment must start "// along with Moodle. If not, see <https://www.gnu.org/licenses/>.".
(#30) Missing docblock for class restore_vinapse_activity_task
(#31) Opening brace should be on the same line as the declaration for class restore_vinapse_activity_task
(#32) Missing docblock for function define_my_settings
(#33) Opening brace should be on the same line as the declaration
(#36) Missing docblock for function define_my_steps
(#37) Opening brace should be on the same line as the declaration
(#41) The static declaration must come after the visibility declaration
(#41) Missing docblock for function define_decode_contents
(#42) Opening brace should be on the same line as the declaration
(#43) Short array syntax must be used to define arrays
(#46) The static declaration must come after the visibility declaration
(#46) Missing docblock for function define_decode_rules
(#47) Opening brace should be on the same line as the declaration
(#48) Short array syntax must be used to define arrays
(#51) The static declaration must come after the visibility declaration
(#51) Missing docblock for function define_restore_log_rules
(#52) Opening brace should be on the same line as the declaration
(#53) Inline comments must end in full-stops, exclamation marks, or question marks
(#54) Short array syntax must be used to define arrays
(#57) The static declaration must come after the visibility declaration
(#57) Missing docblock for function define_restore_log_rules_for_course
(#58) Opening brace should be on the same line as the declaration
(#59) Short array syntax must be used to define arrays
mod/vinapse/backup/moodle2/restore_vinapse_stepslib.php
(#1) No one-line description found in phpdocs for docblock of file restore_vinapse_stepslib.php
(#11) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".
(#15) Line 14 of the opening comment must start "// along with Moodle. If not, see <https://www.gnu.org/licenses/>.".
(#24) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#26) Missing docblock for class restore_vinapse_activity_structure_step
(#27) Opening brace should be on the same line as the declaration for class restore_vinapse_activity_structure_step
(#28) Missing docblock for function define_structure
(#29) Opening brace should be on the same line as the declaration
(#30) Short array syntax must be used to define arrays
(#31) There should be a comma after the last array item in a multi-line array.
(#37) Missing docblock for function process_vinapse
(#38) Opening brace should be on the same line as the declaration
mod/vinapse/classes/external/api.php
(#1) No one-line description found in phpdocs for docblock of file api.php
(#11) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".
(#15) Line 14 of the opening comment must start "// along with Moodle. If not, see <https://www.gnu.org/licenses/>.".
(#30) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#34) Missing docblock for class api
(#35) Opening brace should be on the same line as the declaration for class api
(#36) Missing docblock for function set_uuid_parameters
(#37) Opening brace should be on the same line as the declaration
(#39) Short array syntax must be used to define arrays
(#46) Missing docblock for function set_uuid_returns
(#47) Opening brace should be on the same line as the declaration
(#51) Missing docblock for function set_uuid
(#52) Opening brace should be on the same line as the declaration
(#57) Short array syntax must be used to define arrays
(#59) There should be a comma after the last array item in a multi-line array.
(#74) Short array syntax must be used to define arrays
mod/vinapse/classes/lti_helper.php
(#1) No one-line description found in phpdocs for docblock of file lti_helper.php
(#11) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".
(#15) Line 14 of the opening comment must start "// along with Moodle. If not, see <https://www.gnu.org/licenses/>.".
(#33) Missing docblock for class lti_helper
(#34) Opening brace should be on the same line as the declaration for class lti_helper
(#44) Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $courseid.
(#45) Opening brace should be on the same line as the declaration
(#47) Inline comments must end in full-stops, exclamation marks, or question marks
(#50) Variable "is_context_admin" must not contain underscores.
(#52) Inline comments must end in full-stops, exclamation marks, or question marks
(#62) Variable "is_context_admin" must not contain underscores.
(#65) Inline comments must end in full-stops, exclamation marks, or question marks
(#66) Variable "is_role_switched" must not contain underscores.
(#67) Variable "is_role_switched" must not contain underscores.
(#67) Variable "is_context_admin" must not contain underscores.
(#75) Missing docblock for function request_lti_launch_lecture
(#81) Opening brace should be on the same line as the declaration
(#89) There should be a comma after the last array item in a multi-line array.
(#95) Missing docblock for function request_lti_launch_generic
(#96) Opening brace should be on the same line as the declaration
(#100) There should be a comma after the last array item in a multi-line array.
(#106) Missing docblock for function request_lti_launch_chat
(#110) Opening brace should be on the same line as the declaration
(#117) There should be a comma after the last array item in a multi-line array.
(#123) Missing docblock for function generate_launch_form
(#124) Opening brace should be on the same line as the declaration
(#132) Inline comments must end in full-stops, exclamation marks, or question marks
(#135) Inline comments must end in full-stops, exclamation marks, or question marks
(#140) Inline comments must end in full-stops, exclamation marks, or question marks
(#146) Inline comments must end in full-stops, exclamation marks, or question marks
(#153) Missing docblock for function get_courses
(#154) Opening brace should be on the same line as the declaration
(#163) Inline comments must end in full-stops, exclamation marks, or question marks
mod/vinapse/classes/privacy/provider.php
(#1) No one-line description found in phpdocs for docblock of file provider.php
(#11) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".
(#15) Line 14 of the opening comment must start "// along with Moodle. If not, see <https://www.gnu.org/licenses/>.".
(#31) Missing docblock for class provider
(#35) Opening brace should be on the same line as the declaration for class provider
(#37) Missing docblock for function get_metadata
(#38) Opening brace should be on the same line as the declaration
(#49) Missing docblock for function get_contexts_for_userid
(#50) Opening brace should be on the same line as the declaration
(#54) Missing docblock for function export_user_data
(#55) Opening brace should be on the same line as the declaration
(#58) Missing docblock for function delete_data_for_all_users_in_context
(#59) Opening brace should be on the same line as the declaration
(#62) Missing docblock for function delete_data_for_user
(#63) Opening brace should be on the same line as the declaration
(#66) Missing docblock for function get_users_in_context
(#67) Opening brace should be on the same line as the declaration
(#70) Missing docblock for function delete_data_for_users
(#71) Opening brace should be on the same line as the declaration
mod/vinapse/classes/utils.php
(#1) No one-line description found in phpdocs for docblock of file utils.php
(#11) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".
(#15) Line 14 of the opening comment must start "// along with Moodle. If not, see <https://www.gnu.org/licenses/>.".
(#25) Missing docblock for class utils
(#26) Opening brace should be on the same line as the declaration for class utils
(#27) Inline comments must start with a capital letter, digit or 3-dots sequence
(#27) Inline comments must end in full-stops, exclamation marks, or question marks
(#28) Missing docblock for function str_putcsv
(#29) Opening brace should be on the same line as the declaration
mod/vinapse/db/access.php
(#1) No one-line description found in phpdocs for docblock of file access.php
(#11) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".
(#15) Line 14 of the opening comment must start "// along with Moodle. If not, see <https://www.gnu.org/licenses/>.".
(#23) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#23) Short array syntax must be used to define arrays
(#24) Short array syntax must be used to define arrays
(#27) Short array syntax must be used to define arrays
(#29) There should be a comma after the last array item in a multi-line array.
(#31) There should be a comma after the last array item in a multi-line array.
mod/vinapse/db/install.php
(#11) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".
(#15) Line 14 of the opening comment must start "// along with Moodle. If not, see <https://www.gnu.org/licenses/>.".
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/vinapse/db/services.php
(#1) No one-line description found in phpdocs for docblock of file services.php
(#11) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".
(#15) Line 14 of the opening comment must start "// along with Moodle. If not, see <https://www.gnu.org/licenses/>.".
(#23) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#23) Short array syntax must be used to define arrays
(#24) Short array syntax must be used to define arrays
(#31) Short array syntax must be used to define arrays
(#31) There should be a comma after the last array item in a multi-line array.
(#32) There should be a comma after the last array item in a multi-line array.
mod/vinapse/db/uninstall.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/vinapse/db/upgrade.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#35) Opening brace should be on the same line as the declaration
(#49) Inline comments must start with a capital letter, digit or 3-dots sequence
(#52) Functions must not contain multiple empty lines in a row; found 2 empty lines
mod/vinapse/index.php
(#28) Inline doc block type-hinting for '$DB' does not match next code line '$id...'
(#29) Inline doc block type-hinting for '$PAGE' does not match next code line '$id...'
(#30) Inline doc block type-hinting for '$OUTPUT' does not match next code line '$id...'
(#34) Short array syntax must be used to define arrays
(#39) Short array syntax must be used to define arrays
(#52) Short array syntax must be used to define arrays
(#59) Short array syntax must be used to define arrays
(#60) Short array syntax must be used to define arrays
(#62) Short array syntax must be used to define arrays
(#63) Short array syntax must be used to define arrays
(#65) Short array syntax must be used to define arrays
(#66) Short array syntax must be used to define arrays
(#72) Short array syntax must be used to define arrays
(#74) Short array syntax must be used to define arrays
(#77) Short array syntax must be used to define arrays
(#83) Logical operator "or" is prohibited; use "||" instead
(#84) Short array syntax must be used to define arrays
(#86) Short array syntax must be used to define arrays
mod/vinapse/lang/en/vinapse.php
(#29) The string key "modulename" is not in the correct order, it should be before "pluginname"
(#31) The string key "modulename_help" is not in the correct order, it should be before "modulenameplural"
(#33) Whitespace found at end of line within string
(#37) The string key "pluginadministration" is not in the correct order, it should be before "vinapsename"
(#38) The string key "noresources" is not in the correct order, it should be before "pluginadministration"
(#40) The string key "form_remoteuuid" is not in the correct order, it should be before "noresources"
(#41) The string key "form_gotoupload" is not in the correct order, it should be before "form_remoteuuid"
(#47) The string key "setting_lti_provider_url" is not in the correct order, it should be before "vinapse:addinstance"
(#49) The string key "setting_lti_key" is not in the correct order, it should be before "setting_lti_provider_url_desc"
(#54) The string key "error_popup_title" is not in the correct order, it should be before "setting_lti_secret_desc"
(#55) The string key "error_popup_message" is not in the correct order, it should be before "error_popup_title"
(#56) The string key "error_popup_button" is not in the correct order, it should be before "error_popup_message"
(#58) The string key "error_not_configured" is not in the correct order, it should be before "error_popup_button"
(#61) The string key "launch_guest_description" is not in the correct order, it should be before "launch_guest_title"
(#65) The string key "privacy:metadata:language" is not in the correct order, it should be before "privacy:metadata:userid"
(#67) The string key "privacy:metadata:courses" is not in the correct order, it should be before "privacy:metadata:roles"
mod/vinapse/lang/it/vinapse.php
(#29) The string key "modulename" is not in the correct order, it should be before "pluginname"
(#31) The string key "modulename_help" is not in the correct order, it should be before "modulenameplural"
(#37) The string key "pluginadministration" is not in the correct order, it should be before "vinapsename"
(#38) The string key "noresources" is not in the correct order, it should be before "pluginadministration"
(#40) The string key "form_remoteuuid" is not in the correct order, it should be before "noresources"
(#41) The string key "form_gotoupload" is not in the correct order, it should be before "form_remoteuuid"
(#47) The string key "setting_lti_provider_url" is not in the correct order, it should be before "vinapse:addinstance"
(#49) The string key "setting_lti_key" is not in the correct order, it should be before "setting_lti_provider_url_desc"
(#54) The string key "error_popup_title" is not in the correct order, it should be before "setting_lti_secret_desc"
(#55) The string key "error_popup_message" is not in the correct order, it should be before "error_popup_title"
(#56) The string key "error_popup_button" is not in the correct order, it should be before "error_popup_message"
(#58) The string key "error_not_configured" is not in the correct order, it should be before "error_popup_button"
(#61) The string key "launch_guest_description" is not in the correct order, it should be before "launch_guest_title"
(#65) The string key "privacy:metadata:language" is not in the correct order, it should be before "privacy:metadata:userid"
(#67) The string key "privacy:metadata:courses" is not in the correct order, it should be before "privacy:metadata:roles"
mod/vinapse/launch.php
(#1) No one-line description found in phpdocs for docblock of file launch.php
(#11) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".
(#15) Line 14 of the opening comment must start "// along with Moodle. If not, see <https://www.gnu.org/licenses/>.".
(#27) Inline doc block type-hinting for '$PAGE' does not match next code line '$destinationpath...'
(#28) Inline doc block type-hinting for '$OUTPUT' does not match next code line '$destinationpath...'
(#29) Inline doc block type-hinting for '$USER' does not match next code line '$destinationpath...'
(#33) Inline comments must end in full-stops, exclamation marks, or question marks
(#36) Inline comments must end in full-stops, exclamation marks, or question marks
(#39) Short array syntax must be used to define arrays
mod/vinapse/launch_embed.php
(#1) No one-line description found in phpdocs for docblock of file launch_embed.php
(#11) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".
(#15) Line 14 of the opening comment must start "// along with Moodle. If not, see <https://www.gnu.org/licenses/>.".
(#27) Inline doc block type-hinting for '$DB' does not match next code line '$cmid...'
(#28) Inline doc block type-hinting for '$USER' does not match next code line '$cmid...'
(#30) Inline comments must end in full-stops, exclamation marks, or question marks
(#33) Inline comments must end in full-stops, exclamation marks, or question marks
(#39) Inline comments must end in full-stops, exclamation marks, or question marks
(#40) Short array syntax must be used to define arrays
(#42) Inline comments must end in full-stops, exclamation marks, or question marks
mod/vinapse/lib.php
(#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#34) Opening brace should be on the same line as the declaration
(#62) Opening brace should be on the same line as the declaration
(#83) Opening brace should be on the same line as the declaration
(#99) Opening brace should be on the same line as the declaration
(#102) Short array syntax must be used to define arrays
(#107) Short array syntax must be used to define arrays
mod/vinapse/mod_form.php
(#37) Opening brace should be on the same line as the declaration for class mod_vinapse_mod_form
(#43) Opening brace should be on the same line as the declaration
(#46) Inline comments must end in full-stops, exclamation marks, or question marks
(#49) Inline comments must end in full-stops, exclamation marks, or question marks
(#50) Short array syntax must be used to define arrays
(#55) Inline comments must end in full-stops, exclamation marks, or question marks
(#58) Inline comments must end in full-stops, exclamation marks, or question marks
(#60) Inline comments must end in full-stops, exclamation marks, or question marks
(#61) Short array syntax must be used to define arrays
(#69) Inline comments must end in full-stops, exclamation marks, or question marks
(#73) Inline comments must end in full-stops, exclamation marks, or question marks
(#76) Inline comments must end in full-stops, exclamation marks, or question marks
mod/vinapse/output/video_page.php
(#1) No one-line description found in phpdocs for docblock of file video_page.php
(#11) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".
(#15) Line 14 of the opening comment must start "// along with Moodle. If not, see <https://www.gnu.org/licenses/>.".
(#31) Inline comments must end in full-stops, exclamation marks, or question marks
(#32) Missing docblock for class video_page
(#33) Opening brace should be on the same line as the declaration for class video_page
(#35) Missing member variable doc comment
(#37) Missing docblock for function __construct
(#38) Opening brace should be on the same line as the declaration
(#48) Opening brace should be on the same line as the declaration
mod/vinapse/view.php
(#30) Inline doc block type-hinting for '$DB' does not match next code line '$cmid...'
(#31) Inline doc block type-hinting for '$PAGE' does not match next code line '$cmid...'
(#32) Inline doc block type-hinting for '$OUTPUT' does not match next code line '$cmid...'
(#34) Inline comments must end in full-stops, exclamation marks, or question marks
(#37) Inline comments must end in full-stops, exclamation marks, or question marks
(#40) Inline comments must end in full-stops, exclamation marks, or question marks
(#41) Short array syntax must be used to define arrays
(#43) Inline comments must end in full-stops, exclamation marks, or question marks
(#46) Inline comments must end in full-stops, exclamation marks, or question marks
(#50) Short array syntax must be used to define arrays
(#54) Inline comments must end in full-stops, exclamation marks, or question marks
(#55) Variable "lti_endpoint" must not contain underscores.
(#56) Variable "lti_hostname" must not contain underscores.
(#56) Variable "lti_endpoint" must not contain underscores.
(#58) Short array syntax must be used to define arrays
(#58) Variable "lti_hostname" must not contain underscores.

Javascript coding style problems

(1 errors, 5 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

mod/vinapse/amd/src/view.js
(#17) @package should be empty. (jsdoc/empty-tags)
(#100) Expected catch,fail,always() or return (promise/catch-or-return)
(#100) Avoid using promises inside of callbacks. (promise/no-promise-in-callback)
(#104) Each then() should return a value or throw (promise/always-return)
(#104) Unexpected space before function parentheses. (space-before-function-paren)
(#105) Unexpected space before function parentheses. (space-before-function-paren)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(1 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

mod/vinapse/output/video_page.php
(#42) Phpdocs for function video_page::export_for_template has incomplete parameters list

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "eslint:amd" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 3 warnings)

This section shows problems detected in mustache templates [More info]

mod/vinapse/templates/video_page.mustache
(#1) Example context missing (@template section not found.)
(#1) HTML Validation error, line 4: Bad value “” for attribute “src” on element “iframe”: Must be non-empty. (nit"> <iframe id="vinapse-embed" src="" allowfullscreen="true" style="width: 100%; height: 600px; border: none"></ifra)
(#1) HTML Validation error, line 4: Bad value “true” for attribute “allowfullscreen” on element “iframe”. (nit"> <iframe id="vinapse-embed" src="" allowfullscreen="true" style="width: 100%; height: 600px; border: none"></ifra)

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]