Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(150 errors, 16 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/via/api.class.php
(#24) Whitespace found at end of line
(#28) Expected MOODLE_INTERNAL check or config.php inclusion
(#131) Whitespace found at end of line
(#199) This comment is 55% valid code; is this commented out code?
(#307) Whitespace found at end of line
(#878) Whitespace found at end of line
(#879) Whitespace found at end of line
(#922) Whitespace found at end of line
(#959) Expected 1 space after asterisk; 0 found
(#962) Whitespace found at end of line
(#1036) Whitespace found at end of line
(#1161) Whitespace found at end of line
mod/via/auth.php
(#20) Whitespace found at end of line
(#25) Whitespace found at end of line
(#28) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#30) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
mod/via/backup/moodle2/backup_via_activity_task.class.php
(#23) Whitespace found at end of line
(#26) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
mod/via/backup/moodle2/backup_via_stepslib.php
(#18) Whitespace found at end of line
(#21) Whitespace found at end of line
(#31) Expected MOODLE_INTERNAL check or config.php inclusion
(#53) Line exceeds 132 characters; contains 135 characters
mod/via/backup/moodle2/restore_via_activity_task.class.php
(#21) Whitespace found at end of line
(#26) Whitespace found at end of line
(#65) Spaces must be used to indent lines; tabs are not allowed
(#65) Tab found within whitespace
(#65) Line indented incorrectly; expected at least 8 spaces, found 3
mod/via/backup/moodle2/restore_via_stepslib.php
(#25) Whitespace found at end of line
(#28) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
mod/via/choosecategories.php
(#20) Whitespace found at end of line
(#25) Whitespace found at end of line
mod/via/conntest.php
(#21) Whitespace found at end of line
(#26) Whitespace found at end of line
mod/via/db/access.php
(#20) Whitespace found at end of line
(#25) Whitespace found at end of line
mod/via/db/install.php
(#20) Whitespace found at end of line
(#25) Whitespace found at end of line
mod/via/db/upgrade.php
(#33) Expected MOODLE_INTERNAL check or config.php inclusion
(#368) Spaces must be used to indent lines; tabs are not allowed
(#368) Tab found within whitespace
(#368) Whitespace found at end of line
(#369) Spaces must be used to indent lines; tabs are not allowed
(#369) Tab found within whitespace
(#369) Line indented incorrectly; expected 4 spaces, found 1
(#370) Spaces must be used to indent lines; tabs are not allowed
(#370) Tab found within whitespace
(#370) Whitespace found at end of line
(#371) Spaces must be used to indent lines; tabs are not allowed
(#371) Tab found within whitespace
(#371) Line indented incorrectly; expected at least 8 spaces, found 2
(#372) Spaces must be used to indent lines; tabs are not allowed
(#372) Tab found within whitespace
(#372) Line indented incorrectly; expected at least 8 spaces, found 2
(#373) Spaces must be used to indent lines; tabs are not allowed
(#373) Tab found within whitespace
(#373) Line indented incorrectly; expected 4 spaces, found 1
mod/via/download_recording.php
(#25) Whitespace found at end of line
(#27) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
mod/via/edit_review.php
(#25) Whitespace found at end of line
(#28) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
mod/via/index.php
(#20) Whitespace found at end of line
(#25) Whitespace found at end of line
(#28) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
mod/via/lang/en/via.php
(#20) Whitespace found at end of line
(#25) Whitespace found at end of line
mod/via/lib.php
(#20) Whitespace found at end of line
(#25) Whitespace found at end of line
(#394) Whitespace found at end of line
(#482) Whitespace found at end of line
(#545) Whitespace found at end of line
(#796) Whitespace found at end of line
(#834) Whitespace found at end of line
(#1303) Whitespace found at end of line
(#1436) Whitespace found at end of line
mod/via/locallib.php
(#19) Whitespace found at end of line
(#24) Whitespace found at end of line
(#35) Whitespace found at end of line
(#221) Whitespace found at end of line
(#362) Whitespace found at end of line
(#909) Spaces must be used to indent lines; tabs are not allowed
(#909) Tab found within whitespace
(#909) Line indented incorrectly; expected at least 16 spaces, found 4
(#910) Spaces must be used to indent lines; tabs are not allowed
(#910) Tab found within whitespace
(#910) Line indented incorrectly; expected at least 16 spaces, found 4
(#973) Whitespace found at end of line
(#1396) Whitespace found at end of line
mod/via/manage.form.php
(#20) Whitespace found at end of line
(#25) Whitespace found at end of line
(#28) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#35) Line indented incorrectly; expected 12 spaces, found 10
(#39) Line indented incorrectly; expected 12 spaces, found 10
(#46) Whitespace found at end of line
(#67) Whitespace found at end of line
(#77) Whitespace found at end of line
mod/via/manage.php
(#20) Whitespace found at end of line
(#25) Whitespace found at end of line
mod/via/mod_form.php
(#20) Whitespace found at end of line
(#25) Whitespace found at end of line
(#28) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#248) Spaces must be used to indent lines; tabs are not allowed
(#248) Tab found within whitespace
(#248) Whitespace found at end of line
(#249) Spaces must be used to indent lines; tabs are not allowed
(#249) Tab found within whitespace
(#249) This comment is 76% valid code; is this commented out code?
(#249) Inline comments must start with a capital letter, digit or 3-dots sequence
(#249) Line indented incorrectly; expected at least 8 spaces, found 2
(#249) No space found before comment text; expected "// $mform->addElement('select', 'users', 'users', array(0=>'user1', 1=> 'user2', 2=> 'user3'));" but found "//$mform->addElement('select', 'users', 'users', array(0=>'user1', 1=> 'user2', 2=> 'user3'));"
(#250) Spaces must be used to indent lines; tabs are not allowed
(#250) Tab found within whitespace
(#250) This comment is 80% valid code; is this commented out code?
(#250) Line indented incorrectly; expected at least 8 spaces, found 2
(#250) No space found before comment text; expected "// $mform->setDefault('enroltype', 0);" but found "//$mform->setDefault('enroltype', 0);"
(#251) Spaces must be used to indent lines; tabs are not allowed
(#251) Tab found within whitespace
(#251) Inline comments must end in full-stops, exclamation marks, or question marks
(#251) This comment is 77% valid code; is this commented out code?
(#251) Line indented incorrectly; expected at least 8 spaces, found 2
(#251) No space found before comment text; expected "// $mform->addHelpButton('enroltype', 'enrolmenttype', 'via');" but found "//$mform->addHelpButton('enroltype', 'enrolmenttype', 'via');"
mod/via/phpxml.php
(#20) Whitespace found at end of line
(#25) Whitespace found at end of line
(#39) Expected MOODLE_INTERNAL check or config.php inclusion
mod/via/presence.php
(#20) Whitespace found at end of line
(#25) Whitespace found at end of line
(#28) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#31) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
mod/via/send_invite.php
(#20) Whitespace found at end of line
(#25) Whitespace found at end of line
mod/via/settings.php
(#20) Whitespace found at end of line
(#25) Whitespace found at end of line
mod/via/tabs.php
(#20) Whitespace found at end of line
(#25) Whitespace found at end of line
(#28) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
mod/via/testadminid.php
(#19) Whitespace found at end of line
(#24) Whitespace found at end of line
mod/via/uapi/auth.php
(#20) Whitespace found at end of line
(#25) Whitespace found at end of line
(#28) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#30) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
mod/via/uapi/getversion/index.php
(#20) Whitespace found at end of line
(#25) Whitespace found at end of line
(#28) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#30) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
mod/via/version.php
(#20) Whitespace found at end of line
(#25) Whitespace found at end of line
(#35) This comment is 50% valid code; is this commented out code?
mod/via/vialib/version24.php
(#20) Whitespace found at end of line
(#25) Whitespace found at end of line
(#28) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#34) Whitespace found at end of line
(#48) Whitespace found at end of line
(#62) Whitespace found at end of line
(#76) Whitespace found at end of line
mod/via/vialib/version27.php
(#20) Whitespace found at end of line
(#25) Whitespace found at end of line
(#28) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#34) Whitespace found at end of line
(#47) Whitespace found at end of line
(#60) Whitespace found at end of line
mod/via/view.assistant.php
(#20) Whitespace found at end of line
(#25) Whitespace found at end of line
mod/via/view.php
(#20) Whitespace found at end of line
(#25) Whitespace found at end of line
mod/via/view.via.php
(#20) Whitespace found at end of line
(#25) Whitespace found at end of line

Javascript coding style problems

(0 errors, 19 warnings)

This section shows the coding style problems detected in the code by jshint [More info]

mod/via/javascript/conntest.js
(#4) Line is too long.
(#15) Line is too long.
(#21) Line is too long.
(#33) Line is too long.
(#5) 'alert' is not defined.
(#11) 'escape' is not defined.
(#12) 'escape' is not defined.
(#13) 'escape' is not defined.
(#15) 'openpopup' is not defined.
(#22) 'alert' is not defined.
(#28) 'escape' is not defined.
(#29) 'escape' is not defined.
(#30) 'escape' is not defined.
(#31) 'escape' is not defined.
(#33) 'openpopup' is not defined.
(#1) 'testConnection' is defined but never used.
(#18) 'testAdminId' is defined but never used.
mod/via/javascript/list.js
(#27) Missing semicolon.
(#1) 'change' is defined but never used.

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by csslint [More info]


PHPDocs style problems

(114 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

mod/via/api.class.php
(#455) Function mod_via_api::via_get_categories is not documented
(#703) Phpdocs for function mod_via_api::edituser_activity has incomplete parameters list
(#961) Phpdocs for function mod_via_api::via_download_record has incomplete parameters list
(#1000) Phpdocs for function mod_via_api::get_notices has incomplete parameters list
(#1123) Phpdocs for function mod_via_api::testadminid has incomplete parameters list
(#27) Class mod_via_api does not have @copyright tag
(#27) Class mod_via_api does not have @license tag
(#20) Package mod is not valid
mod/via/auth.php
(#21) Package mod is not valid
mod/via/backup/moodle2/backup_via_activity_task.class.php
(#17) No one-line description found in phpdocs for file
(#28) No one-line description found in phpdocs for class backup_via_activity_task
(#49) Phpdocs for function backup_via_activity_task::encode_content_links has incomplete parameters list
(#28) Class backup_via_activity_task does not have @copyright tag
(#28) Class backup_via_activity_task does not have @license tag
(#19) Package mod is not valid
mod/via/backup/moodle2/backup_via_stepslib.php
(#33) Function backup_via_activity_structure_step::define_structure is not documented
(#17) No one-line description found in phpdocs for file
(#28) Class backup_via_activity_structure_step does not have @copyright tag
(#28) Class backup_via_activity_structure_step does not have @license tag
mod/via/backup/moodle2/restore_via_activity_task.class.php
(#17) No one-line description found in phpdocs for file
(#34) No one-line description found in phpdocs for class restore_via_activity_task
(#34) Class restore_via_activity_task does not have @copyright tag
(#34) Class restore_via_activity_task does not have @license tag
mod/via/backup/moodle2/restore_via_stepslib.php
(#31) Class restore_via_activity_structure_step does not have @copyright tag
(#31) Class restore_via_activity_structure_step does not have @license tag
mod/via/choosecategories.php
(#21) Package mod is not valid
mod/via/classes/event/course_module_viewed.php
(#38) Class course_module_viewed is not documented
(#20) Package Via is not valid
mod/via/classes/event/playback_downloaded.php
(#38) Class playback_downloaded is not documented
(#20) Package Via is not valid
mod/via/classes/event/playback_viewed.php
(#38) Class playback_viewed is not documented
(#20) Package Via is not valid
mod/via/classes/event/via_accessed.php
(#38) Class via_accessed is not documented
(#20) Package Via is not valid
mod/via/conntest.php
(#17) No one-line description found in phpdocs for file
(#22) Package mod is not valid
mod/via/db/access.php
(#21) Package mod is not valid
mod/via/db/install.php
(#21) Package mod is not valid
mod/via/db/upgrade.php
(#20) Package mod is not valid
mod/via/download_recording.php
(#21) Package mod is not valid
mod/via/edit_review.php
(#21) Package mod is not valid
mod/via/index.php
(#21) Package mod is not valid
mod/via/lang/en/via.php
(#21) Package mod is not valid
mod/via/lib.php
(#1459) Function via_send_invite_form::definition is not documented
(#928) Phpdocs for function via_send_moodle_reminders has incomplete parameters list
(#1034) Phpdocs for function via_send_export_notice has incomplete parameters list
(#1088) Phpdocs for function via_send_moodle_invitations has incomplete parameters list
(#1169) Phpdocs for function via_send_notices has incomplete parameters list
(#1260) Phpdocs for function via_reset_userdata has incomplete parameters list
(#1437) Invalid phpdocs tag @returns used
(#21) Package mod is not valid
(#1453) Package core_message is not valid
mod/via/locallib.php
(#447) Function via_get_confirmationstatus is not documented
(#364) Phpdocs for function via_get_potential_participants has incomplete parameters list
(#377) Phpdocs for function via_participants has incomplete parameters list
(#416) Phpdocs for function via_create_user_password has incomplete parameters list
(#432) Phpdocs for function via_get_random_letter has incomplete parameters list
(#735) Phpdocs for function via_get_participants_table has incomplete parameters list
(#1149) Phpdocs for function via_make_invitation_reminder_mail_html has incomplete parameters list
(#1287) Phpdocs for function via_make_notice_mail_html has incomplete parameters list
(#1333) Phpdocs for function via_user_type has incomplete parameters list
(#1518) Phpdocs for function via_get_role has incomplete parameters list
(#20) Package mod is not valid
mod/via/manage.form.php
(#21) Package mod is not valid
mod/via/manage.php
(#21) Package mod is not valid
mod/via/mod_form.php
(#300) Phpdocs for function mod_via_mod_form::data_preprocessing has incomplete parameters list
(#345) Phpdocs for function mod_via_mod_form::validation has incomplete parameters list
(#31) Class mod_via_mod_form does not have @copyright tag
(#31) Class mod_via_mod_form does not have @license tag
(#21) Package mod is not valid
mod/via/phpxml.php
(#39) Function xml_unserialize is not documented
(#51) Function xml_serialize is not documented
(#103) Function xml::__construct is not documented
(#111) Function xml::destruct is not documented
(#115) Function xml::parse is not documented
(#122) Function xml::open is not documented
(#151) Function xml::data is not documented
(#157) Function xml::close is not documented
(#169) Function count_numeric_items is not documented
(#97) Variable xml::$parser is not documented
(#98) Variable xml::$document is not documented
(#99) Variable xml::$parent is not documented
(#100) Variable xml::$stack is not documented
(#101) Variable xml::$lastopenedtag is not documented
(#92) Class xml does not have @copyright tag
(#92) Class xml does not have @license tag
(#21) Package mod is not valid
mod/via/presence.php
(#21) Package mod is not valid
mod/via/send_invite.php
(#21) Package mod is not valid
mod/via/settings.php
(#21) Package mod is not valid
mod/via/tabs.php
(#21) Package mod is not valid
mod/via/testadminid.php
(#20) Package mod is not valid
mod/via/uapi/auth.php
(#21) Package mod is not valid
mod/via/uapi/getversion/index.php
(#21) Package mod is not valid
mod/via/version.php
(#21) Package mod is not valid
mod/via/vialib/version24.php
(#93) Function via_playback_viewed_log is not documented
(#97) Function via_playback_downloaded_log is not documented
(#101) Function via_viewed_log is not documented
(#38) Phpdocs for function via_get_module_instance has incomplete parameters list
(#52) Phpdocs for function via_get_course_instance has incomplete parameters list
(#66) Phpdocs for function via_get_system_instance has incomplete parameters list
(#79) Phpdocs for function via_accessed_log has incomplete parameters list
(#21) Package mod is not valid
mod/via/vialib/version27.php
(#37) Phpdocs for function via_get_module_instance has incomplete parameters list
(#50) Phpdocs for function via_get_course_instance has incomplete parameters list
(#63) Phpdocs for function via_get_system_instance has incomplete parameters list
(#70) Phpdocs for function via_accessed_log has incomplete parameters list
(#85) Phpdocs for function via_playback_viewed_log has incomplete parameters list
(#102) Phpdocs for function via_playback_downloaded_log has incomplete parameters list
(#119) Phpdocs for function via_viewed_log has incomplete parameters list
(#21) Package mod is not valid
mod/via/view.assistant.php
(#21) Package mod is not valid
mod/via/view.php
(#21) Package mod is not valid
mod/via/view.via.php
(#21) Package mod is not valid

Update savepoints problems

(12 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]

mod/via/db/upgrade.php
Detected more 'if' blocks (11) than 'savepoint' calls (0)
version 2009042701 is missing corresponding savepoint call
version 2013092002 is missing corresponding savepoint call
version 2014040100 is missing corresponding savepoint call
version 2014080162 is missing corresponding savepoint call
version 2014080163 is missing corresponding savepoint call
version 2014080167 is missing corresponding savepoint call
version 2014110100 is missing corresponding savepoint call
version 2014120101 is missing corresponding savepoint call
version 2015012004 is missing corresponding savepoint call
version 2015050101 is missing corresponding savepoint call
version 2015050103 is missing corresponding savepoint call

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]