Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(6 errors, 5 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/tutorialbooking/classes/output/tutorialbooking.php
(#163) Line exceeds 132 characters; contains 136 characters
mod/tutorialbooking/classes/session.php
(#351) Whitespace found at end of line within string
(#352) Whitespace found at end of line within string
(#386) Whitespace found at end of line within string
mod/tutorialbooking/tests/behat/behat_mod_tutorialbooking.php
(#90) Line exceeds maximum limit of 180 characters; contains 192 characters
(#215) Line exceeds 132 characters; contains 177 characters
(#361) Line exceeds 132 characters; contains 140 characters
(#397) Line exceeds maximum limit of 180 characters; contains 187 characters
(#588) Line exceeds maximum limit of 180 characters; contains 189 characters
mod/tutorialbooking/tests/lib_test.php
(#40) PHPUnit testcase name "mod_tutorialbooking_lib_testcase" does not match file name "lib_test"
(#40) PHPUnit class "mod_tutorialbooking_lib_testcase" does not have any namespace. It is recommended to add it to the "mod_tutorialbooking" namespace, using more levels if needed, in order to match the code being tested

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(11 errors, 75 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

mod/tutorialbooking/backup/moodle2/restore_tutorialbooking_stepslib.php
(#58) Not recommended phpdocs tag @global used
(#81) Not recommended phpdocs tag @global used
(#81) Not recommended phpdocs tag @global used
(#110) Not recommended phpdocs tag @global used
(#133) Not recommended phpdocs tag @global used
mod/tutorialbooking/classes/completion/custom_completion.php
(#45) There is no description in phpdocs for function get_state
(#62) There is no description in phpdocs for function get_defined_custom_rules
(#69) There is no description in phpdocs for function get_custom_rule_descriptions
(#78) There is no description in phpdocs for function get_sort_order
(#45) Phpdocs for function custom_completion::get_state has incomplete parameters list
(#46) Invalid phpdocs tag @inheritDoc used
(#63) Invalid phpdocs tag @inheritDoc used
(#70) Invalid phpdocs tag @inheritDoc used
(#79) Invalid phpdocs tag @inheritDoc used
mod/tutorialbooking/classes/export.php
(#95) Phpdocs for function export::getexportcourse has incomplete parameters list
mod/tutorialbooking/classes/external/details.php
(#47) Not recommended phpdocs tag @global used
mod/tutorialbooking/classes/external/removesignup.php
(#47) Not recommended phpdocs tag @global used
(#47) Not recommended phpdocs tag @global used
mod/tutorialbooking/classes/external/signup.php
(#47) Not recommended phpdocs tag @global used
(#47) Not recommended phpdocs tag @global used
mod/tutorialbooking/classes/external/view.php
(#46) Not recommended phpdocs tag @global used
mod/tutorialbooking/classes/message.php
(#49) Not recommended phpdocs tag @global used
(#80) Not recommended phpdocs tag @global used
(#80) Not recommended phpdocs tag @global used
(#155) Not recommended phpdocs tag @global used
(#155) Not recommended phpdocs tag @global used
mod/tutorialbooking/classes/observer.php
(#63) Not recommended phpdocs tag @global used
mod/tutorialbooking/classes/register.php
(#48) Not recommended phpdocs tag @global used
mod/tutorialbooking/classes/search/session.php
(#40) Not recommended phpdocs tag @global used
(#110) Not recommended phpdocs tag @global used
mod/tutorialbooking/classes/session.php
(#67) Not recommended phpdocs tag @global used
(#117) Not recommended phpdocs tag @global used
(#168) Not recommended phpdocs tag @global used
(#168) Not recommended phpdocs tag @global used
(#231) Not recommended phpdocs tag @global used
(#246) Not recommended phpdocs tag @global used
(#264) Not recommended phpdocs tag @global used
(#278) Not recommended phpdocs tag @global used
(#328) Not recommended phpdocs tag @global used
(#363) Not recommended phpdocs tag @global used
(#414) Not recommended phpdocs tag @global used
(#414) Not recommended phpdocs tag @global used
(#414) Not recommended phpdocs tag @global used
mod/tutorialbooking/classes/session_add_user.php
(#70) Not recommended phpdocs tag @global used
mod/tutorialbooking/classes/task/fix_duplicates.php
(#56) Not recommended phpdocs tag @global used
mod/tutorialbooking/classes/tutorial.php
(#183) Phpdocs for function tutorial::update_events has incomplete parameters list
(#51) Not recommended phpdocs tag @global used
(#68) Not recommended phpdocs tag @global used
(#90) Not recommended phpdocs tag @global used
(#104) Not recommended phpdocs tag @global used
(#142) Not recommended phpdocs tag @global used
(#142) Not recommended phpdocs tag @global used
mod/tutorialbooking/classes/user.php
(#53) Not recommended phpdocs tag @global used
(#53) Not recommended phpdocs tag @global used
(#137) Not recommended phpdocs tag @global used
(#185) Not recommended phpdocs tag @global used
(#216) Not recommended phpdocs tag @global used
(#287) Not recommended phpdocs tag @global used
(#312) Not recommended phpdocs tag @global used
mod/tutorialbooking/tests/behat/behat_mod_tutorialbooking.php
(#91) Not recommended phpdocs tag @global used
(#216) Not recommended phpdocs tag @global used
(#332) Not recommended phpdocs tag @global used
(#362) Not recommended phpdocs tag @global used
(#484) Not recommended phpdocs tag @global used
(#571) Not recommended phpdocs tag @global used
mod/tutorialbooking/tests/external/capabilities_test.php
(#47) Not recommended phpdocs tag @global used
(#97) Not recommended phpdocs tag @global used
(#146) Not recommended phpdocs tag @global used
(#196) Not recommended phpdocs tag @global used
mod/tutorialbooking/tests/external/details_test.php
(#47) Not recommended phpdocs tag @global used
(#127) Not recommended phpdocs tag @global used
mod/tutorialbooking/tests/external/remove_signup_test.php
(#48) Not recommended phpdocs tag @global used
(#103) Not recommended phpdocs tag @global used
(#149) Not recommended phpdocs tag @global used
(#198) Not recommended phpdocs tag @global used
mod/tutorialbooking/tests/external/signup_test.php
(#48) Not recommended phpdocs tag @global used
(#100) Not recommended phpdocs tag @global used
(#149) Not recommended phpdocs tag @global used
(#196) Not recommended phpdocs tag @global used
(#245) Not recommended phpdocs tag @global used
mod/tutorialbooking/tests/external/view_test.php
(#47) Not recommended phpdocs tag @global used
mod/tutorialbooking/tests/generator/lib.php
(#43) Not recommended phpdocs tag @global used
(#43) Not recommended phpdocs tag @global used
(#207) Not recommended phpdocs tag @global used
mod/tutorialbooking/tests/privacy/provider_test.php
(#336) Not recommended phpdocs tag @global used
mod/tutorialbooking/tests/tutorial_test.php
(#310) Not recommended phpdocs tag @global used

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


Missing changes in external functions or backup support for new detected tables or columns

(0 errors, 0 warnings)

This section shows potential problems detected when there are new database structures added in a patch and it is detected that nothing has been changed related with external functions (to be used by WS) or backup and restore. It must be checked that everything is correct and nothing is being missed in those areas. [More info]


grunt changes

(2 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]

mod/tutorialbooking/amd/build/move.min.js
Uncommitted change detected.
mod/tutorialbooking/amd/build/move.min.js.map
Uncommitted change detected.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 24 warnings)

This section shows problems detected in mustache templates [More info]

mod/tutorialbooking/templates/mobile/ionic3/signup.mustache
(#1) Template produced no content
mod/tutorialbooking/templates/mobile/ionic3/slot.mustache
(#1) HTML Validation info, line 21: Attribute “[params]” is not serializable as XML 1.0. ( <button ion-button icon-start core-site-plugins-call-ws name="mod_tutorialbooking_signup" [params]="{slotid: 6}" [preSets]="{getFromCache: 0, saveToCache: 0}" refreshOnSuccess="true"> )
(#1) HTML Validation info, line 21: Attribute “[presets]” is not serializable as XML 1.0. ( <button ion-button icon-start core-site-plugins-call-ws name="mod_tutorialbooking_signup" [params]="{slotid: 6}" [preSets]="{getFromCache: 0, saveToCache: 0}" refreshOnSuccess="true"> )
(#1) HTML Validation error, line 21: Attribute “ion-button” not allowed on element “button” at this point. ( <button ion-button icon-start core-site-plugins-call-ws name="mod_tutorialbooking_signup" [params]="{slotid: 6}" [preSets]="{getFromCache: 0, saveToCache: 0}" refreshOnSuccess="true"> )
(#1) HTML Validation error, line 21: Attribute “icon-start” not allowed on element “button” at this point. ( <button ion-button icon-start core-site-plugins-call-ws name="mod_tutorialbooking_signup" [params]="{slotid: 6}" [preSets]="{getFromCache: 0, saveToCache: 0}" refreshOnSuccess="true"> )
(#1) HTML Validation error, line 21: Attribute “core-site-plugins-call-ws” not allowed on element “button” at this point. ( <button ion-button icon-start core-site-plugins-call-ws name="mod_tutorialbooking_signup" [params]="{slotid: 6}" [preSets]="{getFromCache: 0, saveToCache: 0}" refreshOnSuccess="true"> )
(#1) HTML Validation error, line 21: Attribute “[params]” not allowed on element “button” at this point. ( <button ion-button icon-start core-site-plugins-call-ws name="mod_tutorialbooking_signup" [params]="{slotid: 6}" [preSets]="{getFromCache: 0, saveToCache: 0}" refreshOnSuccess="true"> )
(#1) HTML Validation error, line 21: Attribute “[presets]” not allowed on element “button” at this point. ( <button ion-button icon-start core-site-plugins-call-ws name="mod_tutorialbooking_signup" [params]="{slotid: 6}" [preSets]="{getFromCache: 0, saveToCache: 0}" refreshOnSuccess="true"> )
(#1) HTML Validation error, line 21: Attribute “refreshonsuccess” not allowed on element “button” at this point. ( <button ion-button icon-start core-site-plugins-call-ws name="mod_tutorialbooking_signup" [params]="{slotid: 6}" [preSets]="{getFromCache: 0, saveToCache: 0}" refreshOnSuccess="true"> )
mod/tutorialbooking/templates/mobile/ionic3/tutorialbooking.mustache
(#1) HTML Validation info, line 7: Attribute “[params]” is not serializable as XML 1.0. (. --> <span core-site-plugins-call-ws-on-load name="mod_tutorialbooking_view_tutorialbooking" [params]="{id: 13}" [preSets]="{getFromCache: 0, saveToCache: 0}"></span)
(#1) HTML Validation info, line 7: Attribute “[presets]” is not serializable as XML 1.0. (. --> <span core-site-plugins-call-ws-on-load name="mod_tutorialbooking_view_tutorialbooking" [params]="{id: 13}" [preSets]="{getFromCache: 0, saveToCache: 0}"></span)
(#1) HTML Validation error, line 7: Attribute “core-site-plugins-call-ws-on-load” not allowed on element “span” at this point. (. --> <span core-site-plugins-call-ws-on-load name="mod_tutorialbooking_view_tutorialbooking" [params]="{id: 13}" [preSets]="{getFromCache: 0, saveToCache: 0}"></span)
(#1) HTML Validation error, line 7: Attribute “name” not allowed on element “span” at this point. (. --> <span core-site-plugins-call-ws-on-load name="mod_tutorialbooking_view_tutorialbooking" [params]="{id: 13}" [preSets]="{getFromCache: 0, saveToCache: 0}"></span)
(#1) HTML Validation error, line 7: Attribute “[params]” not allowed on element “span” at this point. (. --> <span core-site-plugins-call-ws-on-load name="mod_tutorialbooking_view_tutorialbooking" [params]="{id: 13}" [preSets]="{getFromCache: 0, saveToCache: 0}"></span)
(#1) HTML Validation error, line 7: Attribute “[presets]” not allowed on element “span” at this point. (. --> <span core-site-plugins-call-ws-on-load name="mod_tutorialbooking_view_tutorialbooking" [params]="{id: 13}" [preSets]="{getFromCache: 0, saveToCache: 0}"></span)
mod/tutorialbooking/templates/mobile/latest/signup.mustache
(#1) Template produced no content
mod/tutorialbooking/templates/mobile/latest/slot.mustache
(#1) HTML Validation info, line 21: Attribute “[params]” is not serializable as XML 1.0. ( <ion-button size="default" core-site-plugins-call-ws name="mod_tutorialbooking_signup" [params]="{slotid: 6}" [preSets]="{getFromCache: 0, saveToCache: 0}" refreshOnSuccess="true"> )
(#1) HTML Validation info, line 21: Attribute “[presets]” is not serializable as XML 1.0. ( <ion-button size="default" core-site-plugins-call-ws name="mod_tutorialbooking_signup" [params]="{slotid: 6}" [preSets]="{getFromCache: 0, saveToCache: 0}" refreshOnSuccess="true"> )
mod/tutorialbooking/templates/mobile/latest/tutorialbooking.mustache
(#1) HTML Validation info, line 7: Attribute “[params]” is not serializable as XML 1.0. (. --> <span core-site-plugins-call-ws-on-load name="mod_tutorialbooking_view_tutorialbooking" [params]="{id: 13}" [preSets]="{getFromCache: 0, saveToCache: 0}"></span)
(#1) HTML Validation info, line 7: Attribute “[presets]” is not serializable as XML 1.0. (. --> <span core-site-plugins-call-ws-on-load name="mod_tutorialbooking_view_tutorialbooking" [params]="{id: 13}" [preSets]="{getFromCache: 0, saveToCache: 0}"></span)
(#1) HTML Validation error, line 7: Attribute “core-site-plugins-call-ws-on-load” not allowed on element “span” at this point. (. --> <span core-site-plugins-call-ws-on-load name="mod_tutorialbooking_view_tutorialbooking" [params]="{id: 13}" [preSets]="{getFromCache: 0, saveToCache: 0}"></span)
(#1) HTML Validation error, line 7: Attribute “name” not allowed on element “span” at this point. (. --> <span core-site-plugins-call-ws-on-load name="mod_tutorialbooking_view_tutorialbooking" [params]="{id: 13}" [preSets]="{getFromCache: 0, saveToCache: 0}"></span)
(#1) HTML Validation error, line 7: Attribute “[params]” not allowed on element “span” at this point. (. --> <span core-site-plugins-call-ws-on-load name="mod_tutorialbooking_view_tutorialbooking" [params]="{id: 13}" [preSets]="{getFromCache: 0, saveToCache: 0}"></span)
(#1) HTML Validation error, line 7: Attribute “[presets]” not allowed on element “span” at this point. (. --> <span core-site-plugins-call-ws-on-load name="mod_tutorialbooking_view_tutorialbooking" [params]="{id: 13}" [preSets]="{getFromCache: 0, saveToCache: 0}"></span)
mod/tutorialbooking/templates/student_signup.mustache
(#1) HTML Validation error, line 2: Element “li” not allowed as child of element “body” in this context. (Suppressing further errors from this subtree.) (ad><body><li class="signedupuser">Jane S)
mod/tutorialbooking/templates/teacher_signup.mustache
(#1) HTML Validation error, line 2: Element “li” not allowed as child of element “body” in this context. (Suppressing further errors from this subtree.) (ad><body><li class="signedupuser"><a hre)

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]