Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(10 errors, 57 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/tutorialbooking/backup/moodle2/backup_tutorialbooking_activity_task.class.php
(#60) The static declaration must come after the visibility declaration
mod/tutorialbooking/backup/moodle2/restore_tutorialbooking_activity_task.class.php
(#58) The static declaration must come after the visibility declaration
(#67) The static declaration must come after the visibility declaration
(#78) The static declaration must come after the visibility declaration
(#94) The static declaration must come after the visibility declaration
mod/tutorialbooking/classes/event/session_added.php
(#96) Line exceeds 132 characters; contains 137 characters
mod/tutorialbooking/classes/event/session_deleted.php
(#96) Line exceeds 132 characters; contains 140 characters
mod/tutorialbooking/classes/event/session_updated.php
(#96) Line exceeds 132 characters; contains 140 characters
mod/tutorialbooking/classes/external/capabilities.php
(#88) Line exceeds 132 characters; contains 133 characters
(#93) Line exceeds 132 characters; contains 145 characters
mod/tutorialbooking/classes/external/details.php
(#121) Line exceeds 132 characters; contains 142 characters
(#127) Line exceeds 132 characters; contains 136 characters
(#133) Line exceeds 132 characters; contains 153 characters
mod/tutorialbooking/classes/external/moveslot.php
(#94) Line exceeds 132 characters; contains 146 characters
mod/tutorialbooking/classes/external/signup.php
(#50) PHP4 style constructors are not allowed; use "__construct()" instead
mod/tutorialbooking/classes/external/view.php
(#50) PHP4 style constructors are not allowed; use "__construct()" instead
mod/tutorialbooking/classes/output/slot.php
(#75) Line exceeds 132 characters; contains 150 characters
mod/tutorialbooking/classes/output/tutorialbooking.php
(#160) Line exceeds 132 characters; contains 136 characters
mod/tutorialbooking/classes/session.php
(#123) Line exceeds 132 characters; contains 136 characters
(#185) Line exceeds 132 characters; contains 144 characters
(#456) Line exceeds 132 characters; contains 138 characters
mod/tutorialbooking/classes/task/fix_duplicates.php
(#63) Line exceeds 132 characters; contains 134 characters
mod/tutorialbooking/classes/user.php
(#67) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#69) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#71) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#97) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#153) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#219) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#222) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#229) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
mod/tutorialbooking/db/log.php
(#29) Line exceeds 132 characters; contains 133 characters
(#30) Line exceeds 132 characters; contains 136 characters
(#31) Line exceeds 132 characters; contains 136 characters
mod/tutorialbooking/index.php
(#99) Line exceeds 132 characters; contains 145 characters
mod/tutorialbooking/tests/behat/behat_mod_tutorialbooking.php
(#83) Line exceeds 132 characters; contains 138 characters
(#87) Line exceeds maximum limit of 180 characters; contains 192 characters
(#202) Line exceeds 132 characters; contains 177 characters
(#246) Line exceeds 132 characters; contains 133 characters
(#258) Line exceeds 132 characters; contains 141 characters
(#313) Line exceeds 132 characters; contains 145 characters
(#320) Line exceeds 132 characters; contains 140 characters
(#346) Line exceeds 132 characters; contains 135 characters
(#353) Line exceeds maximum limit of 180 characters; contains 187 characters
(#408) Line exceeds 132 characters; contains 137 characters
(#415) Line exceeds 132 characters; contains 141 characters
(#419) Line exceeds 132 characters; contains 139 characters
(#534) Line exceeds maximum limit of 180 characters; contains 189 characters
(#540) Line exceeds 132 characters; contains 139 characters
mod/tutorialbooking/tests/message_test.php
(#90) Line exceeds 132 characters; contains 134 characters
mod/tutorialbooking/tests/privacy_provider_test.php
(#383) Line exceeds 132 characters; contains 136 characters
mod/tutorialbooking/tests/user_test.php
(#99) Line exceeds 132 characters; contains 138 characters
(#102) Line exceeds 132 characters; contains 140 characters
(#106) Line exceeds 132 characters; contains 142 characters
(#107) Line exceeds 132 characters; contains 133 characters
(#110) Line exceeds 132 characters; contains 135 characters
(#117) Line exceeds 132 characters; contains 142 characters
(#118) Line exceeds 132 characters; contains 139 characters
(#121) Line exceeds 132 characters; contains 135 characters
(#128) Line exceeds 132 characters; contains 145 characters
(#138) Line exceeds 132 characters; contains 141 characters
(#141) Line exceeds 132 characters; contains 141 characters
(#144) Line exceeds 132 characters; contains 138 characters
(#147) Line exceeds 132 characters; contains 140 characters
(#151) Line exceeds 132 characters; contains 145 characters
(#162) Line exceeds 132 characters; contains 142 characters
mod/tutorialbooking/tutorialbooking_sessions.php
(#77) Line exceeds 132 characters; contains 138 characters
(#88) Line exceeds 132 characters; contains 146 characters

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(2 errors, 80 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

mod/tutorialbooking/backup/moodle2/restore_tutorialbooking_stepslib.php
(#60) Not recommended phpdocs tag @global used
(#83) Not recommended phpdocs tag @global used
(#83) Not recommended phpdocs tag @global used
(#112) Not recommended phpdocs tag @global used
(#135) Not recommended phpdocs tag @global used
mod/tutorialbooking/classes/external/details.php
(#45) Not recommended phpdocs tag @global used
mod/tutorialbooking/classes/external/removesignup.php
(#45) Not recommended phpdocs tag @global used
(#45) Not recommended phpdocs tag @global used
mod/tutorialbooking/classes/external/signup.php
(#45) Not recommended phpdocs tag @global used
(#45) Not recommended phpdocs tag @global used
mod/tutorialbooking/classes/external/view.php
(#46) Not recommended phpdocs tag @global used
mod/tutorialbooking/classes/message.php
(#45) Not recommended phpdocs tag @global used
(#76) Not recommended phpdocs tag @global used
(#76) Not recommended phpdocs tag @global used
(#151) Not recommended phpdocs tag @global used
(#151) Not recommended phpdocs tag @global used
mod/tutorialbooking/classes/observer.php
(#63) Not recommended phpdocs tag @global used
mod/tutorialbooking/classes/register.php
(#48) Not recommended phpdocs tag @global used
mod/tutorialbooking/classes/search/session.php
(#42) Not recommended phpdocs tag @global used
(#112) Not recommended phpdocs tag @global used
mod/tutorialbooking/classes/session.php
(#162) Phpdocs for function mod_tutorialbooking_session::generate_editsession_formdata has incomplete parameters list
(#64) Not recommended phpdocs tag @global used
(#114) Not recommended phpdocs tag @global used
(#160) Not recommended phpdocs tag @global used
(#160) Not recommended phpdocs tag @global used
(#218) Not recommended phpdocs tag @global used
(#233) Not recommended phpdocs tag @global used
(#251) Not recommended phpdocs tag @global used
(#265) Not recommended phpdocs tag @global used
(#315) Not recommended phpdocs tag @global used
(#346) Not recommended phpdocs tag @global used
(#393) Not recommended phpdocs tag @global used
(#393) Not recommended phpdocs tag @global used
(#393) Not recommended phpdocs tag @global used
mod/tutorialbooking/classes/session_add_user.php
(#64) Not recommended phpdocs tag @global used
mod/tutorialbooking/classes/task/fix_duplicates.php
(#58) Not recommended phpdocs tag @global used
mod/tutorialbooking/classes/tutorial.php
(#174) Phpdocs for function mod_tutorialbooking_tutorial::update_events has incomplete parameters list
(#48) Not recommended phpdocs tag @global used
(#65) Not recommended phpdocs tag @global used
(#87) Not recommended phpdocs tag @global used
(#101) Not recommended phpdocs tag @global used
(#133) Not recommended phpdocs tag @global used
(#133) Not recommended phpdocs tag @global used
mod/tutorialbooking/classes/user.php
(#47) Not recommended phpdocs tag @global used
(#47) Not recommended phpdocs tag @global used
(#127) Not recommended phpdocs tag @global used
(#169) Not recommended phpdocs tag @global used
(#200) Not recommended phpdocs tag @global used
(#271) Not recommended phpdocs tag @global used
(#296) Not recommended phpdocs tag @global used
mod/tutorialbooking/tests/behat/behat_mod_tutorialbooking.php
(#88) Not recommended phpdocs tag @global used
(#203) Not recommended phpdocs tag @global used
(#294) Not recommended phpdocs tag @global used
(#321) Not recommended phpdocs tag @global used
(#430) Not recommended phpdocs tag @global used
(#517) Not recommended phpdocs tag @global used
mod/tutorialbooking/tests/generator/lib.php
(#43) Not recommended phpdocs tag @global used
(#43) Not recommended phpdocs tag @global used
(#207) Not recommended phpdocs tag @global used
mod/tutorialbooking/tests/privacy_provider_test.php
(#338) Not recommended phpdocs tag @global used
mod/tutorialbooking/tests/tutorial_test.php
(#308) Not recommended phpdocs tag @global used
mod/tutorialbooking/tests/webservice_capabiliies_test.php
(#45) Not recommended phpdocs tag @global used
(#83) Not recommended phpdocs tag @global used
(#120) Not recommended phpdocs tag @global used
(#158) Not recommended phpdocs tag @global used
mod/tutorialbooking/tests/webservice_details_test.php
(#45) Not recommended phpdocs tag @global used
(#113) Not recommended phpdocs tag @global used
mod/tutorialbooking/tests/webservice_moveslot_test.php
(#44) Not recommended phpdocs tag @global used
(#68) Not recommended phpdocs tag @global used
(#92) Not recommended phpdocs tag @global used
(#110) Not recommended phpdocs tag @global used
(#127) Not recommended phpdocs tag @global used
mod/tutorialbooking/tests/webservice_remove_signup_test.php
(#46) Not recommended phpdocs tag @global used
(#89) Not recommended phpdocs tag @global used
(#123) Not recommended phpdocs tag @global used
(#160) Not recommended phpdocs tag @global used
mod/tutorialbooking/tests/webservice_signup_test.php
(#45) Not recommended phpdocs tag @global used
(#85) Not recommended phpdocs tag @global used
(#122) Not recommended phpdocs tag @global used
(#157) Not recommended phpdocs tag @global used
(#194) Not recommended phpdocs tag @global used
mod/tutorialbooking/tests/webservice_view_test.php
(#44) Not recommended phpdocs tag @global used

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 27 warnings)

This section shows problems detected in mustache templates [More info]

mod/tutorialbooking/templates/mobile/ionic3/signup.mustache
(#1) Template produced no content
mod/tutorialbooking/templates/mobile/ionic3/slot.mustache
(#1) HTML Validation info, line 21: Attribute “[params]” is not serializable as XML 1.0. ( <button ion-button icon-start core-site-plugins-call-ws name="mod_tutorialbooking_signup" [params]="{slotid: 6}" [preSets]="{getFromCache: 0, saveToCache: 0}" refreshOnSuccess="true"> )
(#1) HTML Validation info, line 21: Attribute “[presets]” is not serializable as XML 1.0. ( <button ion-button icon-start core-site-plugins-call-ws name="mod_tutorialbooking_signup" [params]="{slotid: 6}" [preSets]="{getFromCache: 0, saveToCache: 0}" refreshOnSuccess="true"> )
(#1) HTML Validation error, line 21: Attribute “ion-button” not allowed on element “button” at this point. ( <button ion-button icon-start core-site-plugins-call-ws name="mod_tutorialbooking_signup" [params]="{slotid: 6}" [preSets]="{getFromCache: 0, saveToCache: 0}" refreshOnSuccess="true"> )
(#1) HTML Validation error, line 21: Attribute “icon-start” not allowed on element “button” at this point. ( <button ion-button icon-start core-site-plugins-call-ws name="mod_tutorialbooking_signup" [params]="{slotid: 6}" [preSets]="{getFromCache: 0, saveToCache: 0}" refreshOnSuccess="true"> )
(#1) HTML Validation error, line 21: Attribute “core-site-plugins-call-ws” not allowed on element “button” at this point. ( <button ion-button icon-start core-site-plugins-call-ws name="mod_tutorialbooking_signup" [params]="{slotid: 6}" [preSets]="{getFromCache: 0, saveToCache: 0}" refreshOnSuccess="true"> )
(#1) HTML Validation error, line 21: Attribute “[params]” not allowed on element “button” at this point. ( <button ion-button icon-start core-site-plugins-call-ws name="mod_tutorialbooking_signup" [params]="{slotid: 6}" [preSets]="{getFromCache: 0, saveToCache: 0}" refreshOnSuccess="true"> )
(#1) HTML Validation error, line 21: Attribute “[presets]” not allowed on element “button” at this point. ( <button ion-button icon-start core-site-plugins-call-ws name="mod_tutorialbooking_signup" [params]="{slotid: 6}" [preSets]="{getFromCache: 0, saveToCache: 0}" refreshOnSuccess="true"> )
(#1) HTML Validation error, line 21: Attribute “refreshonsuccess” not allowed on element “button” at this point. ( <button ion-button icon-start core-site-plugins-call-ws name="mod_tutorialbooking_signup" [params]="{slotid: 6}" [preSets]="{getFromCache: 0, saveToCache: 0}" refreshOnSuccess="true"> )
mod/tutorialbooking/templates/mobile/ionic3/tutorialbooking.mustache
(#1) HTML Validation info, line 7: Attribute “[params]” is not serializable as XML 1.0. (. --> <span core-site-plugins-call-ws-on-load name="mod_tutorialbooking_view_tutorialbooking" [params]="{id: 13}" [preSets]="{getFromCache: 0, saveToCache: 0}"></span)
(#1) HTML Validation info, line 7: Attribute “[presets]” is not serializable as XML 1.0. (. --> <span core-site-plugins-call-ws-on-load name="mod_tutorialbooking_view_tutorialbooking" [params]="{id: 13}" [preSets]="{getFromCache: 0, saveToCache: 0}"></span)
(#1) HTML Validation error, line 7: Attribute “core-site-plugins-call-ws-on-load” not allowed on element “span” at this point. (. --> <span core-site-plugins-call-ws-on-load name="mod_tutorialbooking_view_tutorialbooking" [params]="{id: 13}" [preSets]="{getFromCache: 0, saveToCache: 0}"></span)
(#1) HTML Validation error, line 7: Attribute “name” not allowed on element “span” at this point. (. --> <span core-site-plugins-call-ws-on-load name="mod_tutorialbooking_view_tutorialbooking" [params]="{id: 13}" [preSets]="{getFromCache: 0, saveToCache: 0}"></span)
(#1) HTML Validation error, line 7: Attribute “[params]” not allowed on element “span” at this point. (. --> <span core-site-plugins-call-ws-on-load name="mod_tutorialbooking_view_tutorialbooking" [params]="{id: 13}" [preSets]="{getFromCache: 0, saveToCache: 0}"></span)
(#1) HTML Validation error, line 7: Attribute “[presets]” not allowed on element “span” at this point. (. --> <span core-site-plugins-call-ws-on-load name="mod_tutorialbooking_view_tutorialbooking" [params]="{id: 13}" [preSets]="{getFromCache: 0, saveToCache: 0}"></span)
mod/tutorialbooking/templates/mobile/latest/signup.mustache
(#1) Template produced no content
mod/tutorialbooking/templates/mobile/latest/slot.mustache
(#1) HTML Validation info, line 21: Attribute “[params]” is not serializable as XML 1.0. ( <ion-button size="default" core-site-plugins-call-ws name="mod_tutorialbooking_signup" [params]="{slotid: 6}" [preSets]="{getFromCache: 0, saveToCache: 0}" refreshOnSuccess="true"> )
(#1) HTML Validation info, line 21: Attribute “[presets]” is not serializable as XML 1.0. ( <ion-button size="default" core-site-plugins-call-ws name="mod_tutorialbooking_signup" [params]="{slotid: 6}" [preSets]="{getFromCache: 0, saveToCache: 0}" refreshOnSuccess="true"> )
mod/tutorialbooking/templates/mobile/latest/tutorialbooking.mustache
(#1) HTML Validation info, line 7: Attribute “[params]” is not serializable as XML 1.0. (. --> <span core-site-plugins-call-ws-on-load name="mod_tutorialbooking_view_tutorialbooking" [params]="{id: 13}" [preSets]="{getFromCache: 0, saveToCache: 0}"></span)
(#1) HTML Validation info, line 7: Attribute “[presets]” is not serializable as XML 1.0. (. --> <span core-site-plugins-call-ws-on-load name="mod_tutorialbooking_view_tutorialbooking" [params]="{id: 13}" [preSets]="{getFromCache: 0, saveToCache: 0}"></span)
(#1) HTML Validation error, line 7: Attribute “core-site-plugins-call-ws-on-load” not allowed on element “span” at this point. (. --> <span core-site-plugins-call-ws-on-load name="mod_tutorialbooking_view_tutorialbooking" [params]="{id: 13}" [preSets]="{getFromCache: 0, saveToCache: 0}"></span)
(#1) HTML Validation error, line 7: Attribute “name” not allowed on element “span” at this point. (. --> <span core-site-plugins-call-ws-on-load name="mod_tutorialbooking_view_tutorialbooking" [params]="{id: 13}" [preSets]="{getFromCache: 0, saveToCache: 0}"></span)
(#1) HTML Validation error, line 7: Attribute “[params]” not allowed on element “span” at this point. (. --> <span core-site-plugins-call-ws-on-load name="mod_tutorialbooking_view_tutorialbooking" [params]="{id: 13}" [preSets]="{getFromCache: 0, saveToCache: 0}"></span)
(#1) HTML Validation error, line 7: Attribute “[presets]” not allowed on element “span” at this point. (. --> <span core-site-plugins-call-ws-on-load name="mod_tutorialbooking_view_tutorialbooking" [params]="{id: 13}" [preSets]="{getFromCache: 0, saveToCache: 0}"></span)
mod/tutorialbooking/templates/student_signup.mustache
(#1) HTML Validation error, line 2: Element “li” not allowed as child of element “body” in this context. (Suppressing further errors from this subtree.) (ad><body><li class="signedupuser">Jane S)
mod/tutorialbooking/templates/student_tutorialbooking.mustache
(#1) HTML Validation info, line 2: Empty heading. (tutorial"><h2 class="sectionname"></h2>)
mod/tutorialbooking/templates/teacher_signup.mustache
(#1) HTML Validation error, line 2: Element “li” not allowed as child of element “body” in this context. (Suppressing further errors from this subtree.) (ad><body><li class="signedupuser"><a hre)
mod/tutorialbooking/templates/teacher_tutorialbooking.mustache
(#1) HTML Validation info, line 3: Empty heading. (ial"> <h2 class="sectionname"></h2>)
(#1) ESLint error [semi]: Missing semicolon. ( ), Line: 4 Column: 3

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]