Comments

• 

  Aparup Banerjee

  Mon, 12 Aug 2013, 1:07 PM

  Hi Andrew,
  Thanks for submitting your plugin entry, i've just had a look through it and here's some feedback:
  - The Bug tracker link should preferably be able to handle multiple issues being created. This would mean it could either be under https://github.com/garemoko/MoodleLaunch/issues or under https://tracker.moodle.org/browse/CONTRIB (once requested). You could probably link to MDL-35433 from description or from your preferred issue tracker for posterity.
  
  - The Discussion link : https://moodle.org/mod/forum/discuss.php?d=233707 could perhaps be moved, if you desire, to general add-ons forum or a (ask Helen) and 'Discussion' link here updated to point to that. The discussion link seems to make sense pointing to the MDL for now but for the future its best to point it to a forum area as the MDL issue will likely be closed.
  
  - The repository name: we're following a convention for Moodle plugins in the form of moodle-{plugintype}_{pluginname} , mentioned at http://docs.moodle.org/dev/Guidelines_for_contributed_code#How_to_submit_code . In this case renaming from MoodleLaunch to moodle-mod_tincanlaunch would match up with your plugin's code.
  
  
  https://tracker.moodle.org/browse/MDL-35433?focusedCommentId=236515&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-236515
  Based on that comment I've gone and added this into a TinCan set, you can mention this set in future to have them grouped into it.
  
  ps: The general plugin infrastructure seems to be working good and the installation went smoothly. I did try to set it up with a link to google.com but the new window wouldn't pop up, its probably setup incorrectly though.
  
• 

  Andrew Downes

  Sat, 31 Aug 2013, 4:57 AM

  Hi,
  I've made the changes you suggested.
  
  Thanks,
  
  Andrew
• 

  Anthony Borrow

  Tue, 10 Sept 2013, 5:37 AM

  Andrew - Many thanks taking care of the issues Aparup mentioned. I looked and the readme file seemed to be the generic one rather than something specific to the file. Perhaps you could update that so that it either contains the information on the documentation page or at least the URL pointing to it. Also, there were some validation warnings:
  
  Maturity information ($module->maturity) not found in version.php
  Release name ($module->release) not found in version.php
  
  that should be pretty easy to fix up. Peace - Anthony
• 

  Anthony Borrow

  Tue, 10 Sept 2013, 6:04 AM

  Andrew - Documentation could probably be improved to help folks get a quick start. In particular, the concept of endpoint and launch URL probably needs some explaining. Perhaps you could provide folks with an example they can play with a little. I'm going to go ahead and approve this entry so that folks can begin playing around with it and give you further feedback. Keep up the good work! Peace - Anthony