Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(0 errors, 72 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/studentquiz/backup/moodle2/restore_studentquiz_stepslib.php
(#264) Inline comments must end in full-stops, exclamation marks, or question marks
mod/studentquiz/classes/condition/studentquiz_condition.php
(#107) Inline comments must end in full-stops, exclamation marks, or question marks
(#108) Line exceeds 132 characters; contains 148 characters
(#112) Inline comments must end in full-stops, exclamation marks, or question marks
(#113) Line exceeds 132 characters; contains 147 characters
mod/studentquiz/classes/privacy/provider.php
(#45) Duplicate interface name "mod_studentquiz\privacy\studentquiz_userlist" found; first defined in /var/lib/jenkins/git_repositories/prechecker/mod/studentquiz/classes/privacy/provider.php on line 41
(#192) Line exceeds 132 characters; contains 147 characters
(#197) Line exceeds 132 characters; contains 138 characters
mod/studentquiz/classes/question/bank/difficulty_level_column.php
(#90) Line exceeds 132 characters; contains 152 characters
(#103) Line exceeds 132 characters; contains 144 characters
mod/studentquiz/classes/question/bank/sq_hidden_column.php
(#92) Line exceeds 132 characters; contains 134 characters
mod/studentquiz/classes/question/bank/studentquiz_bank_view.php
(#136) Line exceeds 132 characters; contains 138 characters
(#200) Inline comments must end in full-stops, exclamation marks, or question marks
(#258) Inline comments must end in full-stops, exclamation marks, or question marks
(#445) Line exceeds 132 characters; contains 144 characters
(#452) Line exceeds 132 characters; contains 158 characters
(#617) Line exceeds 132 characters; contains 133 characters
(#619) Line exceeds 132 characters; contains 134 characters
(#623) Line exceeds 132 characters; contains 135 characters
(#625) Line exceeds 132 characters; contains 133 characters
mod/studentquiz/db/upgrade.php
(#575) Line exceeds 132 characters; contains 139 characters
mod/studentquiz/externallib.php
(#73) Inline comments must end in full-stops, exclamation marks, or question marks
mod/studentquiz/lib.php
(#124) Inline comments must start with a capital letter, digit or 3-dots sequence
(#124) Inline comments must end in full-stops, exclamation marks, or question marks
mod/studentquiz/locallib.php
(#84) Line exceeds 132 characters; contains 155 characters
(#207) Line exceeds 132 characters; contains 136 characters
mod/studentquiz/mod_form.php
(#196) Inline comments must end in full-stops, exclamation marks, or question marks
mod/studentquiz/renderer.php
(#269) Line exceeds 132 characters; contains 164 characters
(#270) Line exceeds 132 characters; contains 166 characters
(#372) Inline comments must end in full-stops, exclamation marks, or question marks
(#383) The use of backticks in strings is not recommended
(#383) The use of backticks in strings is not recommended
(#383) The use of backticks in strings is not recommended
(#879) Line exceeds 132 characters; contains 145 characters
(#1002) Line exceeds 132 characters; contains 133 characters
(#1004) Line exceeds 132 characters; contains 133 characters
(#1024) Line exceeds 132 characters; contains 151 characters
(#1027) Line exceeds 132 characters; contains 157 characters
(#1315) Inline comments must start with a capital letter, digit or 3-dots sequence
(#1315) Inline comments must end in full-stops, exclamation marks, or question marks
(#1322) Line exceeds 132 characters; contains 153 characters
(#1329) Line exceeds 132 characters; contains 151 characters
(#1857) Line exceeds 132 characters; contains 142 characters
(#1859) Line exceeds 132 characters; contains 133 characters
(#1860) Inline comments must end in full-stops, exclamation marks, or question marks
mod/studentquiz/tests/behat/behat_mod_studentquiz.php
(#41) Line exceeds 132 characters; contains 137 characters
mod/studentquiz/tests/privacy_test.php
(#198) This comment is 70% valid code; is this commented out code?
(#344) Line exceeds 132 characters; contains 135 characters
(#350) This comment is 65% valid code; is this commented out code?
(#414) Line exceeds 132 characters; contains 135 characters
(#423) Line exceeds 132 characters; contains 135 characters
(#431) Inline comments must end in full-stops, exclamation marks, or question marks
(#431) This comment is 70% valid code; is this commented out code?
(#463) Line exceeds 132 characters; contains 135 characters
(#475) Line exceeds 132 characters; contains 135 characters
(#486) Line exceeds 132 characters; contains 135 characters
(#622) Inline comments must end in full-stops, exclamation marks, or question marks
(#624) This comment is 75% valid code; is this commented out code?
(#624) Inline comments must start with a capital letter, digit or 3-dots sequence
(#636) Inline comments must end in full-stops, exclamation marks, or question marks
(#636) This comment is 75% valid code; is this commented out code?
(#745) Inline comments must end in full-stops, exclamation marks, or question marks
mod/studentquiz/tests/report_test.php
(#109) Line exceeds 132 characters; contains 134 characters
(#110) Line exceeds 132 characters; contains 134 characters
(#111) Line exceeds 132 characters; contains 134 characters
(#112) Line exceeds 132 characters; contains 134 characters
(#180) Line exceeds 132 characters; contains 158 characters
mod/studentquiz/tests/studentquiz_bank_view_test.php
(#248) Inline comments must start with a capital letter, digit or 3-dots sequence
(#248) Inline comments must end in full-stops, exclamation marks, or question marks
mod/studentquiz/tests/studentquiz_comment_test.php
(#135) Line exceeds 132 characters; contains 141 characters
mod/studentquiz/view.php
(#82) Inline comments must end in full-stops, exclamation marks, or question marks
mod/studentquiz/viewlib.php
(#130) Inline comments must end in full-stops, exclamation marks, or question marks

Javascript coding style problems

(0 errors, 12 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

mod/studentquiz/amd/src/comment_area.js
(#582) Unexpected @returns tag; function has no return statement. (valid-jsdoc)
mod/studentquiz/amd/src/state_change.js
(#25) Unexpected space before function parentheses. (space-before-function-paren)
(#37) Unexpected space before function parentheses. (space-before-function-paren)
(#44) Unexpected space before function parentheses. (space-before-function-paren)
(#55) Unexpected space before function parentheses. (space-before-function-paren)
(#58) Unexpected space before function parentheses. (space-before-function-paren)
(#69) There should be no space after '{'. (babel/object-curly-spacing)
(#69) There should be no space before '}'. (babel/object-curly-spacing)
(#70) Each then() should return a value or throw (promise/always-return)
(#70) Unexpected space before function parentheses. (space-before-function-paren)
(#87) Unexpected space before function parentheses. (space-before-function-paren)
(#91) Unexpected space before function parentheses. (space-before-function-paren)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(184 errors, 2 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

mod/studentquiz/backup/moodle2/restore_studentquiz_stepslib.php
(#156) Function restore_studentquiz_activity_structure_step::process_attempt is not documented
(#165) Function restore_studentquiz_activity_structure_step::process_progress is not documented
(#174) Function restore_studentquiz_activity_structure_step::process_rate is not documented
(#182) Function restore_studentquiz_activity_structure_step::process_comment is not documented
(#203) Function restore_studentquiz_activity_structure_step::process_question_meta is not documented
(#234) Function restore_studentquiz_activity_structure_step::inform_new_usage_id is not documented
(#271) Phpdocs for function restore_studentquiz_activity_structure_step::get_mappingid_or_null has incomplete parameters list
mod/studentquiz/classes/commentarea/container.php
(#654) Function container::get_fields is not documented
(#594) Phpdocs for function container::has_comment has incomplete parameters list
(#834) Phpdocs for function container::resort has incomplete parameters list
mod/studentquiz/classes/commentarea/form/comment_report_form.php
(#127) Phpdocs for function comment_report_form::check_validate_checkboxes has incomplete parameters list
mod/studentquiz/classes/condition/studentquiz_condition.php
(#52) Function studentquiz_condition::__construct is not documented
(#77) Function studentquiz_condition::is_filter_active is not documented
(#83) Function studentquiz_condition::is_tag_filter_active is not documented
(#87) Function studentquiz_condition::init is not documented
(#141) Function studentquiz_condition::get_special_sql is not documented
(#151) Function studentquiz_condition::get_sql_field is not documented
(#62) Variable studentquiz_condition::$cm is not documented
(#64) Variable studentquiz_condition::$filterform is not documented
(#66) Variable studentquiz_condition::$studentquiz is not documented
(#71) Variable studentquiz_condition::$tests is not documented
(#73) Variable studentquiz_condition::$params is not documented
(#75) Variable studentquiz_condition::$isfilteractive is not documented
(#81) Variable studentquiz_condition::$istagfilteractive is not documented
(#17) No one-line description found in phpdocs for file
(#199) There is no description in phpdocs for function where
(#200) Invalid phpdocs tag @Return used
mod/studentquiz/classes/event/studentquiz_question_comment_created.php
(#28) Class comment_created is not documented
mod/studentquiz/classes/local/external/get_comments_api.php
(#87) Phpdocs for function get_comments_api::get_comments has incomplete parameters list
mod/studentquiz/classes/local/studentquiz_helper.php
(#40) Constant studentquiz_helper::STATE_DISAPPROVED is not documented
(#41) Constant studentquiz_helper::STATE_APPROVED is not documented
(#42) Constant studentquiz_helper::STATE_NEW is not documented
(#43) Constant studentquiz_helper::STATE_CHANGED is not documented
(#44) Constant studentquiz_helper::STATE_HIDE is not documented
(#45) Constant studentquiz_helper::STATE_DELETE is not documented
(#47) Phpdocs for variable studentquiz_helper::$statename does not contain @var or incorrect
mod/studentquiz/classes/privacy/provider.php
(#682) Phpdocs for function provider::delete_comment_for_users has incomplete parameters list
(#709) Phpdocs for function provider::delete_comment_for_user has incomplete parameters list
(#17) File-level phpdocs block does not have @copyright tag
mod/studentquiz/classes/question/bank/anonym_creator_name_column.php
(#56) Function anonym_creator_name_column::display_content is not documented
(#38) Variable anonym_creator_name_column::$currentuserid is not documented
(#40) Variable anonym_creator_name_column::$anonymize is not documented
(#42) Variable anonym_creator_name_column::$anonymousname is not documented
(#44) Variable anonym_creator_name_column::$renderer is not documented
mod/studentquiz/classes/question/bank/comments_column.php
(#37) Variable comment_column::$renderer is not documented
mod/studentquiz/classes/question/bank/difficulty_level_column.php
(#38) Variable difficulty_level_column::$renderer is not documented
(#40) Variable difficulty_level_column::$studentquiz is not documented
(#58) Variable difficulty_level_column::$sqlparams is not documented
mod/studentquiz/classes/question/bank/practice_column.php
(#37) Variable practice_column::$renderer is not documented
mod/studentquiz/classes/question/bank/preview_column.php
(#38) Variable preview_column::$renderer is not documented
(#39) Variable preview_column::$context is not documented
(#40) Variable preview_column::$previewtext is not documented
mod/studentquiz/classes/question/bank/question_bank_filter.php
(#292) Class toggle_filter_checkbox is not documented
(#357) Class user_filter_tag is not documented
(#124) Function studentquiz_user_filter_text::setupForm is not documented
(#154) Function studentquiz_user_filter_date::setupForm is not documented
(#320) Function toggle_filter_checkbox::setup_form_in_group is not documented
(#338) Function toggle_filter_checkbox::get_sql_filter is not documented
(#484) Function user_filter_percent::get_sql_filter is not documented
(#294) Variable toggle_filter_checkbox::$operator is not documented
(#296) Variable toggle_filter_checkbox::$value is not documented
(#298) Variable toggle_filter_checkbox::$helptext is not documented
(#303) Phpdocs for function toggle_filter_checkbox::__construct has incomplete parameters list
mod/studentquiz/classes/question/bank/question_name_column.php
(#38) Variable question_name_column::$renderer is not documented
(#39) Variable question_name_column::$context is not documented
mod/studentquiz/classes/question/bank/rate_column.php
(#37) Variable rate_column::$renderer is not documented
mod/studentquiz/classes/question/bank/state_column.php
(#37) Variable state_column::$renderer is not documented
mod/studentquiz/classes/question/bank/studentquiz_bank_view.php
(#634) Function studentquiz_bank_view::display_question_list_rows is not documented
(#102) Variable studentquiz_bank_view::$pagevars is not documented
(#115) Phpdocs for function studentquiz_bank_view::__construct has incomplete parameters list
(#544) Phpdocs for function studentquiz_bank_view::create_new_question_form has incomplete parameters list
mod/studentquiz/classes/question/bank/tag_column.php
(#66) Function tag_column::set_searchconditions is not documented
(#130) Function tag_column::get_required_fields is not documented
(#134) Function tag_column::is_sortable is not documented
(#37) Variable tag_column::$tags is not documented
(#39) Variable tag_column::$searchconditions is not documented
(#41) Variable tag_column::$tagfilteractive is not documented
(#43) Variable tag_column::$renderer is not documented
(#77) Phpdocs for function tag_column::set_tags has incomplete parameters list
mod/studentquiz/classes/utils.php
(#77) Phpdocs for function utils::nice_shorten_text has incomplete parameters list
(#97) Phpdocs for function utils::get_data_for_comment_area has incomplete parameters list
mod/studentquiz/externallib.php
(#34) Class mod_studentquiz_external is not documented
(#36) There is no description in phpdocs for function change_question_state_parameters
(#48) There is no description in phpdocs for function change_question_state
(#89) There is no description in phpdocs for function change_question_state_returns
mod/studentquiz/lib.php
(#212) Phpdocs for function studentquiz_pre_course_module_delete has incomplete parameters list
(#211) Invalid phpdocs tag @Warning: used
mod/studentquiz/locallib.php
(#84) Function mod_studentquiz_get_studenquiz_progress_class is not documented
(#257) Function mod_studentquiz_prepare_notify_data is not documented
(#923) Function mod_studentquiz_get_question_types_keys is not documented
(#1250) Function mod_studentquiz_count_questions is not documented
(#515) There is no description in phpdocs for function mod_studentquiz_add_question_to_attempt
(#738) There is no description in phpdocs for function mod_studentquiz_helper_attempt_stat_select
(#801) There is no description in phpdocs for function mod_studentquiz_helper_attempt_stat_joins
(#1222) There is no description in phpdocs for function mod_studentquiz_get_tags_by_question_ids
(#60) Phpdocs for function mod_studentquiz_load_studentquiz has incomplete parameters list
(#155) Phpdocs for function mod_studentquiz_migrate_single_studentquiz_instances_to_aggregated_state has incomplete parameters list
(#238) Phpdocs for function mod_studentquiz_check_created_permission has incomplete parameters list
(#330) Phpdocs for function mod_studentquiz_notify_comment_added has incomplete parameters list
(#343) Phpdocs for function mod_studentquiz_notify_comment_deleted has incomplete parameters list
(#382) Phpdocs for function mod_studentquiz_event_notification_comment has incomplete parameters list
(#412) Phpdocs for function mod_studentquiz_event_notification_minecomment has incomplete parameters list
(#475) Phpdocs for function mod_studentquiz_generate_attempt has incomplete parameters list
(#516) Phpdocs for function mod_studentquiz_add_question_to_attempt has incomplete parameters list
(#616) Phpdocs for function mod_studentquiz_helper_get_ids_by_raw_submit has incomplete parameters list
(#677) Phpdocs for function mod_studentquiz_community_stats has incomplete parameters list
(#801) Phpdocs for function mod_studentquiz_helper_attempt_stat_joins has incomplete parameters list
(#1223) Phpdocs for function mod_studentquiz_get_tags_by_question_ids has incomplete parameters list
(#1269) Phpdocs for function mod_studentquiz_question_stats has incomplete parameters list
(#1389) Not recommended phpdocs tag @internal used
(#1389) Not recommended phpdocs tag @internal used
mod/studentquiz/mod_form.php
(#297) There is no description in phpdocs for function get_data
mod/studentquiz/renderer.php
(#842) Class mod_studentquiz_summary_renderer is not documented
(#865) Class mod_studentquiz_overview_renderer is not documented
(#1370) Class mod_studentquiz_attempt_renderer is not documented
(#1576) Class mod_studentquiz_report_renderer is not documented
(#1731) Class mod_studentquiz_ranking_renderer is not documented
(#64) Function mod_studentquiz_renderer::render_table_cell is not documented
(#73) Function mod_studentquiz_renderer::render_stat_block is not documented
(#135) Function mod_studentquiz_renderer::render_ranking_block is not documented
(#179) Function mod_studentquiz_renderer::render_table_row is not documented
(#185) Function mod_studentquiz_renderer::render_table is not documented
(#971) Function mod_studentquiz_overview_renderer::display_javascript_snippet is not documented
(#40) Variable mod_studentquiz_renderer::$cachedquestionpreviewlinkimage is not documented
(#291) There is no description in phpdocs for function question_preview_link
(#894) There is no description in phpdocs for function render_questionbank
(#905) There is no description in phpdocs for function render_select_qtype_form
(#1733) There is no description in phpdocs for function view_rank
(#44) Phpdocs for function mod_studentquiz_renderer::render_table_data has incomplete parameters list
(#200) Phpdocs for function mod_studentquiz_renderer::render_progress_bar has incomplete parameters list
(#295) Phpdocs for function mod_studentquiz_renderer::question_preview_link has incomplete parameters list
(#331) Phpdocs for function mod_studentquiz_renderer::render_anonym_creator_name_column has incomplete parameters list
(#364) Phpdocs for function mod_studentquiz_renderer::render_state_column has incomplete parameters list
(#405) Phpdocs for function mod_studentquiz_renderer::render_comment_column has incomplete parameters list
(#424) Phpdocs for function mod_studentquiz_renderer::render_difficulty_level_column has incomplete parameters list
(#456) Phpdocs for function mod_studentquiz_renderer::render_difficultybar has incomplete parameters list
(#512) Phpdocs for function mod_studentquiz_renderer::render_practice_column has incomplete parameters list
(#550) Phpdocs for function mod_studentquiz_renderer::render_rate_column has incomplete parameters list
(#581) Phpdocs for function mod_studentquiz_renderer::render_ratingbar has incomplete parameters list
(#630) Phpdocs for function mod_studentquiz_renderer::render_tag_column has incomplete parameters list
(#652) Phpdocs for function mod_studentquiz_renderer::render_tag has incomplete parameters list
(#669) Phpdocs for function mod_studentquiz_renderer::render_fill_bar has incomplete parameters list
(#698) Phpdocs for function mod_studentquiz_renderer::render_fill_bolt has incomplete parameters list
(#721) Phpdocs for function mod_studentquiz_renderer::render_fill_star has incomplete parameters list
(#744) Phpdocs for function mod_studentquiz_renderer::render_question_name_column has incomplete parameters list
(#955) Phpdocs for function mod_studentquiz_overview_renderer::render_question_form has incomplete parameters list
(#1105) Phpdocs for function mod_studentquiz_overview_renderer::render_control_buttons has incomplete parameters list
(#1178) Phpdocs for function mod_studentquiz_overview_renderer::render_pagination_bar has incomplete parameters list
(#1251) Phpdocs for function mod_studentquiz_overview_renderer::render_hidden_field has incomplete parameters list
(#1271) Phpdocs for function mod_studentquiz_overview_renderer::generate_hidden_input has incomplete parameters list
(#1378) Phpdocs for function mod_studentquiz_attempt_renderer::feedback has incomplete parameters list
(#1500) Phpdocs for function mod_studentquiz_attempt_renderer::render_state_choice has incomplete parameters list
(#1734) Phpdocs for function mod_studentquiz_ranking_renderer::view_rank has incomplete parameters list
(#1742) Phpdocs for function mod_studentquiz_ranking_renderer::view_quantifier_information has incomplete parameters list
(#292) Invalid phpdocs tag @Override used
mod/studentquiz/reportlib.php
(#64) Function mod_studentquiz_report::get_available_questions is not documented
(#74) Function mod_studentquiz_report::get_enrolled_users is not documented
(#83) Function mod_studentquiz_report::get_studentquiz_stats is not documented
(#100) Function mod_studentquiz_report::get_user_stats is not documented
(#136) Function mod_studentquiz_report::get_useractivitystats is not documented
(#28) No one-line description found in phpdocs for class mod_studentquiz_report
(#279) There is no description in phpdocs for function get_quantifiers
(#344) There is no description in phpdocs for function is_anonymized
(#78) Phpdocs for variable mod_studentquiz_report::$studentquizstats does not contain @var or incorrect
(#96) Phpdocs for variable mod_studentquiz_report::$userrankingstats does not contain @var or incorrect
(#131) Phpdocs for variable mod_studentquiz_report::$useractivitystats does not contain @var or incorrect
mod/studentquiz/tests/behat/behat_mod_studentquiz.php
(#40) There is no description in phpdocs for function i_set_availability_field_to
(#72) There is no description in phpdocs for function i_check_moodle_version
(#88) Phpdocs for function behat_mod_studentquiz::enter_the_text_into_field has incomplete parameters list
mod/studentquiz/tests/privacy_test.php
(#821) Phpdocs for function mod_studentquiz_privacy_testcase::create_question has incomplete parameters list
(#849) Phpdocs for function mod_studentquiz_privacy_testcase::create_question_approval has incomplete parameters list
(#870) Phpdocs for function mod_studentquiz_privacy_testcase::create_rate has incomplete parameters list
(#893) Phpdocs for function mod_studentquiz_privacy_testcase::create_comment has incomplete parameters list
(#923) Phpdocs for function mod_studentquiz_privacy_testcase::create_progress has incomplete parameters list
(#949) Phpdocs for function mod_studentquiz_privacy_testcase::create_attempt has incomplete parameters list
(#974) Phpdocs for function mod_studentquiz_privacy_testcase::create_practice has incomplete parameters list
(#17) File-level phpdocs block does not have @copyright tag
mod/studentquiz/tests/report_test.php
(#40) Class mod_studentquiz_report_testcase is not documented
(#178) Function mod_studentquiz_report_testcase::debugdb is not documented
mod/studentquiz/tests/studentquiz_bank_view_test.php
(#97) There is no description in phpdocs for function run_questionbank
mod/studentquiz/tests/studentquiz_comment_test.php
(#141) There is no description in phpdocs for function get_comment_by_id
mod/studentquiz/tests/viewlib_test.php
(#39) Class mod_studentquiz_viewlib_testcase is not documented
(#44) Variable mod_studentquiz_viewlib_testcase::$cm is not documented
(#125) Phpdocs for function mod_studentquiz_viewlib_testcase::invoke_method has incomplete parameters list
mod/studentquiz/viewlib.php
(#91) Phpdocs for function mod_studentquiz_view::__construct has incomplete parameters list
(#80) Phpdocs for variable mod_studentquiz_view::$questionbank does not contain @var or incorrect

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(6 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]

mod/studentquiz/amd/build/comment_area.min.js
Uncommitted change detected.
mod/studentquiz/amd/build/comment_area.min.js.map
Uncommitted change detected.
mod/studentquiz/amd/build/state_change.min.js
Uncommitted change detected.
mod/studentquiz/amd/build/state_change.min.js.map
Uncommitted change detected.
mod/studentquiz/amd/build/studentquiz.min.js
Uncommitted change detected.
mod/studentquiz/amd/build/toggle_filter_checkbox.min.js
Uncommitted change detected.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]