Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(53 errors, 36 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/skype/backup/moodle2/backup_skype_stepslib.php
(#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/skype/backup/moodle2/restore_skype_stepslib.php
(#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/skype/classes/event/course_module_instance_list_viewed.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/skype/classes/event/course_module_viewed.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/skype/classes/local/results.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#42) Expected 1 space before opening brace; found 2
(#116) Line exceeds 132 characters; contains 135 characters
(#117) Line exceeds 132 characters; contains 172 characters
(#118) Line exceeds maximum limit of 180 characters; contains 191 characters
(#119) Line exceeds maximum limit of 180 characters; contains 184 characters
(#120) Line exceeds maximum limit of 180 characters; contains 181 characters
(#344) Usage of "$this" in static methods will cause runtime errors
(#344) "$this" can no longer be used in a plain function or method since PHP 7.1.
(#345) Usage of "$this" in static methods will cause runtime errors
(#345) "$this" can no longer be used in a plain function or method since PHP 7.1.
(#348) Usage of "$this" in static methods will cause runtime errors
(#348) "$this" can no longer be used in a plain function or method since PHP 7.1.
(#349) Usage of "$this" in static methods will cause runtime errors
(#349) "$this" can no longer be used in a plain function or method since PHP 7.1.
(#350) Usage of "$this" in static methods will cause runtime errors
(#350) "$this" can no longer be used in a plain function or method since PHP 7.1.
(#352) Usage of "$this" in static methods will cause runtime errors
(#352) "$this" can no longer be used in a plain function or method since PHP 7.1.
(#353) Usage of "$this" in static methods will cause runtime errors
(#353) "$this" can no longer be used in a plain function or method since PHP 7.1.
(#356) File must end with a newline character
mod/skype/classes/privacy/provider.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/skype/classes/task/cron_task.php
(#18) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/skype/db/install.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#56) Whitespace found at end of line
(#98) File must end with a newline character
mod/skype/db/uninstall.php
(#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/skype/db/upgrade.php
(#34) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/skype/lib.php
(#32) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#264) File must end with a newline character
mod/skype/locallib.php
(#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#50) Inline comments must start with a capital letter, digit or 3-dots sequence
(#50) Inline comments must end in full-stops, exclamation marks, or question marks
(#50) This comment is 64% valid code; is this commented out code?
(#50) No space found before comment text; expected "// function printskypeuserslist($skypeusers, $rec) {" but found "//function printskypeuserslist($skypeusers, $rec) {"
(#53) Line indented incorrectly; expected at least 4 spaces, found 0
(#53) The use of function print_object() is forbidden
(#54) Line indented incorrectly; expected at least 4 spaces, found 0
(#54) The use of function print_object() is forbidden
(#55) Line indented incorrectly; expected at least 4 spaces, found 0
(#55) The use of function print_object() is forbidden
(#68) Line exceeds 132 characters; contains 135 characters
(#69) Line exceeds 132 characters; contains 172 characters
(#70) Line exceeds maximum limit of 180 characters; contains 191 characters
(#71) Line exceeds maximum limit of 180 characters; contains 184 characters
(#72) Line exceeds maximum limit of 180 characters; contains 181 characters
(#284) Line indented incorrectly; expected at least 12 spaces, found 8
(#285) Line indented incorrectly; expected at least 12 spaces, found 8
(#286) Line indented incorrectly; expected at least 12 spaces, found 8
(#295) Line indented incorrectly; expected at least 12 spaces, found 8
(#297) Line indented incorrectly; expected at least 12 spaces, found 8
(#297) The use of function print_object() is forbidden
(#298) Line indented incorrectly; expected at least 12 spaces, found 8
(#298) The use of function print_object() is forbidden
(#300) Line indented incorrectly; expected 8 spaces, found 4
(#300) Closing brace indented incorrectly; expected 8 spaces, found 4
(#301) Functions must not contain multiple empty lines in a row; found 2 empty lines
mod/skype/oops.php
(#47) Inline comments must start with a capital letter, digit or 3-dots sequence
(#47) This comment is 80% valid code; is this commented out code?
(#49) Inline comments must start with a capital letter, digit or 3-dots sequence
(#49) This comment is 78% valid code; is this commented out code?
(#53) Inline comments must start with a capital letter, digit or 3-dots sequence
(#53) Inline comments must end in full-stops, exclamation marks, or question marks
(#53) This comment is 73% valid code; is this commented out code?
(#62) Line exceeds 132 characters; contains 180 characters
(#65) Line exceeds maximum limit of 180 characters; contains 291 characters
(#77) Line exceeds 132 characters; contains 169 characters
(#92) Whitespace found at end of line within string
(#94) Whitespace found at end of line within string
(#95) Whitespace found at end of line within string
(#98) Whitespace found at end of line within string
(#101) Inline comments must start with a capital letter, digit or 3-dots sequence
(#101) Inline comments must end in full-stops, exclamation marks, or question marks
(#101) This comment is 75% valid code; is this commented out code?
(#108) Inline comments must start with a capital letter, digit or 3-dots sequence
(#108) This comment is 63% valid code; is this commented out code?
(#109) Inline comments must end in full-stops, exclamation marks, or question marks
mod/skype/renderer.php
(#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#76) File must end with a newline character
mod/skype/view.php
(#88) This comment is 44% valid code; is this commented out code?
(#89) No space found before comment text; expected "// $cminfo = cm_info::create($cm);" but found "//$cminfo = cm_info::create($cm);"
(#90) No space found before comment text; expected "// $completiondetails = \core_completion\cm_completion_details::get_instance($cminfo, $USER->id);" but found "//$completiondetails = \core_completion\cm_completion_details::get_instance($cminfo, $USER->id);"
(#91) No space found before comment text; expected "// $activitydates = \core\activity_dates::get_dates_for_module($cminfo, $USER->id);" but found "//$activitydates = \core\activity_dates::get_dates_for_module($cminfo, $USER->id);"
(#92) No space found before comment text; expected "// echo $output->introduction($cminfo, $completiondetails, $activitydates);" but found "//echo $output->introduction($cminfo, $completiondetails, $activitydates);"

Javascript coding style problems

(26 errors, 44 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

mod/skype/js/skypecheck.js
(#1) This line has a length of 149. Maximum allowed is 132. (max-len)
(#1) Multiple spaces found before '!='. (no-multi-spaces)
(#1) There should be no space before this paren. (space-in-parens)
(#2) Multiple spaces found before '!='. (no-multi-spaces)
(#2) Multiple spaces found before '!='. (no-multi-spaces)
(#4) Missing JSDoc comment. (require-jsdoc)
(#5) This line has a length of 224. Maximum allowed is 132. (max-len)
(#5) Expected space(s) after "if". (keyword-spacing)
(#6) 'URLtoOpen' used outside of binding context. (block-scoped-var)
(#8) 'URLtoOpen' is already defined. (no-redeclare)
(#8) 'URLtoOpen' used outside of binding context. (block-scoped-var)
(#10) Unexpected tab character. (no-tabs)
(#11) Unexpected tab character. (no-tabs)
(#11) Expected variable declaration to be on a new line. (one-var-declaration-per-line)
(#12) Unexpected tab character. (no-tabs)
(#13) Unexpected tab character. (no-tabs)
(#13) 'w' is not defined. (no-undef)
(#14) Unexpected tab character. (no-tabs)
(#14) 'h' is not defined. (no-undef)
(#15) Unexpected tab character. (no-tabs)
(#15) 'w' is not defined. (no-undef)
(#15) Operator '-' must be spaced. (space-infix-ops)
(#15) Operator '/' must be spaced. (space-infix-ops)
(#15) Expected variable declaration to be on a new line. (one-var-declaration-per-line)
(#15) 'h' is not defined. (no-undef)
(#15) Operator '-' must be spaced. (space-infix-ops)
(#15) Operator '/' must be spaced. (space-infix-ops)
(#16) This line has a length of 195. Maximum allowed is 132. (max-len)
(#16) Unexpected tab character. (no-tabs)
(#16) 'oopswindow' is not defined. (no-undef)
(#16) 'URLtoOpen' used outside of binding context. (block-scoped-var)
(#16) 'URLtoOpen' used outside of binding context. (block-scoped-var)
(#16) A space is required after ','. (comma-spacing)
(#16) Operator '+' must be spaced. (space-infix-ops)
(#16) Operator '+' must be spaced. (space-infix-ops)
(#16) Operator '+' must be spaced. (space-infix-ops)
(#16) Operator '+' must be spaced. (space-infix-ops)
(#16) Operator '+' must be spaced. (space-infix-ops)
(#16) Operator '+' must be spaced. (space-infix-ops)
(#16) Operator '+' must be spaced. (space-infix-ops)
(#17) Unexpected tab character. (no-tabs)
(#20) Expected space(s) after "if". (keyword-spacing)
(#20) Unary word operator 'typeof' must be followed by whitespace. (space-unary-ops)
(#33) Missing JSDoc comment. (require-jsdoc)
(#34) Expected space(s) after "if". (keyword-spacing)
(#36) Expected space(s) after "if". (keyword-spacing)
(#38) 'detected' is not defined. (no-undef)
(#39) Expected space(s) after "if". (keyword-spacing)
(#39) Unary word operator 'typeof' must be followed by whitespace. (space-unary-ops)
(#45) Expected space(s) after "if". (keyword-spacing)
(#45) 'isSkypeInstalled' is not defined. (no-undef)
(#46) 'detected' is not defined. (no-undef)
(#50) Trailing spaces not allowed. (no-trailing-spaces)
(#51) 'detected' is not defined. (no-undef)
(#55) Missing JSDoc comment. (require-jsdoc)
(#56) Expected space(s) after "if". (keyword-spacing)
(#57) Expected { after 'if' condition. (curly)
(#58) Expected { after 'if' condition. (curly)
(#62) Missing JSDoc comment. (require-jsdoc)
(#64) Operator '=' must be spaced. (space-infix-ops)
(#65) Expected space(s) after "if". (keyword-spacing)
(#66) This line has a length of 258. Maximum allowed is 132. (max-len)
(#66) Expected space(s) after "if". (keyword-spacing)
(#66) Unnecessary escape character: \/. (no-useless-escape)
(#66) Unnecessary escape character: \/. (no-useless-escape)
(#66) Unary word operator 'typeof' must be followed by whitespace. (space-unary-ops)
(#66) Use '===' to compare with null. (no-eq-null)
(#67) Statement inside of curly braces should be on next line. (brace-style)
(#67) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
(#67) Missing semicolon. (semi)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(8 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

mod/skype/backup/moodle2/restore_skype_activity_task.class.php
(#29) No one-line description found in phpdocs for class restore_skype_activity_task
(#90) Inline phpdocs tag {@link restore_logs_processor} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
(#92) Inline phpdocs tag {@link restore_log_rule} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
(#108) Inline phpdocs tag {@link restore_logs_processor} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
(#110) Inline phpdocs tag {@link restore_log_rule} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
mod/skype/classes/local/results.php
(#60) Phpdocs for function results::user_skype_id has incomplete parameters list
mod/skype/locallib.php
(#51) Function printskypeuserslist is not documented
(#278) Phpdocs for function updateskypeusers has incomplete parameters list

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


Missing changes in external functions or backup support for new detected tables or columns

(0 errors, 2 warnings)

This section shows potential problems detected when there are new database structures added in a patch and it is detected that nothing has been changed related with external functions (to be used by WS) or backup and restore. It must be checked that everything is correct and nothing is being missed in those areas. [More info]

mod/skype/db/upgrade.php
Database modifications (new tables or columns) detected in the patch without any change to some important areas.
No changes detected to external functions, that may affect apps and other web service integrations, please verify!

grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]