PHP lint problems
(0 errors, 0 warnings)
This section shows php lint problems in the code detected by php -l [More info]
PHP coding style problems
(1 errors, 0 warnings)
This section shows the coding style problems detected in the code by phpcs [More info]
- mod/simplelesson/db/upgrade.php
- (#88) Functions must not contain multiple empty lines in a row; found 6 empty lines
Javascript coding style problems
(0 errors, 0 warnings)
This section shows the coding style problems detected in the code by eslint [More info]
CSS problems
(0 errors, 0 warnings)
This section shows CSS problems detected by stylelint [More info]
PHPDocs style problems
(97 errors, 0 warnings)
This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]
- mod/simplelesson/backup/moodle2/restore_simplelesson_activity_task.class.php
- (#87) Inline phpdocs tag {@link restore_logs_processor} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
- (#89) Inline phpdocs tag {@link restore_log_rule} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
- (#112) Inline phpdocs tag {@link restore_logs_processor} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
- (#114) Inline phpdocs tag {@link restore_log_rule} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
- mod/simplelesson/classes/forms/edit_page_form.php
- (#81) Function edit_page_form::data_preprocessing is not documented
- mod/simplelesson/classes/forms/essay_grading_form.php
- (#28) Package is not specified for class essay_grading_form. It is also not specified in file-level phpdocs
- mod/simplelesson/classes/forms/select_question_form.php
- (#36) Variable select_question_form::$simplelesson is not documented
- (#37) Variable select_question_form::$sequence is not documented
- (#38) Variable select_question_form::$questions is not documented
- (#39) Variable select_question_form::$actionurl is not documented
- (#41) Phpdocs for function select_question_form::__construct has incomplete parameters list
- mod/simplelesson/classes/local/attempts.php
- (#33) Phpdocs for function attempts::create_usage has incomplete parameters list
- (#101) Phpdocs for function attempts::remove_usage_data has incomplete parameters list
- (#234) Phpdocs for function attempts::get_sessiondata has incomplete parameters list
- (#268) Phpdocs for function attempts::save_lesson_answerdata has incomplete parameters list
- (#357) Phpdocs for function attempts::fetch_attempt_questions has incomplete parameters list
- (#394) Phpdocs for function attempts::fetch_question_score has incomplete parameters list
- (#409) Phpdocs for function attempts::get_slot has incomplete parameters list
- mod/simplelesson/classes/local/grading.php
- (#32) Phpdocs for function grading::grade_user has incomplete parameters list
- mod/simplelesson/classes/local/lesson.php
- (#39) Phpdocs for function lesson::__construct has incomplete parameters list
- (#92) Phpdocs for function lesson::get_page_id_from_sequence has incomplete parameters list
- (#28) Phpdocs for variable lesson::$id does not contain @var or incorrect
- (#32) Phpdocs for variable lesson::$pages does not contain @var or incorrect
- mod/simplelesson/classes/local/reporting.php
- (#34) Class reporting is not documented
- (#38) Phpdocs for function reporting::fetch_module_data has incomplete parameters list
- (#54) Phpdocs for function reporting::show_basic_report has incomplete parameters list
- (#86) Phpdocs for function reporting::fetch_essay_answer_data has incomplete parameters list
- (#111) Phpdocs for function reporting::get_essay_report_data has incomplete parameters list
- (#154) Phpdocs for function reporting::show_essay_answer_report has incomplete parameters list
- (#183) Phpdocs for function reporting::fetch_essay_answer_report_headers has incomplete parameters list
- (#223) Phpdocs for function reporting::fetch_attempt_data has incomplete parameters list
- (#264) Phpdocs for function reporting::fetch_attempt_report_headers has incomplete parameters list
- (#285) Phpdocs for function reporting::fetch_answer_data has incomplete parameters list
- (#339) Phpdocs for function reporting::fetch_answer_report_headers has incomplete parameters list
- (#361) Phpdocs for function reporting::fetch_course_attempt_data has incomplete parameters list
- (#447) Phpdocs for function reporting::fetch_course_attempt_report_headers has incomplete parameters list
- mod/simplelesson/classes/output/delete_page.php
- (#38) Class delete_page is not documented
- (#40) Variable delete_page::$mform is not documented
- (#41) Variable delete_page::$title is not documented
- (#46) Phpdocs for function delete_page::__construct has incomplete parameters list
- mod/simplelesson/classes/output/display_options.php
- (#16) No one-line description found in phpdocs for file
- (#35) Phpdocs for function display_options::get_options has incomplete parameters list
- mod/simplelesson/classes/output/lesson_editing.php
- (#34) Class lesson_editing is not documented
- (#36) Variable lesson_editing::$courseid is not documented
- (#37) Variable lesson_editing::$simplelessonid is not documented
- (#38) Variable lesson_editing::$pages is not documented
- (#39) Variable lesson_editing::$cm is not documented
- (#40) Variable lesson_editing::$pageurl is not documented
- (#41) Variable lesson_editing::$mform is not documented
- (#46) Phpdocs for function lesson_editing::__construct has incomplete parameters list
- mod/simplelesson/classes/output/lesson_summary.php
- (#37) Class lesson_summary is not documented
- (#55) Function lesson_summary::__construct is not documented
- (#39) Variable lesson_summary::$options is not documented
- (#40) Variable lesson_summary::$user is not documented
- (#41) Variable lesson_summary::$answerdata is not documented
- (#42) Variable lesson_summary::$markdp is not documented
- (#43) Variable lesson_summary::$sessiondata is not documented
- mod/simplelesson/classes/output/manual_grading.php
- (#31) Class manual_grading is not documented
- (#36) Function manual_grading::__construct is not documented
- (#33) Variable manual_grading::$answerdata is not documented
- (#34) Variable manual_grading::$graderinfo is not documented
- mod/simplelesson/classes/output/reports.php
- (#40) Class reports is not documented
- (#44) Function reports::__construct is not documented
- (#42) Variable reports::$options is not documented
- mod/simplelesson/classes/output/show_question.php
- (#32) Class show_question is not documented
- (#39) Function show_question::__construct is not documented
- (#34) Variable show_question::$question is not documented
- (#35) Variable show_question::$actionurl is not documented
- (#36) Variable show_question::$slot is not documented
- (#37) Variable show_question::$canfinish is not documented
- mod/simplelesson/classes/output/showpage.php
- (#33) Class showpage is not documented
- (#41) Function showpage::__construct is not documented
- (#35) Variable showpage::$simplelesson is not documented
- (#36) Variable showpage::$lessonpage is not documented
- (#37) Variable showpage::$attemptid is not documented
- (#38) Variable showpage::$returnurl is not documented
- (#39) Variable showpage::$options is not documented
- mod/simplelesson/classes/output/view.php
- (#43) Class view is not documented
- (#49) Function view::__construct is not documented
- (#45) Variable view::$simplelesson is not documented
- (#46) Variable view::$cmid is not documented
- (#47) Variable view::$options is not documented
- mod/simplelesson/classes/privacy/provider.php
- (#32) Class provider is not documented
- (#43) Function provider::get_metadata is not documented
- (#191) Phpdocs for function provider::export_simplelesson_data_for_user has incomplete parameters list
- mod/simplelesson/classes/task/scheduled_clean.php
- (#33) Function scheduled_clean::get_name is not documented
- (#17) No one-line description found in phpdocs for file
- mod/simplelesson/classes/utility/constants.php
- (#30) Constant constants::MOD_SIMPLELESSON_ATTEMPT_STARTED is not documented
- (#31) Constant constants::MOD_SIMPLELESSON_ATTEMPT_COMPLETE is not documented
- (#33) Constant constants::MOD_SIMPLELESSON_GRADE_HIGHEST is not documented
- (#34) Constant constants::MOD_SIMPLELESSON_GRADE_AVERAGE is not documented
- (#35) Constant constants::MOD_SIMPLELESSON_GRADE_LAST is not documented
- mod/simplelesson/db/upgrade.php
- (#41) Function xmldb_simplelesson_upgrade is not documented
- mod/simplelesson/lib.php
- (#374) Phpdocs for function simplelesson_grade_item_update has incomplete parameters list
- (#35) Inline phpdocs tag {@link plugin_supports()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
- mod/simplelesson/renderer.php
- (#25) Class mod_simplelesson_renderer is not documented
- (#30) Phpdocs for function mod_simplelesson_renderer::render_question_form has incomplete parameters list
Update savepoints problems
(0 errors, 0 warnings)
This section shows problems detected with the handling of upgrade savepoints [More info]
Third party library modification problems
(0 errors, 0 warnings)
This section shows problems detected with the modification of third party libraries [More info]
Missing changes in external functions or backup support for new detected tables or columns
(0 errors, 2 warnings)
This section shows potential problems detected when there are new database structures added in a patch and it is detected that nothing has been changed related with external functions (to be used by WS) or backup and restore. It must be checked that everything is correct and nothing is being missed in those areas. [More info]
- mod/simplelesson/db/upgrade.php
- Database modifications (new tables or columns) detected in the patch without any change to some important areas.
- No changes detected to external functions, that may affect apps and other web service integrations, please verify!
grunt changes
(0 errors, 0 warnings)
This section shows files built by grunt and not commited [More info]
shifter problems
(0 errors, 0 warnings)
This section shows problems detected by shifter [More info]
Mustache template problems
(12 errors, 94 warnings)
This section shows problems detected in mustache templates [More info]
- mod/simplelesson/templates/answer_row.mustache
- (#1) HTML Validation error, line 3: Stray start tag “tr”. (d><body><tr class="danger"> <td)
- (#1) HTML Validation error, line 4: Stray start tag “td”. (anger"> <td>1</td>)
- (#1) HTML Validation error, line 4: Stray end tag “td”. ("> <td>1</td> <td)
- (#1) HTML Validation error, line 5: Stray start tag “td”. (>1</td> <td>Fred</)
- (#1) HTML Validation error, line 5: Stray end tag “td”. ( <td>Fred</td> <td)
- (#1) HTML Validation error, line 6: Stray start tag “td”. (ed</td> <td></td>)
- (#1) HTML Validation error, line 6: Stray end tag “td”. (td> <td></td> <td)
- (#1) HTML Validation error, line 7: Stray start tag “td”. (d></td> <td>1970-1)
- (#1) HTML Validation error, line 7: Stray end tag “td”. (-1-1 12:00</td> <td)
- (#1) HTML Validation error, line 8: Stray start tag “td”. (00</td> <td>Whethe)
- (#1) HTML Validation error, line 8: Stray end tag “td”. ( nobler...</td> <td)
- (#1) HTML Validation error, line 9: Stray start tag “td”. (..</td> <td>In the)
- (#1) HTML Validation error, line 9: Stray end tag “td”. (n the mind</td> <td)
- (#1) HTML Validation error, line 10: Stray start tag “td”. (nd</td> <td>In the)
- (#1) HTML Validation error, line 10: Stray end tag “td”. (n the butt</td> <td)
- (#1) HTML Validation error, line 11: Stray start tag “td”. (tt</td> <td>1</td>)
- (#1) HTML Validation error, line 11: Stray end tag “td”. (d> <td>1</td> <td)
- (#1) HTML Validation error, line 12: Stray start tag “td”. (>1</td> <td>1</td>)
- (#1) HTML Validation error, line 12: Stray end tag “td”. (d> <td>1</td> <td)
- (#1) HTML Validation error, line 13: Stray start tag “td”. (>1</td> <td>1</td>)
- (#1) HTML Validation error, line 13: Stray end tag “td”. (d> <td>1</td></tr>)
- (#1) HTML Validation error, line 14: Stray end tag “tr”. (td>1</td></tr></bod)
- mod/simplelesson/templates/attempt_row.mustache
- (#1) HTML Validation error, line 3: Stray start tag “tr”. (d><body><tr class="danger"> <td)
- (#1) HTML Validation error, line 4: Stray start tag “td”. (anger"> <td>Fred</)
- (#1) HTML Validation error, line 4: Stray end tag “td”. ( <td>Fred</td> <td)
- (#1) HTML Validation error, line 5: Stray start tag “td”. (ed</td> <td></td>)
- (#1) HTML Validation error, line 5: Stray end tag “td”. (td> <td></td> <td)
- (#1) HTML Validation error, line 6: Stray start tag “td”. (d></td> <td>1970-1)
- (#1) HTML Validation error, line 6: Stray end tag “td”. (-1-1 12:00</td> <td)
- (#1) HTML Validation error, line 7: Stray start tag “td”. (00</td> <td>Comple)
- (#1) HTML Validation error, line 7: Stray end tag “td”. (d>Complete</td> <td)
- (#1) HTML Validation error, line 8: Stray start tag “td”. (te</td> <td>10</td)
- (#1) HTML Validation error, line 8: Stray end tag “td”. (> <td>10</td> <td)
- (#1) HTML Validation error, line 9: Stray start tag “td”. (10</td> <td>10</td)
- (#1) HTML Validation error, line 9: Stray end tag “td”. (> <td>10</td> <td)
- (#1) HTML Validation error, line 10: Stray start tag “td”. (10</td> <td>1</td>)
- (#1) HTML Validation error, line 10: Stray end tag “td”. (d> <td>1</td></tr>)
- (#1) HTML Validation error, line 11: Stray end tag “tr”. (td>1</td></tr></bod)
- mod/simplelesson/templates/edit_questions.mustache
- (#1) Mustache syntax exception: Example context JSON is unparsable, fails with: Syntax error
- mod/simplelesson/templates/lesson_editing.mustache
- (#1) Mustache syntax exception: Example context JSON is unparsable, fails with: Syntax error
- mod/simplelesson/templates/lesson_summary.mustache
- (#1) Mustache syntax exception: Example context JSON is unparsable, fails with: Syntax error
- mod/simplelesson/templates/managelesson.mustache
- (#1) Mustache syntax exception: Example context JSON is unparsable, fails with: Syntax error
- mod/simplelesson/templates/managepage.mustache
- (#1) Mustache syntax exception: Example context JSON is unparsable, fails with: Syntax error
- mod/simplelesson/templates/manual_grade_row.mustache
- (#1) HTML Validation error, line 3: Stray start tag “tr”. (d><body><tr class="danger"> <td)
- (#1) HTML Validation error, line 4: Stray start tag “td”. (anger"> <td>Fred</)
- (#1) HTML Validation error, line 4: Stray end tag “td”. ( <td>Fred</td> <td)
- (#1) HTML Validation error, line 5: Stray start tag “td”. (ed</td> <td></td>)
- (#1) HTML Validation error, line 5: Stray end tag “td”. (td> <td></td> <td)
- (#1) HTML Validation error, line 6: Stray start tag “td”. (d></td> <td></td>)
- (#1) HTML Validation error, line 6: Stray end tag “td”. (td> <td></td> <td)
- (#1) HTML Validation error, line 7: Stray start tag “td”. (d></td> <td>-1</td)
- (#1) HTML Validation error, line 7: Stray end tag “td”. (> <td>-1</td> <td)
- (#1) HTML Validation error, line 8: Stray start tag “td”. (-1</td> <td>Comple)
- (#1) HTML Validation error, line 8: Stray end tag “td”. (d>Complete</td> <td)
- (#1) HTML Validation error, line 9: Stray start tag “td”. (te</td> <td>https:)
- (#1) HTML Validation error, line 9: Stray end tag “td”. (e.php?id=1</td></tr>)
- (#1) HTML Validation error, line 10: Stray end tag “tr”. (id=1</td></tr></bod)
- mod/simplelesson/templates/navigation.mustache
- (#1) Mustache syntax exception: Example context JSON is unparsable, fails with: Syntax error
- mod/simplelesson/templates/page_row.mustache
- (#1) Mustache syntax exception: Example context JSON is unparsable, fails with: State mismatch (invalid or malformed JSON)
- mod/simplelesson/templates/question_form.mustache
- (#1) Mustache syntax exception: Example context JSON is unparsable, fails with: Syntax error
- mod/simplelesson/templates/question_row.mustache
- (#1) HTML Validation error, line 3: Stray start tag “tr”. (d><body><tr class="danger"> <td)
- (#1) HTML Validation error, line 4: Stray start tag “td”. (anger"> <td> <)
- (#1) HTML Validation error, line 6: Stray end tag “td”. (sabled> </td> <)
- (#1) HTML Validation error, line 7: Stray start tag “td”. (</td> <td> )
- (#1) HTML Validation error, line 9: Stray end tag “td”. (span> </td> <)
- (#1) HTML Validation error, line 10: Stray start tag “td”. (</td> <td> )
- (#1) HTML Validation error, line 12: Stray end tag “td”. (span> </td> <)
- (#1) HTML Validation error, line 13: Stray start tag “td”. (</td> <td></td>)
- (#1) HTML Validation error, line 13: Stray end tag “td”. (> <td></td> <)
- (#1) HTML Validation error, line 14: Stray start tag “td”. (</td> <td> )
- (#1) HTML Validation error, line 16: Stray end tag “td”. (span> </td></tr>)
- (#1) HTML Validation error, line 17: Stray end tag “tr”. ( </td></tr></bo)
- mod/simplelesson/templates/reports.mustache
- (#1) Mustache syntax exception: Example context JSON is unparsable, fails with: Syntax error
- mod/simplelesson/templates/reportsmenu.mustache
- (#1) Mustache syntax exception: Example context JSON is unparsable, fails with: Syntax error
- mod/simplelesson/templates/select_question_form.mustache
- (#1) Mustache syntax exception: Example context JSON is unparsable, fails with: Syntax error
- mod/simplelesson/templates/show_question.mustache
- (#1) HTML Validation error, line 3: No space between attributes. (er-sm"> <form id="responseform" method="post", actio)
- (#1) HTML Validation error, line 3: No space between attributes. (od="post", action="", encty)
- (#1) HTML Validation error, line 3: Duplicate attribute “,”. (action="", enctyp)
- (#1) HTML Validation error, line 3: No space between attributes. (ction="", enctype="multipart/form-data")> )
- (#1) HTML Validation info, line 3: Attribute “,” is not serializable as XML 1.0. (orm-data")> <)
- (#1) HTML Validation info, line 3: Attribute “)” is not serializable as XML 1.0. (orm-data")> <)
- (#1) HTML Validation error, line 3: Attribute “,” not allowed on element “form” at this point. (orm-data")> <)
- (#1) HTML Validation error, line 3: Bad value “” for attribute “action” on element “form”: Must be non-empty. (orm-data")> <)
- (#1) HTML Validation error, line 3: Attribute “)” not allowed on element “form” at this point. (orm-data")> <)
- mod/simplelesson/templates/showpage.mustache
- (#1) Mustache syntax exception: Example context JSON is unparsable, fails with: Syntax error
- mod/simplelesson/templates/summary_row.mustache
- (#1) HTML Validation error, line 3: Stray start tag “tr”. (d><body><tr class="danger"> <td)
- (#1) HTML Validation error, line 4: Stray start tag “td”. (anger"> <td>Whethe)
- (#1) HTML Validation error, line 4: Stray end tag “td”. ( nobler...</td> <td)
- (#1) HTML Validation error, line 5: Stray start tag “td”. (..</td> <td></td>)
- (#1) HTML Validation error, line 5: Stray end tag “td”. (td> <td></td> <td)
- (#1) HTML Validation error, line 6: Stray start tag “td”. (d></td> <td></td>)
- (#1) HTML Validation error, line 6: Stray end tag “td”. (td> <td></td> <td)
- (#1) HTML Validation error, line 7: Stray start tag “td”. (d></td> <td></td>)
- (#1) HTML Validation error, line 7: Stray end tag “td”. (td> <td></td> <td)
- (#1) HTML Validation error, line 8: Stray start tag “td”. (d></td> <td>1</td>)
- (#1) HTML Validation error, line 8: Stray end tag “td”. (d> <td>1</td> <td)
- (#1) HTML Validation error, line 9: Stray start tag “td”. (>1</td> <td>1</td>)
- (#1) HTML Validation error, line 9: Stray end tag “td”. (d> <td>1</td> <td)
- (#1) HTML Validation error, line 10: Stray start tag “td”. (>1</td> <td>42</td)
- (#1) HTML Validation error, line 10: Stray end tag “td”. (> <td>42</td></tr>)
- (#1) HTML Validation error, line 11: Stray end tag “tr”. (d>42</td></tr></bo)
- mod/simplelesson/templates/view.mustache
- (#1) HTML Validation info, line 5: Empty heading. (ody"> <h2 class="card-title"></h2>)
- (#1) HTML Validation error, line 24: Stray end tag “a”. (lelesson]]</a></h4>)
- (#1) HTML Validation error, line 41: No space between attributes. (> <a href=""button )
- (#1) HTML Validation error, line 41: Attribute “button” not allowed on element “a” at this point. (a href=""button type="button" class="btn btn-primary btn-sm"> )
- (#1) HTML Validation error, line 41: Bad value “button” for attribute “type” on element “a”: Subtype missing. (a href=""button type="button" class="btn btn-primary btn-sm"> )
Gherkin .feature problems
(0 errors, 0 warnings)
This section shows problems detected in behat .feature files [More info]