Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(64 errors, 10 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/simplelesson/classes/local/constants.php
(#33) Inline comments must start with a capital letter, digit or 3-dots sequence
(#33) Inline comments must end in full-stops, exclamation marks, or question marks
mod/simplelesson/classes/local/grading.php
(#40) Expected "if (...) {\n"; found "if (...) { "
(#40) Closing brace must be on a line by itself
(#70) Line indented incorrectly; expected at least 24 spaces, found 22
(#71) Line indented incorrectly; expected at least 24 spaces, found 22
mod/simplelesson/classes/output/link_data.php
(#118) Inline comments must end in full-stops, exclamation marks, or question marks
(#145) Expected 1 space before "=>"; 0 found
(#182) Expected 1 space after "=>"; 0 found
(#251) Line indented incorrectly; expected at least 8 spaces, found 7
(#270) Line indented incorrectly; expected 4 spaces, found 5
(#282) Inline comments must end in full-stops, exclamation marks, or question marks
(#286) Expected 1 space after "=>"; 0 found
(#292) Expected 1 space after "=>"; 0 found
(#297) Closing brace indented incorrectly; expected 5 spaces, found 4
(#304) Line indented incorrectly; expected 4 spaces, found 5
(#316) Inline comments must end in full-stops, exclamation marks, or question marks
(#325) Expected 1 space after "=>"; 0 found
(#331) Closing brace indented incorrectly; expected 5 spaces, found 4
mod/simplelesson/classes/output/table_data.php
(#103) Expected 1 space before "=>"; 0 found
(#107) Expected 1 space before "=>"; 0 found
(#138) Expected 1 space before "=>"; 0 found
(#147) Expected 1 space before "=>"; 0 found
mod/simplelesson/db/upgrade.php
(#47) Functions must not contain multiple empty lines in a row; found 2 empty lines
mod/simplelesson/edit_questions.php
(#23) Inline doc block comments are not allowed; use "// Comment." instead
(#187) This comment is 47% valid code; is this commented out code?
(#188) No space found before comment text; expected "// $questions = questions::fetch_questions($simplelessonid);" but found "//$questions = questions::fetch_questions($simplelessonid);"
(#189) No space found before comment text; expected "// echo $renderer->question_management(" but found "//echo $renderer->question_management("
(#190) Inline comments must end in full-stops, exclamation marks, or question marks
(#190) Expected 1 space before comment text but found 8; use block comment if you need indentation
mod/simplelesson/lang/en/simplelesson.php
(#45) Inline comments must end in full-stops, exclamation marks, or question marks
(#254) Inline comments must end in full-stops, exclamation marks, or question marks
mod/simplelesson/lib.php
(#352) Expected 1 space before "=>"; 0 found
(#352) Expected 1 space after "=>"; 0 found
(#353) Expected 1 space before "=>"; 0 found
(#353) Expected 1 space after "=>"; 0 found
(#413) Expected 1 space before "=>"; 0 found
(#413) Expected 1 space after "=>"; 0 found
(#415) Expected 1 space before "=>"; 0 found
(#415) Expected 1 space after "=>"; 0 found
(#417) Inline comments must start with a capital letter, digit or 3-dots sequence
(#441) Line indented incorrectly; expected at least 4 spaces, found 3
(#506) TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL"
mod/simplelesson/manual_grading.php
(#77) Line indented incorrectly; expected at least 1 spaces, found 0
(#83) Line indented incorrectly; expected at least 1 spaces, found 0
(#84) Line indented incorrectly; expected at least 1 spaces, found 0
(#85) Line indented incorrectly; expected at least 1 spaces, found 0
(#86) Line indented incorrectly; expected at least 1 spaces, found 0
(#91) Line indented incorrectly; expected at least 1 spaces, found 0
(#92) Line indented incorrectly; expected at least 1 spaces, found 0
(#94) Line indented incorrectly; expected at least 1 spaces, found 0
(#95) Line indented incorrectly; expected at least 1 spaces, found 0
(#96) Line indented incorrectly; expected at least 1 spaces, found 0
(#98) Line indented incorrectly; expected at least 1 spaces, found 0
(#100) Line indented incorrectly; expected at least 1 spaces, found 0
(#101) Line indented incorrectly; expected at least 1 spaces, found 0
(#108) Line indented incorrectly; expected 1 spaces, found 0
(#109) Line indented incorrectly; expected at least 5 spaces, found 4
(#111) Line indented incorrectly; expected 4 spaces, found 0
(#113) Line indented incorrectly; expected 4 spaces, found 0
(#114) Line indented incorrectly; expected at least 8 spaces, found 4
(#115) Line indented incorrectly; expected at least 8 spaces, found 4
(#116) Line indented incorrectly; expected at least 8 spaces, found 4
(#117) Line indented incorrectly; expected at least 8 spaces, found 4
(#120) Line indented incorrectly; expected 4 spaces, found 0
(#122) Line indented incorrectly; expected at least 4 spaces, found 0
(#123) Line indented incorrectly; expected at least 4 spaces, found 0
(#124) Line indented incorrectly; expected at least 4 spaces, found 0
(#125) Line indented incorrectly; expected at least 4 spaces, found 0
(#126) Line indented incorrectly; expected at least 4 spaces, found 0
(#127) Line indented incorrectly; expected at least 4 spaces, found 0
mod/simplelesson/renderer.php
(#80) Commas (,) must be followed by white space.
(#329) Expected "if (...) {\n"; found "if (...){\n"
mod/simplelesson/view.php
(#131) Commas (,) must be followed by white space.

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(10 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]

mod/simplelesson/styles.css
(#10) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#19) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#22) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#26) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#30) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#34) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#37) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#40) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#22) Expected indentation of 4 spaces (indentation)
(#23) Expected indentation of 4 spaces (indentation)

PHPDocs style problems

(82 errors, 4 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

mod/simplelesson/add_question.php
(#16) No one-line description found in phpdocs for file
mod/simplelesson/autosequence.php
(#17) No one-line description found in phpdocs for file
mod/simplelesson/backup/moodle2/restore_simplelesson_stepslib.php
(#92) Function restore_simplelesson_activity_structure_step::process_simplelesson_page is not documented
(#103) Function restore_simplelesson_activity_structure_step::process_simplelesson_attempt is not documented
(#117) Function restore_simplelesson_activity_structure_step::process_simplelesson_answer is not documented
mod/simplelesson/classes/event/course_module_viewed.php
(#54) Function course_module_viewed::get_name is not documented
mod/simplelesson/classes/local/attempts.php
(#43) Phpdocs for function attempts::create_usage has incomplete parameters list
(#118) Phpdocs for function attempts::remove_usage_data has incomplete parameters list
(#273) Phpdocs for function attempts::get_sessiondata has incomplete parameters list
(#307) Phpdocs for function attempts::save_lesson_answerdata has incomplete parameters list
(#334) Phpdocs for function attempts::is_answered has incomplete parameters list
mod/simplelesson/classes/local/constants.php
(#31) Constant constants::MOD_SIMPLELESSON_ATTEMPT_STARTED is not documented
(#32) Constant constants::MOD_SIMPLELESSON_ATTEMPT_COMPLETE is not documented
(#34) Constant constants::MOD_SIMPLELESSON_GRADE_HIGHEST is not documented
(#35) Constant constants::MOD_SIMPLELESSON_GRADE_AVERAGE is not documented
(#36) Constant constants::MOD_SIMPLELESSON_GRADE_LAST is not documented
mod/simplelesson/classes/local/display_options.php
(#16) No one-line description found in phpdocs for file
mod/simplelesson/classes/local/grading.php
(#34) Phpdocs for function grading::grade_user has incomplete parameters list
mod/simplelesson/classes/local/pages.php
(#72) Phpdocs for function pages::fetch_page_links has incomplete parameters list
(#159) Phpdocs for function pages::get_page_id_from_sequence has incomplete parameters list
(#186) Phpdocs for function pages::get_page_title has incomplete parameters list
(#320) Phpdocs for function pages::update_page_record has incomplete parameters list
(#344) Phpdocs for function pages::fix_page_links has incomplete parameters list
mod/simplelesson/classes/local/questions.php
(#69) Phpdocs for function questions::fetch_questions has incomplete parameters list
(#87) Phpdocs for function questions::fetch_attempt_questions has incomplete parameters list
(#129) Phpdocs for function questions::update_question_table has incomplete parameters list
(#174) Phpdocs for function questions::get_slot has incomplete parameters list
(#190) Phpdocs for function questions::get_questionid has incomplete parameters list
(#231) Phpdocs for function questions::fetch_question_score has incomplete parameters list
(#269) Phpdocs for function questions::get_page_sequence has incomplete parameters list
mod/simplelesson/classes/local/reporting.php
(#31) Class reporting is not documented
(#39) Function reporting::fetch_module_data is not documented
(#519) Function reporting::fetch_course_attempt_data is not documented
(#52) Phpdocs for function reporting::show_reports_tab has incomplete parameters list
(#81) Phpdocs for function reporting::show_basic_report has incomplete parameters list
(#113) Phpdocs for function reporting::fetch_essay_answer_data has incomplete parameters list
(#140) Phpdocs for function reporting::get_essay_report_data has incomplete parameters list
(#184) Phpdocs for function reporting::show_essay_answer_report has incomplete parameters list
(#213) Phpdocs for function reporting::fetch_essay_answer_report_headers has incomplete parameters list
(#259) Phpdocs for function reporting::fetch_attempt_data has incomplete parameters list
(#301) Phpdocs for function reporting::show_attempt_report has incomplete parameters list
(#332) Phpdocs for function reporting::fetch_attempt_report_headers has incomplete parameters list
(#358) Phpdocs for function reporting::fetch_answer_data has incomplete parameters list
(#405) Phpdocs for function reporting::fetch_answer_report_headers has incomplete parameters list
(#428) Phpdocs for function reporting::show_answer_report has incomplete parameters list
(#477) Phpdocs for function reporting::get_report_menu has incomplete parameters list
(#603) Phpdocs for function reporting::fetch_course_attempt_report_headers has incomplete parameters list
mod/simplelesson/classes/output/link_data.php
(#79) Function link_data::get_edit_links is not documented
(#27) No one-line description found in phpdocs for class link_data
(#40) Phpdocs for function link_data::get_firstpage_links has incomplete parameters list
(#108) Phpdocs for function link_data::get_nav_links has incomplete parameters list
mod/simplelesson/classes/output/table_data.php
(#28) No one-line description found in phpdocs for class table_data
mod/simplelesson/classes/privacy/provider.php
(#34) Class provider is not documented
(#45) Function provider::get_metadata is not documented
(#193) Phpdocs for function provider::export_simplelesson_data_for_user has incomplete parameters list
mod/simplelesson/classes/task/scheduled_clean.php
(#34) Function scheduled_clean::get_name is not documented
(#17) No one-line description found in phpdocs for file
mod/simplelesson/db/upgrade.php
(#43) Function xmldb_simplelesson_upgrade is not documented
mod/simplelesson/edit_page_form.php
(#86) Function simplelesson_edit_page_form::data_preprocessing is not documented
mod/simplelesson/edit_questions.php
(#33) Package is not specified for class simplelesson_pagechanger_form. It is also not specified in file-level phpdocs
(#17) File-level phpdocs block is not found
mod/simplelesson/lib.php
(#342) Function simplelesson_reset_gradebook is not documented
(#595) Function simplelesson_get_editor_options is not documented
(#696) Function mod_simplelesson_question_pluginfile is not documented
(#433) Phpdocs for function simplelesson_grade_item_update has incomplete parameters list
(#387) Not recommended phpdocs tag @global used
(#387) Not recommended phpdocs tag @global used
(#515) Not recommended phpdocs tag @global used
(#515) Not recommended phpdocs tag @global used
mod/simplelesson/manual_grading.php
(#31) Package is not specified for class simplelesson_essaygrading_form. It is also not specified in file-level phpdocs
(#17) File-level phpdocs block is not found
mod/simplelesson/renderer.php
(#105) Phpdocs for function mod_simplelesson_renderer::first_page_links has incomplete parameters list
(#114) Phpdocs for function mod_simplelesson_renderer::edit_links has incomplete parameters list
(#123) Phpdocs for function mod_simplelesson_renderer::nav_links has incomplete parameters list
(#132) Phpdocs for function mod_simplelesson_renderer::manage_links has incomplete parameters list
(#141) Phpdocs for function mod_simplelesson_renderer::home_button has incomplete parameters list
(#150) Phpdocs for function mod_simplelesson_renderer::report_menu has incomplete parameters list
(#159) Phpdocs for function mod_simplelesson_renderer::page_management_links has incomplete parameters list
(#168) Phpdocs for function mod_simplelesson_renderer::edit_table_links has incomplete parameters list
(#177) Phpdocs for function mod_simplelesson_renderer::question_table has incomplete parameters list
(#186) Phpdocs for function mod_simplelesson_renderer::questionpage_links has incomplete parameters list
(#269) Phpdocs for function mod_simplelesson_renderer::fetch_index has incomplete parameters list
(#289) Phpdocs for function mod_simplelesson_renderer::render_question_form has incomplete parameters list
(#350) Phpdocs for function mod_simplelesson_renderer::lesson_summary has incomplete parameters list
(#415) Phpdocs for function mod_simplelesson_renderer::grading_header has incomplete parameters list
(#443) Phpdocs for function mod_simplelesson_renderer::essay_text has incomplete parameters list

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "stylelint:css" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 34 warnings)

This section shows problems detected in mustache templates [More info]

mod/simplelesson/templates/buttonlinks.mustache
(#1) Example context missing.
mod/simplelesson/templates/page_actions.mustache
(#1) Example context missing.
mod/simplelesson/templates/page_row.mustache
(#1) Example context missing.
(#1) HTML Validation error, line 3: Stray start tag “tr”. (d><body><tr class="danger"> <td)
(#1) HTML Validation error, line 4: Stray start tag “td”. (anger"> <td></td>)
(#1) HTML Validation error, line 4: Stray end tag “td”. (r"> <td></td> <td)
(#1) HTML Validation error, line 5: Stray start tag “td”. (d></td> <td></td>)
(#1) HTML Validation error, line 5: Stray end tag “td”. (td> <td></td> <td)
(#1) HTML Validation error, line 6: Stray start tag “td”. (d></td> <td></td>)
(#1) HTML Validation error, line 6: Stray end tag “td”. (td> <td></td> <td)
(#1) HTML Validation error, line 7: Stray start tag “td”. (d></td> <td></td>)
(#1) HTML Validation error, line 7: Stray end tag “td”. (td> <td></td> <td)
(#1) HTML Validation error, line 8: Stray start tag “td”. (d></td> <td><img )
(#1) HTML Validation error, line 11: Stray end tag “td”. ( '> </td> <td)
(#1) HTML Validation error, line 12: Stray start tag “td”. ( </td> <td> </t)
(#1) HTML Validation error, line 13: Stray end tag “td”. ( <td> </td></tr>)
(#1) HTML Validation error, line 14: Stray end tag “tr”. (> </td></tr></bo)
mod/simplelesson/templates/pages_edit.mustache
(#1) Example context missing.
mod/simplelesson/templates/question_edit.mustache
(#1) Example context missing.
mod/simplelesson/templates/question_row.mustache
(#1) Example context missing.
(#1) HTML Validation error, line 3: Stray start tag “tr”. (d><body><tr> <)
(#1) HTML Validation error, line 4: Stray start tag “td”. (<tr> <td></td>)
(#1) HTML Validation error, line 4: Stray end tag “td”. (> <td></td> <)
(#1) HTML Validation error, line 5: Stray start tag “td”. (</td> <td></td>)
(#1) HTML Validation error, line 5: Stray end tag “td”. (> <td></td> <)
(#1) HTML Validation error, line 6: Stray start tag “td”. (</td> <td></td>)
(#1) HTML Validation error, line 6: Stray end tag “td”. (> <td></td> <)
(#1) HTML Validation error, line 7: Stray start tag “td”. (</td> <td></td>)
(#1) HTML Validation error, line 7: Stray end tag “td”. (> <td></td> <)
(#1) HTML Validation error, line 8: Stray start tag “td”. (</td> <td></td>)
(#1) HTML Validation error, line 8: Stray end tag “td”. (> <td></td> <)
(#1) HTML Validation error, line 9: Stray start tag “td”. (</td> <td><a hre)
(#1) HTML Validation error, line 9: Stray end tag “td”. (ef=""></a></td></tr>)
(#1) HTML Validation error, line 10: Stray end tag “tr”. (</a></td></tr></bo)