Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(143 errors, 113 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/sharedurl/backup/moodle1/lib.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#43) Inline comments must start with a capital letter, digit or 3-dots sequence
(#43) Inline comments must end in full-stops, exclamation marks, or question marks
(#49) Inline comments must start with a capital letter, digit or 3-dots sequence
(#49) Inline comments must end in full-stops, exclamation marks, or question marks
(#58) Inline comments must start with a capital letter, digit or 3-dots sequence
(#58) Inline comments must end in full-stops, exclamation marks, or question marks
(#82) Inline comments must start with a capital letter, digit or 3-dots sequence
(#82) Inline comments must end in full-stops, exclamation marks, or question marks
(#86) Inline comments must start with a capital letter, digit or 3-dots sequence
(#86) Inline comments must end in full-stops, exclamation marks, or question marks
(#94) Inline comments must start with a capital letter, digit or 3-dots sequence
(#94) Inline comments must end in full-stops, exclamation marks, or question marks
mod/sharedurl/backup/moodle2/backup_sharedurl_activity_task.class.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#55) The static declaration must come after the visibility declaration
(#58) Commas (,) must be followed by white space.
(#60) Inline comments must end in full-stops, exclamation marks, or question marks
(#60) No space found before comment text; expected "// Access a list of all links in a course" but found "//Access a list of all links in a course"
(#65) Inline comments must end in full-stops, exclamation marks, or question marks
(#65) No space found before comment text; expected "// Access the link supplying a course module id" but found "//Access the link supplying a course module id"
(#70) Inline comments must end in full-stops, exclamation marks, or question marks
(#70) No space found before comment text; expected "// Access the link supplying an instance id" but found "//Access the link supplying an instance id"
mod/sharedurl/backup/moodle2/backup_sharedurl_stepslib.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#30) Expected 2 space(s) before asterisk; 1 found
(#31) Expected 2 space(s) before asterisk; 1 found
(#36) Inline comments must start with a capital letter, digit or 3-dots sequence
(#36) Inline comments must end in full-stops, exclamation marks, or question marks
(#36) No space found before comment text; expected "// the shared URL module stores no user info" but found "//the shared URL module stores no user info"
(#38) Inline comments must end in full-stops, exclamation marks, or question marks
(#42) Inline comments must end in full-stops, exclamation marks, or question marks
(#45) Inline comments must end in full-stops, exclamation marks, or question marks
(#46) Inline comments must end in full-stops, exclamation marks, or question marks
(#48) Inline comments must end in full-stops, exclamation marks, or question marks
mod/sharedurl/backup/moodle2/restore_sharedurl_activity_task.class.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#28) Inline comments must end in full-stops, exclamation marks, or question marks
(#40) Inline comments must end in full-stops, exclamation marks, or question marks
(#47) Inline comments must start with a capital letter, digit or 3-dots sequence
(#47) Inline comments must end in full-stops, exclamation marks, or question marks
(#55) The static declaration must come after the visibility declaration
(#67) The static declaration must come after the visibility declaration
(#84) The static declaration must come after the visibility declaration
(#104) The static declaration must come after the visibility declaration
mod/sharedurl/backup/moodle2/restore_sharedurl_stepslib.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#37) Inline comments must end in full-stops, exclamation marks, or question marks
(#47) Inline comments must start with a capital letter, digit or 3-dots sequence
(#47) Inline comments must end in full-stops, exclamation marks, or question marks
(#49) Inline comments must start with a capital letter, digit or 3-dots sequence
(#49) Inline comments must end in full-stops, exclamation marks, or question marks
(#54) Inline comments must end in full-stops, exclamation marks, or question marks
mod/sharedurl/db/install.php
(#2) The opening <?php tag must be followed by exactly one newline.
mod/sharedurl/index.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#29) Inline comments must start with a capital letter, digit or 3-dots sequence
(#29) Inline comments must end in full-stops, exclamation marks, or question marks
(#31) Expected 1 space before "=>"; 0 found
(#31) Expected 1 space after "=>"; 0 found
(#97) Inline comments must start with a capital letter, digit or 3-dots sequence
(#97) Inline comments must end in full-stops, exclamation marks, or question marks
(#101) Inline comments must start with a capital letter, digit or 3-dots sequence
(#101) Inline comments must end in full-stops, exclamation marks, or question marks
mod/sharedurl/lang/en/sharedurl.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#38) Inline comments must end in full-stops, exclamation marks, or question marks
mod/sharedurl/lang/fr/sharedurl.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#30) Whitespace found at end of line within string
(#39) Inline comments must end in full-stops, exclamation marks, or question marks
mod/sharedurl/lib.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#35) Opening brace should be on the same line as the declaration
(#67) Opening brace should be on the same line as the declaration
(#82) Opening brace should be on the same line as the declaration
(#97) Opening brace should be on the same line as the declaration
(#108) Opening brace should be on the same line as the declaration
(#141) Opening brace should be on the same line as the declaration
(#175) Opening brace should be on the same line as the declaration
(#185) Inline comments must start with a capital letter, digit or 3-dots sequence
(#185) Inline comments must end in full-stops, exclamation marks, or question marks
(#205) Opening brace should be on the same line as the declaration
(#211) TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL"
(#218) Inline comments must end in full-stops, exclamation marks, or question marks
(#218) No space found before comment text; expected "// $info->icon = sharedurl_guess_icon($url->externalurl, 24);" but found "//$info->icon = sharedurl_guess_icon($url->externalurl, 24);"
(#224) Expected 1 space before "?"; 2 found
(#226) Line exceeds 132 characters; contains 147 characters
(#249) Opening brace should be on the same line as the declaration
(#290) Opening brace should be on the same line as the declaration
(#321) Inline comments must start with a capital letter, digit or 3-dots sequence
(#321) Inline comments must end in full-stops, exclamation marks, or question marks
(#324) Inline comments must start with a capital letter, digit or 3-dots sequence
(#324) Inline comments must end in full-stops, exclamation marks, or question marks
(#329) Inline comments must start with a capital letter, digit or 3-dots sequence
(#329) Inline comments must end in full-stops, exclamation marks, or question marks
(#330) Inline comments must start with a capital letter, digit or 3-dots sequence
(#330) Inline comments must end in full-stops, exclamation marks, or question marks
(#331) Inline comments must start with a capital letter, digit or 3-dots sequence
(#331) Inline comments must end in full-stops, exclamation marks, or question marks
(#332) Inline comments must start with a capital letter, digit or 3-dots sequence
(#332) Inline comments must end in full-stops, exclamation marks, or question marks
(#334) Inline comments must start with a capital letter, digit or 3-dots sequence
(#334) Inline comments must end in full-stops, exclamation marks, or question marks
(#346) Inline comments must start with a capital letter, digit or 3-dots sequence
(#346) Inline comments must end in full-stops, exclamation marks, or question marks
mod/sharedurl/locallib.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#40) Opening brace should be on the same line as the declaration
(#42) Inline comments must start with a capital letter, digit or 3-dots sequence
(#42) Inline comments must end in full-stops, exclamation marks, or question marks
(#59) Opening brace should be on the same line as the declaration
(#60) Inline comments must start with a capital letter, digit or 3-dots sequence
(#60) Inline comments must end in full-stops, exclamation marks, or question marks
(#63) Inline comments must start with a capital letter, digit or 3-dots sequence
(#63) Inline comments must end in full-stops, exclamation marks, or question marks
(#67) Inline comments must start with a capital letter, digit or 3-dots sequence
(#68) Inline comments must end in full-stops, exclamation marks, or question marks
(#87) Opening brace should be on the same line as the declaration
(#88) Inline comments must start with a capital letter, digit or 3-dots sequence
(#88) Inline comments must end in full-stops, exclamation marks, or question marks
(#103) Inline comments must start with a capital letter, digit or 3-dots sequence
(#109) Inline comments must start with a capital letter, digit or 3-dots sequence
(#109) Inline comments must end in full-stops, exclamation marks, or question marks
(#117) Inline comments must start with a capital letter, digit or 3-dots sequence
(#117) Inline comments must end in full-stops, exclamation marks, or question marks
(#141) Opening brace should be on the same line as the declaration
(#159) Opening brace should be on the same line as the declaration
(#214) Commas (,) must be followed by white space.
(#258) Expected 1 space before "?"; 2 found
(#260) Line exceeds 132 characters; contains 147 characters
(#292) Expected 1 space before "=>"; 0 found
(#292) Expected 1 space after "=>"; 0 found
(#304) Commas (,) must be followed by white space.
(#304) Commas (,) must be followed by white space.
(#304) Inline comments must end in full-stops, exclamation marks, or question marks
(#312) Inline comments must start with a capital letter, digit or 3-dots sequence
(#312) Inline comments must end in full-stops, exclamation marks, or question marks
(#327) Inline doc block comments are not allowed; use "// Comment." instead
(#334) This comment is 54% valid code; is this commented out code?
(#372) File must end with a newline character
mod/sharedurl/mod_form.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#29) "require_once" must be immediately followed by an open parenthesis
(#33) Visibility must be declared on method "definition"
(#39) Inline comments must start with a capital letter, digit or 3-dots sequence
(#39) No space found before comment text; expected "// -------------------------------------------------------" but found "//-------------------------------------------------------"
(#41) Expected 1 space before "=>"; 0 found
(#41) Expected 1 space after "=>"; 0 found
(#49) Expected 1 space before "=>"; 0 found
(#49) Expected 1 space after "=>"; 0 found
(#49) Expected 1 space before "=>"; 0 found
(#49) Expected 1 space after "=>"; 0 found
(#49) Line exceeds 132 characters; contains 141 characters
(#58) Inline comments must start with a capital letter, digit or 3-dots sequence
(#58) No space found before comment text; expected "// -------------------------------------------------------" but found "//-------------------------------------------------------"
(#78) Expected 1 space before "=>"; 0 found
(#78) Expected 1 space after "=>"; 0 found
(#85) Expected 1 space before "=>"; 0 found
(#85) Expected 1 space after "=>"; 0 found
(#103) Inline comments must start with a capital letter, digit or 3-dots sequence
(#103) No space found before comment text; expected "// -------------------------------------------------------" but found "//-------------------------------------------------------"
(#106) Inline comments must start with a capital letter, digit or 3-dots sequence
(#106) No space found before comment text; expected "// -------------------------------------------------------" but found "//-------------------------------------------------------"
(#110) Visibility must be declared on method "data_preprocessing"
(#110) Variable "default_values" must not contain underscores.
(#111) Variable "default_values" must not contain underscores.
(#112) Variable "default_values" must not contain underscores.
(#114) Variable "default_values" must not contain underscores.
(#117) Variable "default_values" must not contain underscores.
(#120) Variable "default_values" must not contain underscores.
(#125) Visibility must be declared on method "validation"
(#137) Empty IF statement detected
(#138) Inline comments must start with a capital letter, digit or 3-dots sequence
(#138) Inline comments must end in full-stops, exclamation marks, or question marks
(#141) Inline comments must start with a capital letter, digit or 3-dots sequence
(#141) Inline comments must end in full-stops, exclamation marks, or question marks
(#146) Empty IF statement detected
(#147) Inline comments must start with a capital letter, digit or 3-dots sequence
(#148) Inline comments must end in full-stops, exclamation marks, or question marks
(#151) Inline comments must start with a capital letter, digit or 3-dots sequence
mod/sharedurl/settings.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#44) Inline comments must start with a capital letter, digit or 3-dots sequence
(#44) No space found before comment text; expected "// --- general settings -----------------------------------------------------------------------------------" but found "//--- general settings -----------------------------------------------------------------------------------"
(#51) Inline comments must start with a capital letter, digit or 3-dots sequence
(#51) No space found before comment text; expected "// --- modedit defaults -----------------------------------------------------------------------------------" but found "//--- modedit defaults -----------------------------------------------------------------------------------"
(#52) Line exceeds 132 characters; contains 160 characters
(#57) Line exceeds 132 characters; contains 143 characters
mod/sharedurl/version.php
(#27) Inline comments must end in full-stops, exclamation marks, or question marks
(#28) Inline comments must end in full-stops, exclamation marks, or question marks
(#29) Inline comments must end in full-stops, exclamation marks, or question marks
mod/sharedurl/view.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#33) Inline comments must end in full-stops, exclamation marks, or question marks
(#37) Inline comments must start with a capital letter, digit or 3-dots sequence
(#37) Inline comments must end in full-stops, exclamation marks, or question marks
(#37) This comment is 77% valid code; is this commented out code?
(#37) No space found before comment text; expected "// var_dump($id, $redirect, $forceview);die;" but found "//var_dump($id, $redirect, $forceview);die;"
(#53) Inline comments must end in full-stops, exclamation marks, or question marks
(#54) Variable "parsed_url" must not contain underscores.
(#55) Variable "does_course_module_exist" must not contain underscores.
(#56) Variable "cm_destination" must not contain underscores.
(#57) Variable "course_destination" must not contain underscores.
(#59) Variable "parsed_url" must not contain underscores.
(#59) Variable "parsed_url" must not contain underscores.
(#59) Variable "parsed_url" must not contain underscores.
(#60) Inline comments must end in full-stops, exclamation marks, or question marks
(#61) Variable "is_valid_web" must not contain underscores.
(#61) Variable "parsed_url" must not contain underscores.
(#62) Variable "is_in_same_domain" must not contain underscores.
(#62) Variable "parsed_url" must not contain underscores.
(#63) Variable "is_valid_module" must not contain underscores.
(#63) Variable "parsed_url" must not contain underscores.
(#64) Variable "is_valid_resource" must not contain underscores.
(#64) Variable "parsed_url" must not contain underscores.
(#65) Variable "is_valid_module" must not contain underscores.
(#66) Variable "has_id_param" must not contain underscores.
(#67) Variable "parsed_url" must not contain underscores.
(#68) Variable "has_id_param" must not contain underscores.
(#68) Variable "parsed_url" must not contain underscores.
(#70) Variable "does_course_module_exist" must not contain underscores.
(#71) Variable "is_valid_resource" must not contain underscores.
(#72) Variable "url_tmp" must not contain underscores.
(#73) Variable "url_tmp" must not contain underscores.
(#75) Variable "url_tmp" must not contain underscores.
(#76) Variable "id_context_resource" must not contain underscores.
(#76) Variable "url_tmp" must not contain underscores.
(#77) Variable "has_id_param" must not contain underscores.
(#78) Variable "does_course_module_exist" must not contain underscores.
(#80) Variable "does_course_module_exist" must not contain underscores.
(#81) Variable "has_id_param" must not contain underscores.
(#84) Variable "is_valid_module" must not contain underscores.
(#87) Variable "is_valid_web" must not contain underscores.
(#87) Variable "is_valid_module" must not contain underscores.
(#87) Variable "is_valid_resource" must not contain underscores.
(#87) Variable "has_id_param" must not contain underscores.
(#87) Variable "is_in_same_domain" must not contain underscores.
(#88) Inline comments must end in full-stops, exclamation marks, or question marks
(#89) Variable "id_context_resource" must not contain underscores.
(#89) Inline comments must end in full-stops, exclamation marks, or question marks
(#90) Variable "id_resource" must not contain underscores.
(#90) Variable "id_context_resource" must not contain underscores.
(#91) Variable "get_values" must not contain underscores.
(#91) Variable "id_resource" must not contain underscores.
(#92) Inline comments must end in full-stops, exclamation marks, or question marks
(#93) Variable "parsed_url" must not contain underscores.
(#93) Variable "get_values" must not contain underscores.
(#96) Variable "course_destination" must not contain underscores.
(#96) Variable "cm_destination" must not contain underscores.
(#96) Variable "get_values" must not contain underscores.
(#98) Variable "does_course_module_exist" must not contain underscores.
(#102) Inline comments must end in full-stops, exclamation marks, or question marks
(#103) Variable "does_course_module_exist" must not contain underscores.
(#103) Variable "cm_destination" must not contain underscores.
(#103) Variable "course_destination" must not contain underscores.
(#134) Inline comments must end in full-stops, exclamation marks, or question marks
(#135) Variable "course_destination" must not contain underscores.
(#137) Variable "enrol_plugin" must not contain underscores.
(#139) Inline comments must end in full-stops, exclamation marks, or question marks
(#140) Variable "course_destination" must not contain underscores.
(#141) Variable "enrol_plugin" must not contain underscores.
(#141) Variable "course_destination" must not contain underscores.
(#144) Variable "course_destination" must not contain underscores.
(#146) Inline comments must end in full-stops, exclamation marks, or question marks
(#147) Inline comments must end in full-stops, exclamation marks, or question marks
(#148) Variable "enrol_plugin" must not contain underscores.
(#165) File must end with a newline character

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(25 errors, 15 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

mod/sharedurl/backup/moodle1/lib.php
(#2) Empty line found after PHP open tag
(#37) Phpdocs for function moodle1_mod_sharedurl_handler::process_legacy_resource has incomplete parameters list
mod/sharedurl/backup/moodle2/backup_sharedurl_activity_task.class.php
(#2) Empty line found after PHP open tag
mod/sharedurl/backup/moodle2/backup_sharedurl_stepslib.php
(#2) Empty line found after PHP open tag
(#34) Function backup_sharedurl_activity_structure_step::define_structure is not documented
mod/sharedurl/backup/moodle2/restore_sharedurl_activity_task.class.php
(#2) Empty line found after PHP open tag
(#18) No one-line description found in phpdocs for file
(#30) No one-line description found in phpdocs for class restore_sharedurl_activity_task
(#80) Inline phpdocs tag {@link restore_logs_processor} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
(#82) Inline phpdocs tag {@link restore_log_rule} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
(#96) Inline phpdocs tag {@link restore_logs_processor} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
(#98) Inline phpdocs tag {@link restore_log_rule} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
mod/sharedurl/backup/moodle2/restore_sharedurl_stepslib.php
(#2) Empty line found after PHP open tag
(#33) Function restore_sharedurl_activity_structure_step::define_structure is not documented
(#41) Function restore_sharedurl_activity_structure_step::process_sharedurl is not documented
(#53) Function restore_sharedurl_activity_structure_step::after_execute is not documented
(#18) No one-line description found in phpdocs for file
mod/sharedurl/classes/event/course_module_viewed.php
(#51) Function course_module_viewed::get_objectid_mapping is not documented
mod/sharedurl/classes/privacy/provider.php
(#29) Class provider is not documented
mod/sharedurl/db/install.php
(#2) Empty line found after PHP open tag
(#34) Function xmldb_sharedurl_install is not documented
mod/sharedurl/db/upgrade.php
(#28) Function xmldb_sharedurl_upgrade is not documented
(#17) No one-line description found in phpdocs for file
mod/sharedurl/index.php
(#2) Empty line found after PHP open tag
mod/sharedurl/lang/en/sharedurl.php
(#2) Empty line found after PHP open tag
mod/sharedurl/lang/fr/sharedurl.php
(#2) Empty line found after PHP open tag
mod/sharedurl/lib.php
(#2) Empty line found after PHP open tag
(#63) Phpdocs for function sharedurl_reset_userdata has incomplete parameters list
(#243) Phpdocs for function sharedurl_export_contents has incomplete parameters list
(#199) Inline phpdocs tag {@link get_array_of_activities()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
mod/sharedurl/locallib.php
(#2) Empty line found after PHP open tag
(#36) Phpdocs for function sharedurl_appears_valid_url has incomplete parameters list
(#125) Not recommended phpdocs tag @internal used
mod/sharedurl/mod_form.php
(#2) Empty line found after PHP open tag
(#32) Class mod_sharedurl_mod_form is not documented
(#33) Function mod_sharedurl_mod_form::definition is not documented
(#110) Function mod_sharedurl_mod_form::data_preprocessing is not documented
(#125) Function mod_sharedurl_mod_form::validation is not documented
mod/sharedurl/settings.php
(#2) Empty line found after PHP open tag
mod/sharedurl/view.php
(#2) Empty line found after PHP open tag

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]