Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(32 errors, 89 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/securepdf/backup/moodle2/backup_securepdf_activity_task.class.php
(#62) The static declaration must come after the visibility declaration
mod/securepdf/backup/moodle2/backup_securepdf_stepslib.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#33) Missing docblock for function define_structure
(#35) Short array syntax must be used to define arrays
(#35) Short array syntax must be used to define arrays
(#41) Short array syntax must be used to define arrays
mod/securepdf/backup/moodle2/restore_securepdf_activity_task.class.php
(#31) Missing docblock for class restore_securepdf_activity_task
(#54) The static declaration must come after the visibility declaration
(#55) Short array syntax must be used to define arrays
(#57) Short array syntax must be used to define arrays
(#68) The static declaration must come after the visibility declaration
(#69) Short array syntax must be used to define arrays
(#86) The static declaration must come after the visibility declaration
(#87) Short array syntax must be used to define arrays
(#114) The static declaration must come after the visibility declaration
(#115) Short array syntax must be used to define arrays
mod/securepdf/backup/moodle2/restore_securepdf_stepslib.php
(#1) No one-line description found in phpdocs for docblock of file restore_securepdf_stepslib.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#41) Short array syntax must be used to define arrays
mod/securepdf/classes/event/course_module_instance_list_viewed.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#30) Missing docblock for class course_module_instance_list_viewed
mod/securepdf/classes/event/course_module_viewed.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#30) Missing docblock for class course_module_viewed
(#31) Missing docblock for function init
mod/securepdf/classes/event/page_view.php
(#20) Incorrect @package tag for file page_view.php. Expected mod_securepdf, found securepdf.
(#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#31) Missing docblock for function init
(#37) Missing docblock for function get_name
(#41) Missing docblock for function get_description
(#49) Missing docblock for function get_url
(#50) Short array syntax must be used to define arrays
mod/securepdf/classes/task/create_cache.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#29) Missing docblock for class create_cache
(#30) Opening brace should be on the same line as the declaration for class create_cache
(#31) Missing docblock for function execute
mod/securepdf/db/access.php
(#27) Short array syntax must be used to define arrays
(#28) Short array syntax must be used to define arrays
(#31) Short array syntax must be used to define arrays
(#34) There should be a comma after the last array item in a multi-line array.
(#37) Short array syntax must be used to define arrays
(#42) Short array syntax must be used to define arrays
(#46) There should be a comma after the last array item in a multi-line array.
mod/securepdf/db/caches.php
(#30) There should be a comma after the last array item in a multi-line array.
mod/securepdf/db/install.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/securepdf/db/log.php
(#27) Short array syntax must be used to define arrays
(#28) Short array syntax must be used to define arrays
(#29) Short array syntax must be used to define arrays
(#30) Short array syntax must be used to define arrays
(#31) Short array syntax must be used to define arrays
(#31) There should be a comma after the last array item in a multi-line array.
mod/securepdf/db/upgrade.php
(#32) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/securepdf/index.php
(#1) No one-line description found in phpdocs for docblock of file index.php
(#27) Short array syntax must be used to define arrays
(#39) Short array syntax must be used to define arrays
(#56) Short array syntax must be used to define arrays
(#57) Short array syntax must be used to define arrays
(#59) Short array syntax must be used to define arrays
(#60) Short array syntax must be used to define arrays
(#92) Short array syntax must be used to define arrays
mod/securepdf/lang/en/securepdf.php
(#29) The string key "modulename_help" is not in the correct order, it should be before "modulenameplural"
(#34) The string key "pluginadministration" is not in the correct order, it should be before "securepdf:view"
(#37) The string key "eventpage_view" is not in the correct order, it should be before "pluginname"
(#42) The string key "page" is not in the correct order, it should be before "resolution_explain"
(#43) The string key "nosuchpage" is not in the correct order, it should be before "page"
(#44) The string key "install_imagick" is not in the correct order, it should be before "nosuchpage"
(#45) The string key "imagick_pdf_policy" is not in the correct order, it should be before "install_imagick"
(#46) The string key "cachedef_pages" is not in the correct order, it should be before "imagick_pdf_policy"
(#49) The string key "addusername" is not in the correct order, it should be before "imagickrequired"
(#51) The string key "addsiteaddress" is not in the correct order, it should be before "addusername_explain"
(#55) The string key "top" is not in the correct order, it should be before "usernameposition_explain"
(#56) The string key "bottom" is not in the correct order, it should be before "top"
mod/securepdf/lang/he/securepdf.php
(#28) The string key "modulename_help" is not in the correct order, it should be before "modulenameplural"
(#33) The string key "pluginadministration" is not in the correct order, it should be before "securepdf:view"
(#36) The string key "eventpage_view" is not in the correct order, it should be before "pluginname"
(#41) The string key "page" is not in the correct order, it should be before "resolution_explain"
(#42) The string key "nosuchpage" is not in the correct order, it should be before "page"
(#43) The string key "install_imagick" is not in the correct order, it should be before "nosuchpage"
(#44) The string key "imagick_pdf_policy" is not in the correct order, it should be before "install_imagick"
(#45) The string key "cachedef_pages" is not in the correct order, it should be before "imagick_pdf_policy"
(#48) The string key "addusername" is not in the correct order, it should be before "imagickrequired"
(#50) The string key "addsiteaddress" is not in the correct order, it should be before "addusername_explain"
(#54) The string key "top" is not in the correct order, it should be before "usernameposition_explain"
(#55) The string key "bottom" is not in the correct order, it should be before "top"
mod/securepdf/lib.php
(#32) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#77) Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $form.
(#103) Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $form.
(#148) Short array syntax must be used to define arrays
(#181) Short array syntax must be used to define arrays
(#206) Short array syntax must be used to define arrays
(#223) Short array syntax must be used to define arrays
(#251) Invalid docblock tag "@catgory".
(#256) Short array syntax must be used to define arrays
(#264) Short array syntax must be used to define arrays
(#279) Short array syntax must be used to define arrays
(#374) Short array syntax must be used to define arrays
(#415) Short array syntax must be used to define arrays
mod/securepdf/locallib.php
(#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#101) Short array syntax must be used to define arrays
(#119) Short array syntax must be used to define arrays
(#125) Short array syntax must be used to define arrays
(#150) Short array syntax must be used to define arrays
(#179) Short array syntax must be used to define arrays
(#195) Short array syntax must be used to define arrays
(#263) Short array syntax must be used to define arrays
(#338) Short array syntax must be used to define arrays
(#364) Missing docblock for function check_imagick
(#399) Missing docblock for function ishebrew
(#417) Missing docblock for function mbstrrev
mod/securepdf/mod_form.php
(#34) Missing docblock for class mod_securepdf_mod_form
(#49) Short array syntax must be used to define arrays
(#63) Short array syntax must be used to define arrays
(#87) Short array syntax must be used to define arrays
mod/securepdf/settings.php
(#31) Short array syntax must be used to define arrays
(#32) Short array syntax must be used to define arrays
mod/securepdf/view.php
(#34) Short array syntax must be used to define arrays
(#43) Short array syntax must be used to define arrays
(#44) Short array syntax must be used to define arrays
(#55) There should be a comma after the last array item in a multi-line array.
(#68) Short array syntax must be used to define arrays
(#71) There should be a comma after the last array item in a multi-line array.
(#195) There should be a comma after the last array item in a multi-line array.

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(10 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

mod/securepdf/backup/moodle2/restore_securepdf_activity_task.class.php
(#81) Inline phpdocs tag {@link restore_logs_processor} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#82) Inline phpdocs tag {@link restore_log_rule} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#105) Inline phpdocs tag {@link restore_logs_processor} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#106) Inline phpdocs tag {@link restore_log_rule} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
mod/securepdf/backup/moodle2/restore_securepdf_stepslib.php
(#48) Phpdocs for function restore_securepdf_activity_structure_step::process_securepdf has incomplete parameters list
mod/securepdf/lib.php
(#137) Phpdocs for function securepdf_user_outline has incomplete parameters list
(#411) Phpdocs for function securepdf_reset_userdata has incomplete parameters list
(#214) Inline phpdocs tag {@link get_array_of_activities()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#271) Inline phpdocs tag {@link file_browser::get_file_info_context_module()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
mod/securepdf/mod_form.php
(#81) Phpdocs for function mod_securepdf_mod_form::data_preprocessing has incomplete parameters list

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 2 warnings)

This section shows problems detected in mustache templates [More info]

mod/securepdf/templates/imageview.mustache
(#1) Example context missing (@template section not found.)
(#1) HTML Validation error, line 9: Attribute “galleryimg” not allowed on element “img” at this point. (</div><img src="data:image/png;base64, " alt="Page " galleryimg="no" onContextMenu="return false;"></bo)

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]