Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(31 errors, 144 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/scormremote/backup/moodle2/backup_scormremote_stepslib.php
(#43) Short array syntax must be used to define arrays
(#43) Short array syntax must be used to define arrays
(#47) Short array syntax must be used to define arrays
(#50) Inline comments must end in full-stops, exclamation marks, or question marks
(#51) Inline comments must end in full-stops, exclamation marks, or question marks
mod/scormremote/backup/moodle2/restore_scormremote_activity_task.class.php
(#56) Short array syntax must be used to define arrays
(#58) Short array syntax must be used to define arrays
(#68) Short array syntax must be used to define arrays
(#84) Short array syntax must be used to define arrays
(#101) Short array syntax must be used to define arrays
mod/scormremote/backup/moodle2/restore_scormremote_stepslib.php
(#41) Short array syntax must be used to define arrays
mod/scormremote/classes/client.php
(#37) Short array syntax must be used to define arrays
(#38) Short array syntax must be used to define arrays
(#42) Short array syntax must be used to define arrays
(#47) Short array syntax must be used to define arrays
mod/scormremote/classes/client_domain.php
(#38) Short array syntax must be used to define arrays
(#39) Short array syntax must be used to define arrays
(#41) There should be a comma after the last array item in a multi-line array.
(#43) Short array syntax must be used to define arrays
(#86) Short array syntax must be used to define arrays
mod/scormremote/classes/course_tier.php
(#37) Short array syntax must be used to define arrays
(#38) Short array syntax must be used to define arrays
(#42) Short array syntax must be used to define arrays
(#44) There should be a comma after the last array item in a multi-line array.
(#57) Short array syntax must be used to define arrays
(#68) Short array syntax must be used to define arrays
mod/scormremote/classes/event/new_seat_allocated.php
(#75) Short array syntax must be used to define arrays
mod/scormremote/classes/event/remote_view_error.php
(#75) Short array syntax must be used to define arrays
mod/scormremote/classes/event/remote_viewed.php
(#78) Short array syntax must be used to define arrays
mod/scormremote/classes/form/client.php
(#16) Boilerplate comment must be followed by a single blank line or end of file
(#37) Short array syntax must be used to define arrays
(#60) Short array syntax must be used to define arrays
(#64) Short array syntax must be used to define arrays
(#71) Short array syntax must be used to define arrays
(#83) Short array syntax must be used to define arrays
(#92) Short array syntax must be used to define arrays
(#119) Short array syntax must be used to define arrays
(#138) Short array syntax must be used to define arrays
mod/scormremote/classes/form/tier.php
(#16) Boilerplate comment must be followed by a single blank line or end of file
(#34) Short array syntax must be used to define arrays
(#57) Short array syntax must be used to define arrays
(#61) Short array syntax must be used to define arrays
mod/scormremote/classes/form/wrapper.php
(#16) Boilerplate comment must be followed by a single blank line or end of file
(#74) Short array syntax must be used to define arrays
(#81) Short array syntax must be used to define arrays
(#85) There should be a comma after the last array item in a multi-line array.
mod/scormremote/classes/packagefile.php
(#59) There should be a comma after the last array item in a multi-line array.
mod/scormremote/classes/privacy/provider.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#115) There should be a comma after the last array item in a multi-line array.
mod/scormremote/classes/subscription.php
(#37) Short array syntax must be used to define arrays
(#38) Short array syntax must be used to define arrays
(#42) Short array syntax must be used to define arrays
(#44) There should be a comma after the last array item in a multi-line array.
(#98) Short array syntax must be used to define arrays
(#109) Short array syntax must be used to define arrays
mod/scormremote/classes/tier.php
(#37) Short array syntax must be used to define arrays
(#38) Short array syntax must be used to define arrays
(#42) Short array syntax must be used to define arrays
(#44) There should be a comma after the last array item in a multi-line array.
(#46) Short array syntax must be used to define arrays
(#48) There should be a comma after the last array item in a multi-line array.
mod/scormremote/classes/utils.php
(#78) Short array syntax must be used to define arrays
mod/scormremote/clients.php
(#34) Import statements must not begin with a leading backslash
(#35) Import statements must not begin with a leading backslash
(#36) Import statements must not begin with a leading backslash
(#39) Import statements must not begin with a leading backslash
(#125) Short array syntax must be used to define arrays
(#132) Short array syntax must be used to define arrays
(#190) Short array syntax must be used to define arrays
mod/scormremote/db/access.php
(#36) There should be a comma after the last array item in a multi-line array.
(#38) There should be a comma after the last array item in a multi-line array.
mod/scormremote/db/upgrade.php
(#213) Inline comments must end in full-stops, exclamation marks, or question marks
(#224) Inline comments must end in full-stops, exclamation marks, or question marks
mod/scormremote/error.php
(#34) Short array syntax must be used to define arrays
mod/scormremote/index.php
(#32) Short array syntax must be used to define arrays
(#37) Short array syntax must be used to define arrays
(#52) Short array syntax must be used to define arrays
(#60) Short array syntax must be used to define arrays
(#61) Short array syntax must be used to define arrays
(#63) Short array syntax must be used to define arrays
(#64) Short array syntax must be used to define arrays
(#66) Short array syntax must be used to define arrays
(#67) Short array syntax must be used to define arrays
(#73) Short array syntax must be used to define arrays
(#75) Short array syntax must be used to define arrays
(#78) Short array syntax must be used to define arrays
(#83) Short array syntax must be used to define arrays
(#85) Short array syntax must be used to define arrays
mod/scormremote/lang/en/scormremote.php
(#30) The string key "modulename" is not in the correct order, it should be before "pluginname"
(#33) The string key "client" is not in the correct order, it should be before "pluginadministration"
(#38) The string key "chooseclient" is not in the correct order, it should be before "expiry"
(#41) The string key "optionalsettings" is not in the correct order, it should be before "searchclient"
(#42) The string key "chooseclientdesc" is not in the correct order, it should be before "optionalsettings"
(#47) The string key "manage_clients" is not in the correct order, it should be before "manage_domains_desc"
(#48) The string key "manage_clientdetails" is not in the correct order, it should be before "manage_clients"
(#50) The string key "manage_clientdeletesuccess" is not in the correct order, it should be before "manage_clientupdateheader"
(#51) The string key "manage_clientcreateheader" is not in the correct order, it should be before "manage_clientdeletesuccess"
(#52) The string key "manage_clientadd" is not in the correct order, it should be before "manage_clientcreateheader"
(#55) The string key "manage_clientdomain" is not in the correct order, it should be before "manage_clientname"
(#60) The string key "manage_tieradd" is not in the correct order, it should be before "manage_tiersdescription"
(#67) The string key "manage_tierscmexplaination" is not in the correct order, it should be before "manage_tierseats"
(#68) The string key "filename" is not in the correct order, it should be before "manage_tierscmexplaination"
(#71) The string key "filenameother_error" is not in the correct order, it should be before "filenameother_help"
(#77) The string key "wrappedpackagefile" is not in the correct order, it should be before "wrapper"
(#78) The string key "error_clientnotfound" is not in the correct order, it should be before "wrappedpackagefile"
(#79) The string key "error_clientnamelength" is not in the correct order, it should be before "error_clientnotfound"
(#81) The string key "error_clientdomainnotvalid" is not in the correct order, it should be before "error_clientnamenotvalid"
(#82) The string key "error_clientdomainnotunique" is not in the correct order, it should be before "error_clientdomainnotvalid"
(#87) The string key "error_tiernamelength" is not in the correct order, it should be before "error_tiernotfound"
(#89) The string key "error_imsmanifestmissing" is not in the correct order, it should be before "error_tierseatnumber"
(#92) The string key "event_remoteviewed_name" is not in the correct order, it should be before "event_seatallocated_name"
(#93) The string key "event_nomanualenrolmentinstance" is not in the correct order, it should be before "event_remoteviewed_name"
(#94) The string key "event_missingmanualenrolment" is not in the correct order, it should be before "event_nomanualenrolmentinstance"
(#98) The string key "event_scormviewed" is not in the correct order, it should be before "event_seatlimitreached"
(#101) The string key "event_clientidrequired" is not in the correct order, it should be before "event_unknownorigin"
(#104) The string key "scormremote:deleteclient" is not in the correct order, it should be before "scormremote:manageclient"
(#106) The string key "scormremote:managetier" is not in the correct order, it should be before "scormremote:viewclient"
(#107) The string key "scormremote:deletetier" is not in the correct order, it should be before "scormremote:managetier"
(#109) The string key "scormremote:downloadwrapper" is not in the correct order, it should be before "scormremote:viewtier"
(#110) The string key "errorpage_badrequesttitle" is not in the correct order, it should be before "scormremote:downloadwrapper"
(#111) The string key "errorpage_badrequestmessage" is not in the correct order, it should be before "errorpage_badrequesttitle"
(#113) The string key "errorpage_expiredmessage" is not in the correct order, it should be before "errorpage_expiredtitle"
(#115) The string key "errorpage_nomanualenrolmentinstancemessage" is not in the correct order, it should be before "errorpage_nomanualenrolmentinstancetitle"
(#117) The string key "errorpage_unauthorizedmessage" is not in the correct order, it should be before "errorpage_unauthorizedtitle"
(#118) The string key "errorpage_clientidrequiredtitle" is not in the correct order, it should be before "errorpage_unauthorizedmessage"
(#119) The string key "errorpage_clientidrequiredmessage" is not in the correct order, it should be before "errorpage_clientidrequiredtitle"
(#121) The string key "errorpage_subrequiredmessage" is not in the correct order, it should be before "errorpage_subrequiredtitle"
(#122) The string key "errorpage_sublimittitle" is not in the correct order, it should be before "errorpage_subrequiredmessage"
(#123) The string key "errorpage_sublimitmessage" is not in the correct order, it should be before "errorpage_sublimittitle"
(#131) The string key "privacy:metadata:mod_scormremote:scormremote" is not in the correct order, it should be before "settings:validationtype:referrerandclient"
(#132) The string key "privacy:metadata:mod_scormremote:course" is not in the correct order, it should be before "privacy:metadata:mod_scormremote:scormremote"
(#136) The string key "privacy:metadata:mod_scormremote:intro" is not in the correct order, it should be before "privacy:metadata:mod_scormremote:sha1hash"
(#139) The string key "privacy:metadata:mod_scormremote:name" is duplicated
(#140) The string key "privacy:metadata:mod_scormremote:primarydomain" is not in the correct order, it should be before "privacy:metadata:mod_scormremote:scormremote_clients"
(#142) The string key "privacy:metadata:mod_scormremote:clientid" is not in the correct order, it should be before "privacy:metadata:mod_scormremote:scormremote_client_domains"
(#145) The string key "privacy:metadata:mod_scormremote:name" is duplicated
mod/scormremote/lib.php
(#65) Short array syntax must be used to define arrays
(#131) Short array syntax must be used to define arrays
(#136) Short array syntax must be used to define arrays
(#155) Short array syntax must be used to define arrays
(#189) There should be a comma after the last array item in a multi-line array.
(#212) There should be a comma after the last array item in a multi-line array.
(#241) There should be a comma after the last array item in a multi-line array.
(#259) There should be a comma after the last array item in a multi-line array.
(#285) There should be a comma after the last array item in a multi-line array.
(#306) There should be a comma after the last array item in a multi-line array.
(#325) There should be a comma after the last array item in a multi-line array.
(#348) There should be a comma after the last array item in a multi-line array.
(#371) There should be a comma after the last array item in a multi-line array.
mod/scormremote/mod_form.php
(#70) Short array syntax must be used to define arrays
(#71) Short array syntax must be used to define arrays
(#111) Short array syntax must be used to define arrays
(#144) Short array syntax must be used to define arrays
mod/scormremote/submit_completion.php
(#26) Import statements must not begin with a leading backslash
(#27) Import statements must not begin with a leading backslash
(#48) Short array syntax must be used to define arrays
mod/scormremote/tabs.php
(#40) Short array syntax must be used to define arrays
(#41) Short array syntax must be used to define arrays
(#42) Short array syntax must be used to define arrays
(#43) Short array syntax must be used to define arrays
mod/scormremote/tests/client_test.php
(#28) Unit test client_test should be declared as final.
(#41) Test method test_validation_of_client() is missing a return type
(#72) Data provider method "client_validation_provider" will need to be converted to static in future.
(#99) There should be a comma after the last array item in a multi-line array.
mod/scormremote/tests/generator/lib.php
(#35) Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $options.
mod/scormremote/tests/requirejs_test.php
(#27) Unit test requirejs_test should be declared as final.
(#39) Test method test_build_files() is missing any coverage information, own or at class level
mod/scormremote/tiers.php
(#125) Short array syntax must be used to define arrays
mod/scormremote/view.php
(#37) Short array syntax must be used to define arrays
(#38) Short array syntax must be used to define arrays
(#40) Short array syntax must be used to define arrays
(#41) Short array syntax must be used to define arrays
(#49) Short array syntax must be used to define arrays
mod/scormremote/wrapper.php
(#40) Short array syntax must be used to define arrays
(#41) Short array syntax must be used to define arrays

Javascript coding style problems

(0 errors, 86 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

mod/scormremote/amd/src/layer2.js
(#5) There should be no space after '{'. (@babel/object-curly-spacing)
(#5) There should be no space before '}'. (@babel/object-curly-spacing)
(#6) There should be no space after '{'. (@babel/object-curly-spacing)
(#6) There should be no space before '}'. (@babel/object-curly-spacing)
(#10) Comments should not begin with a lowercase character. (capitalized-comments)
(#66) A function with a name starting with an uppercase letter should only be used as a constructor. (@babel/new-cap)
(#70) There should be no space after this paren. (space-in-parens)
(#70) There should be no space before this paren. (space-in-parens)
(#70) Comments should not begin with a lowercase character. (capitalized-comments)
(#110) A function with a name starting with an uppercase letter should only be used as a constructor. (@babel/new-cap)
(#112) Closing curly brace does not appear on the same line as the subsequent block. (brace-style)
(#128) Requires a space after '{'. (block-spacing)
(#128) Statement inside of curly braces should be on next line. (brace-style)
(#128) Requires a space before '}'. (block-spacing)
(#128) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
(#134) Closing curly brace does not appear on the same line as the subsequent block. (brace-style)
(#136) Comments should not begin with a lowercase character. (capitalized-comments)
(#139) A function with a name starting with an uppercase letter should only be used as a constructor. (@babel/new-cap)
(#146) 'result' declared on line 137 column 13 is used outside of binding context. (block-scoped-var)
(#160) Closing curly brace does not appear on the same line as the subsequent block. (brace-style)
(#161) A function with a name starting with an uppercase letter should only be used as a constructor. (@babel/new-cap)
(#162) A function with a name starting with an uppercase letter should only be used as a constructor. (@babel/new-cap)
(#162) Comments should not begin with a lowercase character. (capitalized-comments)
(#164) Closing curly brace does not appear on the same line as the subsequent block. (brace-style)
(#165) A function with a name starting with an uppercase letter should only be used as a constructor. (@babel/new-cap)
(#168) A function with a name starting with an uppercase letter should only be used as a constructor. (@babel/new-cap)
(#170) Comments should not begin with a lowercase character. (capitalized-comments)
(#195) Closing curly brace does not appear on the same line as the subsequent block. (brace-style)
(#196) A function with a name starting with an uppercase letter should only be used as a constructor. (@babel/new-cap)
(#197) 'err' declared on line 203 column 17 is used outside of binding context. (block-scoped-var)
(#197) A function with a name starting with an uppercase letter should only be used as a constructor. (@babel/new-cap)
(#197) Comments should not begin with a lowercase character. (capitalized-comments)
(#198) 'err' declared on line 203 column 17 is used outside of binding context. (block-scoped-var)
(#199) Closing curly brace does not appear on the same line as the subsequent block. (brace-style)
(#203) 'err' is already defined. (no-redeclare)
(#203) 'err' declared on line 197 column 13 is used outside of binding context. (block-scoped-var)
(#203) A function with a name starting with an uppercase letter should only be used as a constructor. (@babel/new-cap)
(#204) 'err' declared on line 197 column 13 is used outside of binding context. (block-scoped-var)
(#204) 'err' declared on line 197 column 13 is used outside of binding context. (block-scoped-var)
(#222) Closing curly brace does not appear on the same line as the subsequent block. (brace-style)
(#223) A function with a name starting with an uppercase letter should only be used as a constructor. (@babel/new-cap)
(#224) 'err' declared on line 230 column 17 is used outside of binding context. (block-scoped-var)
(#224) A function with a name starting with an uppercase letter should only be used as a constructor. (@babel/new-cap)
(#224) Comments should not begin with a lowercase character. (capitalized-comments)
(#225) 'err' declared on line 230 column 17 is used outside of binding context. (block-scoped-var)
(#226) Closing curly brace does not appear on the same line as the subsequent block. (brace-style)
(#230) 'err' is already defined. (no-redeclare)
(#230) 'err' declared on line 224 column 13 is used outside of binding context. (block-scoped-var)
(#230) A function with a name starting with an uppercase letter should only be used as a constructor. (@babel/new-cap)
(#231) 'err' declared on line 224 column 13 is used outside of binding context. (block-scoped-var)
(#248) Comments should not begin with a lowercase character. (capitalized-comments)
(#248) Expected space or tab after '//' in comment. (spaced-comment)
(#249) Expected space or tab after '//' in comment. (spaced-comment)
(#304) There should be no space after '{'. (@babel/object-curly-spacing)
(#304) There should be no space before '}'. (@babel/object-curly-spacing)
(#314) Comments should not begin with a lowercase character. (capitalized-comments)
(#317) Comments should not begin with a lowercase character. (capitalized-comments)
(#416) ["function"] is better written in dot notation. (dot-notation)
(#417) ["params"] is better written in dot notation. (dot-notation)
(#454) Operator '+' must be spaced. (space-infix-ops)
(#454) Operator '+' must be spaced. (space-infix-ops)
(#459) Operator '+' must be spaced. (space-infix-ops)
(#459) Operator '+' must be spaced. (space-infix-ops)
(#478) A function with a name starting with an uppercase letter should only be used as a constructor. (@babel/new-cap)
(#492) A function with a name starting with an uppercase letter should only be used as a constructor. (@babel/new-cap)
(#498) A function with a name starting with an uppercase letter should only be used as a constructor. (@babel/new-cap)
(#504) A function with a name starting with an uppercase letter should only be used as a constructor. (@babel/new-cap)
(#507) A function with a name starting with an uppercase letter should only be used as a constructor. (@babel/new-cap)
(#511) A function with a name starting with an uppercase letter should only be used as a constructor. (@babel/new-cap)
(#526) A function with a name starting with an uppercase letter should only be used as a constructor. (@babel/new-cap)
(#541) A function with a name starting with an uppercase letter should only be used as a constructor. (@babel/new-cap)
(#555) A function with a name starting with an uppercase letter should only be used as a constructor. (@babel/new-cap)
(#557) There should be no space after '{'. (@babel/object-curly-spacing)
(#557) Unquoted reserved word 'function' used as key. (quote-props)
(#557) There should be no space before '}'. (@babel/object-curly-spacing)
(#571) Unnecessary escape character: \d. (no-useless-escape)
mod/scormremote/amd/src/layer3.js
(#12) Expected space or tab after '//' in comment. (spaced-comment)
(#14) Expected space or tab after '//' in comment. (spaced-comment)
(#23) Expected space or tab after '//' in comment. (spaced-comment)
(#81) ["function"] is better written in dot notation. (dot-notation)
(#82) ["arguments"] is better written in dot notation. (dot-notation)
(#144) Multiple spaces found before '='. (no-multi-spaces)
(#144) Multiple spaces found before 'new'. (no-multi-spaces)
(#182) Multiple spaces found before '='. (no-multi-spaces)
(#182) Multiple spaces found before 'new'. (no-multi-spaces)
(#228) Unquoted reserved word 'function' used as key. (quote-props)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(0 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]


Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]

mod/scormremote/templates/secondlayer.mustache
(#1) HTML Validation info, line 6: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. (/title> <meta charset="UTF-8" /> <sc)
mod/scormremote/templates/thirdlayer.mustache
(#1) HTML Validation info, line 6: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. (/title> <meta charset="UTF-8" /> <sc)

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]