Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(7 errors, 60 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/peerwork/backup/moodle2/backup_peerwork_stepslib.php
(#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/peerwork/backup/moodle2/restore_peerwork_stepslib.php
(#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/peerwork/calculator/webpa/classes/calculator.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/peerwork/calculator/webpa/classes/privacy/provider.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/peerwork/calculator/webpa/tests/calculator_test.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#42) Test method test_webpa_result_basic() is missing any coverage information, own or at class level
(#94) Test method test_webpa_result_with_weighting() is missing any coverage information, own or at class level
(#120) Test method test_webpa_result_with_weighting_and_penalty() is missing any coverage information, own or at class level
(#147) Test method test_webpa_result_without_self_grade_a() is missing any coverage information, own or at class level
(#174) Test method test_webpa_result_outlier_b() is missing any coverage information, own or at class level
(#210) Test method test_webpa_result_outlier_c() is missing any coverage information, own or at class level
(#247) Test method test_webpa_result_outlier_d() is missing any coverage information, own or at class level
mod/peerwork/classes/criteria.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#36) Expected 1 space before opening brace; found 2
mod/peerwork/classes/event/assessable_submitted.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/peerwork/classes/event/course_module_instance_list_viewed.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/peerwork/classes/event/course_module_viewed.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/peerwork/classes/event/gradebookupdate_failed.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/peerwork/classes/event/grades_released.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/peerwork/classes/event/peer_feedback_created.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/peerwork/classes/event/peer_grade_created.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/peerwork/classes/event/peer_grade_overridden.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/peerwork/classes/event/submission_cleared.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/peerwork/classes/event/submission_created.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/peerwork/classes/event/submission_exported.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/peerwork/classes/event/submission_files_deleted.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/peerwork/classes/event/submission_files_uploaded.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/peerwork/classes/event/submission_grade_form_viewed.php
(#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/peerwork/classes/event/submission_graded.php
(#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/peerwork/classes/event/submission_updated.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/peerwork/classes/event/submission_viewed.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/peerwork/classes/event/submissions_downloaded.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/peerwork/classes/event/submissions_exported.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/peerwork/classes/group_grader.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/peerwork/classes/observer.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/peerwork/classes/output/peerwork_detail_summary.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/peerwork/classes/output/peerwork_summary.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/peerwork/classes/pa_result.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/peerwork/classes/peerwork_plugin.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/peerwork/classes/peerworkcalculator_plugin.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/peerwork/classes/plugininfo/peerworkcalculator.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#96) Logical operator "or" is prohibited; use "||" instead
mod/peerwork/classes/privacy/provider.php
(#56) Expected 1 space before opening brace; found 2
(#125) Whitespace found at end of line within string
(#126) Whitespace found at end of line within string
mod/peerwork/classes/search/activity.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/peerwork/classes/task/notify_students.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/peerwork/db/install.php
(#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/peerwork/db/uninstall.php
(#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/peerwork/db/upgrade.php
(#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/peerwork/downloadallsubmissions.php
(#50) Logical operator "and" is prohibited; use "&&" instead
mod/peerwork/index.php
(#79) Logical operator "or" is prohibited; use "||" instead
mod/peerwork/lib.php
(#575) Expected 1 space before "=>"; 0 found
(#575) Expected 1 space after "=>"; 0 found
(#603) File must end with a newline character
mod/peerwork/renderer.php
(#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/peerwork/tests/behat/behat_mod_peerwork.php
(#65) Line exceeds 132 characters; contains 138 characters
(#101) Line exceeds 132 characters; contains 159 characters
mod/peerwork/tests/generator/lib.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/peerwork/tests/privacy_provider_test.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#57) Test method test_get_metadata() is missing any coverage information, own or at class level
(#65) Test method test_get_contexts_for_userid() is missing any coverage information, own or at class level
(#152) Test method test_get_users_in_context() is missing any coverage information, own or at class level
(#256) Test method test_delete_data_for_all_users_in_context() is missing any coverage information, own or at class level
(#375) Test method test_delete_data_for_user() is missing any coverage information, own or at class level
(#495) Test method test_delete_data_for_users() is missing any coverage information, own or at class level
(#615) Test method test_export_data_for_user() is missing any coverage information, own or at class level

Javascript coding style problems

(11 errors, 2 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

mod/peerwork/amd/src/inplace_editable.js
(#26) @package should be empty. (jsdoc/empty-tags)
(#41) 'cfg' is defined but never used. (no-unused-vars)
(#41) 'url' is defined but never used. (no-unused-vars)
(#41) 'autocomplete' is defined but never used. (no-unused-vars)
(#41) 'Pending' is defined but never used. (no-unused-vars)
(#60) Missing JSDoc @returns for function. (valid-jsdoc)
(#65) Trailing spaces not allowed. (no-trailing-spaces)
(#67) Missing JSDoc @param "e" declaration. (jsdoc/require-param)
(#67) Missing JSDoc for parameter 'e'. (valid-jsdoc)
(#74) 'e' is defined but never used. (no-unused-vars)
(#80) Trailing spaces not allowed. (no-trailing-spaces)
(#97) Trailing spaces not allowed. (no-trailing-spaces)
(#102) Trailing spaces not allowed. (no-trailing-spaces)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(7 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

mod/peerwork/locallib.php
(#1675) Phpdocs for function add_all_calculator_plugins has incomplete parameters list
mod/peerwork/tests/privacy_provider_test.php
(#54) There is no description in phpdocs for function test_get_metadata
(#62) There is no description in phpdocs for function test_get_contexts_for_userid
(#253) There is no description in phpdocs for function test_delete_data_for_all_users_in_context
(#372) There is no description in phpdocs for function test_delete_data_for_user
(#492) There is no description in phpdocs for function test_delete_data_for_users
(#612) There is no description in phpdocs for function test_export_data_for_user

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "gherkinlint" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 15 warnings)

This section shows problems detected in mustache templates [More info]

mod/peerwork/templates/criterion_end.mustache
(#1) HTML Validation error, line 2: Stray end tag “div”. (> </div> <)
(#1) HTML Validation error, line 3: Stray end tag “div”. (/div> </div></div)
(#1) HTML Validation error, line 4: Stray end tag “div”. ( </div></div></b)
mod/peerwork/templates/criterion_start.mustache
(#1) HTML Validation error, line 15: End tag for “body” seen, but there were unclosed elements. ( </body></html)
(#1) HTML Validation error, line 13: Unclosed element “div”. (> <div class="mod_peerwork_peers col-md-12"> )
(#1) HTML Validation error, line 9: Unclosed element “div”. (/div> <div class="mod_peerwork_criteriarating row"> )
(#1) HTML Validation error, line 2: Unclosed element “div”. (ad><body><div class="mod_peerwork_criteria" data-criterionid=""> <)
mod/peerwork/templates/justifalert.mustache
(#1) Template produced no content
mod/peerwork/templates/peergrades_end.mustache
(#1) HTML Validation error, line 2: Stray end tag “div”. (body> </div> )
(#1) HTML Validation error, line 3: Stray end tag “div”. ( </div> )
(#1) HTML Validation error, line 4: Stray end tag “div”. ( </div></)
mod/peerwork/templates/peergrades_start.mustache
(#1) HTML Validation error, line 10: End tag for “body” seen, but there were unclosed elements. ( </body></html)
(#1) HTML Validation error, line 7: Unclosed element “div”. ( <div class="mod_peerwork_justif"> )
(#1) HTML Validation error, line 6: Unclosed element “div”. ( <div class="mod_peerwork_ratings col-md-9"> )
(#1) HTML Validation error, line 2: Unclosed element “div”. ( <div class="mod_peerwork_peer row" data-peerid=""> )
mod/peerwork/templates/peerwork_detail_summary.mustache
(#1) HTML Validation error, line 18: End tag “br”. (</table></br><)

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]