Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(77 errors, 0 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/pandavideo/backup/moodle2/backup_pandavideo_activity_task.class.php
(#38) Opening brace must not be followed by a blank line
mod/pandavideo/backup/moodle2/backup_pandavideo_stepslib.php
(#34) Opening brace must not be followed by a blank line
(#47) Opening parenthesis of a multi-line function call must be the last content on the line
(#47) Only one argument is allowed per line in a multi-line function call
(#48) Multi-line function call not indented correctly; expected 8 spaces but found 12
(#48) Closing parenthesis of a multi-line function call must be on a line by itself
mod/pandavideo/backup/moodle2/restore_pandavideo_activity_task.class.php
(#40) Opening brace must not be followed by a blank line
(#81) Function closing brace must go on the next line following the body; found 1 blank lines before brace
mod/pandavideo/backup/moodle2/restore_pandavideo_stepslib.php
(#34) Opening brace must not be followed by a blank line
mod/pandavideo/classes/analytics/pandavideo_view.php
(#30) Opening brace must not be followed by a blank line
mod/pandavideo/classes/completion/completion_util.php
(#35) Opening brace must not be followed by a blank line
(#50) Blank line found at start of control structure
mod/pandavideo/classes/completion/custom_completion.php
(#38) Opening brace must not be followed by a blank line
mod/pandavideo/classes/event/course_module_viewed.php
(#39) Opening brace must not be followed by a blank line
mod/pandavideo/classes/external/progress.php
(#57) Only one argument is allowed per line in a multi-line function call
(#57) Only one argument is allowed per line in a multi-line function call
(#60) Only one argument is allowed per line in a multi-line function call
(#60) Only one argument is allowed per line in a multi-line function call
(#63) Only one argument is allowed per line in a multi-line function call
(#63) Only one argument is allowed per line in a multi-line function call
(#66) Only one argument is allowed per line in a multi-line function call
(#66) Only one argument is allowed per line in a multi-line function call
(#69) Only one argument is allowed per line in a multi-line function call
(#69) Only one argument is allowed per line in a multi-line function call
mod/pandavideo/classes/grade/grades_util.php
(#35) Opening brace must not be followed by a blank line
mod/pandavideo/classes/output/mobile.php
(#31) Opening brace must not be followed by a blank line
mod/pandavideo/classes/panda/repository.php
(#36) Opening brace must not be followed by a blank line
mod/pandavideo/classes/privacy/provider.php
(#45) The interface names in a "class implements" statement should be ordered alphabetically. Expected: \core_privacy\local\metadata\provider, \core_privacy\local\request\core_userlist_provider, \core_privacy\local\request\plugin\provider; Found: \core_privacy\local\request\core_userlist_provider, \core_privacy\local\metadata\provider, \core_privacy\local\request\plugin\provider
(#48) Opening brace must not be followed by a blank line
(#71) Multi-line function call not indented correctly; expected 8 spaces but found 12
(#164) Long list syntax is not allowed
(#179) Function closing brace must go on the next line following the body; found 1 blank lines before brace
(#234) Long list syntax is not allowed
(#254) Long list syntax is not allowed
(#271) Long list syntax is not allowed
(#299) The first parameter of a multi-line function declaration must be on the line after the opening bracket
(#299) Multi-line function declarations must define one parameter per line
(#299) Multi-line function declarations must define one parameter per line
(#300) Multi-line function declaration not indented correctly; expected 8 spaces but found 56
(#300) Multi-line function declarations must define one parameter per line
(#300) The closing parenthesis of a multi-line function declaration must be on a new line
mod/pandavideo/classes/report/pandavideo_view.php
(#37) Opening brace must not be followed by a blank line
(#160) Opening parenthesis of a multi-line function call must be the last content on the line
(#161) Multi-line function call not indented correctly; expected 12 spaces but found 16
(#161) Closing parenthesis of a multi-line function call must be on a line by itself
mod/pandavideo/index.php
(#90) Opening parenthesis of a multi-line function call must be the last content on the line
(#91) Multi-line function call not indented correctly; expected 8 spaces but found 12
(#91) Closing parenthesis of a multi-line function call must be on a line by itself
mod/pandavideo/lib.php
(#78) Space after opening parenthesis of function call prohibited
mod/pandavideo/mod_form.php
(#40) Opening brace must not be followed by a blank line
mod/pandavideo/report.php
(#56) Expected at least 1 space before "."; 0 found
(#56) Expected at least 1 space after "."; 0 found
(#56) Expected at least 1 space before "."; 0 found
(#56) Expected at least 1 space after "."; 0 found
mod/pandavideo/settings.php
(#37) Multi-line function call not indented correctly; expected 4 spaces but found 8
(#37) Closing parenthesis of a multi-line function call must be on a line by itself
(#41) Opening parenthesis of a multi-line function call must be the last content on the line
(#42) Multi-line function call not indented correctly; expected 4 spaces but found 8
(#42) Only one argument is allowed per line in a multi-line function call
(#42) Closing parenthesis of a multi-line function call must be on a line by itself
(#49) Multi-line function call not indented correctly; expected 4 spaces but found 8
(#49) Only one argument is allowed per line in a multi-line function call
(#49) Closing parenthesis of a multi-line function call must be on a line by itself
(#53) Opening parenthesis of a multi-line function call must be the last content on the line
(#54) Multi-line function call not indented correctly; expected 4 spaces but found 8
(#54) Only one argument is allowed per line in a multi-line function call
(#54) Closing parenthesis of a multi-line function call must be on a line by itself
(#61) Multi-line function call not indented correctly; expected 4 spaces but found 8
(#61) Only one argument is allowed per line in a multi-line function call
(#61) Closing parenthesis of a multi-line function call must be on a line by itself
(#68) Multi-line function call not indented correctly; expected 4 spaces but found 8
(#68) Only one argument is allowed per line in a multi-line function call
(#68) Closing parenthesis of a multi-line function call must be on a line by itself
(#76) Opening parenthesis of a multi-line function call must be the last content on the line
(#78) Expected 1 space after comma in argument list; 2 found
(#78) Expected 1 space between the comma and ""pandavideo"". Found: 2 spaces
(#78) Only one argument is allowed per line in a multi-line function call

Javascript coding style problems

(4 errors, 13 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

mod/pandavideo/classes/form/pandavideo_filepicker.js
(#1) Identifier 'pandavideo_filepicker' is not in camel case. (camelcase)
(#5) Unexpected space before function parentheses. (space-before-function-paren)
(#6) Unexpected console statement. (no-console)
(#8) ["client_id"] is better written in dot notation. (dot-notation)
(#8) Missing semicolon. (semi)
(#10) Identifier 'element_elementid' is not in camel case. (camelcase)
(#11) Identifier 'element_elementid' is not in camel case. (camelcase)
(#14) Operator '+' must be spaced. (space-infix-ops)
(#20) Unexpected space before function parentheses. (space-before-function-paren)
(#21) Unexpected console statement. (no-console)
(#22) Expected space or tab after '//' in comment. (spaced-comment)
(#25) Expected space or tab after '//' in comment. (spaced-comment)
(#29) Expected space or tab after '//' in comment. (spaced-comment)
(#35) Unexpected space before function parentheses. (space-before-function-paren)
(#35) Identifier 'client_id' is not in camel case. (camelcase)
(#37) Use '===' to compare with null. (no-eq-null)
(#38) Identifier 'client_id' is not in camel case. (camelcase)

CSS problems

(173 errors, 9 warnings)

This section shows CSS problems detected by stylelint [More info]

mod/pandavideo/styles.css
(#152) Invalid value for "border" (csstree/validator)
(#162) Invalid value for "box-shadow" (csstree/validator)
(#221) Invalid value for "background" (csstree/validator)
(#89) Expected empty line before at-rule (at-rule-empty-line-before)
(#172) Expected empty line before at-rule (at-rule-empty-line-before)
(#23) Expected "#ffffff" to be "#fff" (color-hex-length)
(#82) Expected "#000000" to be "#000" (color-hex-length)
(#192) Expected "#000000" to be "#000" (color-hex-length)
(#205) Expected "#000000" to be "#000" (color-hex-length)
(#186) Unexpected duplicate "padding" (declaration-block-no-duplicate-properties)
(#77) Unexpected !important (declaration-no-important)
(#92) Unexpected !important (declaration-no-important)
(#97) Unexpected !important (declaration-no-important)
(#113) Unexpected !important (declaration-no-important)
(#122) Unexpected !important (declaration-no-important)
(#128) Unexpected !important (declaration-no-important)
(#129) Unexpected !important (declaration-no-important)
(#133) Unexpected !important (declaration-no-important)
(#202) Unexpected !important (declaration-no-important)
(#203) Unexpected !important (declaration-no-important)
(#228) Unexpected !important (declaration-no-important)
(#158) Expected a minimum of 100 milliseconds (time-min-milliseconds)
(#3) Expected indentation of 4 spaces (indentation)
(#4) Expected indentation of 4 spaces (indentation)
(#7) Expected indentation of 4 spaces (indentation)
(#10) Expected indentation of 4 spaces (indentation)
(#11) Expected indentation of 4 spaces (indentation)
(#12) Expected indentation of 4 spaces (indentation)
(#13) Expected indentation of 4 spaces (indentation)
(#17) Expected indentation of 4 spaces (indentation)
(#18) Expected indentation of 4 spaces (indentation)
(#21) Expected indentation of 4 spaces (indentation)
(#22) Expected indentation of 4 spaces (indentation)
(#23) Expected indentation of 4 spaces (indentation)
(#24) Expected indentation of 4 spaces (indentation)
(#25) Expected indentation of 4 spaces (indentation)
(#26) Expected indentation of 4 spaces (indentation)
(#29) Expected indentation of 4 spaces (indentation)
(#30) Expected indentation of 4 spaces (indentation)
(#34) Expected indentation of 4 spaces (indentation)
(#38) Expected indentation of 4 spaces (indentation)
(#39) Expected indentation of 4 spaces (indentation)
(#40) Expected indentation of 4 spaces (indentation)
(#41) Expected indentation of 4 spaces (indentation)
(#42) Expected indentation of 4 spaces (indentation)
(#43) Expected indentation of 4 spaces (indentation)
(#44) Expected indentation of 4 spaces (indentation)
(#47) Expected indentation of 4 spaces (indentation)
(#51) Expected indentation of 4 spaces (indentation)
(#52) Expected indentation of 4 spaces (indentation)
(#53) Expected indentation of 4 spaces (indentation)
(#54) Expected indentation of 4 spaces (indentation)
(#55) Expected indentation of 4 spaces (indentation)
(#59) Expected indentation of 4 spaces (indentation)
(#60) Expected indentation of 4 spaces (indentation)
(#61) Expected indentation of 4 spaces (indentation)
(#62) Expected indentation of 4 spaces (indentation)
(#63) Expected indentation of 4 spaces (indentation)
(#66) Expected indentation of 4 spaces (indentation)
(#69) Expected indentation of 4 spaces (indentation)
(#70) Expected indentation of 4 spaces (indentation)
(#73) Expected indentation of 4 spaces (indentation)
(#74) Expected indentation of 4 spaces (indentation)
(#77) Expected indentation of 4 spaces (indentation)
(#78) Expected indentation of 4 spaces (indentation)
(#79) Expected indentation of 4 spaces (indentation)
(#80) Expected indentation of 4 spaces (indentation)
(#81) Expected indentation of 4 spaces (indentation)
(#82) Expected indentation of 4 spaces (indentation)
(#83) Expected indentation of 4 spaces (indentation)
(#84) Expected indentation of 4 spaces (indentation)
(#87) Expected indentation of 4 spaces (indentation)
(#90) Expected indentation of 4 spaces (indentation)
(#93) Expected indentation of 4 spaces (indentation)
(#91) Expected indentation of 8 spaces (indentation)
(#92) Expected indentation of 8 spaces (indentation)
(#96) Expected indentation of 4 spaces (indentation)
(#97) Expected indentation of 4 spaces (indentation)
(#100) Expected indentation of 4 spaces (indentation)
(#101) Expected indentation of 4 spaces (indentation)
(#102) Expected indentation of 4 spaces (indentation)
(#103) Expected indentation of 4 spaces (indentation)
(#106) Expected indentation of 4 spaces (indentation)
(#107) Expected indentation of 4 spaces (indentation)
(#108) Expected indentation of 4 spaces (indentation)
(#109) Expected indentation of 4 spaces (indentation)
(#113) Expected indentation of 4 spaces (indentation)
(#116) Expected indentation of 4 spaces (indentation)
(#117) Expected indentation of 4 spaces (indentation)
(#118) Expected indentation of 4 spaces (indentation)
(#122) Expected indentation of 4 spaces (indentation)
(#126) Expected indentation of 4 spaces (indentation)
(#127) Expected indentation of 4 spaces (indentation)
(#128) Expected indentation of 4 spaces (indentation)
(#129) Expected indentation of 4 spaces (indentation)
(#130) Expected indentation of 4 spaces (indentation)
(#133) Expected indentation of 4 spaces (indentation)
(#134) Expected indentation of 4 spaces (indentation)
(#137) Expected indentation of 4 spaces (indentation)
(#138) Expected indentation of 4 spaces (indentation)
(#139) Expected indentation of 4 spaces (indentation)
(#140) Expected indentation of 4 spaces (indentation)
(#141) Expected indentation of 4 spaces (indentation)
(#142) Expected indentation of 4 spaces (indentation)
(#143) Expected indentation of 4 spaces (indentation)
(#144) Expected indentation of 4 spaces (indentation)
(#145) Expected indentation of 4 spaces (indentation)
(#146) Expected indentation of 4 spaces (indentation)
(#149) Expected indentation of 4 spaces (indentation)
(#150) Expected indentation of 4 spaces (indentation)
(#151) Expected indentation of 4 spaces (indentation)
(#152) Expected indentation of 4 spaces (indentation)
(#153) Expected indentation of 4 spaces (indentation)
(#154) Expected indentation of 4 spaces (indentation)
(#155) Expected indentation of 4 spaces (indentation)
(#156) Expected indentation of 4 spaces (indentation)
(#157) Expected indentation of 4 spaces (indentation)
(#158) Expected indentation of 4 spaces (indentation)
(#161) Expected indentation of 4 spaces (indentation)
(#162) Expected indentation of 4 spaces (indentation)
(#165) Expected indentation of 4 spaces (indentation)
(#168) Expected indentation of 4 spaces (indentation)
(#169) Expected indentation of 4 spaces (indentation)
(#170) Expected indentation of 4 spaces (indentation)
(#173) Expected indentation of 4 spaces (indentation)
(#175) Expected indentation of 4 spaces (indentation)
(#174) Expected indentation of 8 spaces (indentation)
(#178) Expected indentation of 4 spaces (indentation)
(#181) Expected indentation of 4 spaces (indentation)
(#182) Expected indentation of 4 spaces (indentation)
(#183) Expected indentation of 4 spaces (indentation)
(#184) Expected indentation of 4 spaces (indentation)
(#185) Expected indentation of 4 spaces (indentation)
(#186) Expected indentation of 4 spaces (indentation)
(#187) Expected indentation of 4 spaces (indentation)
(#190) Expected indentation of 4 spaces (indentation)
(#191) Expected indentation of 4 spaces (indentation)
(#192) Expected indentation of 4 spaces (indentation)
(#193) Expected indentation of 4 spaces (indentation)
(#194) Expected indentation of 4 spaces (indentation)
(#195) Expected indentation of 4 spaces (indentation)
(#196) Expected indentation of 4 spaces (indentation)
(#197) Expected indentation of 4 spaces (indentation)
(#198) Expected indentation of 4 spaces (indentation)
(#202) Expected indentation of 4 spaces (indentation)
(#203) Expected indentation of 4 spaces (indentation)
(#204) Expected indentation of 4 spaces (indentation)
(#205) Expected indentation of 4 spaces (indentation)
(#209) Expected indentation of 4 spaces (indentation)
(#212) Expected indentation of 4 spaces (indentation)
(#213) Expected indentation of 4 spaces (indentation)
(#214) Expected indentation of 4 spaces (indentation)
(#215) Expected indentation of 4 spaces (indentation)
(#216) Expected indentation of 4 spaces (indentation)
(#217) Expected indentation of 4 spaces (indentation)
(#218) Expected indentation of 4 spaces (indentation)
(#221) Expected indentation of 4 spaces (indentation)
(#224) Expected indentation of 4 spaces (indentation)
(#225) Expected indentation of 4 spaces (indentation)
(#228) Expected indentation of 4 spaces (indentation)
(#232) Expected indentation of 4 spaces (indentation)
mod/pandavideo/styles.scss
(#145) Invalid value for "border" (csstree/validator)
(#20) Expected "#ffffff" to be "#fff" (color-hex-length)
(#76) Expected "#000000" to be "#000" (color-hex-length)
(#183) Expected "#000000" to be "#000" (color-hex-length)
(#195) Expected "#000000" to be "#000" (color-hex-length)
(#179) Unexpected duplicate "padding" (declaration-block-no-duplicate-properties)
(#193) Expected newline after ";" in a multi-line declaration block (declaration-block-semicolon-newline-after)
(#23) Expected a trailing semicolon (declaration-block-trailing-semicolon)
(#71) Unexpected !important (declaration-no-important)
(#84) Unexpected !important (declaration-no-important)
(#90) Unexpected !important (declaration-no-important)
(#107) Unexpected !important (declaration-no-important)
(#117) Unexpected !important (declaration-no-important)
(#125) Unexpected !important (declaration-no-important)
(#126) Unexpected !important (declaration-no-important)
(#128) Unexpected !important (declaration-no-important)
(#192) Unexpected !important (declaration-no-important)
(#193) Unexpected !important (declaration-no-important)
(#223) Unexpected !important (declaration-no-important)
(#193) Unexpected extra semicolon (no-extra-semicolons)
(#151) Expected a minimum of 100 milliseconds (time-min-milliseconds)

PHPDocs style problems

(27 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

mod/pandavideo/backup/moodle2/restore_pandavideo_activity_task.class.php
(#85) Inline phpdocs tag {@link restore_logs_processor} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#87) Inline phpdocs tag {@link restore_log_rule} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#101) Inline phpdocs tag {@link restore_logs_processor} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#103) Inline phpdocs tag {@link restore_log_rule} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
mod/pandavideo/backup/moodle2/restore_pandavideo_stepslib.php
(#39) Inline phpdocs tag {@link restore_path_element} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
mod/pandavideo/classes/analytics/pandavideo_view.php
(#35) Phpdocs for function pandavideo_view::create has incomplete parameters list
(#61) Phpdocs for function pandavideo_view::internal_create has incomplete parameters list
(#90) Phpdocs for function pandavideo_view::update has incomplete parameters list
mod/pandavideo/classes/completion/completion_util.php
(#40) Phpdocs for function completion_util::get_completion_state has incomplete parameters list
mod/pandavideo/classes/grade/grades_util.php
(#40) Phpdocs for function grades_util::update has incomplete parameters list
(#82) Phpdocs for function grades_util::grade_item_update has incomplete parameters list
mod/pandavideo/classes/output/mobile.php
(#36) Phpdocs for function mobile::mobile_course_view has incomplete parameters list
mod/pandavideo/classes/panda/repository.php
(#44) Phpdocs for function repository::oembed has incomplete parameters list
(#117) Phpdocs for function repository::http_get has incomplete parameters list
mod/pandavideo/classes/report/pandavideo_view.php
(#51) Phpdocs for function pandavideo_view::__construct has incomplete parameters list
(#169) Phpdocs for function pandavideo_view::col_currenttime has incomplete parameters list
(#187) Phpdocs for function pandavideo_view::col_duration has incomplete parameters list
(#204) Phpdocs for function pandavideo_view::col_percent has incomplete parameters list
(#214) Phpdocs for function pandavideo_view::col_videomap has incomplete parameters list
(#238) Phpdocs for function pandavideo_view::col_timecreated has incomplete parameters list
(#248) Phpdocs for function pandavideo_view::col_timemodified has incomplete parameters list
(#258) Phpdocs for function pandavideo_view::col_extra has incomplete parameters list
(#287) Phpdocs for function pandavideo_view::query_db_default has incomplete parameters list
(#383) Phpdocs for function pandavideo_view::query_db_postgresql has incomplete parameters list
mod/pandavideo/lib.php
(#31) Phpdocs for function pandavideo_supports has incomplete parameters list
(#278) Phpdocs for function pandavideo_format_time has incomplete parameters list
mod/pandavideo/mod_form.php
(#219) Phpdocs for function mod_pandavideo_mod_form::validation has incomplete parameters list

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "stylelint:css" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 15 warnings)

This section shows problems detected in mustache templates [More info]

mod/pandavideo/templates/embed.mustache
(#1) HTML validation skipped
(#1) ESLint warning [space-before-function-paren]: Unexpected space before function parentheses. ( require(["jquery", "core/ajax"], function ($, Ajax) {
(#1) ESLint warning [space-before-function-paren]: Unexpected space before function parentheses. ( init: function () {
(#1) ESLint warning [space-before-function-paren]: Unexpected space before function parentheses. ( window.addEventListener("message", function (event) {
(#1) ESLint warning [consistent-return]: Expected to return a value at the end of method '_saveprogress'. ( _saveprogress: function (currenttime, duration) {
(#1) ESLint warning [space-before-function-paren]: Unexpected space before function parentheses. ( _saveprogress: function (currenttime, duration) {
(#1) ESLint warning [consistent-return]: Method '_saveprogress' expected a return value. ( return;
(#1) ESLint warning [consistent-return]: Method '_saveprogress' expected a return value. ( return;
(#1) ESLint warning [space-before-function-paren]: Unexpected space before function parentheses. ( _progresscreate: function (duration) {
(#1) ESLint warning [space-before-function-paren]: Unexpected space before function parentheses. ( .click(function () {
(#1) ESLint warning [comma-spacing]: A space is required after ','. ( let pandavideoviewmaps = [1,0,0,0,0];
(#1) ESLint warning [comma-spacing]: A space is required after ','. ( let pandavideoviewmaps = [1,0,0,0,0];
(#1) ESLint warning [comma-spacing]: A space is required after ','. ( let pandavideoviewmaps = [1,0,0,0,0];
(#1) ESLint warning [comma-spacing]: A space is required after ','. ( let pandavideoviewmaps = [1,0,0,0,0];
(#1) ESLint error [no-console]: Unexpected console statement. ( console.error(e);
(#1) ESLint warning [space-before-function-paren]: Unexpected space before function parentheses. ( _setcurrenttime: function (currenttime) {
mod/pandavideo/templates/mobile.mustache
(#1) HTML validation skipped

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]