PHP lint problems
(0 errors, 0 warnings)
This section shows php lint problems in the code detected by php -l [More info]
PHP coding style problems
(11 errors, 50 warnings)
This section shows the coding style problems detected in the code by phpcs [More info]
- mod/onlyoffice/callback.php
- (#28) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
- (#51) The "salt" parameter for function crypt() is missing. Passing this parameter is strongly recommended since PHP 5.6
- mod/onlyoffice/classes/crypt.php
- (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- (#84) File must end with a newline character
- mod/onlyoffice/classes/editor.php
- (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- (#57) Line exceeds 132 characters; contains 173 characters
- (#62) Line exceeds 132 characters; contains 136 characters
- (#74) Inline comments must start with a capital letter, digit or 3-dots sequence
- (#74) Inline comments must end in full-stops, exclamation marks, or question marks
- (#78) Inline comments must start with a capital letter, digit or 3-dots sequence
- (#78) Inline comments must end in full-stops, exclamation marks, or question marks
- (#92) Inline comments must start with a capital letter, digit or 3-dots sequence
- (#92) Inline comments must end in full-stops, exclamation marks, or question marks
- (#97) Inline comments must start with a capital letter, digit or 3-dots sequence
- (#97) Inline comments must end in full-stops, exclamation marks, or question marks
- (#103) Inline comments must start with a capital letter, digit or 3-dots sequence
- (#103) Inline comments must end in full-stops, exclamation marks, or question marks
- (#112) Inline comments must start with a capital letter, digit or 3-dots sequence
- (#112) Inline comments must end in full-stops, exclamation marks, or question marks
- (#120) Inline comments must start with a capital letter, digit or 3-dots sequence
- (#120) Inline comments must end in full-stops, exclamation marks, or question marks
- (#125) Inline comments must start with a capital letter, digit or 3-dots sequence
- (#125) Inline comments must end in full-stops, exclamation marks, or question marks
- (#133) File must end with a newline character
- mod/onlyoffice/classes/event/course_module_instance_list_viewed.php
- (#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- mod/onlyoffice/classes/event/course_module_viewed.php
- (#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- mod/onlyoffice/classes/output/renderer.php
- (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- (#45) File must end with a newline character
- mod/onlyoffice/classes/output/summary.php
- (#50) Inline comments must start with a capital letter, digit or 3-dots sequence
- (#50) Inline comments must end in full-stops, exclamation marks, or question marks
- (#55) File must end with a newline character
- mod/onlyoffice/classes/util.php
- (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- (#106) File must end with a newline character
- mod/onlyoffice/db/access.php
- (#56) File must end with a newline character
- mod/onlyoffice/db/upgrade.php
- (#23) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- (#36) File must end with a newline character
- mod/onlyoffice/dsconfig.php
- (#24) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
- (#40) File must end with a newline character
- mod/onlyoffice/lang/en/onlyoffice.php
- (#55) File must end with a newline character
- mod/onlyoffice/lib.php
- (#31) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- (#77) Inline comments must start with a capital letter, digit or 3-dots sequence
- (#77) Inline comments must end in full-stops, exclamation marks, or question marks
- (#158) Line exceeds 132 characters; contains 152 characters
- (#189) Line exceeds 132 characters; contains 148 characters
- (#198) Inline comments must start with a capital letter, digit or 3-dots sequence
- (#301) The "salt" parameter for function crypt() is missing. Passing this parameter is strongly recommended since PHP 5.6
- (#314) Line exceeds 132 characters; contains 133 characters
- mod/onlyoffice/mod_form.php
- (#66) Inline comments must start with a capital letter, digit or 3-dots sequence
- (#67) Inline comments must start with a capital letter, digit or 3-dots sequence
- (#67) This comment is 67% valid code; is this commented out code?
- (#83) Inline comments must start with a capital letter, digit or 3-dots sequence
- (#131) File must end with a newline character
- mod/onlyoffice/settings.php
- (#35) File must end with a newline character
- mod/onlyoffice/view.php
- (#27) Inline comments must end in full-stops, exclamation marks, or question marks
- (#28) Inline comments must end in full-stops, exclamation marks, or question marks
- (#61) Inline comments must start with a capital letter, digit or 3-dots sequence
- (#61) Inline comments must end in full-stops, exclamation marks, or question marks
- (#63) Line exceeds 132 characters; contains 140 characters
- (#68) Line exceeds 132 characters; contains 140 characters
- (#71) Inline comments must start with a capital letter, digit or 3-dots sequence
- (#71) Inline comments must end in full-stops, exclamation marks, or question marks
Javascript coding style problems
(2 errors, 7 warnings)
This section shows the coding style problems detected in the code by eslint [More info]
- mod/onlyoffice/amd/src/editor.js
- (#22) Unexpected space before function parentheses. (space-before-function-paren)
- (#23) Unexpected space before function parentheses. (space-before-function-paren)
- (#24) Unexpected space before function parentheses. (space-before-function-paren)
- (#26) Unexpected space before function parentheses. (space-before-function-paren)
- (#34) Unexpected space before function parentheses. (space-before-function-paren)
- (#39) Identifier 'ajax_url' is not in camel case. (camelcase)
- (#43) Unexpected space before function parentheses. (space-before-function-paren)
- (#44) 'docEditor' is assigned a value but never used. (no-unused-vars)
- (#44) 'DocsAPI' is not defined. (no-undef)
CSS problems
(0 errors, 0 warnings)
This section shows CSS problems detected by stylelint [More info]
PHPDocs style problems
(54 errors, 0 warnings)
This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]
- mod/onlyoffice/callback.php
- (#17) No one-line description found in phpdocs for file
- mod/onlyoffice/classes/crypt.php
- (#32) Class crypt is not documented
- (#41) Function crypt::__construct is not documented
- (#45) Function crypt::get_hash is not documented
- (#51) Function crypt::read_hash is not documented
- (#78) Function crypt::signature_create is not documented
- (#17) No one-line description found in phpdocs for file
- mod/onlyoffice/classes/document.php
- (#28) Class document is not documented
- (#30) Function document::get_key is not documented
- (#38) Function document::set_key is not documented
- (#45) Function document::get_permissions is not documented
- (#17) No one-line description found in phpdocs for file
- mod/onlyoffice/classes/editor.php
- (#34) Class editor is not documented
- (#42) Function editor::__construct is not documented
- (#36) Variable editor::$courseid is not documented
- (#37) Variable editor::$context is not documented
- (#38) Variable editor::$cm is not documented
- (#39) Variable editor::$modconfig is not documented
- (#40) Variable editor::$file is not documented
- (#17) No one-line description found in phpdocs for file
- (#56) There is no description in phpdocs for function config
- mod/onlyoffice/classes/output/renderer.php
- (#17) No one-line description found in phpdocs for file
- (#32) No one-line description found in phpdocs for class renderer
- (#37) Phpdocs for function renderer::render_summary has incomplete parameters list
- mod/onlyoffice/classes/output/summary.php
- (#17) No one-line description found in phpdocs for file
- mod/onlyoffice/classes/util.php
- (#30) Class util is not documented
- (#40) Function util::get_appkey is not documented
- (#49) Function util::save_document_permissions is not documented
- (#60) Function util::save_file is not documented
- (#71) Function util::get_connection_info is not documented
- (#78) Function util::save_document_to_moodle is not documented
- (#32) Constant util::STATUS_NOTFOUND is not documented
- (#33) Constant util::STATUS_EDITING is not documented
- (#34) Constant util::STATUS_MUSTSAVE is not documented
- (#35) Constant util::STATUS_ERRORSAVING is not documented
- (#36) Constant util::STATUS_CLOSEDNOCHANGES is not documented
- (#37) Constant util::STATUS_FORCESAVE is not documented
- (#38) Constant util::STATUS_ERRORFORCESAVE is not documented
- (#17) No one-line description found in phpdocs for file
- mod/onlyoffice/db/access.php
- (#17) No one-line description found in phpdocs for file
- mod/onlyoffice/db/install.php
- (#17) No one-line description found in phpdocs for file
- mod/onlyoffice/db/uninstall.php
- (#17) No one-line description found in phpdocs for file
- mod/onlyoffice/db/upgrade.php
- (#17) No one-line description found in phpdocs for file
- mod/onlyoffice/dsconfig.php
- (#17) No one-line description found in phpdocs for file
- mod/onlyoffice/lang/en/onlyoffice.php
- (#17) No one-line description found in phpdocs for file
- mod/onlyoffice/lib.php
- (#193) There is no description in phpdocs for function onlyoffice_cm_info_dynamic
- (#198) Invalid inline phpdocs tag @todo found
- (#38) Inline phpdocs tag {@link plugin_supports()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
- (#146) Inline phpdocs tag {@link get_array_of_activities()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
- (#254) Inline phpdocs tag {@link file_browser::get_file_info_context_module()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
- mod/onlyoffice/mod_form.php
- (#33) Class mod_onlyoffice_mod_form is not documented
- (#92) Function mod_onlyoffice_mod_form::validation is not documented
- (#66) Invalid inline phpdocs tag @todo found
- (#83) Invalid inline phpdocs tag @todo found
Update savepoints problems
(0 errors, 0 warnings)
This section shows problems detected with the handling of upgrade savepoints [More info]
Third party library modification problems
(0 errors, 0 warnings)
This section shows problems detected with the modification of third party libraries [More info]
Missing changes in external functions or backup support for new detected tables or columns
(0 errors, 0 warnings)
This section shows potential problems detected when there are new database structures added in a patch and it is detected that nothing has been changed related with external functions (to be used by WS) or backup and restore. It must be checked that everything is correct and nothing is being missed in those areas. [More info]
grunt changes
(1 errors, 1 warnings)
This section shows files built by grunt and not commited [More info]
- Problems running grunt
- Task "eslint:amd" failed. Use --force to continue.
shifter problems
(0 errors, 0 warnings)
This section shows problems detected by shifter [More info]
Mustache template problems
(1 errors, 0 warnings)
This section shows problems detected in mustache templates [More info]
- mod/onlyoffice/templates/summary.mustache
- (#1) Mustache syntax exception: Example context JSON is unparsable, fails with: Syntax error
Gherkin .feature problems
(0 errors, 0 warnings)
This section shows problems detected in behat .feature files [More info]