Prechecker results: warning


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(0 errors, 66 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/observation/tests/backup_test.php
(#26) PHPUnit class "backup_test" does not have any namespace. It is recommended to add it to the "mod_observation" namespace, using more levels if needed, in order to match the code being tested
(#70) Test method test_backup_and_restore() is missing any coverage information, own or at class level
mod/observation/tests/observation_point_test.php
(#36) PHPUnit class "observation_point_test" does not have any namespace. It is recommended to add it to the "mod_observation" namespace, using more levels if needed, in order to match the code being tested
(#97) Test method test_crud_expected() is missing any coverage information, own or at class level
(#161) Test method test_ordering_single() is missing any coverage information, own or at class level
(#180) Test method test_ordering_multiple() is missing any coverage information, own or at class level
(#219) Test method test_ordering_overstep() is missing any coverage information, own or at class level
(#273) Test method test_float_maxgrade() is missing any coverage information, own or at class level
(#289) Test method test_negative_maxgrade() is missing any coverage information, own or at class level
(#304) Test method test_string_maxgrade() is missing any coverage information, own or at class level
(#319) Test method test_missing_maxgrade() is missing any coverage information, own or at class level
(#334) Test method test_invalid_restype() is missing any coverage information, own or at class level
mod/observation/tests/observation_session_test.php
(#36) PHPUnit class "observation_session_test" does not have any namespace. It is recommended to add it to the "mod_observation" namespace, using more levels if needed, in order to match the code being tested
(#113) Test method test_valid_session_flow() is missing any coverage information, own or at class level
(#188) Test method test_cancel_session() is missing any coverage information, own or at class level
(#196) Test method test_submit_invalid_grade() is missing any coverage information, own or at class level
(#206) Test method test_submit_high_grade() is missing any coverage information, own or at class level
(#216) Test method test_finish_nonexistent_session() is missing any coverage information, own or at class level
(#223) Test method test_submit_no_response() is missing any coverage information, own or at class level
(#239) Test method test_modified_before_submit() is missing any coverage information, own or at class level
(#273) Test method test_start_session_lockout() is missing any coverage information, own or at class level
(#285) Test method test_start_session_lockout_neg() is missing any coverage information, own or at class level
mod/observation/tests/privacy_test.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#40) PHPUnit testcase name "mod_observation_privacy_testcase" does not match file name "privacy_test"
(#40) PHPUnit class "mod_observation_privacy_testcase" does not have any namespace. It is recommended to add it to the "mod_observation" namespace, using more levels if needed, in order to match the code being tested
(#74) Test method test_get_metadata() is missing any coverage information, own or at class level
(#84) Test method test_get_contexts_for_userid() is missing any coverage information, own or at class level
(#111) Test method test_get_users_in_context() is missing any coverage information, own or at class level
(#142) Test method test_delete_data_for_users() is missing any coverage information, own or at class level
(#207) Test method test_delete_data_for_user() is missing any coverage information, own or at class level
(#267) Test method test_delete_data_for_all_users_in_context() is missing any coverage information, own or at class level
(#331) Test method test_export_user_data() is missing any coverage information, own or at class level
mod/observation/tests/timeslot_joining_test.php
(#36) PHPUnit class "timeslot_joining_test" does not have any namespace. It is recommended to add it to the "mod_observation" namespace, using more levels if needed, in order to match the code being tested
(#95) Test method test_joining_function() is missing any coverage information, own or at class level
(#112) Test method test_double_joining() is missing any coverage information, own or at class level
(#125) Test method test_join_filled() is missing any coverage information, own or at class level
(#139) Test method test_signup_notification() is missing any coverage information, own or at class level
mod/observation/tests/timeslot_notification_test.php
(#36) PHPUnit class "timeslot_notification_test" does not have any namespace. It is recommended to add it to the "mod_observation" namespace, using more levels if needed, in order to match the code being tested
(#103) Test method test_notification_crud() is missing any coverage information, own or at class level
(#124) Test method test_delete_not_owned() is missing any coverage information, own or at class level
(#142) Test method test_create_too_many() is missing any coverage information, own or at class level
(#162) Test method test_invalid_interval() is missing any coverage information, own or at class level
(#190) Test method test_invalid_multiplier() is missing any coverage information, own or at class level
(#218) Test method test_deleted_after_unenrol() is missing any coverage information, own or at class level
(#242) Test method test_deleted_after_kicked() is missing any coverage information, own or at class level
(#266) Test method test_deleted_after_slot_deleted() is missing any coverage information, own or at class level
mod/observation/tests/timeslots_test.php
(#36) PHPUnit class "timeslots_test" does not have any namespace. It is recommended to add it to the "mod_observation" namespace, using more levels if needed, in order to match the code being tested
(#97) Test method test_valid_crud() is missing any coverage information, own or at class level
(#182) Test method test_negative_duration() is missing any coverage information, own or at class level
(#193) Test method test_float_duration() is missing any coverage information, own or at class level
(#204) Test method test_string_start_time() is missing any coverage information, own or at class level
(#215) Test method test_negative_start_time() is missing any coverage information, own or at class level
(#244) Test method test_interval() is missing any coverage information, own or at class level
(#257) Test method test_interval_invalid_amount() is missing any coverage information, own or at class level
(#268) Test method test_interval_invalid_multiplier() is missing any coverage information, own or at class level
(#279) Test method test_interval_end_before_start() is missing any coverage information, own or at class level
(#290) Test method test_interval_invalid_end() is missing any coverage information, own or at class level
(#305) Test method test_random_assign_single_user() is missing any coverage information, own or at class level
(#325) Test method test_random_assign_not_enough_slots() is missing any coverage information, own or at class level
(#344) Test method test_random_assign_excessive_slots() is missing any coverage information, own or at class level
(#370) Test method test_kick_observee() is missing any coverage information, own or at class level
mod/observation/tests/unenrol_test.php
(#36) PHPUnit class "unenrol_test" does not have any namespace. It is recommended to add it to the "mod_observation" namespace, using more levels if needed, in order to match the code being tested
(#91) Test method test_unenrolling_enabled() is missing any coverage information, own or at class level
(#121) Test method test_unenrolling_disabled() is missing any coverage information, own or at class level
(#138) Test method test_unenrolling_empty() is missing any coverage information, own or at class level
(#152) Test method test_unenrolling_not_own() is missing any coverage information, own or at class level

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(0 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]


Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


Missing changes in external functions or backup support for new detected tables or columns

(0 errors, 2 warnings)

This section shows potential problems detected when there are new database structures added in a patch and it is detected that nothing has been changed related with external functions (to be used by WS) or backup and restore. It must be checked that everything is correct and nothing is being missed in those areas. [More info]

mod/observation/db/upgrade.php
Database modifications (new tables or columns) detected in the patch without any change to some important areas.
No changes detected to external functions, that may affect apps and other web service integrations, please verify!

grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]